concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-02-04T14:40:33+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1007Expiration date on partner pages2020-02-04T14:40:33+01:00Jen Dusseljeejendusseljee@gmail.comExpiration date on partner pages<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Can you add a functionality to set an expiration date on profile pages of partners.
### Motivation
<!-- Why should we care? -->
Because it ...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Can you add a functionality to set an expiration date on profile pages of partners.
### Motivation
<!-- Why should we care? -->
Because it is pretty annoying to have to memorise the duration of all contracts. It would be way easier to just be able to set an expiration date when the contract enters.
### Desired functionality
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
An extra date field in the admin page when editing/creating a partner page. When this date has passed, the profile page should automatically be set to inactive (maybe send a mail to extern@ to let the extern know when this happens).
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
-https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1006Miscellaneous annual files on document page2020-02-04T16:04:53+01:00Nick van OersMiscellaneous annual files on document page
<!--
You want something new.
-->
### One-sentence description
The ability to add more yearly files on the document page.
### Motivation
Normally things like the half year report are added as GM documents, but now we want to add ...
<!--
You want something new.
-->
### One-sentence description
The ability to add more yearly files on the document page.
### Motivation
Normally things like the half year report are added as GM documents, but now we want to add yearly documents that are not necessarily discussed at a GM. We want to add a report from the societies on how well everything worked that year, as the society rules state that they should publish this.
<!-- Why should we care? -->
### Desired functionality
A new section underneath the GMs, where miscellaneous or other documents can be added.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
### Suggested implementation
See picture in the comments.
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1003Create more kinds of fixtures2020-02-19T22:57:03+01:00Job DoesburgCreate more kinds of fixtures<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should b...<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should be created for courses. But also maybe for photos and albums, documents, payments, registrations?, etc...
### Suggested implementationSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1000Internet required to run tests2020-01-26T22:07:58+01:00Joren VranckenInternet required to run tests### Description
Internet required to run tests, because [`activemembers/signals.py` always initializes the G Suite API](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/signals.py#L15). This is not (and sho...### Description
Internet required to run tests, because [`activemembers/signals.py` always initializes the G Suite API](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/signals.py#L15). This is not (and should not be) always necessary (e.g. when running tests).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/997Review url is not clear from CI logs2020-01-23T19:48:00+01:00Joren VranckenReview url is not clear from CI logs### One-sentence description
Review Host url is not clear from CI logs.
### Current implementation
The username and password are shown to the user, but not the url to the review environment.### One-sentence description
Review Host url is not clear from CI logs.
### Current implementation
The username and password are shown to the user, but not the url to the review environment.Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/995Deliver sliders or other large images as webp2020-01-15T22:41:46+01:00Jelle Besselingjelle@pingiun.comDeliver sliders or other large images as webp<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### Why?
According to [Google PageSpeed](https://developers.google.com/speed/pagespeed/insights/?hl=nl&url=thalia.nu&tab=mobile), we can speed up our site by a lot by converting slider images to webp.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Large pictures are all served as png, this is a good image format for things that need to be compressed lossless.
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Supply images as `<picture>` [with multiple sources](https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images#Use_modern_image_formats_boldly)
<!-- Provide (a) suggestion(s) for how we could approach this -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/994Improve messages for exam/summary upload2020-01-21T09:03:42+01:00Sébastiaan VersteegImprove messages for exam/summary upload### One-sentence description
Improve messages for exam/summary upload
### Why?
They're unclear?. It does not say that the exam will be added to the approval queue. And that causes confusion because people often upload the document ag...### One-sentence description
Improve messages for exam/summary upload
### Why?
They're unclear?. It does not say that the exam will be added to the approval queue. And that causes confusion because people often upload the document again.
Edit: I did not get any messages at all.
(Maybe we could even make the approval queue crowd sourced so that everyone can approve documents that are not their own? Although that may not work because you can get money for summaries)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/991Members that have been `minimizeinformation`ed before don't have contact info...2019-12-19T15:02:15+01:00Jelle Besselingjelle@pingiun.comMembers that have been `minimizeinformation`ed before don't have contact information### One-sentence description
Members should fill in their information again when renewing after a information minimisation has happened.
### Motivation
There are currently some members that do not have address information in their profi...### One-sentence description
Members should fill in their information again when renewing after a information minimisation has happened.
### Motivation
There are currently some members that do not have address information in their profile because this has been erased. This creates difficulties when sending an invoice or the Thabloid.
### Desired functionality
Contact information is filled in again when it's detected that it's not complete.
### Suggested implementation
Something at the renewal pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/987Make it clear when members are not allowed to go to events2020-02-19T21:47:45+01:00Jelle Besselingjelle@pingiun.comMake it clear when members are not allowed to go to events### One-sentence description
Make it clearer for members when they cannot go to events.
### Motivation
Sometimes members miss the email that tells them they are banned from events (because they forgot to pay their fines). This causes co...### One-sentence description
Make it clearer for members when they cannot go to events.
### Motivation
Sometimes members miss the email that tells them they are banned from events (because they forgot to pay their fines). This causes confusion when they cannot register for events.
### Desired functionality
Better information on the website when registrations are not allowed.
### Suggested implementation
A banner at the top of the site that clearly states when people are banned from something, and to contact the treasurer for more information.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/986Automatically send email with G Suite calendar id invite to member on joining...2020-02-19T20:27:12+01:00Job DoesburgAutomatically send email with G Suite calendar id invite to member on joining committee<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -→
Automatically send email with G Suite calendar id invite to member on joining committee
### Motivation
<!-- Why should we care? -->
To prev...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -→
Automatically send email with G Suite calendar id invite to member on joining committee
### Motivation
<!-- Why should we care? -->
To prevent ourselves from explaining this over and over
### Desired functionality
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
If a members joins a committee they will receive an email from Thalia stating 'hey you have joined committee x, fun times, here you also have the calendar stream for this committee'
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
Probably we will need to introduce a field in the active member group model that contains the id for their calendar. And then we can use that one to send an email to the new membershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/985Add link to the G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenAdd link to the G Suite Knowledge Base<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Add link to the [G Suite Knowledge Base](https://gsuite.members.thalia.nu/) in the "for members" menu.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/983Update members translations2020-01-29T21:21:15+01:00Joren VranckenUpdate members translations### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.### One-sentence description
Add the missing translations and update translations with mismatched punctuation/capitals (e.g. "Address:" and "adres") in the members app.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/977Remove obsolete permissions2019-12-04T21:29:10+01:00Sébastiaan VersteegRemove obsolete permissions### One-sentence description
Remove obsolete permissions that are left from removed things
### Why?
They're obsolete!
### Current implementation
We have the sentry backend, access to the board wiki and soon the nextcloud admin permi...### One-sentence description
Remove obsolete permissions that are left from removed things
### Why?
They're obsolete!
### Current implementation
We have the sentry backend, access to the board wiki and soon the nextcloud admin permissions.
### Suggested implementation
Should be removed.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/976Use html email template for all emails we send2020-02-19T21:13:30+01:00Job DoesburgUse html email template for all emails we send### One-sentence description
Use html email template for all emails we send
### Why?
It looks nice
### Current implementation
We only send plaintext mails, except for the information check emails
### Suggested implementation
Use t...### One-sentence description
Use html email template for all emails we send
### Why?
It looks nice
### Current implementation
We only send plaintext mails, except for the information check emails
### Suggested implementation
Use the information check email templatehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/974Improve navigation between admin views for event admin2019-12-18T19:14:35+01:00Job DoesburgImprove navigation between admin views for event admin<!--
You want something new.
-->
### One-sentence description
Improve navigation between admin views for event admin
### Motivation
Currently it works terrible.
### Desired functionality
On save, go to the view that makes sens...<!--
You want something new.
-->
### One-sentence description
Improve navigation between admin views for event admin
### Motivation
Currently it works terrible.
### Desired functionality
On save, go to the view that makes sense instead of very often go back to the event overview.
Also maybe provide buttons that take you to the event detail overview page, or to the frontend view, etc etc
I don't yet have clear suggestions but I think everyone can think of their own what makes sense.
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/973Automatically set referral event-slide hyperlink to event page2019-12-04T20:13:17+01:00Job DoesburgAutomatically set referral event-slide hyperlink to event page<!--
You want something new.
-->
### One-sentence description
Automatically set referral event-slide hyperlink to event page
### Motivation
Usability
### Desired functionality
If you set a slide to be an event slide, automatic...<!--
You want something new.
-->
### One-sentence description
Automatically set referral event-slide hyperlink to event page
### Motivation
Usability
### Desired functionality
If you set a slide to be an event slide, automatically fill in the hyperlink field with a URL to the event page (and maybe also auto fill in the title to be the event title?)
### Suggested implementation
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/970Update to Django 32020-02-19T20:02:34+01:00Joren VranckenUpdate to Django 3### Description
<!-- Please motivate why we should invest into this change -->
Django 3 has been [released](https://docs.djangoproject.com/en/3.0/releases/3.0/).### Description
<!-- Please motivate why we should invest into this change -->
Django 3 has been [released](https://docs.djangoproject.com/en/3.0/releases/3.0/).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/965Make mailinglist deletion safer/better informed2019-11-20T13:12:51+01:00Jelle Besselingjelle@pingiun.comMake mailinglist deletion safer/better informed### Motivation
Currently deleting a mailinglist will disable the group on gsuite, but delete the list on the website. This means that the name can be added as an alias for another list on the website, but gsuite will not support his, so ...### Motivation
Currently deleting a mailinglist will disable the group on gsuite, but delete the list on the website. This means that the name can be added as an alias for another list on the website, but gsuite will not support his, so we have a syncing error.
We could do an actual deletion on gsuite, and preserve archives another way. Or make sure the name cannot be used anymore after deletion, except when recreating the same list. If this method is chosen, the user should be informed on deletion.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/962Almanac entry page2020-03-11T19:29:52+01:00Job DoesburgAlmanac entry page<!--
You want something new.
-->
### One-sentence description
Make a page where people can enter things for the almanac of next year.
### Motivation
A lustrum is coming. The lustrum also involves an almanac. The almanaccie wants...<!--
You want something new.
-->
### One-sentence description
Make a page where people can enter things for the almanac of next year.
### Motivation
A lustrum is coming. The lustrum also involves an almanac. The almanaccie wants people to (opt in) appear in the almanac with a photo and, for example, a quote, etc.
Google Forms are mweh because uploads don't work very well and people are definitely going to make mistakes.
### Desired functionality
Actually just a copy of ones user profile, but on a separate page where we can add certain fields.
- appear in almanac yes/no
- photo
- quote
- maybe extra fields for statistics or something like that
- whether you want to buy the almanac
### Suggested implementation
I think we will need a separate package for this since it can be disabled after a while.
Yes, I know, maybe it is a bit overkill, but I'm curious about what you guys think of it. Otherwise we will move to another solution...https://gitlab.science.ru.nl/thalia/concrexit/-/issues/961Remove Payment type None2020-03-09T17:59:50+01:00Job DoesburgRemove Payment type None<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove Payment type None
### Why?
It is weird to have payment objects for payments that not yet have taken place. It makes much more sense to just have no payment then.
### Current implementation
For registrations, we now make payments for every accepted registration, and change the type when it really is paid.
### Suggested implementation
Make a payment object upon payment.