concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-11-06T19:31:20+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/930Thalia Pay: Add a direct debit payment method to the payment model2019-11-06T19:31:20+01:00Sébastiaan VersteegThalia Pay: Add a direct debit payment method to the payment modelSubtask of #632
### One-sentence description
Add a direct debit payment method to the payment model
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
The Payment model should have an option to ...Subtask of #632
### One-sentence description
Add a direct debit payment method to the payment model
### Motivation
Because we want to introduce Thalia Pay (#632)
### Desired functionality
The Payment model should have an option to mark it as paid using direct debit.
### Suggested implementation
Just like the other payment methods.Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/926English version of partner profile2019-10-03T16:43:11+02:00Thomas Klein BretelerEnglish version of partner profile### One sentence description
Partner profiles do not have an English description field
### Motivation
Because we're an international association
### Desired functionality
An English description field in the site administration for p...### One sentence description
Partner profiles do not have an English description field
### Motivation
Because we're an international association
### Desired functionality
An English description field in the site administration for partner pages so that we can publish both English and Dutch version of the partners profile.
### Suggested implementation
Just like with the general event forms both an English and Dutch field
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/922Receive the newsletter in the app2020-02-05T22:31:42+01:00Sébastiaan VersteegReceive the newsletter in the app### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.### One-sentence description
Receive the newsletter in the app
### Motivation
Useful new channel for promotion.
### Desired functionality
Receive and open the newsletter in the app sending a push notification.Mario TsatsevMario Tsatsevhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/914Update placeholder in activemembers2019-10-03T16:37:03+02:00Sébastiaan VersteegUpdate placeholder in activemembers### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we ...### One-sentence description
Update placeholder in activemembers
### Why?
It's in Dutch
### Current implementation
static/activemembers/images/placeholder.png
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->Job DoesburgJob Doesburghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/913Double occurrence of Society in public profile2019-09-04T13:04:48+02:00Julian van der HorstDouble occurrence of Society in public profile### One-sentence description
In a public profile of a user him/her being in a society shows in achievements and in Societies.
### Current behavior / Reproducing the bug
1. Go to a public profile of a member of a society
2. See that th...### One-sentence description
In a public profile of a user him/her being in a society shows in achievements and in Societies.
### Current behavior / Reproducing the bug
1. Go to a public profile of a member of a society
2. See that the society achievement appears double
### Expected behavior
The occurrence of the society should only be shown once, namely in the societies tabhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/896Remove course shorthands2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove course shorthands### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model### One-sentence description
Remove course shorthands
### Why?
Unused keys in the model of courses
### Current implementation
There are fields for shorthands
### Suggested implementation
Remove the fields from the model26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/894Typo in notification type description2019-06-27T13:47:35+02:00Job DoesburgTypo in notification type description### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<...### One-sentence description
Omg a typo
### Current behaviour / Reproducing the bug
![DC56FE60-E6D9-4091-8E59-37C78996ABA7](/uploads/a27561778f99f0abb7c73b49e092a430/DC56FE60-E6D9-4091-8E59-37C78996ABA7.jpeg)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/890Add information about other payment methods to the registration/renewal payme...2019-06-26T20:12:46+02:00Sébastiaan VersteegAdd information about other payment methods to the registration/renewal payment emails<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ beri...<!--
You want something new.
-->
### One-sentence description
Add information about other payment methods to the registration/renewal payment emails.
> Zouden jullie wellicht de tekst van de mailtjes met het ‘je moet betalen’ bericht kunnen aanpassen, waarbij je noemt dat ze als ze op een andere manier willen betalen, contact kunnen opnemen met penningmeester@thalia.nu? Dan verplichten we bijvoorbeeld docenten niet om langs te komen in de bk en dan kan ik ze in een eigen e-mail wel uitleggen dat als ze via incasso willen betalen, ze via bank accounts een machtiging (ook digitaal) mogen ondertekenen, en dan houden we in een apart lijstje bij dat we bij ze moeten incasseren.
<!-- What do you want? -->
### Motivation
Because some people (teachers) then do not need to visit the board room to renew their benefactor status.
### Desired functionality
Add some text.25Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/880Warning text for unregistering after deadline is unclear2019-08-13T14:18:34+02:00Job DoesburgWarning text for unregistering after deadline is unclear### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of...### One-sentence description
The warning text for unregistering after deadline is unclear
### Current behaviour / Reproducing the bug
The current text suggests that the fine for unregistering is fixed (it says "the costs per person of € x,xx").
### Expected behaviour
The text should suggest that the exact amount will be determined later, and that the amount that is indicated is just an estimate. The terms and conditions are clear about this, but it would be nice to make the initial warning text just as clear.26https://gitlab.science.ru.nl/thalia/concrexit/-/issues/879Update fullcalendar to v42019-06-20T14:16:37+02:00Sébastiaan VersteegUpdate fullcalendar to v4### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v3### One-sentence description
Update fullcalendar to v4
### Why?
New version
### Current implementation
v3
### Suggested implementation
v4
https://fullcalendar.io/docs/upgrading-from-v326Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/878Remove 'Set all registered to present and paid'2019-08-28T18:56:23+02:00Sébastiaan VersteegRemove 'Set all registered to present and paid'<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove 'Set all registered to present and paid'
### Why?
1. It's broken
2. It assumes that there is one option for the payment which there is not anymore.
### Current implementation
Some.
### Suggested implementation
None.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/877Remove vacancy expiration mails2020-02-04T14:40:33+01:00Joren VranckenRemove vacancy expiration mails<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Remove vacancy expiration mails.
### Why?
<!-- Please motivate why we should invest into this change -->
The vacancy expiration mails are a bit feature creep. They are not really helpful, because the commissioner of external affairs has their own administration with expiration dates (including the vacancies). Furthermore, the emails also don't help because they arrive either too late or too soon. Some partners have a lot longer negotiating time than one month, while others can be handled within a few days.
Besides that, it is also a bit weird that we are only sending mails about vacancies. What about the partner profiles? Why are we not tracking expiration dates for those?
### Suggested implementation
I suggest we remove this functionality altogether which will result in less code to maintain and less useless emails to be sent.26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/876Use aliases instead of aliasses2019-11-27T19:49:53+01:00Joren VranckenUse aliases instead of aliasses<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
Replace "aliasses" with "aliases" in the `mailinglists` app.
### Why?
<!-- Please motivate why we should invest into this change -->
"aliases" is the correct plural of "alias".Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/875Use Firebase SDK batch sending2019-08-04T18:46:25+02:00Sébastiaan VersteegUse Firebase SDK batch sending<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
Because it wasn't possible before: https://firebase.google.com/support/release-notes/admin/python#version_2170_-_may_23_2019
### Current implementation
No batch sending: https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/pushnotifications/models.py#L172
### Suggested implementation
Batch sending using the new API.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/874Cancel events2019-05-22T13:09:37+02:00Joren VranckenCancel events<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Add a way to cancel events.
### Motivation
<!-- Why should we care? -->
When an event is canceled, it is indicated on the event page by the...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
Add a way to cancel events.
### Motivation
<!-- Why should we care? -->
When an event is canceled, it is indicated on the event page by the organiser. At the moment, organisers do this in multiple ways. For example, some delete the event, some put "[CANCELED]" in the title and some change the description. One consistent way to do this would be nice.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/873Fitting 2000x430 images to 2000x430 does not work2019-05-23T13:26:21+02:00Nick van OersFitting 2000x430 images to 2000x430 does not work/label ~bug ~"priority: medium"
### One-sentence description
Fitting 2000x430 images to 2000x430 does not work
### Current behaviour / Reproducing the bug
1. Upload a 2000x430px slide to the website
2. Check the homepage for the slid.../label ~bug ~"priority: medium"
### One-sentence description
Fitting 2000x430 images to 2000x430 does not work
### Current behaviour / Reproducing the bug
1. Upload a 2000x430px slide to the website
2. Check the homepage for the slide
3. It does not load
### Expected behaviour
1. Upload a 2000x430px slide to the website
2. Check the homepage for the slide
3. It does load
### Upstream problem
This is caused by a precision problem in Pillow. The `ImageOps.fit` method calculates a box to crop the image in.
Since the image is the same the calculation made is as follows:
```
>>> 2000/430 * 430
2000.0000000000002
```
This is then used `2000-(2000/430 * 430)` and the box has a left value that is negative causing an exception.
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/869Improve categories2019-08-28T20:01:52+02:00Sébastiaan VersteegImprove categories### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
...### One-sentence description
Improve categories
### Why?
Because it's not really useful right now, everything is marked as 'Other'
### Current implementation
- Drinks
- Activity
- Lunch Lecture
- General Meeting
- Workshop
- Alumni
- Party
- Other
### Suggested implementation
- Alumni (old: Alumni)
- Education (old: Workshop + Lunch Lecture)
- Career (some workshops should go here, manual intervention)
- Leisure (old: Drinks + Party, now also: paintball + lasertag etc)
- Association Affairs (old: GM, now also: SNIC info meeting, board interest meetings) (Verenigingszaken)
- Other (old: Other + Activity)
Important: this requires migrations to changes the categories of existing events to the new ones!26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/866Investigate event saving error2019-05-15T20:44:39+02:00Sébastiaan VersteegInvestigate event saving error### One-sentence description
Something goes wrong during the saving of events.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/380
### Expected behaviour
No Sentry errors### One-sentence description
Something goes wrong during the saving of events.
### Current behaviour / Reproducing the bug
https://sentry.thalia.nu/sentry/concrexit/issues/380
### Expected behaviour
No Sentry errorshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/863Large events on mobile closes automatically2019-06-26T20:14:06+02:00Joren VranckenLarge events on mobile closes automatically### One-sentence description
<!-- What breaks -->
Large events on mobile closes automatically.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Ste...### One-sentence description
<!-- What breaks -->
Large events on mobile closes automatically.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
1. Go to [the event page](https://thalia.nu/events).
2. Click on BIT-event.
3. Scroll down to "the go to the evenpage"-button.
4. Observe that the information card closes.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/858Log to disk in production2019-04-15T11:01:31+02:00Joren VranckenLog to disk in production### One-sentence description
<!-- What do you want? -->
In production log to `/concrexit/log/django.log`.
### Motivation
<!-- Why should we care? -->
Extra logging.### One-sentence description
<!-- What do you want? -->
In production log to `/concrexit/log/django.log`.
### Motivation
<!-- Why should we care? -->
Extra logging.24Sébastiaan VersteegSébastiaan Versteeg