concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-14T21:53:41+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/739Change dropdown menu in front-end for user registration/enrollment with amount2018-11-14T21:53:41+01:00Job DoesburgChange dropdown menu in front-end for user registration/enrollment with amount<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the p...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the price of membership type in the dropdown menu of front-end registration page.
### Why?
People are lazy. They don't read the whole text and only fill in the form. They select 'study membership' and when they want to pay, they see it is more expensive. That's annoying because you have to change data afterwards (which can't be done a.t.m. after approval).
### Current implementation
The dropdown menu only shows 'one year membership' and 'study membership'
### Suggested implementation
The dropdown menu shows 'one year membership (€ 7,50)' and 'study membership (€ 30,00)'Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/633Change language in backend2018-05-16T19:49:26+02:00Joren VranckenChange language in backend### One-sentence description
Add the possibility to change the language in the backend.
### Why?
It is not possible to change the language in the backend.
### Current implementation
It is only possible to change the language in the fro...### One-sentence description
Add the possibility to change the language in the backend.
### Why?
It is not possible to change the language in the backend.
### Current implementation
It is only possible to change the language in the frontend.
If you want to change the language in the backend, you have to first go to the frontend and change the language there and then go back to the backend.
### Desired implementation
A button to switch the language in the backend, similar to the one in the frontend.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/697Change mentions of 'supporter' to 'benefactor'2018-10-18T11:31:34+02:00Sébastiaan VersteegChange mentions of 'supporter' to 'benefactor'### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use ...### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use several different names for the 'begunstiger' membership type.
### Desired implementation
Always use 'benefactor' as translation.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/545Change the way we do board permissions2018-01-16T22:20:57+01:00Sébastiaan VersteegChange the way we do board permissionsRelated to #479:
>twiggers: Somewhat related: I'd rather attach the board to a regular Django group than edit their (committee)group's permissions each year: it's much more error-prone to re-add those permissions than it is to add and r...Related to #479:
>twiggers: Somewhat related: I'd rather attach the board to a regular Django group than edit their (committee)group's permissions each year: it's much more error-prone to re-add those permissions than it is to add and remove some members from a Django Group.
> sversteeg: We could create a connection between committees and groups? I don't believe opening 12 user profiles and changing the groups is less error-prone than removing and re-adding the permissions. Maybe continue this is another issue, since I finished this one.
> twiggers: The difference is the kind of mistakes you make. When opening/changing 12 user profiles, you may forget one. When manually adding the tens of permissions we need to give to boards, we're bound to forget one. This is followed by a board member then trying to do something they need to do, and then assigning themselves superuser privileges, and then later perhaps breaking the site.
Good point, needs discussion1.13https://gitlab.science.ru.nl/thalia/concrexit/-/issues/431Comma separated mail export event registrations2017-12-10T21:12:53+01:00Jesse van SonComma separated mail export event registrations### One-sentence description
Comma separated mail export event registrations
### Desired behaviour
Add a button to event detail admin page to immediately export the email addresses of all members that have registered for an even...### One-sentence description
Comma separated mail export event registrations
### Desired behaviour
Add a button to event detail admin page to immediately export the email addresses of all members that have registered for an event.
The export should just be a string in a text field so that it is copy-pasteable.Joost Rijneveldjoost@joostrijneveld.nlJoost Rijneveldjoost@joostrijneveld.nlhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/434Committee email address on committee page2017-12-13T12:44:17+01:00Joren VranckenCommittee email address on committee page### One-sentence description
Show the email for each committee on their respective pages.
### Why?
Not every committee has put its email address in its description on the website.
For example, if I want to reach the study trip committ...### One-sentence description
Show the email for each committee on their respective pages.
### Why?
Not every committee has put its email address in its description on the website.
For example, if I want to reach the study trip committee, I will not find an email to reach them on [their page](https://thalia.nu/committees/49/).
### Current implementation
On each committee page, there is a description of the committee.
### Desired implementation
On each committee page, there is a description of the committee and below the description there is an email address to reach the committee.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/828Committee/Society Names on Profile Page Should be Clickable2019-02-13T21:24:43+01:00Thijs de JongCommittee/Society Names on Profile Page Should be Clickable### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievem...### One-sentence description
The committee names on the profile pages of people should link to the committee/society pages
### Current behaviour / Reproducing the bug
At the profile pages of people, there is a section called Achievements for Thalia. At this moment, if you click on the committees/societies, nothing happens.
### Expected behaviour
When you click on a committee/society underneath the Achievements for Thalia, it sends you to the Page of the corresponding committee/society.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/604Committee Treasurers2018-05-08T13:40:29+02:00Milan van StiphoutCommittee Treasurers### One-sentence description
Allow committees to have a treasurer.
### Desired behaviour
In the past Committee Chairman Meeting (CVO), the committee chairmen agreed that having an explicit treasurer would increase financial responsibilit...### One-sentence description
Allow committees to have a treasurer.
### Desired behaviour
In the past Committee Chairman Meeting (CVO), the committee chairmen agreed that having an explicit treasurer would increase financial responsibility in the committees.
Similarly to a committee chairman, committee treasurer should be a status (with a ribbon similar to that of a chairman) on the website. There can be at most one treasurer per committee at any given time. The status of treasurer on the website is identical to that of chairman.
Thanks. :)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/590Confirmation for registration cancellation2018-03-21T20:25:20+01:00Freek van de Venfreek@freekvandeven.nlConfirmation for registration cancellation### One-sentence description
People need to get a confirmation window to cancel
### Desired behaviour
when someone clicks the cancel registration a pop-up appears with a confirmation message### One-sentence description
People need to get a confirmation window to cancel
### Desired behaviour
when someone clicks the cancel registration a pop-up appears with a confirmation messageSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/790Conscribo sync Thalia members2019-01-23T21:11:16+01:00Job DoesburgConscribo sync Thalia members<!--
You want something new.
-->
### One-sentence description
Synchronise Thalia members (and benefactors and honorary members) with Conscribo relation management.
### Motivation
Now when sending an invoice to a member, we must c...<!--
You want something new.
-->
### One-sentence description
Synchronise Thalia members (and benefactors and honorary members) with Conscribo relation management.
### Motivation
Now when sending an invoice to a member, we must check whether the email-address and other data is still up to date in Conscribo and for new members we must copy everything by hand to Conscribo. Conscribo has an (somewhat limited but existing) API for this purpose.
Since the wallet-issue is a long-term thing, it might be nice to implement this part of synchronization already.
### Desired functionality
In Conscribo I can add a relation-group type "Member" and add all desirable fields to it. This would include: name, email, address and maybe bank account things (sepa mandates possibly as well, but not really important since hardly anyone uses it and it is administered by hand anyway currently).
Conscribo, according to their awesome documentation, then updates or adds that contact. Then in Conscribo I can add reimbursements or invoices to all members without copying data by hand, and have them up-to-date always.
### Suggested implementation
Every now and then (every night? every week? every update?) the thalia server contacts Conscribo and sends edited members.
For privacy, we do have a data processing agreement with Conscribo. Removing members from Conscribo is also possible, except for when they have invoices linked to them; then you can only archive them. However since then that member is part of the financial administration of Thalia, this is not a real problem privacy wise.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/937Create HTML version of information check email2019-11-13T21:58:58+01:00Sébastiaan VersteegCreate HTML version of information check email### One-sentence description
Create HTML version of information check email
### Motivation
It's formatting in the text version is bad.
### Desired functionality
Have the data nicely formatted.
### Suggested implementation
Use a ta...### One-sentence description
Create HTML version of information check email
### Motivation
It's formatting in the text version is bad.
### Desired functionality
Have the data nicely formatted.
### Suggested implementation
Use a table or something.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1003Create more kinds of fixtures2020-02-19T22:57:03+01:00Job DoesburgCreate more kinds of fixtures<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should b...<!--
You want something new.
-->
### One-sentence description
Create fixtures should create fixture for, for example, courses as well.
### Motivation
It makes testing easier
### Desired functionality
At least fixtures should be created for courses. But also maybe for photos and albums, documents, payments, registrations?, etc...
### Suggested implementationSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1010Create Payable interface2020-03-04T19:09:01+01:00Job DoesburgCreate Payable interface### One-sentence description
Create a Payable interface to be used for all models that use Payments
### Why?
To prevent code duplication and improve testing
### Current implementation
Shitty, chaotic, anarchy, tears
### Suggested i...### One-sentence description
Create a Payable interface to be used for all models that use Payments
### Why?
To prevent code duplication and improve testing
### Current implementation
Shitty, chaotic, anarchy, tears
### Suggested implementation
Payable abstract class with `@property @abstractmethod`s:
- `payment_amount` as the amount of the payment
- `payment_topic` as the grouping key for the type of payment (ledger information)
- `payment_notes` for the user specific details
- `payment_payer` for the user paying
Payments must then have a constructor `create_payment` that takes as arguments:
- a `Payable` object
- a payment `processor` that is the person that processes the payment
- the payment `type` being either thalia pay, card, cash or wire transfer (no None anymore!)Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/609Creating an event without specifying time crashes the request2018-03-28T19:48:00+02:00Sébastiaan VersteegCreating an event without specifying time crashes the request### One-sentence description
Creating an event without specifying time crashes the request
### Current behaviour
Crash
### Expected behaviour
Nice error message
### Steps to reproduce
1. Create a new event, only specify the _date_...### One-sentence description
Creating an event without specifying time crashes the request
### Current behaviour
Crash
### Expected behaviour
Nice error message
### Steps to reproduce
1. Create a new event, only specify the _date_ and no _time_ for the start/end of the event.
2. SaveLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/220CSS refactoren en kleine issues fixen2018-11-25T01:45:54+01:00Sébastiaan VersteegCSS refactoren en kleine issues fixen* [x] Fotos lopen over elkaar bij kleiner scherm, bijvoorbeeld in de ledenlijst (#207)
* [x] De taal-knop staat op mobiel over het logo (#202)
* [x] Thumbnails respecteren rotatie niet (#186)
* [ ] Meer SCSS, minder standaard CSS
* [...* [x] Fotos lopen over elkaar bij kleiner scherm, bijvoorbeeld in de ledenlijst (#207)
* [x] De taal-knop staat op mobiel over het logo (#202)
* [x] Thumbnails respecteren rotatie niet (#186)
* [ ] Meer SCSS, minder standaard CSS
* [ ] Nutteloze onderdelen van de template weghalen zodat het style bestand minder groot en complex wordt.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/549Ctrl+Alt+Delirium can order inactive pizza's2018-01-10T19:14:15+01:00Thom WiggersCtrl+Alt+Delirium can order inactive pizza's### One-sentence description
In the manual 'add order' form it's possible to order pizza kinds that have long since been out of stock at Domino's
### Current behaviour
1. Click 'add order' on a pizza event order overview
2. See a mass...### One-sentence description
In the manual 'add order' form it's possible to order pizza kinds that have long since been out of stock at Domino's
### Current behaviour
1. Click 'add order' on a pizza event order overview
2. See a massive dropdown
### Expected behaviour
A slightly less massive dropdownThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/850Dataminimisation deletes website profile2019-10-03T16:37:53+02:00Luko van der MaasDataminimisation deletes website profile
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removed
### One-sentence description
When executing the dataminimisation it deletes the website but it shouldn't
### Current behaviour / Reproducing the bug
The website is removed from the profile
### Expected behaviour
Not removedLuna-Elise SchernthanerLuna-Elise Schernthanerhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/881Data minimization on payments and event registrations after 7 years.2019-11-27T17:01:49+01:00Job DoesburgData minimization on payments and event registrations after 7 years.### One-sentence description
Data minimization on payments and event registrations after 7 years.
### Motivation
The privacy office of the RU has indicated that there are no grounds for Thalia to keep data of payments or event partici...### One-sentence description
Data minimization on payments and event registrations after 7 years.
### Motivation
The privacy office of the RU has indicated that there are no grounds for Thalia to keep data of payments or event participation after 7 years (the legal obligatory time to keep this information). So in order to be fully compliant to the AVG/GDPR we should maybe delete this information after 7 years.
### Desired functionality
7 years after an event, information of who attended what activity should be removed and whether they paid, and how.
It would be nice if we can keep track of the amount of participants at that activity.
### Suggested implementation
Apart from that I can imagine this is not quite easy, I have no idea.
Note that this request is only based on information provided by the Radboud University privacy office. But the Technicie I'm sure also have an grounded opinion about this. So if you guys think it is unnecessary to remove this data because of reasons, and you think it is compliant to the AVG/GDPR that is fine as well! This is just passing on information actually.2022-06-01https://gitlab.science.ru.nl/thalia/concrexit/-/issues/995Deliver sliders or other large images as webp2020-01-15T22:41:46+01:00Jelle Besselingjelle@pingiun.comDeliver sliders or other large images as webp<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### Why?
According to [Google PageSpeed](https://developers.google.com/speed/pagespeed/insights/?hl=nl&url=thalia.nu&tab=mobile), we can speed up our site by a lot by converting slider images to webp.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Large pictures are all served as png, this is a good image format for things that need to be compressed lossless.
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
Supply images as `<picture>` [with multiple sources](https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images#Use_modern_image_formats_boldly)
<!-- Provide (a) suggestion(s) for how we could approach this -->https://gitlab.science.ru.nl/thalia/concrexit/-/issues/626Display order of documents2018-05-28T12:50:46+02:00Gerdriaan MulderDisplay order of documents### One-sentence description
The display order of the documents can be configured.
### Desired behaviour
At the moment, there does not seem to be a logical order in the documents page. For example, the document "Huishoudelijk Reglement ...### One-sentence description
The display order of the documents can be configured.
### Desired behaviour
At the moment, there does not seem to be a logical order in the documents page. For example, the document "Huishoudelijk Reglement (26-08-2014)" is mentioned earlier than the more recent document "Huishoudelijk Reglement (04-10-2017)". This is confusing.
What I would like to see is that a more recent document is shown earlier on when multiple versions of that document exist.
It is also acceptable if an admin can configure this (ideally, the "Statuten" and "Huishoudelijk Reglement" would be mentioned first, before all other documents).Jeremy GuijtJeremy Guijt