concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-14T11:15:49+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/767Filter for former members2018-11-14T11:15:49+01:00Rico te WechelFilter for former members### One-sentence description
Apply filter on former members in the backend user list.
### Motivation
For the alumni committee, but perhaps in the future also for other parties and/or occasions, this would be a nice feature to easily rea...### One-sentence description
Apply filter on former members in the backend user list.
### Motivation
For the alumni committee, but perhaps in the future also for other parties and/or occasions, this would be a nice feature to easily reach our former members. In case of the alumni committee: We want to email them with invitations for our events.
### Desired functionality
In the backend, under users, I want to be able to apply a filter on former members. Currently this is only possible for members, benefactors and honorary members. After I applied the filter on the users I want to export their mailadresses. I haven't seen this option under 'desired action'. Should I make a new issue for this, or is there another way to achieve this?20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/765Remind people to fill in full descriptions in both languages in the event bac...2018-11-14T21:53:23+01:00Gijs HendriksenRemind people to fill in full descriptions in both languages in the event backend### One-sentence description
Add a reminder to the event description fields that people need to fill in the descriptions in both languages.
### Motivation
Some Dutch-only events have an English description "This event is in Dutch", wi...### One-sentence description
Add a reminder to the event description fields that people need to fill in the descriptions in both languages.
### Motivation
Some Dutch-only events have an English description "This event is in Dutch", without the actual Dutch description. This forces people to change their language to Dutch if they want to see the description.
See also ThaliApp#84.
### Desired functionality
A small notice at the description input fields, with something along the lines of "Don't forget to include a full description in both languages!".Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/763Sister Association page also contains brother associations2018-11-14T22:00:14+01:00Joren VranckenSister Association page also contains brother associations### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -...### One-sentence description
<!-- What breaks -->
Sister Association page also contains brother associations.
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Go to [Sister Association page](https://thalia.nu/sister-associations)
2. Observe the brother associations (and one foundation).
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
The page is called something like "Brother and Sister Associations" or "Links" (with links to all affiliated organisations like sister associations, the USR and Ninja).Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/761Improve vacancy validation2018-11-08T17:33:16+01:00Sébastiaan VersteegImprove vacancy validation### One-sentence description
Improve vacancy validation
### Current behaviour / Reproducing the bug
Currently the only required field for vacancies is the _title_.
### Expected behaviour
The description should be required as well, j...### One-sentence description
Improve vacancy validation
### Current behaviour / Reproducing the bug
Currently the only required field for vacancies is the _title_.
### Expected behaviour
The description should be required as well, just like the name of the partner and a logo.
Thus if there is no connected partner the partner name/logo fields should be correctly validated.Tom van BusselTom van Busselhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/759Move the events admin views to the admin model2018-11-29T00:04:37+01:00Sébastiaan VersteegMove the events admin views to the admin model### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the a...### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the admin.
### Suggested implementation
Override the url config of the model admin used for events to add our custom views. Just like here: https://docs.djangoproject.com/en/2.1/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_urls20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/754Registration date empty in email notification to first person on waiting list2018-10-31T19:23:20+01:00Gijs HendriksenRegistration date empty in email notification to first person on waiting list### One-sentence description
In the (Dutch) email sent to the first person on the waiting list when someone cancels their registration, the registration date is empty, resulting in the message "Je hebt je op aangemeld voor...".
### Cur...### One-sentence description
In the (Dutch) email sent to the first person on the waiting list when someone cancels their registration, the registration date is empty, resulting in the message "Je hebt je op aangemeld voor...".
### Current behaviour / Reproducing the bug
1. Be the first on the waiting list for a certain event.
2. Trick someone into cancelling their registration so you can go to the event.
3. Receive an email notifying you that you can attend the event.
4. Notice your registration date is not included in the email.
### Expected behaviour
The registration date is not empty.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/749Member list category benefactors2018-10-31T18:46:02+01:00Job DoesburgMember list category benefactors<!--
You want something new.
-->
### One-sentence description
Add benefactors as category to member list.
### Motivation
Currently it's inconsistent. There is a category 'honorary members' and even 'old members' but no 'benefacto...<!--
You want something new.
-->
### One-sentence description
Add benefactors as category to member list.
### Motivation
Currently it's inconsistent. There is a category 'honorary members' and even 'old members' but no 'benefactors' whereas it really is a separate group Thalians.
### Desired functionality
Also have a tab 'benefactors' at the members list page.
### Suggested implementation
I think this is quite clear.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/746Registration front-end notice for address formatting2018-11-05T11:54:03+01:00Job DoesburgRegistration front-end notice for address formatting<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Show notice f...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Show notice for address formatting on thalia registrations page in front end.
### Why?
For international student from, i.e. Great-Britain, address formatting is weird. They put the house number in front. Now this produces an unclear error message.
### Current implementation
An unclear error message
### Suggested implementation
Either a clear error message (or example how you should format your address), or acceptance of more ways of formatting.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/744Sync members with Conscribo2018-10-22T19:05:17+02:00Job DoesburgSync members with Conscribo<!--
You want something new.
-->
### One-sentence description
Sync members with Conscribo
### Motivation
Currently, Thalia keeps 2 databases for members. The main one is the Thalia website of course. However somewhere far away, w...<!--
You want something new.
-->
### One-sentence description
Sync members with Conscribo
### Motivation
Currently, Thalia keeps 2 databases for members. The main one is the Thalia website of course. However somewhere far away, we also have Conscribo for all financial administration. It is a lot of work to keep Conscribo up to date with the Thalia website. Every time an invoice has to be sent, the emailaddress has to be checked with the Thalia website and possibly be updated.
Luckily, Conscribo offers an API for this. It is easy to feed Conscribo a .csv with new data, and Conscribo will update itself. This way, financial administration becomes a whole lot more efficient.
Yes of course GDPR plays a role here. However Thalia has a processing agreement with Conscribo so it shouldn't be that much of a problem.
### Desired functionality
Sync the current members (people with active membership) with Conscribo. As data minimization, you could also select all people that are either active member or have ever registered for an event (those are the relevant members for Thalia's financial bookkeeping, though this will probably be all members).
### Suggested implementation
Every night, a cronjob runs sending a .csv with members' data to Conscribo's API, which can be found here: https://www.conscribo.nl/api/https://gitlab.science.ru.nl/thalia/concrexit/-/issues/743"BHV-er" status, borrelbrevet license and camera license properties for members2018-11-07T19:37:42+01:00Job Doesburg"BHV-er" status, borrelbrevet license and camera license properties for members<!--
You want something new.
-->
### One-sentence description
"BHV-er" status, borrelbrevet license and camera license properties for members
### Motivation
Currently it's a bit of a mess to keep track of which people have a "BHV...<!--
You want something new.
-->
### One-sentence description
"BHV-er" status, borrelbrevet license and camera license properties for members
### Motivation
Currently it's a bit of a mess to keep track of which people have a "BHV" license, borrelbrevet license or camera license. The board keeps all kinds of lists (sometimes even .docx bleh) that get outdated in no time. It would be very nice to have this administration on the website, THE place for this kind of things.
### Desired functionality
There are multiple possibilities.
The first is just to add checkboxes to a members' profile (editable by the board). For camera license and borrelbrevet license, this would suffice. However, a date would be better (so you can register the date they received it.
For BHV status, also some invalidation would be nice. Because a BHV license needs renewal after a year, it would be nice to somewhere show that someones BHV status is not active anymore.
Of course, many features can be added. You could say you only store the date of the last BHV course, or keep a whole history. You could add e-mails for BHV stating that someone's status is about to invalidate, and that they should contact the board in case they did 'update' their BHV.
You could maybe even extend this to just arbitrary information fields, just as for event registration. This is up to you. If you feel like this is very nice to implement, please do so. However a regular checkbox is fine as well ;)
### Suggested implementation
Actually this is described under 'desired functionality'https://gitlab.science.ru.nl/thalia/concrexit/-/issues/742Society members front-end link to profilepage2018-10-22T19:07:31+02:00Job DoesburgSociety members front-end link to profilepage<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make the link...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make the link from members of a society in the front-end, link to their profile page rather than the society page.
### Why?
It is more intuitive and it works the same way for committee members.
### Current implementation
When you click on a society member in the front-end, you're redirected to the (same) society page.
### Suggested implementation
Be redirected to the member profile pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/741Make payments linkable to registration2018-10-22T19:08:51+02:00Job DoesburgMake payments linkable to registration<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make payments...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make payments linkable to registration
### Why?
When checking payments, you can only see a 'payment' object but apart from that they have no real use. However sometimes it really is useful to check all payments done on a certain day.
### Current implementation
The current implementation of payments shows payment objects. However when in a payment object, you can't easily go back to the registration that is connected to the Payment object.
### Suggested implementation
Being able to see the registration that the payment was connected to.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/739Change dropdown menu in front-end for user registration/enrollment with amount2018-11-14T21:53:41+01:00Job DoesburgChange dropdown menu in front-end for user registration/enrollment with amount<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the p...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the price of membership type in the dropdown menu of front-end registration page.
### Why?
People are lazy. They don't read the whole text and only fill in the form. They select 'study membership' and when they want to pay, they see it is more expensive. That's annoying because you have to change data afterwards (which can't be done a.t.m. after approval).
### Current implementation
The dropdown menu only shows 'one year membership' and 'study membership'
### Suggested implementation
The dropdown menu shows 'one year membership (€ 7,50)' and 'study membership (€ 30,00)'Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/738Registrations automatically save at approval2018-10-22T18:57:12+02:00Job DoesburgRegistrations automatically save at approval<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically save registrations that are edited when hitting 'approve'
### Why?
Because it is more intuitive
### Current implementation
You first have to save manually and open the registration before you can hit 'approve'
### Suggested implementation
When 'approve' is hit, the altered data is saved automaticallyhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/735Event registration 'save and add another' doesn't work correctly2018-11-02T15:46:27+01:00Joris ReichertEvent registration 'save and add another' doesn't work correctly### One-sentence description
### Current behaviour
After manually adding a registration in the event admin using the button 'Save and add another' I'm redirected to the overview instead of getting another add form. The message is corre...### One-sentence description
### Current behaviour
After manually adding a registration in the event admin using the button 'Save and add another' I'm redirected to the overview instead of getting another add form. The message is correct, but the page is not.
![image](/uploads/5ec00a8ff5ee2d47420f9dd5b628a140/image.png)
Also, 'Save and continue editing' seems to have the same behaviour.
### Expected behaviour
Get the add form instead of the overview
### Steps to reproduce
1. Create a registration in the backend for and event using 'save and add another'
2. Get the overview instead of form
19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/733Move alert to templatetag2018-10-18T15:53:31+02:00Sébastiaan VersteegMove alert to templatetag### One-sentence description
Move alert to templatetag
### Why?
DRY, lots of alerts everywhere we could just easily make it a templatetag.
### Current implementation
Lots of alerts, for example
```
<div class="alert alert-success al...### One-sentence description
Move alert to templatetag
### Why?
DRY, lots of alerts everywhere we could just easily make it a templatetag.
### Current implementation
Lots of alerts, for example
```
<div class="alert alert-success alert-dismissable">
{% trans "Your profile has been updated successfully." %}
<button type="button" class="close" data-dismiss="alert" aria-label="Close">
<span aria-hidden="true">×</span>
</button>
</div>
```
### Desired implementation
Put the html in an include and us a templatetag to make this easy to reuse. Could use https://django-bootstrap4.readthedocs.io/en/latest/templatetags.html#bootstrap4.templatetags.bootstrap4.bootstrap_alert, but not sure if we want to rely on this.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/728Follow-up from "Fix wiki login"2018-10-24T19:26:53+02:00Thom WiggersFollow-up from "Fix wiki login"The following discussion from !992 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/992#note_55114):
> Perhaps it's a good idea to move the wiki namespace int...The following discussion from !992 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/992#note_55114):
> Perhaps it's a good idea to move the wiki namespace into groupshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/727Accepted registration had no username2018-11-13T19:35:52+01:00Sébastiaan VersteegAccepted registration had no username### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/724Update Fancybox to version 32018-11-14T18:52:53+01:00Sébastiaan VersteegUpdate Fancybox to version 3### One-sentence description
Update Fancybox to version 3
### Why?
We currently use an old version (2.x). However, this version is licensed under CC BY-NC 3.0. Version 3 is GPLv3 for open source projects only. So I think this can be d...### One-sentence description
Update Fancybox to version 3
### Why?
We currently use an old version (2.x). However, this version is licensed under CC BY-NC 3.0. Version 3 is GPLv3 for open source projects only. So I think this can be done only after fully open sourcing. [Their website](http://fancyapps.com/fancybox/3/#license) is unclear:
> fancybox is licensed under the GPLv3 license for all open source applications.
A commercial license is required for all commercial applications (including sites, themes and apps you plan to sell).
¿Our website is non-commercial but not open source?
### Current implementation
Fancybox 2.x
### Desired implementation
Fancybox 3.x20Sébastiaan VersteegSébastiaan Versteeg