concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-02-10T17:20:33+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/291Test sitemap in unit tests2019-02-10T17:20:33+01:00Joost Rijneveldjoost@joostrijneveld.nlTest sitemap in unit testsThe sitemap is quite vulnerable to `NoReverseMatch` exceptions when the URL scheme changes. A test case that tries to access the sitemap would likely reveal these errors preemptively (but it would require fixtures to be fairly complete, ...The sitemap is quite vulnerable to `NoReverseMatch` exceptions when the URL scheme changes. A test case that tries to access the sitemap would likely reveal these errors preemptively (but it would require fixtures to be fairly complete, as such errors might not trigger when parts of the database are empty).https://gitlab.science.ru.nl/thalia/concrexit/-/issues/818Remove SECRET_KEY from production.py2019-02-07T16:26:12+01:00Jelle Besselingjelle@pingiun.comRemove SECRET_KEY from production.py<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove defaul...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove default SECRET_KEY value from production.py settings
### Why?
The SECRET_KEY should always be set in production.py, so it is a better idea to crash when it isn't set, than to use a default nonsecure key.
### Current implementation
A default key is set in production.py. (https://gitlab.science.ru.nl/thalia/concrexit/blob/23b79eb4461ac082a94d7a0c4318c0a848743c67/website/thaliawebsite/settings/production.py#L29)
### Suggested implementation
```python
SECRET_KEY = os.environ.get('DJANGO_SECRET')
```
or, the following, which throws an IndexError when the key isn't present
```python
SECRET_KEY = os.environ.environ['DJANGO_SECRET']
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/813'Wire transfer' as third payment option for admins2019-02-06T20:39:16+01:00Job Doesburg'Wire transfer' as third payment option for admins<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
A third payme...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
A third payment option 'other' only for admins
### Why?
Sometimes things are not being paid in cash nor pin/debit card. It occurs that people pay via wire transfer of something is settled (? google translate says this is the word, verrekenen) with something else or just something else financially interesting happens. This happens often for benefactors (with wire transfers) but occasionally with events too (when people do not pay at the activity but upfront). For clarity it would be nice to be able to register this correctly in the Thalia website. It is especially useful to check the bookkeeping because the 'other' payments are interesting.
Because only the board should do these kind of payments, this option should only be available for people with board permissions.
### Current implementation
There are 2 options for payments.
### Suggested implementation
A third option for payments, that can only be used by board members.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/817Add shoe size2019-02-06T19:24:18+01:00Tobias van der WerffAdd shoe size<!--
You want something new.
-->
### One-sentence description
Add shoe size to user profiles
### Desired behaviour
We would like to know the shoe size of our members so that we can reserve shoes at the bowling alley and skiing re...<!--
You want something new.
-->
### One-sentence description
Add shoe size to user profiles
### Desired behaviour
We would like to know the shoe size of our members so that we can reserve shoes at the bowling alley and skiing resort without asking for the same information each year.
However, the sizes should be restricted to values between 39 and 47, since there are no smaller/larger shoes at those places. Since not everyone might have a size in this range the field can be empty.
We want to edit the field on the member edit page in the admin and show the shoe size on the public user profiles.
### Suggested implementation
New fieldTobias van der WerffTobias van der Werffhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/811Add field for BIC values of bank accounts2019-01-25T13:07:56+01:00Sébastiaan VersteegAdd field for BIC values of bank accounts<!--
You want something new.
-->
### One-sentence description
Add field for BIC values of bank accounts
### Motivation
International students may want to use foreign bank accounts
### Desired functionality
Add field for BIC val...<!--
You want something new.
-->
### One-sentence description
Add field for BIC values of bank accounts
### Motivation
International students may want to use foreign bank accounts
### Desired functionality
Add field for BIC values of bank accounts
### Suggested implementation
Just a non-required fieldhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/790Conscribo sync Thalia members2019-01-23T21:11:16+01:00Job DoesburgConscribo sync Thalia members<!--
You want something new.
-->
### One-sentence description
Synchronise Thalia members (and benefactors and honorary members) with Conscribo relation management.
### Motivation
Now when sending an invoice to a member, we must c...<!--
You want something new.
-->
### One-sentence description
Synchronise Thalia members (and benefactors and honorary members) with Conscribo relation management.
### Motivation
Now when sending an invoice to a member, we must check whether the email-address and other data is still up to date in Conscribo and for new members we must copy everything by hand to Conscribo. Conscribo has an (somewhat limited but existing) API for this purpose.
Since the wallet-issue is a long-term thing, it might be nice to implement this part of synchronization already.
### Desired functionality
In Conscribo I can add a relation-group type "Member" and add all desirable fields to it. This would include: name, email, address and maybe bank account things (sepa mandates possibly as well, but not really important since hardly anyone uses it and it is administered by hand anyway currently).
Conscribo, according to their awesome documentation, then updates or adds that contact. Then in Conscribo I can add reimbursements or invoices to all members without copying data by hand, and have them up-to-date always.
### Suggested implementation
Every now and then (every night? every week? every update?) the thalia server contacts Conscribo and sends edited members.
For privacy, we do have a data processing agreement with Conscribo. Removing members from Conscribo is also possible, except for when they have invoices linked to them; then you can only archive them. However since then that member is part of the financial administration of Thalia, this is not a real problem privacy wise.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/776Automatic notification before end of pizza ordering2019-01-17T13:09:05+01:00Sébastiaan VersteegAutomatic notification before end of pizza ordering### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left ...### One-sentence description
Automatic notification before end of pizza ordering
### Motivation
Because it's cool and useful!
### Desired functionality
Get a notification for every pizza event at the moment there are 10 minutes left to order your pizzas. If the pizza event is attached to an event with registrations only registered members will get the notification, instead of everyone.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/775Members are shown according to cohort2019-01-05T19:11:06+01:00Thijs de JongMembers are shown according to cohort<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current wa...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current way of displaying members when you select all members, is by showing them on cohort order, while this should change to alphabetical order.
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
It is more clear when it is sorted on alphabetical order, instead of first sorted on Cohort order and then alphabetical order.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Currently, it is sorted on Cohort order, and then Alphabetical order, when selecting 'all members'.
https://thalia.nu/members/
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
When selecting 'all members', it should be sorted Alphabetically immediately.
<!-- Provide (a) suggestion(s) for how we could approach this -->21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/799Weird text in email after moving from waiting list after unregistration deadl...2019-01-05T19:09:56+01:00Job DoesburgWeird text in email after moving from waiting list after unregistration deadline has passed.<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Members recei...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Members receive a weird email when they move from the waiting list when someone unregistered after the deadline
### Why?
Currently people receive a text saying that if they want, they can unregister via the website until some moment in the past. This is weird. It would be nice to say that 'the unregistration deadline has passed. However if you're not able to come, please contact somebody from the committee or the board asap'.
### Current implementation
An email is sent to people moving from the waiting list, saying that if they want they can unregister until a moment in the past
### Suggested implementation
After the unregistration deadline has passed, mention that they should contact the organizing committee or board.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/257Add documents to event page2018-12-19T22:46:18+01:00Luuk ScholtenAdd documents to event page
### One-sentence description
Add documents to event page
### Desired behaviour
Have a list with documents on the event page.
### One-sentence description
Add documents to event page
### Desired behaviour
Have a list with documents on the event page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/687Do not send membership notification to soon-to-be members2018-12-19T21:41:13+01:00Sébastiaan VersteegDo not send membership notification to soon-to-be members### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
##...### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
### Steps to reproduce
1.`./manage.py sendmembershipnotification`.Tom van BusselTom van Bussel2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/798latest docker tag is not a stable build2018-12-14T16:43:03+01:00Joren Vranckenlatest docker tag is not a stable build<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please p...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
The `latest` docker tag should be a stable build.
### Why?
<!-- Please motivate why we should invest into this change -->
The `latest` docker tag is the last pushed commit to any MR. It is better if `latest` is the last stable build (last git tag).
### Current implementation
<!-- If relevant, describe how it's done currently -->
The `latest` docker tag is the last pushed commit.
### Suggested implementation
<!-- Provide (a) suggestion(s) for how we could approach this -->
Only push to `latest` if a git tag is build.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/796Add date search for photo albums2018-12-12T22:17:38+01:00Sébastiaan VersteegAdd date search for photo albums### One-sentence description
Add date search for photo albums
### Motivation
Make it easy to search for photos on a certain day
### Desired functionality
Make it possible to search for date### One-sentence description
Add date search for photo albums
### Motivation
Make it easy to search for photos on a certain day
### Desired functionality
Make it possible to search for datehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/759Move the events admin views to the admin model2018-11-29T00:04:37+01:00Sébastiaan VersteegMove the events admin views to the admin model### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the a...### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the admin.
### Suggested implementation
Override the url config of the model admin used for events to add our custom views. Just like here: https://docs.djangoproject.com/en/2.1/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_urls20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/784No Registration Needed Text is in English2018-11-28T21:02:16+01:00Thijs de JongNo Registration Needed Text is in English### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there ...### One-sentence description
No Registration Needed Text is in English under the text NL.
<!-- What breaks -->
### Current behaviour / Reproducing the bug
If you go to the event page to create an event, under the box Message when there is no registration (NL), it says the default message in English, where it should be Dutch.
<!-- Please write what is happening and how we could reproduce it, if relevant -->
### Expected behaviour
The given text should be in Dutch.
<!-- Please write how what happened did not meet your expectations -->Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/87Antwoorden van tentamens2018-11-25T01:45:55+01:00Sébastiaan VersteegAntwoorden van tentamensIk was aan het kijken naar de ingevoerde tentamens op de website, heel mooi natuurlijk.
Maar wat als ik toegang heb tot de antwoorden van oude tentamens? Zoals bij Security (http://www.ru.nl/ds/education/courses/security_2015/). Hoe k...Ik was aan het kijken naar de ingevoerde tentamens op de website, heel mooi natuurlijk.
Maar wat als ik toegang heb tot de antwoorden van oude tentamens? Zoals bij Security (http://www.ru.nl/ds/education/courses/security_2015/). Hoe krijg je die in het systeem?
Het zou natuurlijk heel tof zijn als je daar ook toegang tot hebt, zonder dat de antwoorden gekoppeld zijn met de pdf van het tentamen zelf natuurlijk. Want dat is extra werk.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/126Meer informatie bij uploaden tentamens2018-11-25T01:45:55+01:00Joost Rijneveldjoost@joostrijneveld.nlMeer informatie bij uploaden tentamensNadat je een tentamen hebt geupload kom je weer op het vakkenoverzicht, zonder enige vorm van feedback ("In goede orde ontvangen!") of iets dergelijks. Ook wordt gevraagd om een 'nummer'; ik neem aan dat dat bijv. 'Deeltentamen 3' kan zi...Nadat je een tentamen hebt geupload kom je weer op het vakkenoverzicht, zonder enige vorm van feedback ("In goede orde ontvangen!") of iets dergelijks. Ook wordt gevraagd om een 'nummer'; ik neem aan dat dat bijv. 'Deeltentamen 3' kan zijn, maar dat blijkt nergens uit. Een zinnetje met uitleg kan daar geen kwaad.
Wat me ook een beetje stoorde was dat de vaknamen in de dropdown beginnen met cursuscodes (waardoor je niet de naam van het vak kan typen), en dat oude vakken (die niet meer gegeven worden) lastig te onderscheiden zijn van huidige vakken.. Voor dat laatste zie ik niet meteen een goede oplossing, though. Dit speelt overigens niet als je via de vak-pagina op 'tentamen uploaden' klikt, want dan wordt het vak al geselecteerd.
- [ ] feedback toevoegen
- [ ] nummer verduidelijken
- [ ] vakkenselectie handiger maken
EDIT: er gebeurt hier iets subtiels, want ik kreeg ineens op een andere pagina waar ook een flash handler stond de melding _"Bedankt voor het opsturen. We hebben het tentamen ontvangen en het zal binnenkort beoordeelt worden."_. Misschien heeft het te maken met 't feit dat ik als www-cie ingelogd ben..https://gitlab.science.ru.nl/thalia/concrexit/-/issues/130Foto's progress wordt niet getoond2018-11-25T01:45:54+01:00Sébastiaan VersteegFoto's progress wordt niet getoondNa start importeren lijkt er geen progress dingetje weergeven te worden als 'bezig met: album x' binnen andere sessie's.Na start importeren lijkt er geen progress dingetje weergeven te worden als 'bezig met: album x' binnen andere sessie's.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/132Velden op ledentoevoegformulier zijn niet op dezelfde volgorde als op het pap...2018-11-25T01:45:54+01:00Luuk ScholtenVelden op ledentoevoegformulier zijn niet op dezelfde volgorde als op het papieren ledenregistratieformulier