concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-10-22T19:07:31+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/742Society members front-end link to profilepage2018-10-22T19:07:31+02:00Job DoesburgSociety members front-end link to profilepage<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make the link...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make the link from members of a society in the front-end, link to their profile page rather than the society page.
### Why?
It is more intuitive and it works the same way for committee members.
### Current implementation
When you click on a society member in the front-end, you're redirected to the (same) society page.
### Suggested implementation
Be redirected to the member profile pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/741Make payments linkable to registration2018-10-22T19:08:51+02:00Job DoesburgMake payments linkable to registration<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make payments...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Make payments linkable to registration
### Why?
When checking payments, you can only see a 'payment' object but apart from that they have no real use. However sometimes it really is useful to check all payments done on a certain day.
### Current implementation
The current implementation of payments shows payment objects. However when in a payment object, you can't easily go back to the registration that is connected to the Payment object.
### Suggested implementation
Being able to see the registration that the payment was connected to.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/739Change dropdown menu in front-end for user registration/enrollment with amount2018-11-14T21:53:41+01:00Job DoesburgChange dropdown menu in front-end for user registration/enrollment with amount<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the p...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Display the price of membership type in the dropdown menu of front-end registration page.
### Why?
People are lazy. They don't read the whole text and only fill in the form. They select 'study membership' and when they want to pay, they see it is more expensive. That's annoying because you have to change data afterwards (which can't be done a.t.m. after approval).
### Current implementation
The dropdown menu only shows 'one year membership' and 'study membership'
### Suggested implementation
The dropdown menu shows 'one year membership (€ 7,50)' and 'study membership (€ 30,00)'Bart HofmanBart Hofmanhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/738Registrations automatically save at approval2018-10-22T18:57:12+02:00Job DoesburgRegistrations automatically save at approval<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically save registrations that are edited when hitting 'approve'
### Why?
Because it is more intuitive
### Current implementation
You first have to save manually and open the registration before you can hit 'approve'
### Suggested implementation
When 'approve' is hit, the altered data is saved automaticallyhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/733Move alert to templatetag2018-10-18T15:53:31+02:00Sébastiaan VersteegMove alert to templatetag### One-sentence description
Move alert to templatetag
### Why?
DRY, lots of alerts everywhere we could just easily make it a templatetag.
### Current implementation
Lots of alerts, for example
```
<div class="alert alert-success al...### One-sentence description
Move alert to templatetag
### Why?
DRY, lots of alerts everywhere we could just easily make it a templatetag.
### Current implementation
Lots of alerts, for example
```
<div class="alert alert-success alert-dismissable">
{% trans "Your profile has been updated successfully." %}
<button type="button" class="close" data-dismiss="alert" aria-label="Close">
<span aria-hidden="true">×</span>
</button>
</div>
```
### Desired implementation
Put the html in an include and us a templatetag to make this easy to reuse. Could use https://django-bootstrap4.readthedocs.io/en/latest/templatetags.html#bootstrap4.templatetags.bootstrap4.bootstrap_alert, but not sure if we want to rely on this.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/728Follow-up from "Fix wiki login"2018-10-24T19:26:53+02:00Thom WiggersFollow-up from "Fix wiki login"The following discussion from !992 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/992#note_55114):
> Perhaps it's a good idea to move the wiki namespace int...The following discussion from !992 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/992#note_55114):
> Perhaps it's a good idea to move the wiki namespace into groupshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/727Accepted registration had no username2018-11-13T19:35:52+01:00Sébastiaan VersteegAccepted registration had no username### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/723Replace Highcharts by Chart.js2018-11-14T19:21:31+01:00Sébastiaan VersteegReplace Highcharts by Chart.js### One-sentence description
Replace Highcharts by Chart.js
### Why?
Highcharts is not open source. Only allowed use for non-commercial. Chart.js is MIT licensed.
### Current implementation
Highcharts
### Desired implementation
Ch...### One-sentence description
Replace Highcharts by Chart.js
### Why?
Highcharts is not open source. Only allowed use for non-commercial. Chart.js is MIT licensed.
### Current implementation
Highcharts
### Desired implementation
Chart.jsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/710Sort by name/date in events overview admin2018-09-26T20:27:07+02:00Sébastiaan VersteegSort by name/date in events overview admin### One-sentence description
Sort by date in events overview admin
### Desired behaviour
The events in the admin overview (/admin/events) are sorted by id by default. Since we have overridden the event name, date and registration star...### One-sentence description
Sort by date in events overview admin
### Desired behaviour
The events in the admin overview (/admin/events) are sorted by id by default. Since we have overridden the event name, date and registration start columns for them to be a link and contain the week day respectively these are not sortable automatically anymore.
This could be solved by adding the `admin_order_field` attribute:
```
def colored_first_name(self):
return format_html(
'<span style="color: #{};">{}</span>',
self.color_code,
self.first_name,
)
colored_first_name.admin_order_field = 'first_name'
```
- Overview link: `title` (if possible due to translation)
- Date: `start`
- Registration start: `registration_start`https://gitlab.science.ru.nl/thalia/concrexit/-/issues/709Registrations table in events backend not sorting on cancel date correctly2018-09-26T20:27:07+02:00Sébastiaan VersteegRegistrations table in events backend not sorting on cancel date correctly### One-sentence description
Registrations table in events backend not sorting on cancel date correctly
### Current behaviour
Sorting weird
### Expected behaviour
Sorting correct
### Steps to reproduce
1. Go to event in backend
2....### One-sentence description
Registrations table in events backend not sorting on cancel date correctly
### Current behaviour
Sorting weird
### Expected behaviour
Sorting correct
### Steps to reproduce
1. Go to event in backend
2. Try to sort cancellations on cancel datehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/707Add descriptions to push notification categories2018-09-19T20:17:56+02:00Gijs HendriksenAdd descriptions to push notification categories### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these ...### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these names don't make it clear what kind of push notifications are sent through in this category. Thus, it would be useful to add an explanation of each of the categories.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/690Registrations should not be editable after completion2018-09-26T18:59:06+02:00Sébastiaan VersteegRegistrations should not be editable after completion### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the admin### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/687Do not send membership notification to soon-to-be members2018-12-19T21:41:13+01:00Sébastiaan VersteegDo not send membership notification to soon-to-be members### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
##...### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
### Steps to reproduce
1.`./manage.py sendmembershipnotification`.Tom van BusselTom van Bussel2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/686Dutch translation in membership notification email incorrect2018-09-26T20:48:17+02:00Sébastiaan VersteegDutch translation in membership notification email incorrect### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sen...### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sendmembershipnotification`.Thijs de JongThijs de Jong2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/684Make it possible to renew supportership for old members via the website2018-09-26T18:56:20+02:00Sébastiaan VersteegMake it possible to renew supportership for old members via the website### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the web...### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/682Make it easier to process a payment after accepting registration2018-08-28T16:34:32+02:00Sébastiaan VersteegMake it easier to process a payment after accepting registration### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. ...### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. Go back
### Desired implementation
1. Accept
2. Redirect to the payment detail (or make it optional with an alert)
3. Have the payment return you to the registrations overview.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/681Make re-sending the email confirmation possible for registrations2018-10-03T19:56:43+02:00Sébastiaan VersteegMake re-sending the email confirmation possible for registrations### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it....### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it. Correcting the email address in the admin should be possibly too, if someone made a typo. This way we can correct the values without having to delete the whole registration and let new members do it all over.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/680Batch accepting registrations doesn't create payment2018-09-12T16:23:08+02:00Sébastiaan VersteegBatch accepting registrations doesn't create payment### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch o...### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch of registrationshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/675Fix docblocks with faulty :param: specifications2018-08-28T16:38:11+02:00Thom WiggersFix docblocks with faulty :param: specificationsE.g.
![image](/uploads/34e8857fc703dee6bf665a8ce2d96968/image.png)
This is caused by a missing newline before the `:param:`E.g.
![image](/uploads/34e8857fc703dee6bf665a8ce2d96968/image.png)
This is caused by a missing newline before the `:param:`https://gitlab.science.ru.nl/thalia/concrexit/-/issues/672Use pipenv instead of requirements.txt2018-08-15T15:06:16+02:00Thom WiggersUse pipenv instead of requirements.txt### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfil...### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfile.lock`.
https://github.com/pypa/pipenvThom WiggersThom Wiggers