concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-13T19:35:52+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/727Accepted registration had no username2018-11-13T19:35:52+01:00Sébastiaan VersteegAccepted registration had no username### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/723Replace Highcharts by Chart.js2018-11-14T19:21:31+01:00Sébastiaan VersteegReplace Highcharts by Chart.js### One-sentence description
Replace Highcharts by Chart.js
### Why?
Highcharts is not open source. Only allowed use for non-commercial. Chart.js is MIT licensed.
### Current implementation
Highcharts
### Desired implementation
Ch...### One-sentence description
Replace Highcharts by Chart.js
### Why?
Highcharts is not open source. Only allowed use for non-commercial. Chart.js is MIT licensed.
### Current implementation
Highcharts
### Desired implementation
Chart.jsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/711Allow event registering for open events2020-02-26T17:18:08+01:00Niek JanssenAllow event registering for open events/label ~feature ~"priority: low"
### One-sentence description
Allow event registering for open events
### Motivation
So that the personal calendar can contain these events, notifications only get send to these people and open events .../label ~feature ~"priority: low"
### One-sentence description
Allow event registering for open events
### Motivation
So that the personal calendar can contain these events, notifications only get send to these people and open events have an indication how many people are going to go to the event.
### Desired functionality
The normal registration functionality. But it is not registration, more like Facebooks
### Suggested implementation
We should be able to add an option that if there is no registration required that you can still register.
Mark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/710Sort by name/date in events overview admin2018-09-26T20:27:07+02:00Sébastiaan VersteegSort by name/date in events overview admin### One-sentence description
Sort by date in events overview admin
### Desired behaviour
The events in the admin overview (/admin/events) are sorted by id by default. Since we have overridden the event name, date and registration star...### One-sentence description
Sort by date in events overview admin
### Desired behaviour
The events in the admin overview (/admin/events) are sorted by id by default. Since we have overridden the event name, date and registration start columns for them to be a link and contain the week day respectively these are not sortable automatically anymore.
This could be solved by adding the `admin_order_field` attribute:
```
def colored_first_name(self):
return format_html(
'<span style="color: #{};">{}</span>',
self.color_code,
self.first_name,
)
colored_first_name.admin_order_field = 'first_name'
```
- Overview link: `title` (if possible due to translation)
- Date: `start`
- Registration start: `registration_start`https://gitlab.science.ru.nl/thalia/concrexit/-/issues/709Registrations table in events backend not sorting on cancel date correctly2018-09-26T20:27:07+02:00Sébastiaan VersteegRegistrations table in events backend not sorting on cancel date correctly### One-sentence description
Registrations table in events backend not sorting on cancel date correctly
### Current behaviour
Sorting weird
### Expected behaviour
Sorting correct
### Steps to reproduce
1. Go to event in backend
2....### One-sentence description
Registrations table in events backend not sorting on cancel date correctly
### Current behaviour
Sorting weird
### Expected behaviour
Sorting correct
### Steps to reproduce
1. Go to event in backend
2. Try to sort cancellations on cancel datehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/707Add descriptions to push notification categories2018-09-19T20:17:56+02:00Gijs HendriksenAdd descriptions to push notification categories### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these ...### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these names don't make it clear what kind of push notifications are sent through in this category. Thus, it would be useful to add an explanation of each of the categories.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/690Registrations should not be editable after completion2018-09-26T18:59:06+02:00Sébastiaan VersteegRegistrations should not be editable after completion### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the admin### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/687Do not send membership notification to soon-to-be members2018-12-19T21:41:13+01:00Sébastiaan VersteegDo not send membership notification to soon-to-be members### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
##...### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
### Steps to reproduce
1.`./manage.py sendmembershipnotification`.Tom van BusselTom van Bussel2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/686Dutch translation in membership notification email incorrect2018-09-26T20:48:17+02:00Sébastiaan VersteegDutch translation in membership notification email incorrect### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sen...### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sendmembershipnotification`.Thijs de JongThijs de Jong2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/684Make it possible to renew supportership for old members via the website2018-09-26T18:56:20+02:00Sébastiaan VersteegMake it possible to renew supportership for old members via the website### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the web...### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/682Make it easier to process a payment after accepting registration2018-08-28T16:34:32+02:00Sébastiaan VersteegMake it easier to process a payment after accepting registration### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. ...### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. Go back
### Desired implementation
1. Accept
2. Redirect to the payment detail (or make it optional with an alert)
3. Have the payment return you to the registrations overview.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/681Make re-sending the email confirmation possible for registrations2018-10-03T19:56:43+02:00Sébastiaan VersteegMake re-sending the email confirmation possible for registrations### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it....### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it. Correcting the email address in the admin should be possibly too, if someone made a typo. This way we can correct the values without having to delete the whole registration and let new members do it all over.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/680Batch accepting registrations doesn't create payment2018-09-12T16:23:08+02:00Sébastiaan VersteegBatch accepting registrations doesn't create payment### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch o...### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch of registrationshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/675Fix docblocks with faulty :param: specifications2018-08-28T16:38:11+02:00Thom WiggersFix docblocks with faulty :param: specificationsE.g.
![image](/uploads/34e8857fc703dee6bf665a8ce2d96968/image.png)
This is caused by a missing newline before the `:param:`E.g.
![image](/uploads/34e8857fc703dee6bf665a8ce2d96968/image.png)
This is caused by a missing newline before the `:param:`https://gitlab.science.ru.nl/thalia/concrexit/-/issues/672Use pipenv instead of requirements.txt2018-08-15T15:06:16+02:00Thom WiggersUse pipenv instead of requirements.txt### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfil...### One-sentence description
Migate to `pipenv` and `Pipfile`
### Why?
Better handling of dependencies and virtual envs. Easier to use.
### Current implementation
`requirements.txt`
### Desired implementation
`Pipfile` and `Pipfile.lock`.
https://github.com/pypa/pipenvThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/671Integrate Sentry user feedback2019-03-22T22:40:29+01:00Thom WiggersIntegrate Sentry user feedbackWe could use Sentry to collect user feedback.
See also https://sentry.thalia.nu/settings/thalia/concrexit_beta/user-feedback/
We could use Sentry to collect user feedback.
See also https://sentry.thalia.nu/settings/thalia/concrexit_beta/user-feedback/
https://gitlab.science.ru.nl/thalia/concrexit/-/issues/670There are no installation instructions for Ubuntu 18.04 in the README2018-10-14T20:43:50+02:00Joren VranckenThere are no installation instructions for Ubuntu 18.04 in the README### One-sentence description
Add installation instructions for Ubuntu 18.04
### Why?
Ubuntu 18.04 is the newest version.
### Current implementation
There are no installation instructions for Ubuntu 18.04 in the README.
### Desired im...### One-sentence description
Add installation instructions for Ubuntu 18.04
### Why?
Ubuntu 18.04 is the newest version.
### Current implementation
There are no installation instructions for Ubuntu 18.04 in the README.
### Desired implementation
There are installation instructions for Ubuntu 18.04 in the README.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/669Link to Sphinx documentation2018-09-09T19:10:42+02:00Joren VranckenLink to Sphinx documentation### One-sentence description
Link to Sphinx documentation somewhere
### Desired behaviour
We have a nice [docs page](https://thalia.nu/docs), but it is linked nowhere.
We should link to it, so people can find the page.### One-sentence description
Link to Sphinx documentation somewhere
### Desired behaviour
We have a nice [docs page](https://thalia.nu/docs), but it is linked nowhere.
We should link to it, so people can find the page.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/663Fix names of categories of pushnotifications2018-08-08T23:02:12+02:00Luko van der MaasFix names of categories of pushnotifications### One-sentence description
Make all names uppercase
### Current behaviour
All names are lowercase
### Expected behaviour
The names are uppercase
### Steps to reproduce
1. look at /api/v1/devices### One-sentence description
Make all names uppercase
### Current behaviour
All names are lowercase
### Expected behaviour
The names are uppercase
### Steps to reproduce
1. look at /api/v1/devicesLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/662Escape commas in address label csv export2018-07-11T14:51:58+02:00Gijs HendriksenEscape commas in address label csv export### One-sentence description
Addresses containing a comma are not surrounded with quotes in the csv export, meaning they are split into multiple columns.
### Current behaviour
When exporting addresses for users, some of these addresses ...### One-sentence description
Addresses containing a comma are not surrounded with quotes in the csv export, meaning they are split into multiple columns.
### Current behaviour
When exporting addresses for users, some of these addresses contain commas, like _"Mercator I, room ..."_. In csv, these commas are seen as separator, meaning these addresses are split into several columns. They should be contained in a single column.
### Expected behaviour
Commas are escaped correctly, by surrounding the corresponding fields in quotes during the export.
### Steps to reproduce
1. Add an address field containing a comma for a certain member.
2. Export the address labels csv file.
3. Notice the address field is separated into two columns.