concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-10-24T19:26:53+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/728Follow-up from "Fix wiki login"2018-10-24T19:26:53+02:00Thom WiggersFollow-up from "Fix wiki login"The following discussion from !992 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/992#note_55114):
> Perhaps it's a good idea to move the wiki namespace int...The following discussion from !992 should be addressed:
- [ ] @twiggers started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/992#note_55114):
> Perhaps it's a good idea to move the wiki namespace into groupshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/727Accepted registration had no username2018-11-13T19:35:52+01:00Sébastiaan VersteegAccepted registration had no username### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?### One-sentence description
### Current behaviour
https://sentry.thalia.nu/sentry/concrexit/issues/98/
### Expected behaviour
Accepted registration should always have a username
### Steps to reproduce
1. ?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/724Update Fancybox to version 32018-11-14T18:52:53+01:00Sébastiaan VersteegUpdate Fancybox to version 3### One-sentence description
Update Fancybox to version 3
### Why?
We currently use an old version (2.x). However, this version is licensed under CC BY-NC 3.0. Version 3 is GPLv3 for open source projects only. So I think this can be d...### One-sentence description
Update Fancybox to version 3
### Why?
We currently use an old version (2.x). However, this version is licensed under CC BY-NC 3.0. Version 3 is GPLv3 for open source projects only. So I think this can be done only after fully open sourcing. [Their website](http://fancyapps.com/fancybox/3/#license) is unclear:
> fancybox is licensed under the GPLv3 license for all open source applications.
A commercial license is required for all commercial applications (including sites, themes and apps you plan to sell).
¿Our website is non-commercial but not open source?
### Current implementation
Fancybox 2.x
### Desired implementation
Fancybox 3.x20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/723Replace Highcharts by Chart.js2018-11-14T19:21:31+01:00Sébastiaan VersteegReplace Highcharts by Chart.js### One-sentence description
Replace Highcharts by Chart.js
### Why?
Highcharts is not open source. Only allowed use for non-commercial. Chart.js is MIT licensed.
### Current implementation
Highcharts
### Desired implementation
Ch...### One-sentence description
Replace Highcharts by Chart.js
### Why?
Highcharts is not open source. Only allowed use for non-commercial. Chart.js is MIT licensed.
### Current implementation
Highcharts
### Desired implementation
Chart.jsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/722Add search functionality to photo albums2018-11-14T23:04:28+01:00Sébastiaan VersteegAdd search functionality to photo albums### One-sentence description
Add search functionality to photo albums
### Desired behaviour
Being able to search### One-sentence description
Add search functionality to photo albums
### Desired behaviour
Being able to search20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/714Empty board and committee pages not consistent2018-10-18T11:31:04+02:00Joren VranckenEmpty board and committee pages not consistent### One-sentence description
Going to the board page without any boards is not handled the same as going to the committee page without any committees.
### Current behaviour
If there are no boards, going to the board page results in a 40...### One-sentence description
Going to the board page without any boards is not handled the same as going to the committee page without any committees.
### Current behaviour
If there are no boards, going to the board page results in a 404 page because of an error (`No Board matches the given query.`). Going to the committee page without any committees however shows a nice message "There are no committees!".
Looking at [the template for the board page](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/templates/activemembers/board_index.html#L57) it looks like a similar message should be shown:
```
{% empty %}
{% trans 'There are no boards!' %}
{% endfor %}
```
### Expected behaviour
If there are no boards, going to the board page results in `There are no boards!`.
### Steps to reproduce
1. Go to the boards page without any boards.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/711Allow event registering for open events2020-02-26T17:18:08+01:00Niek JanssenAllow event registering for open events/label ~feature ~"priority: low"
### One-sentence description
Allow event registering for open events
### Motivation
So that the personal calendar can contain these events, notifications only get send to these people and open events .../label ~feature ~"priority: low"
### One-sentence description
Allow event registering for open events
### Motivation
So that the personal calendar can contain these events, notifications only get send to these people and open events have an indication how many people are going to go to the event.
### Desired functionality
The normal registration functionality. But it is not registration, more like Facebooks
### Suggested implementation
We should be able to add an option that if there is no registration required that you can still register.
Mark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/710Sort by name/date in events overview admin2018-09-26T20:27:07+02:00Sébastiaan VersteegSort by name/date in events overview admin### One-sentence description
Sort by date in events overview admin
### Desired behaviour
The events in the admin overview (/admin/events) are sorted by id by default. Since we have overridden the event name, date and registration star...### One-sentence description
Sort by date in events overview admin
### Desired behaviour
The events in the admin overview (/admin/events) are sorted by id by default. Since we have overridden the event name, date and registration start columns for them to be a link and contain the week day respectively these are not sortable automatically anymore.
This could be solved by adding the `admin_order_field` attribute:
```
def colored_first_name(self):
return format_html(
'<span style="color: #{};">{}</span>',
self.color_code,
self.first_name,
)
colored_first_name.admin_order_field = 'first_name'
```
- Overview link: `title` (if possible due to translation)
- Date: `start`
- Registration start: `registration_start`https://gitlab.science.ru.nl/thalia/concrexit/-/issues/709Registrations table in events backend not sorting on cancel date correctly2018-09-26T20:27:07+02:00Sébastiaan VersteegRegistrations table in events backend not sorting on cancel date correctly### One-sentence description
Registrations table in events backend not sorting on cancel date correctly
### Current behaviour
Sorting weird
### Expected behaviour
Sorting correct
### Steps to reproduce
1. Go to event in backend
2....### One-sentence description
Registrations table in events backend not sorting on cancel date correctly
### Current behaviour
Sorting weird
### Expected behaviour
Sorting correct
### Steps to reproduce
1. Go to event in backend
2. Try to sort cancellations on cancel datehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/707Add descriptions to push notification categories2018-09-19T20:17:56+02:00Gijs HendriksenAdd descriptions to push notification categories### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these ...### One-sentence description
Add descriptions to notification categories
### Desired behaviour
As described in ThaliApp#75, the ThaliApp settings screen can now only display the push notifications category names. However, some of these names don't make it clear what kind of push notifications are sent through in this category. Thus, it would be useful to add an explanation of each of the categories.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/705Save calendar view selection to session2018-10-18T11:31:10+02:00Sébastiaan VersteegSave calendar view selection to session### One-sentence description
Save calendar view selection to session
### Desired behaviour
Save the selected view type of the website calendar to the user session so that you don't have to select it over and over again.### One-sentence description
Save calendar view selection to session
### Desired behaviour
Save the selected view type of the website calendar to the user session so that you don't have to select it over and over again.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/700Alphabetically order Miscellaneous Association Documents2018-11-07T19:14:40+01:00Sébastiaan VersteegAlphabetically order Miscellaneous Association Documents### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically19Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/697Change mentions of 'supporter' to 'benefactor'2018-10-18T11:31:34+02:00Sébastiaan VersteegChange mentions of 'supporter' to 'benefactor'### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use ...### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use several different names for the 'begunstiger' membership type.
### Desired implementation
Always use 'benefactor' as translation.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/694Replace main photo header by slider2018-10-22T08:52:10+02:00Sébastiaan VersteegReplace main photo header by slider### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/690Registrations should not be editable after completion2018-09-26T18:59:06+02:00Sébastiaan VersteegRegistrations should not be editable after completion### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the admin### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the adminhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/687Do not send membership notification to soon-to-be members2018-12-19T21:41:13+01:00Sébastiaan VersteegDo not send membership notification to soon-to-be members### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
##...### One-sentence description
Do not send membership notification to soon-to-be members
### Current behaviour
People with a membership starting September 1st will get the notification email.
### Expected behaviour
They should not
### Steps to reproduce
1.`./manage.py sendmembershipnotification`.Tom van BusselTom van Bussel2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/686Dutch translation in membership notification email incorrect2018-09-26T20:48:17+02:00Sébastiaan VersteegDutch translation in membership notification email incorrect### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sen...### One-sentence description
Dutch translation in membership notification email incorrect
### Current behaviour
Starts with `Dear <name>`
### Expected behaviour
Starts with `Beste <name>`
### Steps to reproduce
1. `./manage.py sendmembershipnotification`.Thijs de JongThijs de Jong2019-08-31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/684Make it possible to renew supportership for old members via the website2018-09-26T18:56:20+02:00Sébastiaan VersteegMake it possible to renew supportership for old members via the website### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the web...### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/682Make it easier to process a payment after accepting registration2018-08-28T16:34:32+02:00Sébastiaan VersteegMake it easier to process a payment after accepting registration### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. ...### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. Go back
### Desired implementation
1. Accept
2. Redirect to the payment detail (or make it optional with an alert)
3. Have the payment return you to the registrations overview.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/681Make re-sending the email confirmation possible for registrations2018-10-03T19:56:43+02:00Sébastiaan VersteegMake re-sending the email confirmation possible for registrations### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it....### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it. Correcting the email address in the admin should be possibly too, if someone made a typo. This way we can correct the values without having to delete the whole registration and let new members do it all over.