concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-02T15:46:27+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/735Event registration 'save and add another' doesn't work correctly2018-11-02T15:46:27+01:00Joris ReichertEvent registration 'save and add another' doesn't work correctly### One-sentence description
### Current behaviour
After manually adding a registration in the event admin using the button 'Save and add another' I'm redirected to the overview instead of getting another add form. The message is corre...### One-sentence description
### Current behaviour
After manually adding a registration in the event admin using the button 'Save and add another' I'm redirected to the overview instead of getting another add form. The message is correct, but the page is not.
![image](/uploads/5ec00a8ff5ee2d47420f9dd5b628a140/image.png)
Also, 'Save and continue editing' seems to have the same behaviour.
### Expected behaviour
Get the add form instead of the overview
### Steps to reproduce
1. Create a registration in the backend for and event using 'save and add another'
2. Get the overview instead of form
19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/714Empty board and committee pages not consistent2018-10-18T11:31:04+02:00Joren VranckenEmpty board and committee pages not consistent### One-sentence description
Going to the board page without any boards is not handled the same as going to the committee page without any committees.
### Current behaviour
If there are no boards, going to the board page results in a 40...### One-sentence description
Going to the board page without any boards is not handled the same as going to the committee page without any committees.
### Current behaviour
If there are no boards, going to the board page results in a 404 page because of an error (`No Board matches the given query.`). Going to the committee page without any committees however shows a nice message "There are no committees!".
Looking at [the template for the board page](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/templates/activemembers/board_index.html#L57) it looks like a similar message should be shown:
```
{% empty %}
{% trans 'There are no boards!' %}
{% endfor %}
```
### Expected behaviour
If there are no boards, going to the board page results in `There are no boards!`.
### Steps to reproduce
1. Go to the boards page without any boards.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/705Save calendar view selection to session2018-10-18T11:31:10+02:00Sébastiaan VersteegSave calendar view selection to session### One-sentence description
Save calendar view selection to session
### Desired behaviour
Save the selected view type of the website calendar to the user session so that you don't have to select it over and over again.### One-sentence description
Save calendar view selection to session
### Desired behaviour
Save the selected view type of the website calendar to the user session so that you don't have to select it over and over again.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/700Alphabetically order Miscellaneous Association Documents2018-11-07T19:14:40+01:00Sébastiaan VersteegAlphabetically order Miscellaneous Association Documents### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically19Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/697Change mentions of 'supporter' to 'benefactor'2018-10-18T11:31:34+02:00Sébastiaan VersteegChange mentions of 'supporter' to 'benefactor'### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use ...### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use several different names for the 'begunstiger' membership type.
### Desired implementation
Always use 'benefactor' as translation.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/694Replace main photo header by slider2018-10-22T08:52:10+02:00Sébastiaan VersteegReplace main photo header by slider### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/679Make it possible to correct an acception or rejection in registrations2018-10-18T11:30:37+02:00Sébastiaan VersteegMake it possible to correct an acception or rejection in registrations### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to corr...### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to correct this. For example if it was a mistake or if the payment object was not created.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/704Change default language to English2018-09-19T20:31:26+02:00Sébastiaan VersteegChange default language to English### One-sentence description
Change default language to English
### Why?
Because we have international members now and we shouldn't force them to switch to English.
### Current implementation
https://gitlab.science.ru.nl/thalia/conc...### One-sentence description
Change default language to English
### Why?
Because we have international members now and we shouldn't force them to switch to English.
### Current implementation
https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/thaliawebsite/settings/settings.py#L197
The default language is Dutch, so this means that devices set to a non-Dutch/English language automatically select it as fallback.
### Desired implementation
The default language should be English, so this means that devices set to a non-Dutch/English language automatically select it as fallback.1.18Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/635Societies2018-09-12T16:39:57+02:00Milan van StiphoutSocietiesAfter last general meeting, societies (NL: gezelschappen) are now a thing within Thalia. We want to offer some support for these societies on the website.
### One-sentence description
A page to list societies on.
### Desired behaviour
Th...After last general meeting, societies (NL: gezelschappen) are now a thing within Thalia. We want to offer some support for these societies on the website.
### One-sentence description
A page to list societies on.
### Desired behaviour
The page should behave exactly like https://thalia.nu/committees/. A distinction should be made between trial societies and recognized societies, with the trial societies being below the recognized societies under a header 'trial societies'.
With this feature also comes society membership, which should behave the same as committee memberships.1.18Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/656Reschedule event notification even if previously sent2018-07-09T09:39:40+02:00Sébastiaan VersteegReschedule event notification even if previously sent### One-sentence description
Reschedule event notification even if previously sent
### Current behaviour
Only the notification time is changed, even though it has been sent already.
### Expected behaviour
If the notification was sent a...### One-sentence description
Reschedule event notification even if previously sent
### Current behaviour
Only the notification time is changed, even though it has been sent already.
### Expected behaviour
If the notification was sent already it should be decoupled from the event and a new scheduled notification should be created.
### Steps to reproduce
1. Create event
2. Let notification send
3. Change the event start/registration times1.17https://gitlab.science.ru.nl/thalia/concrexit/-/issues/653Ordering for event registrations in backend is lexicographically, not chronol...2018-08-15T08:24:29+02:00Gijs HendriksenOrdering for event registrations in backend is lexicographically, not chronological### One-sentence description
Ordering in the events backend should be chronological when sorting based on a datetime field.
### Current behaviour
When ordering on the "Registration start" field, for example, the registrations are sorted...### One-sentence description
Ordering in the events backend should be chronological when sorting based on a datetime field.
### Current behaviour
When ordering on the "Registration start" field, for example, the registrations are sorted lexicographically, as can be seen in this screenshot:
![registration_ordering](/uploads/7f59f8d57f8b74e0d12ded2f867cca01/registration_ordering.png)
### Expected behaviour
When ordering on a datetime field, the registrations should be ordered chronologically.
### Steps to reproduce
1. Create registrations for June 2nd and July 1st for a certain event.
2. Go to the admin page for that specific event.
2. Notice that the registration in July is shown before the registration in June.1.17Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/631pipconflictchecker is broken2018-08-08T20:23:06+02:00Thom Wiggerspipconflictchecker is broken### One-sentence description
https://github.com/ambitioninc/pip-conflict-checker/issues/9 will cause builds to fail
### Workaround
Disable `pipconflictchecker` for now (!790, c24dfde4), re-enable it when it starts working again.### One-sentence description
https://github.com/ambitioninc/pip-conflict-checker/issues/9 will cause builds to fail
### Workaround
Disable `pipconflictchecker` for now (!790, c24dfde4), re-enable it when it starts working again.1.17Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/494Sorting registrations in events also by name2018-03-26T16:10:52+02:00Ivar DerksenSorting registrations in events also by name### One-sentence description
When marking people present on the admin page of events it is nice if it would be possible to sort the list of members also by name. Then you can find people easier.
### Desired behaviour
The list of registr...### One-sentence description
When marking people present on the admin page of events it is nice if it would be possible to sort the list of members also by name. Then you can find people easier.
### Desired behaviour
The list of registrations should have filter buttons at the top to be able to change the sorting.1.15https://gitlab.science.ru.nl/thalia/concrexit/-/issues/538Add filtering to push notifications2018-02-22T14:15:44+01:00Sébastiaan VersteegAdd filtering to push notifications### One-sentence description
Add filtering to push notifications
### Desired behaviour
Have a settings field in the `Device` model that holds the categories (see #537) of messages that device should receive and filter devices when sen...### One-sentence description
Add filtering to push notifications
### Desired behaviour
Have a settings field in the `Device` model that holds the categories (see #537) of messages that device should receive and filter devices when sending a message based on these settings so that these devices do not receive messages of categories that they have turned off.1.14Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/545Change the way we do board permissions2018-01-16T22:20:57+01:00Sébastiaan VersteegChange the way we do board permissionsRelated to #479:
>twiggers: Somewhat related: I'd rather attach the board to a regular Django group than edit their (committee)group's permissions each year: it's much more error-prone to re-add those permissions than it is to add and r...Related to #479:
>twiggers: Somewhat related: I'd rather attach the board to a regular Django group than edit their (committee)group's permissions each year: it's much more error-prone to re-add those permissions than it is to add and remove some members from a Django Group.
> sversteeg: We could create a connection between committees and groups? I don't believe opening 12 user profiles and changing the groups is less error-prone than removing and re-adding the permissions. Maybe continue this is another issue, since I finished this one.
> twiggers: The difference is the kind of mistakes you make. When opening/changing 12 user profiles, you may forget one. When manually adding the tens of permissions we need to give to boards, we're bound to forget one. This is followed by a board member then trying to do something they need to do, and then assigning themselves superuser privileges, and then later perhaps breaking the site.
Good point, needs discussion1.13https://gitlab.science.ru.nl/thalia/concrexit/-/issues/499Cancellation dates in event admin2018-01-28T20:48:57+01:00Rico te WechelCancellation dates in event admin### One-sentence description
Cancellation dates in event admin
### Desired behaviour
Show date and time of cancellation of registration in backend.### One-sentence description
Cancellation dates in event admin
### Desired behaviour
Show date and time of cancellation of registration in backend.1.13Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/525Cancel registration in 'registration information fields' not canceling2017-10-14T13:22:13+02:00Job DoesburgCancel registration in 'registration information fields' not canceling### One-sentence description
See title
### Current behaviour
See title
### Expected behaviour
Does cancel
### Steps to reproduce
1. Try to register for an event that does have extra 'registration information fields', like the pub craw...### One-sentence description
See title
### Current behaviour
See title
### Expected behaviour
Does cancel
### Steps to reproduce
1. Try to register for an event that does have extra 'registration information fields', like the pub crawl.
2. After hitting the register button, a new page is loaded with the extra information fields.
3. Hit cancel.
4. You're still enrolled for the event :(1.12Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/520Sponsorpagina geeft tekst niet goed weer2017-10-12T12:04:48+02:00Niek JanssenSponsorpagina geeft tekst niet goed weerOp de sponsorpagina (https://thalia.nu/career/) staat bij topicus een niet goed geformatteerde tekst.
- Er staan random & nbsp;'s in
- Een subkop staat er, zonder spatie, in
Als je op 'lees meer' klikt staat het er wel goed.
Verder ...Op de sponsorpagina (https://thalia.nu/career/) staat bij topicus een niet goed geformatteerde tekst.
- Er staan random & nbsp;'s in
- Een subkop staat er, zonder spatie, in
Als je op 'lees meer' klikt staat het er wel goed.
Verder nog een random sidenote: ik vind dat je vrij snel over onze hoofdsponsor heen scrollt. Misschien een zwarte rand om het hele topicus-blok heen?1.11https://gitlab.science.ru.nl/thalia/concrexit/-/issues/517Push Notifications API2017-10-12T12:04:11+02:00Sébastiaan VersteegPush Notifications API### One-sentence description
Push Notifications API
### Desired behaviour
1. Register device with push token on server via API
2. Send messages via Firebase (FCM)### One-sentence description
Push Notifications API
### Desired behaviour
1. Register device with push token on server via API
2. Send messages via Firebase (FCM)1.11Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/502Add description to board detail page2017-09-27T19:17:34+02:00Sébastiaan VersteegAdd description to board detail page### One-sentence description
Add description to board detail page
### Desired behaviour
Give boards the option to write descriptions and show these on their individual pages.### One-sentence description
Add description to board detail page
### Desired behaviour
Give boards the option to write descriptions and show these on their individual pages.1.11Bram in 't ZandtBram in 't Zandt