concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-03-11T23:54:58+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1031Topic should be visible in https://thalia.nu/user/finance/payments/2020-03-11T23:54:58+01:00Job DoesburgTopic should be visible in https://thalia.nu/user/finance/payments/### One-sentence description
Topic should be visible in https://thalia.nu/user/finance/payments/
### Current behaviour / Reproducing the bug
The topic field is not visible
### Expected behaviour
Be visible### One-sentence description
Topic should be visible in https://thalia.nu/user/finance/payments/
### Current behaviour / Reproducing the bug
The topic field is not visible
### Expected behaviour
Be visiblehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1029Payment fields not translated in admin2020-03-11T19:53:43+01:00Job DoesburgPayment fields not translated in admin### One-sentence description
Payment fields not translated in admin
### Current behaviour / Reproducing the bug
At (staging.)thalia.nu/admin/payments/payment/*/change, the field names are not translated
### Expected behaviour
They ...### One-sentence description
Payment fields not translated in admin
### Current behaviour / Reproducing the bug
At (staging.)thalia.nu/admin/payments/payment/*/change, the field names are not translated
### Expected behaviour
They should be translatedhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1027Website starts up in the wrong language2020-03-09T15:45:44+01:00Leon van den BoogaardWebsite starts up in the wrong language<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
To have a language preference in your profile so that the website starts up in your prefered language
<!-- Why should we care? -->
Every ti...<!--
You want something new.
-->
### One-sentence description
<!-- What do you want? -->
To have a language preference in your profile so that the website starts up in your prefered language
<!-- Why should we care? -->
Every time I start up the website or click on a link in the newsletter it starts up in English. I don't speak English so I would like it to start up in Dutch.
<!--
What we should support.
Please provide this in general terms, if possible.
You can provide suggestions on how to implement this later.
We like high-level descriptions as those allow us to better consider
the desired result. Assumptions on how the site works don't
necessarily match how we implemented certain things.
-->
Have a cookie or something with a long time to live so that we shouldn't click on the flag every time we use the website
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->
Cookies
Thank you in advance!
Love you!https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1018Saving event crashes when registration start is placed before current date2020-03-04T21:13:44+01:00Jelle Besselingjelle@pingiun.comSaving event crashes when registration start is placed before current date### One-sentence description
Saving event crashes when registration start is placed before current date
<!-- What breaks -->
### Current behaviour / Reproducing the bug
1. Create an event
2. Set registration start date in the future
3....### One-sentence description
Saving event crashes when registration start is placed before current date
<!-- What breaks -->
### Current behaviour / Reproducing the bug
1. Create an event
2. Set registration start date in the future
3. Save event
4. Change registration date before current date
5. Crash (locally I get a `Fatal Python error: Cannot recover from stack overflow.`, which looks like infinite recursion
### Expected behaviour
Setting registration start date before current date opens registrationsJelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1016Event looks like registered for though on waiting list2020-02-17T21:55:37+01:00Job DoesburgEvent looks like registered for though on waiting list### One-sentence description
When on the waiting list for an event, it still looks like you are registered for that event.
### Current behaviour / Reproducing the bug
- In the calendar stream, the event does appear in your calendar
- ...### One-sentence description
When on the waiting list for an event, it still looks like you are registered for that event.
### Current behaviour / Reproducing the bug
- In the calendar stream, the event does appear in your calendar
- Cancelling your registration does show the warning that you have to pay a fine, if after the unregistration deadline
- In the event overview calendar, the dot in front of the event is colored as if you are registered.
### Expected behaviour
- Do not appear in the calendar stream
- Do not show a message that you cannot unregister without having to pay a fine, but something different more fit to the situation
- In the event overview, show some other, pending-ish, colored dot.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/1015RecursionError: maximum recursion depth exceeded while calling a Python object2020-03-04T21:13:45+01:00Thalia TechnicieRecursionError: maximum recursion depth exceeded while calling a Python objectThe below error occurs when trying to delete or unpublish an event from the event details page. @jdusseljee says the error doesn't happen if the unpublish action is used from the overview page.
Sentry Issue: [CONCREXIT-22](https://sentr...The below error occurs when trying to delete or unpublish an event from the event details page. @jdusseljee says the error doesn't happen if the unpublish action is used from the overview page.
Sentry Issue: [CONCREXIT-22](https://sentry.io/organizations/thalia/issues/1516920010/?referrer=gitlab_integration)
```
RecursionError: maximum recursion depth exceeded while calling a Python object
(245 additional frame(s) were not displayed)
...
File "django/db/models/query_utils.py", line 139, in __get__
instance.refresh_from_db(fields=[field_name])
File "django/db/models/base.py", line 627, in refresh_from_db
db_instance = db_instance_qs.get()
File "django/db/models/query.py", line 411, in get
num = len(clone)
File "django/db/models/query.py", line 258, in __len__
self._fetch_all()
File "django/utils/deconstruct.py", line 16, in __new__
obj = super(klass, cls).__new__(cls)
```Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1004'All members' in members directory not marked as active2020-02-05T21:18:38+01:00Sébastiaan Versteeg'All members' in members directory not marked as active### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected ...### One-sentence description
In the members directory the 'all members' tab is never marked as active
### Current behaviour / Reproducing the bug
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
### Expected behaviour
1. Go to https://thalia.nu/members/directory/
2. The item is selectedSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/1001Fix styleguide link2020-01-27T16:10:04+01:00Jelle Besselingjelle@pingiun.comFix styleguide link### One-sentence description
The styleguide link on the website is broken.
### Current behaviour / Reproducing the bug
Try to download the styleguide, get a nextcloud error page.
### Expected behaviour
The link downloads a zip with the...### One-sentence description
The styleguide link on the website is broken.
### Current behaviour / Reproducing the bug
Try to download the styleguide, get a nextcloud error page.
### Expected behaviour
The link downloads a zip with the styleguide.
I know that sharing a folder from a shared drive in GSuite is not possible, but the link has been broken for a while and will be even more broken when NextCloud goes offline.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/999No favicon for the admin site2020-02-05T21:24:49+01:00Luko van der MaasNo favicon for the admin siteThe admin site has no favicon, not the development grayscale favicon and not the normal thalia favicon. This increases the risk of changing something on the wrong site.The admin site has no favicon, not the development grayscale favicon and not the normal thalia favicon. This increases the risk of changing something on the wrong site.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/998Add information to exam / summary submission2020-03-11T20:14:27+01:00Ward TheunisseAdd information to exam / summary submission<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of ex...<!--
You want something new.
-->
### One-sentence description
Add some confirmation message when submitting an exam.
### Motivation
Currently there is no confirmation when you submit an exam + it doesn't show up in the list of exams immediately because there's a review first. This way it is not clear whether the submission was actually performed correctly + people don't know that an submission is manually checked before being published.
### Desired functionality
Inform people whether their submission was succesful and why it isn't immediately visible.
### Suggested implementation
Show a message thanking someone for their submission, also informing them that it will be published after a review.Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/996Review Host DNS records are not removed when the review remove CI job is run2020-01-19T16:48:29+01:00Joren VranckenReview Host DNS records are not removed when the review remove CI job is run### One-sentence description
Review Host DNS records are not removed when the review remove CI job is run.
### Current behaviour / Reproducing the bug
The [command that removes the record](https://gitlab.science.ru.nl/thalia/concrexit/...### One-sentence description
Review Host DNS records are not removed when the review remove CI job is run.
### Current behaviour / Reproducing the bug
The [command that removes the record](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/.gitlab-ci.yml#L311) returns the following error:
```
Parameter validation failed:
Invalid length for parameter ChangeBatch.Changes, value: 0, valid range: 1-inf
```https://gitlab.science.ru.nl/thalia/concrexit/-/issues/990Style guide links are broken2020-01-29T18:49:21+01:00Jelle Besselingjelle@pingiun.comStyle guide links are broken### One-sentence description
Download links in the style guide, e.g. https://cloud.thalia.nu/s/NP6T7cpfiAHqBXb, don't work anymore.
### Current behaviour / Reproducing the bug
In the style guide there are some links that link to the Tha...### One-sentence description
Download links in the style guide, e.g. https://cloud.thalia.nu/s/NP6T7cpfiAHqBXb, don't work anymore.
### Current behaviour / Reproducing the bug
In the style guide there are some links that link to the Thalia cloud, these downloads have either been expired or have been removed.
### Expected behaviour
The links download the suggested file
<!-- Please write how what happened did not meet your expectations -->Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/988internal server error on adding slide to event2019-12-12T13:48:15+01:00Job Doesburginternal server error on adding slide to event### One-sentence description
Adding a slide to an event produces an internal server error
### Current behaviour / Reproducing the bug
1. Add a slide
2. Try to select the slide in the event
3. Profit
### Expected behaviour
Do not crash### One-sentence description
Adding a slide to an event produces an internal server error
### Current behaviour / Reproducing the bug
1. Add a slide
2. Try to select the slide in the event
3. Profit
### Expected behaviour
Do not crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/984Guest registrations can not be marked paid2020-02-12T19:53:44+01:00Luko van der MaasGuest registrations can not be marked paid### One-sentence description
When there is a guest registration for an event that has a price. If this person is marked as paid, an error occurs.
Associated sentry error: [https://sentry.io/organizations/thalia/issues/1372921592/?proje...### One-sentence description
When there is a guest registration for an event that has a price. If this person is marked as paid, an error occurs.
Associated sentry error: [https://sentry.io/organizations/thalia/issues/1372921592/?project=1463433&referrer=slack](https://sentry.io/organizations/thalia/issues/1372921592/?project=1463433)
### Current behaviour / Reproducing the bug
1. Create an event with registrations and a price
2. Register a guest user for this event
3. Try to mark this guest user as paid
4. Breakage
### Expected behaviour
1. Create an event with registrations and a price
2. Register a guest user for this event
3. Try to mark this guest user as paid
4. either you can't mark their payment status at all or you can. However marking a guest user as paid creates a lot more complication in the payments module.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/982Missing colors in statistics committee chart2020-01-08T23:00:26+01:00Job DoesburgMissing colors in statistics committee chart### One-sentence description
We ran out of colors for all our committees
### Current behaviour / Reproducing the bug
Check the middle graph in https://thalia.nu/members/statistics/
### Expected behaviour
We can just reuse other colo...### One-sentence description
We ran out of colors for all our committees
### Current behaviour / Reproducing the bug
Check the middle graph in https://thalia.nu/members/statistics/
### Expected behaviour
We can just reuse other colors in my opinion. Or decide on which colors to use based on the total number of colors required (if 1 → magenta, is 2 → magenta and black, 3 or more → generate a list of shades ranging from full black to magenta to white).Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/981Missing translations in statistics page2020-02-19T23:46:54+01:00Job DoesburgMissing translations in statistics page### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right ch...### One-sentence description
The graph of members/benefactors per cohort does not have member type benefactor and honorary translated
### Current behaviour / Reproducing the bug
check https://thalia.nu/members/statistics/ top right chart
### Expected behaviour
be translatedMark BouteMark Boutehttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/980Thalia Pay process button enabled in payments widget even though TPAY_ENABLED...2020-02-19T21:48:26+01:00Sébastiaan VersteegThalia Pay process button enabled in payments widget even though TPAY_ENABLED=False### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
#...### One-sentence description
Thalia Pay process button enabled in payments admin even though TPAY_DISABLED
### Current behaviour / Reproducing the bug
1. I can click the process button in for a membership registration
2. It crashes
### Expected behaviour
1. I cannot click it
2. If I should be able to click it, it should not crash.Marie SimonMarie Simonhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/979Login page visible when logged-in2020-02-05T21:24:02+01:00Sébastiaan VersteegLogin page visible when logged-in### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page s...### One-sentence description
Login page visible when logged-in
### Current behaviour / Reproducing the bug
1. You can visit the login page (and probably other pages related to it) while authenticated
### Expected behaviour
The page should redirect to home or something.Luc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/978Event admin view does not include 'user-tools' like other admin templates2020-02-19T19:38:58+01:00Job DoesburgEvent admin view does not include 'user-tools' like other admin templates### One-sentence description
Event admin view does not include 'user-tools' like other admin templates
### Current behaviour / Reproducing the bug
Check an event admin details page. It does not contain the 'Welcome user, view website,...### One-sentence description
Event admin view does not include 'user-tools' like other admin templates
### Current behaviour / Reproducing the bug
Check an event admin details page. It does not contain the 'Welcome user, view website, change password, log out' user tools that all other admin pages do contain.
### Expected behaviour
Correctly extend the templates, so it is similar to the other admin viewsSimcha van CollemSimcha van Collemhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/975/api/v1/token-auth does not return json on login failure2020-02-20T08:45:46+01:00Jelle Besselingjelle@pingiun.com/api/v1/token-auth does not return json on login failure### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expect...### One-sentence description
`/api/v1/token-auth` returns plain text when wrong credentials are used
### Current behaviour / Reproducing the bug
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
### Expected behaviour
Json object should be returnedSimcha van CollemSimcha van Collem