concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-01-25T22:36:53+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/972Hyperlink of "display [event] on website" button always refers to thalia.nu (...2020-01-25T22:36:53+01:00Job DoesburgHyperlink of "display [event] on website" button always refers to thalia.nu (also on staging)### One-sentence description
Hyperlink of "display [event] on website" button <s>is hardcoded</s> always refers to thalia.nu (also on staging)
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we c...### One-sentence description
Hyperlink of "display [event] on website" button <s>is hardcoded</s> always refers to thalia.nu (also on staging)
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
At staging.thalia.nu, the action button "display on website" (in the events admin) refers to thalia.nu
### Expected behaviour
Be a relative url (to staging.thalia.nu)https://gitlab.science.ru.nl/thalia/concrexit/-/issues/961Remove Payment type None2020-03-09T17:59:50+01:00Job DoesburgRemove Payment type None<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI...<!--
This template is for changes that do not affect the behaviour of the website.
** If you are not in the Technicie, there is a very high chance that you
should not use this template
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Remove Payment type None
### Why?
It is weird to have payment objects for payments that not yet have taken place. It makes much more sense to just have no payment then.
### Current implementation
For registrations, we now make payments for every accepted registration, and change the type when it really is paid.
### Suggested implementation
Make a payment object upon payment.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/867Revisit urls schemes2019-10-09T19:02:39+02:00Sébastiaan VersteegRevisit urls schemes### One-sentence description
Revisit urls schemes
### Why?
It's currently a bit messy and not consistent.
### Current implementation
We have one central urls.py for our application in thaliawebsite which decides the namespacing of a...### One-sentence description
Revisit urls schemes
### Why?
It's currently a bit messy and not consistent.
### Current implementation
We have one central urls.py for our application in thaliawebsite which decides the namespacing of all the modules.
### Suggested implementation
The central urls.py only includes the urls.py files of all the packages. These packages are then allowed to fill in their url schemes how they see fit. This allows us to re-use the same namespace in multiple modules and follow the way our menu is structured to decide the full url of a page.
All urls used in the django admin and implemented via the central urls.py (like push notifications and newsletters) should be implemented using the ModelAdmin's `get_urls` method like it was done in registrations and payments.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/826Follow-up from "Thumbnailing refactor"2019-02-13T19:04:46+01:00Thom WiggersFollow-up from "Thumbnailing refactor"The following discussion from !1155 should be addressed:
- [ ] @jbesseling started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/1155#note_65798): (+3 comments)
> Wouldn't it be better to add these do...The following discussion from !1155 should be addressed:
- [ ] @jbesseling started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/1155#note_65798): (+3 comments)
> Wouldn't it be better to add these docs to `docs/utils.media.rst`?Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/787Multiple organisers per event2019-11-27T18:58:50+01:00Sébastiaan VersteegMultiple organisers per event<!--
You want something new.
-->
### One-sentence description
Multiple organisers per event
### Motivation
I noticed that since the introduction of the Partnercie (once again) multiple committees (and the board) involved in event...<!--
You want something new.
-->
### One-sentence description
Multiple organisers per event
### Motivation
I noticed that since the introduction of the Partnercie (once again) multiple committees (and the board) involved in events increased (Lunches are board + partnercie, laser tag was evc + partnercie). It would be quite useful if an event can have multiple organisers. With the new societies this might happen even more often, think 'EVC + board game society'.
### Desired functionality
Select more than one organiser per event.
### Food for thought
- Currently you can only select the groups you belong to as organiser unless you're a board member. That's not useful if you want to add a group as organiser that you're not in
- The organiser determines the mailing list that is used for the unregister notifications. Should all organisers have a mailing list to enable that option? Do we send all organisers that email?https://gitlab.science.ru.nl/thalia/concrexit/-/issues/395Refactor thumbnails2019-02-10T13:29:22+01:00Thom WiggersRefactor thumbnailsThey are currently generated in rather complicated ways. We also have too many variants of thumbnails. The back-and-forth with quote, unquote, reverse and redirect are very unwieldy and hard to comprehend. They are also a source of vulne...They are currently generated in rather complicated ways. We also have too many variants of thumbnails. The back-and-forth with quote, unquote, reverse and redirect are very unwieldy and hard to comprehend. They are also a source of vulnerabilities.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/55Create ActiveMemberManager2016-08-17T22:51:43+02:00Joost Rijneveldjoost@joostrijneveld.nlCreate ActiveMemberManagerCurrently we rely on iterating over members, using the `is_active` property. Instead, we can create an ActiveMemberManager that performs this in bulk by comparing `user__membership__end` to the current time.
This is useful e.g. for #9 Currently we rely on iterating over members, using the `is_active` property. Instead, we can create an ActiveMemberManager that performs this in bulk by comparing `user__membership__end` to the current time.
This is useful e.g. for #9 Thom WiggersThom Wiggers