concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-10-09T19:02:39+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/867Revisit urls schemes2019-10-09T19:02:39+02:00Sébastiaan VersteegRevisit urls schemes### One-sentence description
Revisit urls schemes
### Why?
It's currently a bit messy and not consistent.
### Current implementation
We have one central urls.py for our application in thaliawebsite which decides the namespacing of a...### One-sentence description
Revisit urls schemes
### Why?
It's currently a bit messy and not consistent.
### Current implementation
We have one central urls.py for our application in thaliawebsite which decides the namespacing of all the modules.
### Suggested implementation
The central urls.py only includes the urls.py files of all the packages. These packages are then allowed to fill in their url schemes how they see fit. This allows us to re-use the same namespace in multiple modules and follow the way our menu is structured to decide the full url of a page.
All urls used in the django admin and implemented via the central urls.py (like push notifications and newsletters) should be implemented using the ModelAdmin's `get_urls` method like it was done in registrations and payments.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/826Follow-up from "Thumbnailing refactor"2019-02-13T19:04:46+01:00Thom WiggersFollow-up from "Thumbnailing refactor"The following discussion from !1155 should be addressed:
- [ ] @jbesseling started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/1155#note_65798): (+3 comments)
> Wouldn't it be better to add these do...The following discussion from !1155 should be addressed:
- [ ] @jbesseling started a [discussion](https://gitlab.science.ru.nl/thalia/concrexit/merge_requests/1155#note_65798): (+3 comments)
> Wouldn't it be better to add these docs to `docs/utils.media.rst`?Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/395Refactor thumbnails2019-02-10T13:29:22+01:00Thom WiggersRefactor thumbnailsThey are currently generated in rather complicated ways. We also have too many variants of thumbnails. The back-and-forth with quote, unquote, reverse and redirect are very unwieldy and hard to comprehend. They are also a source of vulne...They are currently generated in rather complicated ways. We also have too many variants of thumbnails. The back-and-forth with quote, unquote, reverse and redirect are very unwieldy and hard to comprehend. They are also a source of vulnerabilities.Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/55Create ActiveMemberManager2016-08-17T22:51:43+02:00Joost Rijneveldjoost@joostrijneveld.nlCreate ActiveMemberManagerCurrently we rely on iterating over members, using the `is_active` property. Instead, we can create an ActiveMemberManager that performs this in bulk by comparing `user__membership__end` to the current time.
This is useful e.g. for #9 Currently we rely on iterating over members, using the `is_active` property. Instead, we can create an ActiveMemberManager that performs this in bulk by comparing `user__membership__end` to the current time.
This is useful e.g. for #9 Thom WiggersThom Wiggers