concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2020-02-23T15:15:36+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/948Member can be accepted and have paid, but status is not completed2020-02-23T15:15:36+01:00Thalia TechnicieMember can be accepted and have paid, but status is not completedThis ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will...This ValueError happens sometimes while processing payments for new members or renewals. I'm not quite sure how to reproduce it, but sometimes when setting a registration or renewal to paid. The status of the renewal or registration will afterwards be "Accepted" instead of "Completed", and a 500 error is shown.
Sentry Issue: [CONCREXIT-H](https://sentry.io/organizations/thalia/issues/1172358095/?referrer=gitlab_integration)
```
ValueError: The given username must be set
(19 additional frame(s) were not displayed)
...
File "registrations/signals.py", line 12, in post_payment_save
services.process_payment(instance)
File "registrations/services.py", line 414, in process_payment
member = _create_member_from_registration(registration)
File "registrations/services.py", line 286, in _create_member_from_registration
last_name=registration.last_name
File "django/contrib/auth/models.py", line 151, in create_user
return self._create_user(username, email, password, **extra_fields)
File "django/contrib/auth/models.py", line 140, in _create_user
raise ValueError('The given username must be set')
```31https://gitlab.science.ru.nl/thalia/concrexit/-/issues/706Handle re-registrations after data minimisation2020-02-04T16:22:58+01:00Sébastiaan VersteegHandle re-registrations after data minimisation### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired impleme...### One-sentence description
Handle re-registrations after data minimisation
### Why?
Because we need to minimise data and this might cause issues with renewals in ~registrations
### Current implementation
None
### Desired implementation
Handle renewals of members of whom data was minimised by allowing them to re-enter the data.31Sébastiaan VersteegSébastiaan Versteeg