concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-05-15T20:37:10+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/560Register as benefactor via the website2019-05-15T20:37:10+02:00Sébastiaan VersteegRegister as benefactor via the website### One-sentence description
Register as benefactor via the website
### Desired behaviour
Supporters should be able to register via the website too.### One-sentence description
Register as benefactor via the website
### Desired behaviour
Supporters should be able to register via the website too.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/584Improve documentation for the registrations module2018-09-21T15:10:04+02:00Thom WiggersImprove documentation for the registrations moduleThe ~registrations module could use improved docs.The ~registrations module could use improved docs.Improve documentationhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/608Opnieuw lid worden2018-05-16T15:47:28+02:00Simone RuijsOpnieuw lid worden### One-sentence description
Als je al ooit lid bent geweest van Thalia, dan kun je je niet opnieuw aanmelden met hetzelfde e-mailadres via de website.
### Current behaviour
Je email wordt niet geaccepteerd
### Expected behaviour
Ondan...### One-sentence description
Als je al ooit lid bent geweest van Thalia, dan kun je je niet opnieuw aanmelden met hetzelfde e-mailadres via de website.
### Current behaviour
Je email wordt niet geaccepteerd
### Expected behaviour
Ondanks dat je ooit eerder lid bent geweest via het zelfde e-mailadres, zou je nu opnieuw lid kunnen moeten worden.
### Steps to reproduce
1. Proberen aan te melden voor Thalia met een e-mailadres dat al bij een lid hoort.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/622Crash on registration renew page2018-05-08T13:50:50+02:00Sébastiaan VersteegCrash on registration renew page### One-sentence description
Crash on registration renew page
### Current behaviour
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "...### One-sentence description
Crash on registration renew page
### Current behaviour
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
128. response = self.process_exception_by_middleware(e, request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
126. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in view
69. return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in _wrapper
62. return bound_func(*args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
21. return view_func(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/utils/decorators.py" in bound_func
58. return func.__get__(self, type(self))(*args2, **kwargs2)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
89. return handler(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/edit.py" in get
133. return self.render_to_response(self.get_context_data())
File "./registrations/views.py" in get_context_data
143. c[1] for c in Membership.MEMBERSHIP_TYPES
File "./registrations/views.py" in <listcomp>
144. if c[0] == context['membership'].type
Exception Type: AttributeError at /registration/renew/
Exception Value: 'NoneType' object has no attribute 'type'
Request information:
USER: azijlstra
```
### Expected behaviour
No crash
### Steps to reproduce
Unknownhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/657Add privacy policy checkbox to renewal form2018-07-11T14:36:26+02:00Sébastiaan VersteegAdd privacy policy checkbox to renewal form### One-sentence description
Add privacy policy checkbox to renewal form
### Desired behaviour
Have people accept the privacy policy on renewal.### One-sentence description
Add privacy policy checkbox to renewal form
### Desired behaviour
Have people accept the privacy policy on renewal.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/658Add birthday calendar opt-in to registration form2018-07-11T19:18:25+02:00Sébastiaan VersteegAdd birthday calendar opt-in to registration form### One-sentence description
Add birthday calendar opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in.### One-sentence description
Add birthday calendar opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/659Add mailinglist opt-in to registration form.2018-07-11T19:38:52+02:00Sébastiaan VersteegAdd mailinglist opt-in to registration form.### One-sentence description
Add mailinglist opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in to the mailinglist.### One-sentence description
Add mailinglist opt-in to registration form.
### Desired behaviour
Have a checkbox in the new member registration form for opt-in to the mailinglist.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/660Make phone number optional during registration2018-07-11T18:48:17+02:00Sébastiaan VersteegMake phone number optional during registration### One-sentence description
Make phone number optional during registration
### Why?
Because GDPR and it should not be required
### Current implementation
It's required
### Desired implementation
Not required### One-sentence description
Make phone number optional during registration
### Why?
Because GDPR and it should not be required
### Current implementation
It's required
### Desired implementation
Not required1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/issues/664Bug on registering as member with incomplete form2018-08-08T10:34:17+02:00Sébastiaan VersteegBug on registering as member with incomplete form### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`...### One-sentence description
Bug on registering as member with incomplete form
### Current behaviour
The website gives a 500
### Expected behaviour
Error message in the form
### Steps to reproduce
1. Go to the registration page (`/registration/register`)
2. Enter the form and leave the starting year _empty_.
3. Submit
4. Error!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/665Crash on confirming non-existing email address2018-08-07T12:34:00+02:00Sébastiaan VersteegCrash on confirming non-existing email address### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stac...### One-sentence description
### Current behaviour
500 error
### Expected behaviour
404 not found
### Steps to reproduce
1. Go to `/registration/confirm-email/some-uuid`
**Note that it should be a UUID inside the url!**
### Stacktrace
```
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/exception.py" in inner
35. response = get_response(request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
128. response = self.process_exception_by_middleware(e, request)
File "/usr/local/lib/python3.5/site-packages/django/core/handlers/base.py" in _get_response
126. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in view
69. return self.dispatch(request, *args, **kwargs)
File "/usr/local/lib/python3.5/site-packages/django/views/generic/base.py" in dispatch
89. return handler(request, *args, **kwargs)
File "./registrations/views.py" in get
100. emails.send_new_registration_board_message(entry.get())
File "/usr/local/lib/python3.5/site-packages/django/db/models/query.py" in get
403. self.model._meta.object_name
Exception Type: DoesNotExist at /registration/confirm-email/33c721a7-c032-407b-82a0-2f81c4061804/
Exception Value: Entry matching query does not exist.
```1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/666Registration with same username causes problems on payment process2018-08-27T17:37:09+02:00Sébastiaan VersteegRegistration with same username causes problems on payment process### One-sentence description
Registration with same username causes problems on payment process
### Current behaviour
If two registrations exist with the same entered/generated username and the first is fully processed while the secon...### One-sentence description
Registration with same username causes problems on payment process
### Current behaviour
If two registrations exist with the same entered/generated username and the first is fully processed while the second is in the accepted stage the payment for that second registration will not be able to fully succeed since the username is taken. However, the payment is marked processed. Thus the registration will be in limbo, forever.
### Expected behaviour
No limbo!
### Steps to reproduce
1. Create two registrations with the same first and last name
2. Accept them both
3. Process payment for 1
4. Try to process payment for 2
5. Erreur! :boom:https://gitlab.science.ru.nl/thalia/concrexit/-/issues/667Make the starting year field in the registration form a dropdown2018-08-07T12:34:14+02:00Sébastiaan VersteegMake the starting year field in the registration form a dropdown### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!### One-sentence description
Make the starting year field in the registration form a dropdown
### Why?
To prevent weird values being entered
### Current implementation
It's an integer field
### Desired implementation
Dropdown!1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/issues/679Make it possible to correct an acception or rejection in registrations2018-10-18T11:30:37+02:00Sébastiaan VersteegMake it possible to correct an acception or rejection in registrations### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to corr...### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to correct this. For example if it was a mistake or if the payment object was not created.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/680Batch accepting registrations doesn't create payment2018-09-12T16:23:08+02:00Sébastiaan VersteegBatch accepting registrations doesn't create payment### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch o...### One-sentence description
Batch accepting registrations doesn't create payment
### Current behaviour
No payment objects are created
### Expected behaviour
Should create payment objects
### Steps to reproduce
1. Accept a batch of registrationshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/681Make re-sending the email confirmation possible for registrations2018-10-03T19:56:43+02:00Sébastiaan VersteegMake re-sending the email confirmation possible for registrations### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it....### One-sentence description
Make re-sending the email confirmation possible for registrations
### Desired behaviour
Have a button to resend the email confirmation (in the admin), since it's possible that someone might not receive it. Correcting the email address in the admin should be possibly too, if someone made a typo. This way we can correct the values without having to delete the whole registration and let new members do it all over.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/682Make it easier to process a payment after accepting registration2018-08-28T16:34:32+02:00Sébastiaan VersteegMake it easier to process a payment after accepting registration### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. ...### One-sentence description
Make it easier to process a payment after accepting registration
### Why?
Easier. Faster.
### Current implementation
1. Accept
2. Go back to the overview
3. Open payment
3. Process payment
4. Go back
5. Go back
### Desired implementation
1. Accept
2. Redirect to the payment detail (or make it optional with an alert)
3. Have the payment return you to the registrations overview.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/683Email subject renewal is wrong2018-08-27T17:14:09+02:00Sébastiaan VersteegEmail subject renewal is wrong### One-sentence description
Email subject renewal is wrong
### Current behaviour
Dutch translation says 'afgekeurd'
### Expected behaviour
should be 'goedgekeurd'
### Steps to reproduce
1. Accept a renewal
2. Check the email subject### One-sentence description
Email subject renewal is wrong
### Current behaviour
Dutch translation says 'afgekeurd'
### Expected behaviour
should be 'goedgekeurd'
### Steps to reproduce
1. Accept a renewal
2. Check the email subjecthttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/684Make it possible to renew supportership for old members via the website2018-09-26T18:56:20+02:00Sébastiaan VersteegMake it possible to renew supportership for old members via the website### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the web...### One-sentence description
Make it possible to renew supportership for old members via the website
### Desired behaviour
Old members don't need signatures to become a supporter so we can easily enable their supportership via the website.https://gitlab.science.ru.nl/thalia/concrexit/-/issues/689Automatically execute data minimisation on accepted/rejected registrations af...2019-05-08T19:50:33+02:00Sébastiaan VersteegAutomatically execute data minimisation on accepted/rejected registrations after 1 month### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be mi...### One-sentence description
Automatically execute data minimalisation on accepted/rejected registrations after 1 month
### Desired behaviour
- Once registrations are accepted _and paid_ the data in the registration object should be minimalised to just the created membership. This will minimalise the places where user data is stored.
- Once registrations are rejected the data should be removed from our system.
- **This should not deleted accepted *and* non-paid registrations**. So those that are waiting for payment.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/690Registrations should not be editable after completion2018-09-26T18:59:06+02:00Sébastiaan VersteegRegistrations should not be editable after completion### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the admin### One-sentence description
Registrations should not be editable after completion
### Current behaviour
Can edit/save
### Expected behaviour
No edit
### Steps to reproduce
1. Open a completed registration in the admin