concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-08-28T16:59:10+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/677Make sure users have email addresses2018-08-28T16:59:10+02:00Sébastiaan VersteegMake sure users have email addresses### One-sentence description
Make sure users have email addresses
### Why?
Because the management commands could crash
### Current implementation
No checks for empty email addresses
### Desired implementation
Checks for empty emai...### One-sentence description
Make sure users have email addresses
### Why?
Because the management commands could crash
### Current implementation
No checks for empty email addresses
### Desired implementation
Checks for empty email addresses1.172018-10-15https://gitlab.science.ru.nl/thalia/concrexit/-/issues/656Reschedule event notification even if previously sent2018-07-09T09:39:40+02:00Sébastiaan VersteegReschedule event notification even if previously sent### One-sentence description
Reschedule event notification even if previously sent
### Current behaviour
Only the notification time is changed, even though it has been sent already.
### Expected behaviour
If the notification was sent a...### One-sentence description
Reschedule event notification even if previously sent
### Current behaviour
Only the notification time is changed, even though it has been sent already.
### Expected behaviour
If the notification was sent already it should be decoupled from the event and a new scheduled notification should be created.
### Steps to reproduce
1. Create event
2. Let notification send
3. Change the event start/registration times1.17https://gitlab.science.ru.nl/thalia/concrexit/-/issues/655Do not schedule/revoke messages for unpublished events2018-07-09T09:39:38+02:00Sébastiaan VersteegDo not schedule/revoke messages for unpublished events### One-sentence description
Do not schedule/revoke messages for unpublished events
### Current behaviour
Non published events still schedule messages
### Expected behaviour
No messages should be schedule
### Steps to reproduce
1....### One-sentence description
Do not schedule/revoke messages for unpublished events
### Current behaviour
Non published events still schedule messages
### Expected behaviour
No messages should be schedule
### Steps to reproduce
1. Create an event1.17https://gitlab.science.ru.nl/thalia/concrexit/-/issues/653Ordering for event registrations in backend is lexicographically, not chronol...2018-08-15T08:24:29+02:00Gijs HendriksenOrdering for event registrations in backend is lexicographically, not chronological### One-sentence description
Ordering in the events backend should be chronological when sorting based on a datetime field.
### Current behaviour
When ordering on the "Registration start" field, for example, the registrations are sorted...### One-sentence description
Ordering in the events backend should be chronological when sorting based on a datetime field.
### Current behaviour
When ordering on the "Registration start" field, for example, the registrations are sorted lexicographically, as can be seen in this screenshot:
![registration_ordering](/uploads/7f59f8d57f8b74e0d12ded2f867cca01/registration_ordering.png)
### Expected behaviour
When ordering on a datetime field, the registrations should be ordered chronologically.
### Steps to reproduce
1. Create registrations for June 2nd and July 1st for a certain event.
2. Go to the admin page for that specific event.
2. Notice that the registration in July is shown before the registration in June.1.17Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/631pipconflictchecker is broken2018-08-08T20:23:06+02:00Thom Wiggerspipconflictchecker is broken### One-sentence description
https://github.com/ambitioninc/pip-conflict-checker/issues/9 will cause builds to fail
### Workaround
Disable `pipconflictchecker` for now (!790, c24dfde4), re-enable it when it starts working again.### One-sentence description
https://github.com/ambitioninc/pip-conflict-checker/issues/9 will cause builds to fail
### Workaround
Disable `pipconflictchecker` for now (!790, c24dfde4), re-enable it when it starts working again.1.17Thom WiggersThom Wiggers