concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-11-02T15:46:27+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/735Event registration 'save and add another' doesn't work correctly2018-11-02T15:46:27+01:00Joris ReichertEvent registration 'save and add another' doesn't work correctly### One-sentence description
### Current behaviour
After manually adding a registration in the event admin using the button 'Save and add another' I'm redirected to the overview instead of getting another add form. The message is corre...### One-sentence description
### Current behaviour
After manually adding a registration in the event admin using the button 'Save and add another' I'm redirected to the overview instead of getting another add form. The message is correct, but the page is not.
![image](/uploads/5ec00a8ff5ee2d47420f9dd5b628a140/image.png)
Also, 'Save and continue editing' seems to have the same behaviour.
### Expected behaviour
Get the add form instead of the overview
### Steps to reproduce
1. Create a registration in the backend for and event using 'save and add another'
2. Get the overview instead of form
19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/734Don't use inline script2018-10-17T19:16:10+02:00Jelle Besselingjelle@pingiun.comDon't use inline script### One-sentence description
https://thalia.nu/thabloid/ uses an inline script for a click handler, inline scripts should not be used as they are unsafe.
The Content-Security-Policy should block inline scripts, so the remaining inline s...### One-sentence description
https://thalia.nu/thabloid/ uses an inline script for a click handler, inline scripts should not be used as they are unsafe.
The Content-Security-Policy should block inline scripts, so the remaining inline scripts should be removed.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/732Clicking members in society page directs to wrong page.2018-10-22T19:07:32+02:00Joris ReichertClicking members in society page directs to wrong page.Clicking a member in a society page links to the same page as you are on instead of the profile of that member.Clicking a member in a society page links to the same page as you are on instead of the profile of that member.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/731Societies are being treated the same way as committees2018-10-24T19:49:35+02:00Rico te WechelSocieties are being treated the same way as committees### One-sentence description
- Change voorzitter/chairman to contactpersoon/contact person.
- Either remove being in a society from 'achievements for Thalia', or rename 'achievements for Thalia' to 'history' or something alike.
- In case...### One-sentence description
- Change voorzitter/chairman to contactpersoon/contact person.
- Either remove being in a society from 'achievements for Thalia', or rename 'achievements for Thalia' to 'history' or something alike.
- In case the latter option is chosen, please also fix the following: being in a society is already visible under 'achievements for Thalia', even when the society is not active, and thus hidden, yet.
### Why?
- Societies don't have a voorzitter/chairman.
- Being in a society is not an achievement for Thalia.
### Current implementation
See above.
### Desired implementation
See above.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/729500 error on sitemap.xml2018-10-18T11:30:19+02:00Jelle Besselingjelle@pingiun.com500 error on sitemap.xml### Current behaviour
https://thalia.nu/sitemap.xml generates a 500 error instead of a sitemap
Related sentry entry: https://sentry.thalia.nu/sentry/concrexit/issues/100/?query=is:unresolved
### Expected behaviour
https://thalia.nu/site...### Current behaviour
https://thalia.nu/sitemap.xml generates a 500 error instead of a sitemap
Related sentry entry: https://sentry.thalia.nu/sentry/concrexit/issues/100/?query=is:unresolved
### Expected behaviour
https://thalia.nu/sitemap.xml generates a sitemap
### Steps to reproduce
1. Go to https://thalia.nu/sitemap.xml
2. See 500 error19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/725User profiles in committee pages don't link to user profiles2018-10-22T19:07:32+02:00Jelte SmitsUser profiles in committee pages don't link to user profiles### One-sentence description
User profiles in committee pages don't link to user profiles
### Current behaviour
When clicking on a user in a committee page the page just reloads
### Expected behaviour
The profiles should link to the ac...### One-sentence description
User profiles in committee pages don't link to user profiles
### Current behaviour
When clicking on a user in a committee page the page just reloads
### Expected behaviour
The profiles should link to the actual profiles
### Steps to reproduce
1. Go to a committee page
2. Click on a profile19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/721Report correct membership status / history on renewal page2018-10-18T11:30:19+02:00Joost Rijneveldjoost@joostrijneveld.nlReport correct membership status / history on renewal page### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
...### One-sentence description
Currently, on [this page](https://thalia.nu/registration/renew/) when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
Related, you may want to more explicitly mark the listed membership as the _last_ membership (since it's not my _current_ membership), or display _all_ historic memberships. Perhaps the latter is already the case, though - I'm not sure what my membership history looks like in the database, and I didn't do any local testing. Feel free to fork that off into a new issue if desirable.
I do feel like it's useful to display the just-expired membership, though, since that contains the expiry date (which may avoid confusion for year-members and supporters).
### Current behaviour
```
## MEMBERSHIP INFORMATION
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Active: no
You're a supporter. Contact the board to renew your membership.
```
### Expected behaviour
```
## MEMBERSHIP INFORMATION
### Current membership:
No active membership. Contact the board to renew your membership.
### Former memberships:
Membership type: Supporter
Since: Sept. 1, 2017
Until: Sept. 1, 2018
Membership type: Supporter
Since: Sept. 1, 2016
Until: Sept. 1, 2017
[..]
```
### Steps to reproduce
1. Don't have an active membership
2. Go to https://thalia.nu/registration/renew/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/720Event registration export does not have the correct date associated with it.2018-10-18T11:30:19+02:00Luko van der MaasEvent registration export does not have the correct date associated with it.~bug ~"priority: high"
### One-sentence description
When exporting the registrations of an event the date is incorrect.
### Current behaviour
Instead of the time with seconds, `%H:%m` is used.
### Expected behaviour
`%H:%M:%S.%f` is u...~bug ~"priority: high"
### One-sentence description
When exporting the registrations of an event the date is incorrect.
### Current behaviour
Instead of the time with seconds, `%H:%m` is used.
### Expected behaviour
`%H:%M:%S.%f` is used.
### Steps to reproduce
1. export registration of an event.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/714Empty board and committee pages not consistent2018-10-18T11:31:04+02:00Joren VranckenEmpty board and committee pages not consistent### One-sentence description
Going to the board page without any boards is not handled the same as going to the committee page without any committees.
### Current behaviour
If there are no boards, going to the board page results in a 40...### One-sentence description
Going to the board page without any boards is not handled the same as going to the committee page without any committees.
### Current behaviour
If there are no boards, going to the board page results in a 404 page because of an error (`No Board matches the given query.`). Going to the committee page without any committees however shows a nice message "There are no committees!".
Looking at [the template for the board page](https://gitlab.science.ru.nl/thalia/concrexit/blob/master/website/activemembers/templates/activemembers/board_index.html#L57) it looks like a similar message should be shown:
```
{% empty %}
{% trans 'There are no boards!' %}
{% endfor %}
```
### Expected behaviour
If there are no boards, going to the board page results in `There are no boards!`.
### Steps to reproduce
1. Go to the boards page without any boards.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/705Save calendar view selection to session2018-10-18T11:31:10+02:00Sébastiaan VersteegSave calendar view selection to session### One-sentence description
Save calendar view selection to session
### Desired behaviour
Save the selected view type of the website calendar to the user session so that you don't have to select it over and over again.### One-sentence description
Save calendar view selection to session
### Desired behaviour
Save the selected view type of the website calendar to the user session so that you don't have to select it over and over again.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/700Alphabetically order Miscellaneous Association Documents2018-11-07T19:14:40+01:00Sébastiaan VersteegAlphabetically order Miscellaneous Association Documents### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically### One-sentence description
Alphabetically order Miscellaneous Association Documents
### Desired behaviour
The documents on the documents page are ordered Alphabetically19Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/698Vacancy fixture creation broken2018-10-18T11:30:21+02:00Thom WiggersVacancy fixture creation broken### One-sentence description
```
./manage.py createfixtures -w 1
Traceback (most recent call last):
File "./manage.py", line 19, in <module>
execute_from_command_line(sys.argv)
File "/home/thom/.pythonenvs/concrexit-rWyBZ2S8/li...### One-sentence description
```
./manage.py createfixtures -w 1
Traceback (most recent call last):
File "./manage.py", line 19, in <module>
execute_from_command_line(sys.argv)
File "/home/thom/.pythonenvs/concrexit-rWyBZ2S8/lib/python3.6/site-packages/django/core/management/__init__.py", line 371, in execute_from_command_line
utility.execute()
File "/home/thom/.pythonenvs/concrexit-rWyBZ2S8/lib/python3.6/site-packages/django/core/management/__init__.py", line 365, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/home/thom/.pythonenvs/concrexit-rWyBZ2S8/lib/python3.6/site-packages/django/core/management/base.py", line 288, in run_from_argv
self.execute(*args, **cmd_options)
File "/home/thom/.pythonenvs/concrexit-rWyBZ2S8/lib/python3.6/site-packages/django/core/management/base.py", line 335, in execute
output = self.handle(*args, **options)
File "/home/thom/git/thalia/concrexit/website/utils/management/commands/createfixtures.py", line 432, in handle
self.create_vacancy(partners, categories)
File "/home/thom/git/thalia/concrexit/website/utils/management/commands/createfixtures.py", line 362, in create_vacancy
random.randint(0, 3))
File "/home/thom/.pythonenvs/concrexit-rWyBZ2S8/lib/python3.6/site-packages/django/db/models/fields/related_descriptors.py", line 509, in __set__
% self._get_set_deprecation_msg_params(),
TypeError: Direct assignment to the forward side of a many-to-many set is prohibited. Use categories.set() instead.
```19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/697Change mentions of 'supporter' to 'benefactor'2018-10-18T11:31:34+02:00Sébastiaan VersteegChange mentions of 'supporter' to 'benefactor'### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use ...### One-sentence description
Change mentions of 'supporter' to 'benefactor' for begunstigers
### Why?
It is the translation we use in all official documents that was decided upon by the Translacie.
### Current implementation
We use several different names for the 'begunstiger' membership type.
### Desired implementation
Always use 'benefactor' as translation.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/696Events on are shown outside of the bounding box2018-10-18T11:30:20+02:00Joren VranckenEvents on are shown outside of the bounding box### One-sentence description
Events description on homepage are shown outside of the bounding box.
### Current behaviour
![Example.png](/uploads/618dd909babab2af0763ae9a48cfc852/Screenshot_Chrome_20180908-123314.png)
The descriptions o...### One-sentence description
Events description on homepage are shown outside of the bounding box.
### Current behaviour
![Example.png](/uploads/618dd909babab2af0763ae9a48cfc852/Screenshot_Chrome_20180908-123314.png)
The descriptions of the three events are not contained within the grey box.
### Expected behaviour
The descriptions are contained within the grey box.
### Steps to reproduce
1. Using a phone, go to [thalia.nu](https://thalia.nu/).19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/695Styleguide documents via Google Drive2018-10-18T11:30:19+02:00Job DoesburgStyleguide documents via Google Drive### One-sentence description
Styleguide documents via Google Drive
### Why?
We want to replace the styleguide downloads by a URL to a subfolder in our drive so new files are always directly available and up-to-date.
### Current imple...### One-sentence description
Styleguide documents via Google Drive
### Why?
We want to replace the styleguide downloads by a URL to a subfolder in our drive so new files are always directly available and up-to-date.
### Current implementation
Files are hosted from the Thalia servers
### Desired implementation
Google Drive folders that can be accessed by members
19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/694Replace main photo header by slider2018-10-22T08:52:10+02:00Sébastiaan VersteegReplace main photo header by slider### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.### One-sentence description
Replace main photo header by slider
### Desired behaviour
We should have a slider like we had in Concrete5 to make promotion on the website easier.19Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/691Investigate double registrations2018-10-18T11:30:20+02:00Sébastiaan VersteegInvestigate double registrations### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrati...### One-sentence description
### Current behaviour
Two registrations with the same email address
### Expected behaviour
Only one registration/user per email address
### Steps to reproduce
1. Check https://thalia.nu/admin/registrations/registration/dd814d82-1a53-40a7-9b1c-19ee9b82ed18/change/
2. Check https://thalia.nu/admin/registrations/registration/ed857356-e362-4493-bb0d-f546c9ffcacb/change/19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/679Make it possible to correct an acception or rejection in registrations2018-10-18T11:30:37+02:00Sébastiaan VersteegMake it possible to correct an acception or rejection in registrations### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to corr...### One-sentence description
Make it possible to correct an acception or rejection
### Desired behaviour
Accepted or rejected registration can only be deleted but not corrected or changed in any way. We should make it possible to correct this. For example if it was a mistake or if the payment object was not created.19https://gitlab.science.ru.nl/thalia/concrexit/-/issues/533Directly linking to vacancies is broken2018-10-18T11:30:21+02:00Joost Rijneveldjoost@joostrijneveld.nlDirectly linking to vacancies is broken### One-sentence description
When clicking a vacancy and copy-pasting the link, the resulting page does not show the actual vacancy.
### Current behaviour
Copy-pasting a link to a vacancy causes you to navigate to a seemingly random p...### One-sentence description
When clicking a vacancy and copy-pasting the link, the resulting page does not show the actual vacancy.
### Current behaviour
Copy-pasting a link to a vacancy causes you to navigate to a seemingly random part of the page. This is probably due to the Javascript loading quite late. I realize this is perhaps non-trivial to fix, but that's Javascript for you.
### Expected behaviour
Copy-pasting a link to a vacancy causes you to navigate to the correct uncollapsed vacancy. Perhaps this can be more easily achieved by passing a server-sided CSS class when a page with an anchor is requested.
### Steps to reproduce
1. Go to e.g. https://thalia.nu/career/vacancies#vacancy-41
2. Land randomly on the page rather than seeing the correct uncollapsed vacancy19