concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2018-12-12T18:52:49+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/797Cannot open unpublished events in admin2018-12-12T18:52:49+01:00Sébastiaan VersteegCannot open unpublished events in admin### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview### One-sentence description
Cannot open unpublished events in admin
### Current behaviour / Reproducing the bug
Try to open https://beta.thalia.nu/admin/events/event/388/details/
### Expected behaviour
It opens the event overview20https://gitlab.science.ru.nl/thalia/concrexit/-/issues/782List view of events is really broken2018-11-28T19:00:04+01:00Leon van den BoogaardList view of events is really broken### One-sentence description
<!-- What breaks -->
The list view doesnt work when birthdays are shown
The list view shows too many events and events that already passed or are not in the timeslot
### Current behaviour / Reproducing the...### One-sentence description
<!-- What breaks -->
The list view doesnt work when birthdays are shown
The list view shows too many events and events that already passed or are not in the timeslot
### Current behaviour / Reproducing the bug
<!-- Please write what is happening and how we could reproduce it, if relevant -->
1. Click agenda (you see the calender view with a few events on it)
2. Click show verjaardagen
3. Click list
4. There is nothing on most weeks, or sometimes only 1 event from that week
5. KAPUT
<!-- -->
1. Click agenda
2. Click show verjaardagen
3. Click list
4. Nothing (like case 1)
5. Click 'week' or 'maand'
6. Click toon verjaardagen
7. All verjaardagen are now dubbel (also kind of an issue but im too lazy to make a seperate thingy)
8. Click hide verjaardagen
9. Click list
10. Look at the date it says on top and the dates of the events in the list
11. Those events are not in the selected week
12. KAPUT
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
I want to see the events normally in a list20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/779Buttons in event are ugly2018-11-21T19:44:18+01:00Sébastiaan VersteegButtons in event are ugly### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected beh...### One-sentence description
Buttons in event are ugly
### Current behaviour / Reproducing the bug
![Screenshot_2018-11-15_at_14.09.02](/uploads/3678e819d7f6fe8b1b1197874b0adb54/Screenshot_2018-11-15_at_14.09.02.png)
### Expected behaviour
Space between the buttons20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/768Export email addresses of selected members2018-11-14T11:19:22+01:00Sébastiaan VersteegExport email addresses of selected members### One-sentence description
Export email addresses of selected members
### Motivation
So that they can easily be contacted. Normally we would use mailing lists but some people are not part of those (anymore).
### Desired functionali...### One-sentence description
Export email addresses of selected members
### Motivation
So that they can easily be contacted. Normally we would use mailing lists but some people are not part of those (anymore).
### Desired functionality
Have the possibility to export email addresses of users from the admin
### Suggested implementation
Add an action to do this export20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/767Filter for former members2018-11-14T11:15:49+01:00Rico te WechelFilter for former members### One-sentence description
Apply filter on former members in the backend user list.
### Motivation
For the alumni committee, but perhaps in the future also for other parties and/or occasions, this would be a nice feature to easily rea...### One-sentence description
Apply filter on former members in the backend user list.
### Motivation
For the alumni committee, but perhaps in the future also for other parties and/or occasions, this would be a nice feature to easily reach our former members. In case of the alumni committee: We want to email them with invitations for our events.
### Desired functionality
In the backend, under users, I want to be able to apply a filter on former members. Currently this is only possible for members, benefactors and honorary members. After I applied the filter on the users I want to export their mailadresses. I haven't seen this option under 'desired action'. Should I make a new issue for this, or is there another way to achieve this?20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/766Remove usage of Celery for push notifications2018-11-28T18:52:23+01:00Sébastiaan VersteegRemove usage of Celery for push notifications### One-sentence description
Remove usage of Celery for push notifications
### Why?
Celery is not performing as expected.
### Current implementation
Celery is used to schedule push notifications
### Suggested implementation
Use a ...### One-sentence description
Remove usage of Celery for push notifications
### Why?
Celery is not performing as expected.
### Current implementation
Celery is used to schedule push notifications
### Suggested implementation
Use a management command and cronjob instead20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/762New navbar hinders usability2018-11-08T15:10:03+01:00Ward TheunisseNew navbar hinders usabilityThe new navbar styling is a bit large. This is especially apparent on mobile, where it occupies about a third of the screen, making navigation harder than it used to be.
These screenshots were taken using an iphone 5s:
![photo598797508...The new navbar styling is a bit large. This is especially apparent on mobile, where it occupies about a third of the screen, making navigation harder than it used to be.
These screenshots were taken using an iphone 5s:
![photo5987975080199695786](/uploads/8da2de814e106202235592f4d1c4d09d/photo5987975080199695786.jpg)
![photo5987975080199695787](/uploads/ada8c46155b6e05d80d87b26979245d7/photo5987975080199695787.jpg)20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/759Move the events admin views to the admin model2018-11-29T00:04:37+01:00Sébastiaan VersteegMove the events admin views to the admin model### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the a...### One-sentence description
Move the events admin views to the admin model
### Why?
It improves our codebase
### Current implementation
We have a `admin_views.py` and `admin.py`. The admin views are routed through `urls.py`, not the admin.
### Suggested implementation
Override the url config of the model admin used for events to add our custom views. Just like here: https://docs.djangoproject.com/en/2.1/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_urls20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/758Sentry has a new SDK2018-11-29T07:32:39+01:00Thom WiggersSentry has a new SDK<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Raven is depr...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Raven is deprecated and they now have `sentry-sdk`.
https://docs.sentry.io/quickstart?platform=python
https://docs.sentry.io/platforms/python/django/
### Why?
Shiny features probably won't end up in Raven. Also it seems like it's easier to configure.20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/757Switch to Firebase Admin SDK for push notifications2018-11-28T18:52:23+01:00Sébastiaan VersteegSwitch to Firebase Admin SDK for push notifications### One-sentence description
Switch to Firebase Admin SDK for push notifications
### Why?
Possible deprecation of a used package.
### Current implementation
We're currently using [pyFCM](https://github.com/olucurious/PyFCM/) which i...### One-sentence description
Switch to Firebase Admin SDK for push notifications
### Why?
Possible deprecation of a used package.
### Current implementation
We're currently using [pyFCM](https://github.com/olucurious/PyFCM/) which is using an older version of the Firebase Cloud Messaging APIs. There is a newer API (FCM v1) which has not been implemented.
### Suggested implementation
Use the Firebase Admin SDK to communicate with the Firebase servers and send messages.
https://firebase.google.com/docs/admin/setup
This package is also open source and is maintained by Firebase/Google instead of being a community project.20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/752Alumni page2018-11-19T12:26:58+01:00Jeroen van AlemAlumni page### One-sentence description
The alumnicie would like a page on the website that explains what we do and shows all future events.
### Motivation
We would like a central place were alumni can find information about future events. We'll ...### One-sentence description
The alumnicie would like a page on the website that explains what we do and shows all future events.
### Motivation
We would like a central place were alumni can find information about future events. We'll add a link in the event description where they can register without needing a Thalia account. A page would allow us to communicate this to alumni.
### Desired functionality
The page would contain a piece of general information about alumni events. It would contain a list with future events, around 4/5. All the events will contain a piece of information about the event together with the title and date.
### Suggested implementation
We trust in your expertise.
<!--
If you have any notes on how we could achieve this feature,
share them here.
-->20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/740Registrations input validation student number auto capitalize2018-12-05T19:47:12+01:00Job DoesburgRegistrations input validation student number auto capitalize<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
Automatically convert student numbers to correct capitalization
### Why?
Especially on mobile devices, when entering a student number in the registration form, it starts with an capital S while only a small letter s is accepted (or the other way around, sorry I don't know). It would be nice to just accept both and convert it automatically. Same for people just entering a 7-digit number without prefix s.
### Current implementation
Only certain capitalization is accepted.
### Suggested implementation
Accept all CaPiTaliZatIoN and convert it automatically to a specific format.20Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/724Update Fancybox to version 32018-11-14T18:52:53+01:00Sébastiaan VersteegUpdate Fancybox to version 3### One-sentence description
Update Fancybox to version 3
### Why?
We currently use an old version (2.x). However, this version is licensed under CC BY-NC 3.0. Version 3 is GPLv3 for open source projects only. So I think this can be d...### One-sentence description
Update Fancybox to version 3
### Why?
We currently use an old version (2.x). However, this version is licensed under CC BY-NC 3.0. Version 3 is GPLv3 for open source projects only. So I think this can be done only after fully open sourcing. [Their website](http://fancyapps.com/fancybox/3/#license) is unclear:
> fancybox is licensed under the GPLv3 license for all open source applications.
A commercial license is required for all commercial applications (including sites, themes and apps you plan to sell).
¿Our website is non-commercial but not open source?
### Current implementation
Fancybox 2.x
### Desired implementation
Fancybox 3.x20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/722Add search functionality to photo albums2018-11-14T23:04:28+01:00Sébastiaan VersteegAdd search functionality to photo albums### One-sentence description
Add search functionality to photo albums
### Desired behaviour
Being able to search### One-sentence description
Add search functionality to photo albums
### Desired behaviour
Being able to search20Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/487Sort out re-use of event registration objects2018-11-14T11:12:03+01:00Joost Rijneveldjoost@joostrijneveld.nlSort out re-use of event registration objectsIn #484, it became apparent that Registration objects were expected to be recreated, but are currently being re-used (https://gitlab.science.ru.nl/thalia/concrexit/issues/484#note_34876). We should look into this, and make it consistent....In #484, it became apparent that Registration objects were expected to be recreated, but are currently being re-used (https://gitlab.science.ru.nl/thalia/concrexit/issues/484#note_34876). We should look into this, and make it consistent.
Creating new registration objects when people re-register creates a more accurate timeline, but it may make things a bit harder to understand when someone occurs as both cancelled and registered (in that case, should we omit the cancelled registration from the view?).20Sébastiaan VersteegSébastiaan Versteeg