concrexit issueshttps://gitlab.science.ru.nl/thalia/concrexit/-/issues2019-01-05T19:12:03+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/issues/801Thumbnails of partner images2019-01-05T19:12:03+01:00Sébastiaan VersteegThumbnails of partner images### One-sentence description
Partner images do not have thumbnails
### Current behaviour / Reproducing the bug
Check all partner images
### Expected behaviour
Originals are not used### One-sentence description
Partner images do not have thumbnails
### Current behaviour / Reproducing the bug
Check all partner images
### Expected behaviour
Originals are not used21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/800Pizza order page lost sorting functionality2019-01-05T19:12:31+01:00Serena RietbergenPizza order page lost sorting functionality/label ~bug ~"priority: medium"
### One-sentence description
Pizza order page lost sorting functionality
### Current behaviour / Reproducing the bug
Example: https://thalia.nu/pizzas/orders/76/
Cannot sort in the table anymore
### E.../label ~bug ~"priority: medium"
### One-sentence description
Pizza order page lost sorting functionality
### Current behaviour / Reproducing the bug
Example: https://thalia.nu/pizzas/orders/76/
Cannot sort in the table anymore
### Expected behaviour
Sorting is possible
21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/795Search button on photos page not responsive2018-12-16T16:08:24+01:00Sébastiaan VersteegSearch button on photos page not responsiveJust like #773
### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
Visit photos page on mobile
### Expected behaviour
Not ugly.Just like #773
### One-sentence description
Search button on members page not responsive
### Current behaviour / Reproducing the bug
Visit photos page on mobile
### Expected behaviour
Not ugly.21https://gitlab.science.ru.nl/thalia/concrexit/-/issues/794Can still add `oudbesturen` as manual mailinglist2019-01-05T19:14:49+01:00Sébastiaan VersteegCan still add `oudbesturen` as manual mailinglistRelated to !1079 and !1071
### One-sentence description
Can still add `oudbesturen` as manual mailinglist
### Current behaviour / Reproducing the bug
1. Create a mailinglist or alias with the name 'oudbesturen'/'oldboards'.
### Expe...Related to !1079 and !1071
### One-sentence description
Can still add `oudbesturen` as manual mailinglist
### Current behaviour / Reproducing the bug
1. Create a mailinglist or alias with the name 'oudbesturen'/'oldboards'.
### Expected behaviour
Block creation.21Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/issues/793Thabloid filtering keeps items that should be hidden2018-12-16T16:09:32+01:00Sébastiaan VersteegThabloid filtering keeps items that should be hidden### One-sentence description
Thabloid filtering keeps items that should be hidden
### Current behaviour / Reproducing the bug
1. Go to the Thabloid page
2. Filter on a year
3. Notice that all the whitespace
### Expected behaviour
No...### One-sentence description
Thabloid filtering keeps items that should be hidden
### Current behaviour / Reproducing the bug
1. Go to the Thabloid page
2. Filter on a year
3. Notice that all the whitespace
### Expected behaviour
No whitespace, nice grid.
### Solution
The `col` items for the grid are not connected to the filter plugin, the content is hidden but the container is not resulting in the visible whitespace.21https://gitlab.science.ru.nl/thalia/concrexit/-/issues/783Always set rel="noopener" with target="_blank" for external domains2018-12-16T16:06:32+01:00Joren VranckenAlways set rel="noopener" with target="_blank" for external domains### One-sentence description
<!-- What breaks -->
Always set `rel="noopener"` with `target = "_blank"` for external domains.
### Why
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2...### One-sentence description
<!-- What breaks -->
Always set `rel="noopener"` with `target = "_blank"` for external domains.
### Why
<!-- Please write what is happening and how we could reproduce it, if relevant -->
<!--
1. Step 1
2. Step 2
3. ???
4. Breakage
-->
Using `target="_blank"` without `rel="noopener"` for external domains is a security vulnerability.
* [source](https://www.tutorialdocs.com/article/html-opener-blank.html)
* [source](https://developers.google.com/web/tools/lighthouse/audits/noopener)
### Expected behaviour
<!-- Please write how what happened did not meet your expectations -->
`a` tags containing `target="_blank"` should also contain `rel="noopener noreferrer nofollow"`.21https://gitlab.science.ru.nl/thalia/concrexit/-/issues/775Members are shown according to cohort2019-01-05T19:11:06+01:00Thijs de JongMembers are shown according to cohort<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current wa...<!--
This template is for changes that do not affect the behaviour of the website.
Examples:
* Changes in CI
* Refactoring of code
* Technicie-facing documentation
-->
### One-sentence description
The current way of displaying members when you select all members, is by showing them on cohort order, while this should change to alphabetical order.
<!-- Please provide a brief description of the issue. Don't go into specifics. -->
### Why?
It is more clear when it is sorted on alphabetical order, instead of first sorted on Cohort order and then alphabetical order.
<!-- Please motivate why we should invest into this change -->
### Current implementation
Currently, it is sorted on Cohort order, and then Alphabetical order, when selecting 'all members'.
https://thalia.nu/members/
<!-- If relevant, describe how it's done currently -->
### Suggested implementation
When selecting 'all members', it should be sorted Alphabetically immediately.
<!-- Provide (a) suggestion(s) for how we could approach this -->21Sébastiaan VersteegSébastiaan Versteeg