Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
concrexit
concrexit
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 10
    • Merge Requests 10
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thalia
  • concrexitconcrexit
  • Issues
  • #1020

Closed
Open
Opened Feb 26, 2020 by Job Doesburg@jdoesburgContributor

Do not use hardcoded colors for calendar API

One-sentence description

Do not use hardcoded colors for calendar API in website/members/api/serializers.py r42-49 and website/events/api/serializers.py

Why?

We shouldn't hardcode these things at the API level but provide them using CSS.

Current implementation

The API provides a backgroundColor and textColor in the event sources APIs that is used by FullCalendar via https://fullcalendar.io/docs/events-json-feed. Every item in the feed is an event source object: https://fullcalendar.io/docs/event-source-object.

Suggested implementation

Provide a className attribute instead and determine the background color and text color based on the class using CSS.

Edited Feb 26, 2020 by Sébastiaan Versteeg
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: thalia/concrexit#1020