Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • concrexit concrexit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 70
    • Issues 70
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • thaliathalia
  • concrexitconcrexit
  • Issues
  • #159
Closed
Open
Issue created Nov 23, 2016 by Joost Rijneveld@lrijneveldContributor

Partner logos stored in sessions may be out of date

When visiting a random page, a variable is added to a user's session that contains the sequence in which partner logos are displayed in the header. If partners are then updated (added / modified / deleted), the sequence in the session no longer matches reality. However, there is no way to invalidate this.

It can be solved by caching some sort of checksum over the existing partners (something that does not hit the database on every request!) and comparing this to the value in the user's session. Calling save() on a partner would then need to invalidate this cache and recompute the checksum.

Notably, the @cached_property decorator does not apply here, as it is recomputed for every new instance (and thus does not persist across requests).

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking