Report correct membership status / history on renewal page
Currently, on this page when you don't have an active status, it'll display your last status (i.e. "You're a supporter"). That sentence should probably not be there.
Related, you may want to more explicitly mark the listed membership as the last membership (since it's not my current membership), or display all historic memberships. Perhaps the latter is already the case, though - I'm not sure what my membership history looks like in the database, and I didn't do any local testing. Feel free to fork that off into a new issue if desirable.
I do feel like it's useful to display the just-expired membership, though, since that contains the expiry date (which may avoid confusion for year-members and supporters).
## MEMBERSHIP INFORMATION Membership type: Supporter Since: Sept. 1, 2017 Until: Sept. 1, 2018 Active: no You're a supporter. Contact the board to renew your membership.
## MEMBERSHIP INFORMATION ### Current membership: No active membership. Contact the board to renew your membership. ### Former memberships: Membership type: Supporter Since: Sept. 1, 2017 Until: Sept. 1, 2018 Membership type: Supporter Since: Sept. 1, 2016 Until: Sept. 1, 2017 [..]
Steps to reproduce
- Don't have an active membership
- Go to https://thalia.nu/registration/renew/
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information