concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-03-13T16:56:20+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1535Remove non-ascii characters from the almanac translations2020-03-13T16:56:20+01:00Joren VranckenRemove non-ascii characters from the almanac translations#### Previous behaviour
Steps to reproduce:
1. Go to the [almanac page](https://thalia.nu/members/almanac/) in Dutch.
2. Observe that the TypeForm link goes to `https://thalia.nu/members/almanac/%E2%80%9Chttps://typeform.com%E2%80%9D`.
...#### Previous behaviour
Steps to reproduce:
1. Go to the [almanac page](https://thalia.nu/members/almanac/) in Dutch.
2. Observe that the TypeForm link goes to `https://thalia.nu/members/almanac/%E2%80%9Chttps://typeform.com%E2%80%9D`.
#### New behaviour
Steps to validate that it works:
1. Go to the [almanac page](https://thalia.nu/members/almanac/) in Dutch.
2. Observe that the TypeForm link goes to `https://typeform.com`.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1531Fix banner about events permissions2020-03-11T21:29:49+01:00Sébastiaan VersteegFix banner about events permissions#### Previous behaviour
Steps to reproduce:
1. See that while not logged in you always get a banner about event permissions.
#### New behaviour
Steps to validate that it works:
1. See that while not logged in you not always get a bann...#### Previous behaviour
Steps to reproduce:
1. See that while not logged in you always get a banner about event permissions.
#### New behaviour
Steps to validate that it works:
1. See that while not logged in you not always get a banner about event permissions.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1530Fix users set to newsletter push notification2020-03-11T20:24:56+01:00Sébastiaan VersteegFix users set to newsletter push notification#### Previous behaviour
Steps to reproduce:
1. Send a newsletter
2. Receive a notification in the app
#### New behaviour
Steps to validate that it works:
1. Send a newsletter
2. Receive a notification in the app#### Previous behaviour
Steps to reproduce:
1. Send a newsletter
2. Receive a notification in the app
#### New behaviour
Steps to validate that it works:
1. Send a newsletter
2. Receive a notification in the app31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1529Fix summary creation message2020-03-11T20:14:25+01:00Sébastiaan VersteegFix summary creation messageReally fixes #998
#### Previous behaviour
Steps to reproduce:
1. Create a summary
#### New behaviour
Steps to validate that it works:
1. Create a summaryReally fixes #998
#### Previous behaviour
Steps to reproduce:
1. Create a summary
#### New behaviour
Steps to validate that it works:
1. Create a summary31Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1528Change alamanc setting to environ variable2020-03-11T19:52:01+01:00Luko van der MaasChange alamanc setting to environ variable#### Previous behaviour
Steps to reproduce:
1. Go to thalia.nu/members/almanac
2. You see coming soon
#### New behaviour
Steps to validate that it works:
1. Go to thalia.nu/members/almanac
2. See something for the almanac#### Previous behaviour
Steps to reproduce:
1. Go to thalia.nu/members/almanac
2. You see coming soon
#### New behaviour
Steps to validate that it works:
1. Go to thalia.nu/members/almanac
2. See something for the almanac31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1519Fix crash when pizza event admin orders pizza2020-03-04T21:14:03+01:00Gijs HendriksenFix crash when pizza event admin orders pizza#### Previous behaviour
When an organizer of a pizza event orders a pizza, the API crashes.
Steps to reproduce:
1. Create an event for which you are organizer.
2. Create an accompanying pizza event.
3. Order pizza using the API/app.
4...#### Previous behaviour
When an organizer of a pizza event orders a pizza, the API crashes.
Steps to reproduce:
1. Create an event for which you are organizer.
2. Create an accompanying pizza event.
3. Order pizza using the API/app.
4. Crash.
#### New behaviour
Ordering works even if you're organizer.
Steps to validate that it works:
1. Create an event for which you are organizer.
2. Create an accompanying pizza event.
3. Order pizza using the API/app.
4. No crash.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1512Fix events blacklist announcement if-statement2020-03-11T19:08:38+01:00Sébastiaan VersteegFix events blacklist announcement if-statement#### Previous behaviour
Steps to reproduce:
1. The 'you are blocked from going to events' banner is always showing
#### New behaviour
Steps to validate that it works:
1. The 'you are blocked from going to events' banner is not always ...#### Previous behaviour
Steps to reproduce:
1. The 'you are blocked from going to events' banner is always showing
#### New behaviour
Steps to validate that it works:
1. The 'you are blocked from going to events' banner is not always showing31Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1511Fix recursion error events models2020-03-04T21:54:10+01:00Sébastiaan VersteegFix recursion error events modelsCloses #1015 #1018
#### Previous behaviour
Steps to reproduce:
1. Save a published event after changing it to unpublished
2. Remove a published event
#### New behaviour
Steps to validate that it works:
1. Save a published...Closes #1015 #1018
#### Previous behaviour
Steps to reproduce:
1. Save a published event after changing it to unpublished
2. Remove a published event
#### New behaviour
Steps to validate that it works:
1. Save a published event after changing it to unpublished
2. Remove a published eventJelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1506Resolve "Show deregistration disclaimer text even if not registered for event"2020-02-23T16:53:09+01:00Mark BouteResolve "Show deregistration disclaimer text even if not registered for event"Closes #1008Closes #100831https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1503Resolve "Missing translations in statistics page"2020-02-19T23:46:54+01:00Mark BouteResolve "Missing translations in statistics page"Closes #981Closes #98131https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1501Disable payment button for Thalia Pay in payment widget2020-02-19T21:48:25+01:00Marie SimonDisable payment button for Thalia Pay in payment widgetCloses #980
#### Previous behaviour
Steps to reproduce:
1. One can click the process button for Thalia Pay for a membership registration
2. It crashes
#### New behaviour
Steps to validate that it works:
1.Cannot click it anymoreCloses #980
#### Previous behaviour
Steps to reproduce:
1. One can click the process button for Thalia Pay for a membership registration
2. It crashes
#### New behaviour
Steps to validate that it works:
1.Cannot click it anymore31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1500Fixed login message visible2020-02-19T21:47:58+01:00Luc KnolFixed login message visible/label ~bug
Closes #968
#### Previous behaviour
Steps to reproduce:
1. Do not log in.
2. Go to an event for which no registration is required.
3. A login button appears.
#### New behaviour
Steps to validate that it works:.../label ~bug
Closes #968
#### Previous behaviour
Steps to reproduce:
1. Do not log in.
2. Go to an event for which no registration is required.
3. A login button appears.
#### New behaviour
Steps to validate that it works:
1. Do not log in.
2. Go to an event for which no registration is required.
3. No login button appears, a message "no registration required" is displayed.
31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1497Set Postgres Password in CI2020-02-19T21:50:16+01:00Joren VranckenSet Postgres Password in CI#### Previous behaviour
CI failed, because Postgres password was not set ([upstream commit](https://github.com/docker-library/postgres/commit/f1bc8782e7e57cc403d0b32c0e24599535859f76)).
#### New behaviour
Postgres password is set.#### Previous behaviour
CI failed, because Postgres password was not set ([upstream commit](https://github.com/docker-library/postgres/commit/f1bc8782e7e57cc403d0b32c0e24599535859f76)).
#### New behaviour
Postgres password is set.31Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1492Resolve "/api/v1/token-auth does not return json on login failure"2020-02-20T08:45:53+01:00Simcha van CollemResolve "/api/v1/token-auth does not return json on login failure"Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-...Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-auth`
2. `{"error": "Unauthorized"}` is returned31Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1486Login page not visible anymore when logged-in2020-02-05T21:24:02+01:00Luc KnolLogin page not visible anymore when logged-inCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to homeCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to home31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1485Resolve "'All members' in members directory not marked as active"2020-02-05T21:18:38+01:00Simcha van CollemResolve "'All members' in members directory not marked as active"Closes #1004
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
#### New behaviour
Steps to validate that it works:
1. Go to https://thalia.nu/members/directory/
2. ...Closes #1004
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
#### New behaviour
Steps to validate that it works:
1. Go to https://thalia.nu/members/directory/
2. The item is selected31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1483Resolve "Event admin view does not include 'user-tools' like other admin temp...2020-02-19T19:38:58+01:00Simcha van CollemResolve "Event admin view does not include 'user-tools' like other admin templates"Closes #978
#### Previous behaviour
Steps to reproduce:
1. Edit an event
2. There is no user-tools in the navbar
#### New behaviour
Steps to validate that it works:
1. Edit an event
2. There is an user-tools in the navbarCloses #978
#### Previous behaviour
Steps to reproduce:
1. Edit an event
2. There is no user-tools in the navbar
#### New behaviour
Steps to validate that it works:
1. Edit an event
2. There is an user-tools in the navbar31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1482Success_messages added for every exam and summary upload2020-02-05T21:35:25+01:00Marthijn van den NieuwenhuizenSuccess_messages added for every exam and summary uploadCloses #998
#### Previous behaviour
Steps to reproduce:
1. Upload Exam or Summary
2. Receive no notification message upon successful upload
#### New behaviour
Steps to validate that it works:
1. Upload Exam or Summary
2. Receive not...Closes #998
#### Previous behaviour
Steps to reproduce:
1. Upload Exam or Summary
2. Receive no notification message upon successful upload
#### New behaviour
Steps to validate that it works:
1. Upload Exam or Summary
2. Receive notification message upon successful upload31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1481Resolve "No favicon for the admin site"2020-02-05T21:24:49+01:00Wouter DoelandResolve "No favicon for the admin site"/label ~bug
Closes #999
#### Previous behaviour
Steps to reproduce:
1. Open the admin panel
2. There is no favicon
#### New behaviour
Steps to validate that it works:
1. Open the admin panel
2. There is a favicon
/label ~bug
Closes #999
#### Previous behaviour
Steps to reproduce:
1. Open the admin panel
2. There is no favicon
#### New behaviour
Steps to validate that it works:
1. Open the admin panel
2. There is a favicon
31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1472Replace Nextcloud menu item with G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenReplace Nextcloud menu item with G Suite Knowledge Base### Short description
Replace Nextcloud menu item with G Suite Knowledge Base, because we will shutdown Nextcloud on February 3rd in favor of G Suite.### Short description
Replace Nextcloud menu item with G Suite Knowledge Base, because we will shutdown Nextcloud on February 3rd in favor of G Suite.30