concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-02-13T19:16:31+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1152Fix vars in fstr in conscribosync.py2019-02-13T19:16:31+01:00Sébastiaan VersteegFix vars in fstr in conscribosync.py#### Previous behaviour
Steps to reproduce:
1. Syncs name with `$` inside value
#### New behaviour
Steps to validate that it works:
1. Syncs name without `$` inside value#### Previous behaviour
Steps to reproduce:
1. Syncs name with `$` inside value
#### New behaviour
Steps to validate that it works:
1. Syncs name without `$` inside value22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1159Changed Date Format in List View + Translations2019-02-13T19:51:24+01:00Thijs de JongChanged Date Format in List View + TranslationsCloses #823
#### Previous behaviour
The date format in the list view would be: YYYY-MM-DD
#### New behaviour
The date format in the list view is: day, date, time (Using LLLL)
Translations have also been added.Closes #823
#### Previous behaviour
The date format in the list view would be: YYYY-MM-DD
#### New behaviour
The date format in the list view is: day, date, time (Using LLLL)
Translations have also been added.22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1163Fix pizza order where pizza event has no notification, closes #8192019-02-13T20:54:35+01:00Sébastiaan VersteegFix pizza order where pizza event has no notification, closes #819Closes #819
#### Previous behaviour
Steps to reproduce:
1. Create a pizza event without notification
2. Order a product
3. Crash
#### New behaviour
Steps to validate that it works:
1. Create a pizza event without notification
2. Orde...Closes #819
#### Previous behaviour
Steps to reproduce:
1. Create a pizza event without notification
2. Order a product
3. Crash
#### New behaviour
Steps to validate that it works:
1. Create a pizza event without notification
2. Order a product
3. No crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1149Fixed Visual Error Committees2019-02-13T21:00:25+01:00Thijs de JongFixed Visual Error CommitteesCloses #791
#### Previous behaviour
Text in Committee Grid View would not match on phone
#### New behaviour
Text in Committee Grid View matches the boxCloses #791
#### Previous behaviour
Text in Committee Grid View would not match on phone
#### New behaviour
Text in Committee Grid View matches the box22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1160Clickable links to Achievements and Societies2019-02-13T21:24:42+01:00Thijs de JongClickable links to Achievements and SocietiesCloses #828
#### Previous behaviour
The committees/societies on a profile page were not clickable
#### New behaviour
The committees/societies on a profile page are clickableCloses #828
#### Previous behaviour
The committees/societies on a profile page were not clickable
#### New behaviour
The committees/societies on a profile page are clickable22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1169Fix NoneType error in payments csv export2019-02-17T15:04:17+01:00Sébastiaan VersteegFix NoneType error in payments csv export#### Previous behaviour
Steps to reproduce:
1. Export a csv of payments
2. Crash
#### New behaviour
Steps to validate that it works:
1. Export a csv of payments
2. No crash#### Previous behaviour
Steps to reproduce:
1. Export a csv of payments
2. Crash
#### New behaviour
Steps to validate that it works:
1. Export a csv of payments
2. No crash22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1162Fix for API assuming non external registration2019-02-18T20:10:52+01:00Luko van der MaasFix for API assuming non external registrationFix #822Fix #82222Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1165Always show member group members for authenticated users2019-02-20T20:20:09+01:00Sébastiaan VersteegAlways show member group members for authenticated usersCloses #478
#### Previous behaviour
Steps to reproduce:
1. Hide member group
2. Authenticated
3. No visible members
#### New behaviour
Steps to validate that it works:
1. Hide member group
2. Authenticated
3. Visible membersCloses #478
#### Previous behaviour
Steps to reproduce:
1. Hide member group
2. Authenticated
3. No visible members
#### New behaviour
Steps to validate that it works:
1. Hide member group
2. Authenticated
3. Visible members22Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1172Fix events payments migration2019-02-20T20:49:41+01:00Sébastiaan VersteegFix events payments migration/label ~bug
#### Previous behaviour
Steps to reproduce:
1. Migrate the events.
2. Weird notes.
#### New behaviour
Steps to validate that it works:
1. Migrate the events.
2. Better notes.
/label ~bug
#### Previous behaviour
Steps to reproduce:
1. Migrate the events.
2. Weird notes.
#### New behaviour
Steps to validate that it works:
1. Migrate the events.
2. Better notes.
22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1175Fix admin.py headers in payments2019-02-20T21:33:26+01:00Sébastiaan VersteegFix admin.py headers in paymentsFix admin.py headers in paymentsFix admin.py headers in paymentshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1181Fix member tabs active state2019-02-27T20:14:50+01:00Sébastiaan VersteegFix member tabs active state#### Previous behaviour
Steps to reproduce:
1. Click 'former' or 'older' members tabs in directory
2. No active state
#### New behaviour
Steps to validate that it works:
1. Click 'former' or 'older' members tabs in director...#### Previous behaviour
Steps to reproduce:
1. Click 'former' or 'older' members tabs in directory
2. No active state
#### New behaviour
Steps to validate that it works:
1. Click 'former' or 'older' members tabs in directory
2. Has active state23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1178Thumbnail the merchandise images2019-02-27T20:15:24+01:00Sébastiaan VersteegThumbnail the merchandise images#### Previous behaviour
Steps to reproduce:
1. Go to the merchandise page
2. All full size images loaded
#### New behaviour
Steps to validate that it works:
1. Go to the merchandise page
2. Thumbnails loaded#### Previous behaviour
Steps to reproduce:
1. Go to the merchandise page
2. All full size images loaded
#### New behaviour
Steps to validate that it works:
1. Go to the merchandise page
2. Thumbnails loaded23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1197Fix grayscaling of unavailable albums2019-03-27T19:18:00+01:00Sébastiaan VersteegFix grayscaling of unavailable albumsCloses #834
#### Previous behaviour
Steps to reproduce:
1. Go to a photo album that is not accessible for you
2. It is not grayed out and clickable
#### New behaviour
Steps to validate that it works:
1. Go to a photo album that is n...Closes #834
#### Previous behaviour
Steps to reproduce:
1. Go to a photo album that is not accessible for you
2. It is not grayed out and clickable
#### New behaviour
Steps to validate that it works:
1. Go to a photo album that is not accessible for you in the list of photo albums
2. It is grayed out and not clickable23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1198Set html language code based on current session2019-03-27T19:50:18+01:00Sébastiaan VersteegSet html language code based on current sessionCloses #835
#### Previous behaviour
Steps to reproduce:
1. Check the HTML attribute on production when the language is Dutch
2. It's set to `en`
#### New behaviour
Steps to validate that it works:
1. Check the HTML attribute on produ...Closes #835
#### Previous behaviour
Steps to reproduce:
1. Check the HTML attribute on production when the language is Dutch
2. It's set to `en`
#### New behaviour
Steps to validate that it works:
1. Check the HTML attribute on production when the language is Dutch
2. It's set to `nl`23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1183Allow board membership to contain end date2019-03-27T19:50:29+01:00Tobias van der WerffAllow board membership to contain end dateCloses #416
#### Previous behaviour
Steps to reproduce:
1. Enter end date for Board membership; this produces an error message.
#### New behaviour
Steps to validate that it works:
1. Enter end date for Board membership; this no long...Closes #416
#### Previous behaviour
Steps to reproduce:
1. Enter end date for Board membership; this produces an error message.
#### New behaviour
Steps to validate that it works:
1. Enter end date for Board membership; this no longer produces an error message.23Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1194Fix registration editing organiser non member2019-03-27T20:33:33+01:00Sébastiaan VersteegFix registration editing organiser non memberCloses #839
#### Previous behaviour
Steps to reproduce:
1. Create two non-members in an event registration
2. Mark one as paid & refresh
3. Status moved back
#### New behaviour
Steps to validate that it works:
1. Create two non-memb...Closes #839
#### Previous behaviour
Steps to reproduce:
1. Create two non-members in an event registration
2. Mark one as paid & refresh
3. Status moved back
#### New behaviour
Steps to validate that it works:
1. Create two non-members in an event registration
2. Mark one as paid & refresh
3. Works23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1201Changed Translation For Programme Registration2019-04-03T20:10:14+02:00Thijs de JongChanged Translation For Programme RegistrationCloses #846
#### Previous behaviour
Translation to Dutch for ``Computing Science`` and ``Information Sciences`` was ``Informatica`` and ``Informatiekunde``.
#### New behaviour
New translations have been added; in Dutch, it is no...Closes #846
#### Previous behaviour
Translation to Dutch for ``Computing Science`` and ``Information Sciences`` was ``Informatica`` and ``Informatiekunde``.
#### New behaviour
New translations have been added; in Dutch, it is now ``Informatica (Computing Science)`` and ``Informatiekunde (Information Sciences)``.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1166Restrict changing registration to users with change registration perms2019-04-03T20:30:42+02:00Sébastiaan VersteegRestrict changing registration to users with change registration permsCloses #825
#### Previous behaviour
Steps to reproduce:
1. Create a user without registration change permission but with event change permission
2. Edit a registration of an event organised by a member group that the member is in
3. W...Closes #825
#### Previous behaviour
Steps to reproduce:
1. Create a user without registration change permission but with event change permission
2. Edit a registration of an event organised by a member group that the member is in
3. Works
#### New behaviour
Steps to validate that it works:
1. Create a user without registration change permission but with event change permission
2. Edit a registration of an event organised by a member group that the member is in
3. Does not work23Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1164Restrict updates to pizza orders to organisers of the pizza event2019-04-03T20:30:50+02:00Gijs HendriksenRestrict updates to pizza orders to organisers of the pizza event#### Previous behaviour
Every member with permissions to change pizza orders can edit all orders through the API
Steps to reproduce:
1. `PUT /api/v1/pizzas/orders/[pk]` when you are not the organiser of the event associated with the p...#### Previous behaviour
Every member with permissions to change pizza orders can edit all orders through the API
Steps to reproduce:
1. `PUT /api/v1/pizzas/orders/[pk]` when you are not the organiser of the event associated with the pizza event.
2. Notice it is successful if you have the `pizzas.change_order` permission.
#### New behaviour
Only members that are organiser of the event associated with the pizza event can change orders.
Steps to validate that it works:
1. `PUT /api/v1/pizzas/orders/[pk]` when you are not the organiser of the event associated with the pizza event.
2. Notice it is only successful for the product of your own order if you are not the organiser of this pizza event.23Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1196Fix race condition in registration approve/save2019-04-03T20:32:13+02:00Sébastiaan VersteegFix race condition in registration approve/saveCloses #841
#### Previous behaviour
Steps to reproduce:
1. Create new registration
2. Try to approve + save within couple of seconds
3. Empty payment
#### New behaviour
Steps to validate that it works:
1. Create new registration
2. ...Closes #841
#### Previous behaviour
Steps to reproduce:
1. Create new registration
2. Try to approve + save within couple of seconds
3. Empty payment
#### New behaviour
Steps to validate that it works:
1. Create new registration
2. Try to approve + save within couple of seconds
3. Cannot save + existing payment23