concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-05-31T15:28:43+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/818Fix settings import to the right module2018-05-31T15:28:43+02:00Sébastiaan VersteegFix settings import to the right moduleThis should prevent issues with overridden settings in `production.py` or `localsettings.py`This should prevent issues with overridden settings in `production.py` or `localsettings.py`1.16Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/814Add membership decorator and require an active membership to download exams/s...2018-06-13T19:43:34+02:00Sébastiaan VersteegAdd membership decorator and require an active membership to download exams/summaries#### Previous behaviour
Steps to reproduce:
1. Non-members could download summaries/exams
#### New behaviour
Steps to validate that it works:
1. Only members can download summaries/exams#### Previous behaviour
Steps to reproduce:
1. Non-members could download summaries/exams
#### New behaviour
Steps to validate that it works:
1. Only members can download summaries/exams1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/808Change pizzas product pricing space to nbsp for all products in list.2018-06-13T18:54:48+02:00Sébastiaan VersteegChange pizzas product pricing space to nbsp for all products in list.### Short description
Change pizzas product pricing space to nbsp for all products in list.### Short description
Change pizzas product pricing space to nbsp for all products in list.1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/804Fix committee membership role on detail page2018-05-24T10:31:50+02:00Sébastiaan VersteegFix committee membership role on detail page#### Previous behaviour
Steps to reproduce:
1. Set a role on a committee membership
2. Not showing on the detail page
#### New behaviour
Steps to validate that it works:
1. Set a role on a committee membership
2. Showing on the detail...#### Previous behaviour
Steps to reproduce:
1. Set a role on a committee membership
2. Not showing on the detail page
#### New behaviour
Steps to validate that it works:
1. Set a role on a committee membership
2. Showing on the detail pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/796Allow the album cover to return None when the album has no images2018-05-16T20:02:15+02:00Sébastiaan VersteegAllow the album cover to return None when the album has no images#### Previous behaviour
Steps to reproduce:
1. Add an album without photos
2. Open the photos API
#### New behaviour
Steps to validate that it works:
1. Add an album without photos
2. Open the photos API#### Previous behaviour
Steps to reproduce:
1. Add an album without photos
2. Open the photos API
#### New behaviour
Steps to validate that it works:
1. Add an album without photos
2. Open the photos API1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/792Allow event cancellations when member has a fine2018-05-16T19:02:36+02:00Tom van BusselAllow event cancellations when member has a fineCloses #627
#### Previous behaviour
Steps to reproduce:
1. Register for an event
2. Get a fine
3. Can no longer cancel the registration created in step 1.
#### New behaviour
Steps to validate that it works:
1. Register for an event
2...Closes #627
#### Previous behaviour
Steps to reproduce:
1. Register for an event
2. Get a fine
3. Can no longer cancel the registration created in step 1.
#### New behaviour
Steps to validate that it works:
1. Register for an event
2. Get a fine
3. Can still longer cancel the registration created in step 1.1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/791Added   for pizza price2018-05-16T19:02:36+02:00Stan DerksenAdded for pizza price- Added non-breaking space between the €-sign and price to prevent it from breaking to a newline- Added non-breaking space between the €-sign and price to prevent it from breaking to a newline1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/786Fix typo on renewal page2018-05-16T19:02:33+02:00Sébastiaan VersteegFix typo on renewal pageCloses #623Closes #6231.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/785Fix membership renewal page when user has no previous memberships2018-05-16T19:02:35+02:00Sébastiaan VersteegFix membership renewal page when user has no previous membershipsCloses #622
#### Previous behaviour
Steps to reproduce:
1. Create a user without memberships
2. Go to the renewal page
#### New behaviour
Steps to validate that it works:
1. Create a user without memberships
2. Go to the ...Closes #622
#### Previous behaviour
Steps to reproduce:
1. Create a user without memberships
2. Go to the renewal page
#### New behaviour
Steps to validate that it works:
1. Create a user without memberships
2. Go to the renewal page1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/784Only show cohort when cohort is not None2018-04-05T14:07:29+02:00Joren VranckenOnly show cohort when cohort is not NoneCloses #552Closes #5521.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/783Fix link to minutes in meetingyear.html2018-04-05T14:20:03+02:00Sébastiaan VersteegFix link to minutes in meetingyear.htmlCloses #620
#### Previous behaviour
Steps to reproduce:
1. Try to open the minutes of a GM
#### New behaviour
Steps to validate that it works:
1. Try to open the minutes of a GMCloses #620
#### Previous behaviour
Steps to reproduce:
1. Try to open the minutes of a GM
#### New behaviour
Steps to validate that it works:
1. Try to open the minutes of a GM1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/782Translate 'Notulen' in meetingyear.html2018-03-29T15:09:31+02:00Joren VranckenTranslate 'Notulen' in meetingyear.htmlCloses #619Closes #6191.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/770Resolve "Creating an event without specifying time crashes the request"2018-03-28T19:45:32+02:00Luko van der MaasResolve "Creating an event without specifying time crashes the request"Closes #609
#### Previous behaviour
Steps to reproduce:
1. Create an event with all field filled in except for the time of the start of the event and the end of the event
2. Click save
3. Server crash
#### New behaviour
Ste...Closes #609
#### Previous behaviour
Steps to reproduce:
1. Create an event with all field filled in except for the time of the start of the event and the end of the event
2. Click save
3. Server crash
#### New behaviour
Steps to validate that it works:
1. Create an event with all field filled in except for the time of the start of the event and the end of the event
2. Click save
3. No crash but an error for the user1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/769Fix multiple issues with Pizza Events2018-03-28T19:45:32+02:00Thom WiggersFix multiple issues with Pizza EventsCloses #606
#### Previous behaviour
* Crash when handling multiple pizza events
* Allow creating pizza events with end < start
* Don't allow consecutive pizza events
#### New behaviour
Steps to validate that it works:
* R...Closes #606
#### Previous behaviour
* Crash when handling multiple pizza events
* Allow creating pizza events with end < start
* Don't allow consecutive pizza events
#### New behaviour
Steps to validate that it works:
* Run tests1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/768Set max length for profile description2018-03-28T19:45:45+02:00Thom WiggersSet max length for profile descriptionCloses #615
#### Previous behaviour
Steps to reproduce:
1. Set a too-long profile text
#### New behaviour
Steps to validate that it works:
1. Set a too-long profile textCloses #615
#### Previous behaviour
Steps to reproduce:
1. Set a too-long profile text
#### New behaviour
Steps to validate that it works:
1. Set a too-long profile text1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/765Miscellaneous documents fixes2018-03-20T12:55:59+01:00Tom van BusselMiscellaneous documents fixesCloses #612
Fixes the following:
1. The migrations now hopefully work
2. It's now possible to set `members_only` on minutes
3. It's now possible to make a `GeneralMeeting` without any documents.Closes #612
Fixes the following:
1. The migrations now hopefully work
2. It's now possible to set `members_only` on minutes
3. It's now possible to make a `GeneralMeeting` without any documents.1.14https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/764Add missing `<hr>` to account page2018-03-29T15:12:00+02:00Sébastiaan VersteegAdd missing `<hr>` to account page#### Previous behaviour
Steps to reproduce:
1. Go to account page
![image](/uploads/57eee0684d7f39d96797d0da3f4e0ddc/image.png)
#### New behaviour
Steps to validate that it works:
1. Go to account page
![image](/uploads/...#### Previous behaviour
Steps to reproduce:
1. Go to account page
![image](/uploads/57eee0684d7f39d96797d0da3f4e0ddc/image.png)
#### New behaviour
Steps to validate that it works:
1. Go to account page
![image](/uploads/df1d5a162a1fd372599b4315fb965ceb/image.png)1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/757Fix uploading gifs2018-03-20T17:34:35+01:00Thom WiggersFix uploading gifsCloses #610
#### Previous behaviour
Steps to reproduce:
1. upload GIF avatar or photo
2. OSError exception about the image conversion
#### New behaviour
Steps to validate that it works:
1. upload GIF avatar or photo
2. observe it wo...Closes #610
#### Previous behaviour
Steps to reproduce:
1. upload GIF avatar or photo
2. OSError exception about the image conversion
#### New behaviour
Steps to validate that it works:
1. upload GIF avatar or photo
2. observe it works.1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/755Fix/documents minutes file2018-03-14T15:42:09+01:00Sébastiaan VersteegFix/documents minutes file#### Previous behaviour
Steps to reproduce:
1. Could not open general meeting in admin
#### New behaviour
Steps to validate that it works:
1. Can open GM in admin#### Previous behaviour
Steps to reproduce:
1. Could not open general meeting in admin
#### New behaviour
Steps to validate that it works:
1. Can open GM in admin1.14https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/754Add failsafes, if no receive_category values are set in the API: enable them all2018-03-14T15:43:19+01:00Sébastiaan VersteegAdd failsafes, if no receive_category values are set in the API: enable them all#### Previous behaviour
Steps to reproduce:
1. Register a new device using the API without setting `receive_category`
2. No categories enabled
#### New behaviour
Steps to validate that it works:
1. Register a new device using the API ...#### Previous behaviour
Steps to reproduce:
1. Register a new device using the API without setting `receive_category`
2. No categories enabled
#### New behaviour
Steps to validate that it works:
1. Register a new device using the API without setting `receive_category`
2. All categories enabled1.14