concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-05-31T15:28:43+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/818Fix settings import to the right module2018-05-31T15:28:43+02:00Sébastiaan VersteegFix settings import to the right moduleThis should prevent issues with overridden settings in `production.py` or `localsettings.py`This should prevent issues with overridden settings in `production.py` or `localsettings.py`1.16Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/814Add membership decorator and require an active membership to download exams/s...2018-06-13T19:43:34+02:00Sébastiaan VersteegAdd membership decorator and require an active membership to download exams/summaries#### Previous behaviour
Steps to reproduce:
1. Non-members could download summaries/exams
#### New behaviour
Steps to validate that it works:
1. Only members can download summaries/exams#### Previous behaviour
Steps to reproduce:
1. Non-members could download summaries/exams
#### New behaviour
Steps to validate that it works:
1. Only members can download summaries/exams1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/808Change pizzas product pricing space to nbsp for all products in list.2018-06-13T18:54:48+02:00Sébastiaan VersteegChange pizzas product pricing space to nbsp for all products in list.### Short description
Change pizzas product pricing space to nbsp for all products in list.### Short description
Change pizzas product pricing space to nbsp for all products in list.1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1535Remove non-ascii characters from the almanac translations2020-03-13T16:56:20+01:00Joren VranckenRemove non-ascii characters from the almanac translations#### Previous behaviour
Steps to reproduce:
1. Go to the [almanac page](https://thalia.nu/members/almanac/) in Dutch.
2. Observe that the TypeForm link goes to `https://thalia.nu/members/almanac/%E2%80%9Chttps://typeform.com%E2%80%9D`.
...#### Previous behaviour
Steps to reproduce:
1. Go to the [almanac page](https://thalia.nu/members/almanac/) in Dutch.
2. Observe that the TypeForm link goes to `https://thalia.nu/members/almanac/%E2%80%9Chttps://typeform.com%E2%80%9D`.
#### New behaviour
Steps to validate that it works:
1. Go to the [almanac page](https://thalia.nu/members/almanac/) in Dutch.
2. Observe that the TypeForm link goes to `https://typeform.com`.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1534Fix public events calendarjs API2020-03-13T19:35:44+01:00Sébastiaan VersteegFix public events calendarjs APICloses #1033
#### Previous behaviour
Steps to reproduce:
1. Open the calendarjs API when not logged in using https://thalia.nu/api/v1/events/calendarjs/?start=2019-07-01T00:00:00&end=2020-07-01T00:00:00
2. Crash
#### New behaviour
S...Closes #1033
#### Previous behaviour
Steps to reproduce:
1. Open the calendarjs API when not logged in using https://thalia.nu/api/v1/events/calendarjs/?start=2019-07-01T00:00:00&end=2020-07-01T00:00:00
2. Crash
#### New behaviour
Steps to validate that it works:
1. Open the calendarjs API when not logged in
2. Does not crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1531Fix banner about events permissions2020-03-11T21:29:49+01:00Sébastiaan VersteegFix banner about events permissions#### Previous behaviour
Steps to reproduce:
1. See that while not logged in you always get a banner about event permissions.
#### New behaviour
Steps to validate that it works:
1. See that while not logged in you not always get a bann...#### Previous behaviour
Steps to reproduce:
1. See that while not logged in you always get a banner about event permissions.
#### New behaviour
Steps to validate that it works:
1. See that while not logged in you not always get a banner about event permissions.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1519Fix crash when pizza event admin orders pizza2020-03-04T21:14:03+01:00Gijs HendriksenFix crash when pizza event admin orders pizza#### Previous behaviour
When an organizer of a pizza event orders a pizza, the API crashes.
Steps to reproduce:
1. Create an event for which you are organizer.
2. Create an accompanying pizza event.
3. Order pizza using the API/app.
4...#### Previous behaviour
When an organizer of a pizza event orders a pizza, the API crashes.
Steps to reproduce:
1. Create an event for which you are organizer.
2. Create an accompanying pizza event.
3. Order pizza using the API/app.
4. Crash.
#### New behaviour
Ordering works even if you're organizer.
Steps to validate that it works:
1. Create an event for which you are organizer.
2. Create an accompanying pizza event.
3. Order pizza using the API/app.
4. No crash.Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1518Resolve "ValueError: day is out of range for month"2020-03-11T20:27:25+01:00Marie SimonResolve "ValueError: day is out of range for month"Closes #1025
#### Previous behaviour
Steps to reproduce:
1. On leap years the function to get the mentor year would crash because the 29th of Feb does not exist in most years
#### New behaviour
Steps to validate that it works...Closes #1025
#### Previous behaviour
Steps to reproduce:
1. On leap years the function to get the mentor year would crash because the 29th of Feb does not exist in most years
#### New behaviour
Steps to validate that it works:
1. The if-statement checks for leap year and replaces it with 28th Feb in that caseLuc KnolLuc Knolhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1511Fix recursion error events models2020-03-04T21:54:10+01:00Sébastiaan VersteegFix recursion error events modelsCloses #1015 #1018
#### Previous behaviour
Steps to reproduce:
1. Save a published event after changing it to unpublished
2. Remove a published event
#### New behaviour
Steps to validate that it works:
1. Save a published...Closes #1015 #1018
#### Previous behaviour
Steps to reproduce:
1. Save a published event after changing it to unpublished
2. Remove a published event
#### New behaviour
Steps to validate that it works:
1. Save a published event after changing it to unpublished
2. Remove a published eventJelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1499Changed typo information check email2020-03-11T19:12:00+01:00Marthijn van den NieuwenhuizenChanged typo information check emailCloses #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Send an information check email, notice some weird text missing.
#### New behaviour
Steps to validate that it works:
1. Send an information check email, notice typo is fixe...Closes #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Send an information check email, notice some weird text missing.
#### New behaviour
Steps to validate that it works:
1. Send an information check email, notice typo is fixed and dutch translation is correcthttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1467WIP: Resolve "Event information is public"2020-01-22T20:45:29+01:00Luna-Elise SchernthanerWIP: Resolve "Event information is public"Closes #919Closes #919https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1456WIP: Resolve "Missing colors in statistics committee chart"2020-01-08T22:45:52+01:00Luc KnolWIP: Resolve "Missing colors in statistics committee chart"Closes #982Closes #982https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1440Fix start reminder users slicing2019-12-13T15:41:54+01:00Sébastiaan VersteegFix start reminder users slicingCloses #989
#### Previous behaviour
Steps to reproduce:
1. Create an event with participants
2. Crash on save
#### New behaviour
Steps to validate that it works:
1. Create an event with participants
2. No crash on saveCloses #989
#### Previous behaviour
Steps to reproduce:
1. Create an event with participants
2. Crash on save
#### New behaviour
Steps to validate that it works:
1. Create an event with participants
2. No crash on savehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1437Fix G Suite env variable and profile option2019-12-05T13:24:25+01:00Sébastiaan VersteegFix G Suite env variable and profile option#### Previous behaviour
Steps to reproduce:
1. It syncs `thalia.nu` in mailinglists instead of the members domain because the env variable is wrong
2. The profile option for G Suite is missing
#### New behaviour
Steps to validat...#### Previous behaviour
Steps to reproduce:
1. It syncs `thalia.nu` in mailinglists instead of the members domain because the env variable is wrong
2. The profile option for G Suite is missing
#### New behaviour
Steps to validate that it works:
1. It syncs using the right domain
2. The profile option is availablehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1433Split sent_date migrations for push notifications2019-12-03T10:29:01+01:00Sébastiaan VersteegSplit sent_date migrations for push notifications#### Previous behaviour
Steps to reproduce:
1. Non working migrations on staging
#### New behaviour
Steps to validate that it works:
1. working migrations on staging#### Previous behaviour
Steps to reproduce:
1. Non working migrations on staging
#### New behaviour
Steps to validate that it works:
1. working migrations on staginghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1409Add root logging configuration and improve format2019-11-13T22:00:53+01:00Jelle Besselingjelle@pingiun.comAdd root logging configuration and improve formatPreviously no loggers were enabled that concrexit uses. This means that
all logs by concrexit code were ignored in production. This commit adds
a root logger that will make sure all logs by concrexit and imported
packages are logged t...Previously no loggers were enabled that concrexit uses. This means that
all logs by concrexit code were ignored in production. This commit adds
a root logger that will make sure all logs by concrexit and imported
packages are logged to the log file.
This commit also improves the 'verbose' logging format, which previously
contained unneeded information and less specific information on which
package was doing the logging.
Closes #956 and #957https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1402Fix small issues in the mailinglists app2019-10-30T23:25:52+01:00Sébastiaan VersteegFix small issues in the mailinglists app
#### Previous behaviour
Steps to reproduce:
1. You could not search for mailinglists
2. Moderated was not clear in the overview
2. The mailinglist sync contained duplicate and empty email addresses
4. List names could be longe...
#### Previous behaviour
Steps to reproduce:
1. You could not search for mailinglists
2. Moderated was not clear in the overview
2. The mailinglist sync contained duplicate and empty email addresses
4. List names could be longer than the maximum
5. No dashes in mailinglist names
#### New behaviour
Steps to validate that it works:
1. You can search for mailinglists again
2. Moderated is now in the overview
2. The mailinglist sync filters out empty and duplicate addresses
4. Maximum of length 60 applied to names
5. Allow dashes in mailinglist names
https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1400Send the newsletter to individual members2019-10-30T19:58:04+01:00Sébastiaan VersteegSend the newsletter to individual membersRelated to #947
#### Previous behaviour
Steps to reproduce:
1. Send the newsletter
2. Everyone in the BCC
#### New behaviour
Steps to validate that it works:
1. Send the newsletter
2. Individual emailsRelated to #947
#### Previous behaviour
Steps to reproduce:
1. Send the newsletter
2. Everyone in the BCC
#### New behaviour
Steps to validate that it works:
1. Send the newsletter
2. Individual emailshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1385Fix token-auth path in urls.py2019-10-22T13:46:29+02:00Sébastiaan VersteegFix token-auth path in urls.pyCloses ThaliApp#117
#### Previous behaviour
Steps to reproduce:
1. Try a call to `<url>/api/v1/token-auth/`
2. Does not work
#### New behaviour
Steps to validate that it works:
1. Try a call to `<url>/api/v1/token-auth/`
2. Works fineCloses ThaliApp#117
#### Previous behaviour
Steps to reproduce:
1. Try a call to `<url>/api/v1/token-auth/`
2. Does not work
#### New behaviour
Steps to validate that it works:
1. Try a call to `<url>/api/v1/token-auth/`
2. Works finehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1381Fix removal of Firebase Admin SDK error2019-10-19T09:21:52+02:00Sébastiaan VersteegFix removal of Firebase Admin SDK errorCloses #940
#### Previous behaviour
Steps to reproduce:
1. Send a push message that triggers an error
2. The message is not marked as sent and hard crash
#### New behaviour
Steps to validate that it works:
1. Send a push ...Closes #940
#### Previous behaviour
Steps to reproduce:
1. Send a push message that triggers an error
2. The message is not marked as sent and hard crash
#### New behaviour
Steps to validate that it works:
1. Send a push message that triggers an error
2. The message is marked as sent and everything worksLuko van der MaasLuko van der Maas