concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-10-24T19:16:47+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1374Remove fixed height for footer to correctly display all content on mobile dev...2019-10-24T19:16:47+02:00Job DoesburgRemove fixed height for footer to correctly display all content on mobile devicesCloses #929
#### Previous behaviour
Steps to reproduce:
1. Footer not shown correctly on mobile devices
#### New behaviour
Steps to validate that it works:
1. Footer shown correctlyCloses #929
#### Previous behaviour
Steps to reproduce:
1. Footer not shown correctly on mobile devices
#### New behaviour
Steps to validate that it works:
1. Footer shown correctly29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1375Fixed creating group membership without filling in required field 'member' or...2019-11-13T21:59:18+01:00Marthijn van den NieuwenhuizenFixed creating group membership without filling in required field 'member' or 'group'Closes #910
#### Previous behaviour
Steps to reproduce:
1. Create a group membership without filling in either a name or a group
2. breakage
#### New behaviour
Steps to validate that it works:
1. Create a group membership...Closes #910
#### Previous behaviour
Steps to reproduce:
1. Create a group membership without filling in either a name or a group
2. breakage
#### New behaviour
Steps to validate that it works:
1. Create a group membership without filling in either a name or a group
2. Receive error message29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1376Fix localized overview placeholder thumbnail2019-10-16T18:33:30+02:00Job DoesburgFix localized overview placeholder thumbnail#### Previous behaviour
Steps to reproduce:
1. Check the thumbnails of committees/boards/societies without images
2. They're not working
#### New behaviour
Steps to validate that it works:
1. Check the thumbnails of committee...#### Previous behaviour
Steps to reproduce:
1. Check the thumbnails of committees/boards/societies without images
2. They're not working
#### New behaviour
Steps to validate that it works:
1. Check the thumbnails of committees/boards/societies without images
2. They're working
27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1377Edited some translations2019-10-16T18:31:08+02:00Thijs de JongEdited some translationsSome translations were incorrectSome translations were incorrect27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1381Fix removal of Firebase Admin SDK error2019-10-19T09:21:52+02:00Sébastiaan VersteegFix removal of Firebase Admin SDK errorCloses #940
#### Previous behaviour
Steps to reproduce:
1. Send a push message that triggers an error
2. The message is not marked as sent and hard crash
#### New behaviour
Steps to validate that it works:
1. Send a push ...Closes #940
#### Previous behaviour
Steps to reproduce:
1. Send a push message that triggers an error
2. The message is not marked as sent and hard crash
#### New behaviour
Steps to validate that it works:
1. Send a push message that triggers an error
2. The message is marked as sent and everything worksLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1385Fix token-auth path in urls.py2019-10-22T13:46:29+02:00Sébastiaan VersteegFix token-auth path in urls.pyCloses ThaliApp#117
#### Previous behaviour
Steps to reproduce:
1. Try a call to `<url>/api/v1/token-auth/`
2. Does not work
#### New behaviour
Steps to validate that it works:
1. Try a call to `<url>/api/v1/token-auth/`
2. Works fineCloses ThaliApp#117
#### Previous behaviour
Steps to reproduce:
1. Try a call to `<url>/api/v1/token-auth/`
2. Does not work
#### New behaviour
Steps to validate that it works:
1. Try a call to `<url>/api/v1/token-auth/`
2. Works finehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1388Fix event registration terms URL in event page2019-10-30T20:11:49+01:00Gijs HendriksenFix event registration terms URL in event pageCloses #941
#### Previous behaviour
The link to the terms and conditions of event registrations is broken.
Steps to reproduce:
1. Open an event with open registration.
2. Press the link to the terms and conditions.
3. Notice you are ...Closes #941
#### Previous behaviour
The link to the terms and conditions of event registrations is broken.
Steps to reproduce:
1. Open an event with open registration.
2. Press the link to the terms and conditions.
3. Notice you are directed to the same page.
#### New behaviour
The link to the terms and conditions of event registrations points to the correct page.
Steps to validate that it works:
1. Open an event with open registration.
2. Press the link to the terms and conditions.
3. Notice you are directed to the terms and conditions page.29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1393Fix whoCanViewGroup in GSuite sync2019-10-24T19:17:28+02:00Sébastiaan VersteegFix whoCanViewGroup in GSuite sync28Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1394Use ThreadPoolExecutor instead of unlimited threads for gsuite sync2019-10-24T19:17:28+02:00Sébastiaan VersteegUse ThreadPoolExecutor instead of unlimited threads for gsuite sync28https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1400Send the newsletter to individual members2019-10-30T19:58:04+01:00Sébastiaan VersteegSend the newsletter to individual membersRelated to #947
#### Previous behaviour
Steps to reproduce:
1. Send the newsletter
2. Everyone in the BCC
#### New behaviour
Steps to validate that it works:
1. Send the newsletter
2. Individual emailsRelated to #947
#### Previous behaviour
Steps to reproduce:
1. Send the newsletter
2. Everyone in the BCC
#### New behaviour
Steps to validate that it works:
1. Send the newsletter
2. Individual emailshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1401Remove threading completely from sync_mailinglists2019-10-30T20:48:03+01:00Sébastiaan VersteegRemove threading completely from sync_mailinglists
#### Previous behaviour
Steps to reproduce:
1. malloc errors
#### New behaviour
Steps to validate that it works:
1. no malloc errors
#### Previous behaviour
Steps to reproduce:
1. malloc errors
#### New behaviour
Steps to validate that it works:
1. no malloc errors28https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1402Fix small issues in the mailinglists app2019-10-30T23:25:52+01:00Sébastiaan VersteegFix small issues in the mailinglists app
#### Previous behaviour
Steps to reproduce:
1. You could not search for mailinglists
2. Moderated was not clear in the overview
2. The mailinglist sync contained duplicate and empty email addresses
4. List names could be longe...
#### Previous behaviour
Steps to reproduce:
1. You could not search for mailinglists
2. Moderated was not clear in the overview
2. The mailinglist sync contained duplicate and empty email addresses
4. List names could be longer than the maximum
5. No dashes in mailinglist names
#### New behaviour
Steps to validate that it works:
1. You can search for mailinglists again
2. Moderated is now in the overview
2. The mailinglist sync filters out empty and duplicate addresses
4. Maximum of length 60 applied to names
5. Allow dashes in mailinglist names
https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1403Now really fix mailinglists search2019-11-06T18:42:22+01:00Sébastiaan VersteegNow really fix mailinglists searchCloses #876
#### Previous behaviour
Steps to reproduce:
1. Wrong name in the admin code
#### New behaviour
Steps to validate that it works:
1. Right name in the admin codeCloses #876
#### Previous behaviour
Steps to reproduce:
1. Wrong name in the admin code
#### New behaviour
Steps to validate that it works:
1. Right name in the admin code29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1409Add root logging configuration and improve format2019-11-13T22:00:53+01:00Jelle Besselingjelle@pingiun.comAdd root logging configuration and improve formatPreviously no loggers were enabled that concrexit uses. This means that
all logs by concrexit code were ignored in production. This commit adds
a root logger that will make sure all logs by concrexit and imported
packages are logged t...Previously no loggers were enabled that concrexit uses. This means that
all logs by concrexit code were ignored in production. This commit adds
a root logger that will make sure all logs by concrexit and imported
packages are logged to the log file.
This commit also improves the 'verbose' logging format, which previously
contained unneeded information and less specific information on which
package was doing the logging.
Closes #956 and #957https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1412Fix API authentication returns 400 when providing the wrong credentials2019-12-04T19:31:08+01:00Simcha van CollemFix API authentication returns 400 when providing the wrong credentialsCloses #959
#### Previous behaviour
Steps to reproduce:
1. Authenticate at `/api/v1/token-auth`
2. Get a 400
#### New behaviour
Steps to validate that it works:
1. Authenticate at `/api/v1/token-auth`
2. Get a 401Closes #959
#### Previous behaviour
Steps to reproduce:
1. Authenticate at `/api/v1/token-auth`
2. Get a 400
#### New behaviour
Steps to validate that it works:
1. Authenticate at `/api/v1/token-auth`
2. Get a 40129https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1420Change the euro sign encoding in newsletters2019-11-13T22:00:35+01:00Luna-Elise SchernthanerChange the euro sign encoding in newslettersCloses #960
#### Previous behaviour
Steps to reproduce:
1. Create a newsletter with an event that has a price or cancellation fee.
2. Send this newsletter to members.
3. The euro sign is not displayed correctly in the received ...Closes #960
#### Previous behaviour
Steps to reproduce:
1. Create a newsletter with an event that has a price or cancellation fee.
2. Send this newsletter to members.
3. The euro sign is not displayed correctly in the received newsletter.
#### New behaviour
Steps to validate that it works:
1. Create a newsletter with an event that has a price or cancellation fee.
2. Send this newsletter to members.
3. The euro sign is displayed correctly in the received newsletter. 29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1427Fixed JS-Charts X-Axis in members-statistics2019-11-27T20:32:15+01:00Marthijn van den NieuwenhuizenFixed JS-Charts X-Axis in members-statisticsCloses #950
#### Previous behaviour
Steps to reproduce:
1. open Statistics
2. See missing statistic names on x-axis
#### New behaviour
Steps to validate that it works:
1. op Statistics
2. See no missing statistic names on x-axisCloses #950
#### Previous behaviour
Steps to reproduce:
1. open Statistics
2. See missing statistic names on x-axis
#### New behaviour
Steps to validate that it works:
1. op Statistics
2. See no missing statistic names on x-axis29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1428Events on personal ical feed are now excluded if someone deregistered2019-11-20T21:39:38+01:00Simcha van CollemEvents on personal ical feed are now excluded if someone deregisteredCloses #963
#### Previous behaviour
Steps to reproduce:
1. Deregister from event
2. Download personal iCal feed
3. See the event despite you deregistered
#### New behaviour
Steps to validate that it works:
1. Deregister from event...Closes #963
#### Previous behaviour
Steps to reproduce:
1. Deregister from event
2. Download personal iCal feed
3. See the event despite you deregistered
#### New behaviour
Steps to validate that it works:
1. Deregister from event
2. Download personal iCal feed
3. No event there29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1429Add git strategy none to gitlab-ci2019-12-02T23:17:12+01:00Sébastiaan VersteegAdd git strategy none to gitlab-ci#### Previous behaviour
Steps to reproduce:
1. Review stop not working
#### New behaviour
Steps to validate that it works:
1. Review stop working#### Previous behaviour
Steps to reproduce:
1. Review stop not working
#### New behaviour
Steps to validate that it works:
1. Review stop working29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1433Split sent_date migrations for push notifications2019-12-03T10:29:01+01:00Sébastiaan VersteegSplit sent_date migrations for push notifications#### Previous behaviour
Steps to reproduce:
1. Non working migrations on staging
#### New behaviour
Steps to validate that it works:
1. working migrations on staging#### Previous behaviour
Steps to reproduce:
1. Non working migrations on staging
#### New behaviour
Steps to validate that it works:
1. working migrations on staging