concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-04-12T18:40:46+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1221Fix pizza API code for ordering2019-04-12T18:40:46+02:00Luko van der MaasFix pizza API code for ordering/label ~bug
Fixed for pizza api. Ordering a pizza on the api will work now.
#### Previous behaviour
Steps to reproduce:
1. Order a pizza
2. Crash
#### New behaviour
Steps to validate that it works:
1. Order a pizza
2. .../label ~bug
Fixed for pizza api. Ordering a pizza on the api will work now.
#### Previous behaviour
Steps to reproduce:
1. Order a pizza
2. Crash
#### New behaviour
Steps to validate that it works:
1. Order a pizza
2. Crash
https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1175Fix admin.py headers in payments2019-02-20T21:33:26+01:00Sébastiaan VersteegFix admin.py headers in paymentsFix admin.py headers in paymentsFix admin.py headers in paymentshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1163Fix pizza order where pizza event has no notification, closes #8192019-02-13T20:54:35+01:00Sébastiaan VersteegFix pizza order where pizza event has no notification, closes #819Closes #819
#### Previous behaviour
Steps to reproduce:
1. Create a pizza event without notification
2. Order a product
3. Crash
#### New behaviour
Steps to validate that it works:
1. Create a pizza event without notification
2. Orde...Closes #819
#### Previous behaviour
Steps to reproduce:
1. Create a pizza event without notification
2. Order a product
3. Crash
#### New behaviour
Steps to validate that it works:
1. Create a pizza event without notification
2. Order a product
3. No crashhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1156Do not show cohort 2019 yet on the members overview page2019-02-13T19:06:33+01:00Sébastiaan VersteegDo not show cohort 2019 yet on the members overview pageCloses #824 ISSUE
#### Previous behaviour
Steps to reproduce:
1. Go to the members overview
2. Already shows filter for 2019
#### New behaviour
Steps to validate that it works:
1. Go to the members overview
2. No filter for 2019 yet,...Closes #824 ISSUE
#### Previous behaviour
Steps to reproduce:
1. Go to the members overview
2. Already shows filter for 2019
#### New behaviour
Steps to validate that it works:
1. Go to the members overview
2. No filter for 2019 yet, after 1 september there will behttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1137Set right entity type in conscribo sync2019-01-24T19:28:42+01:00Sébastiaan VersteegSet right entity type in conscribo sync#### Previous behaviour
Steps to reproduce:
1. manage.py conscribosync
#### New behaviour
Steps to validate that it works:
1. manage.py conscribosync#### Previous behaviour
Steps to reproduce:
1. manage.py conscribosync
#### New behaviour
Steps to validate that it works:
1. manage.py conscribosynchttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1125Remove XFrameOptionsMiddleware2019-01-14T11:29:37+01:00Joren VranckenRemove XFrameOptionsMiddlewareThe `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-option...The `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-options: SAMEORIGIN
...
```
#### New behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
```https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1124Fix problems with pizza event notifications2019-01-16T19:29:56+01:00Sébastiaan VersteegFix problems with pizza event notificationsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1123Add language to frontend form for exams/summaries + fixed unknown language st...2019-01-16T17:01:58+01:00Sébastiaan VersteegAdd language to frontend form for exams/summaries + fixed unknown language state in course overviewCloses #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Check a course https://beta.thalia.nu/education/courses/80/
2. Add a new exam/summary
#### New behaviour
Steps to validate that it works:
1. Check a course for language fla...Closes #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Check a course https://beta.thalia.nu/education/courses/80/
2. Add a new exam/summary
#### New behaviour
Steps to validate that it works:
1. Check a course for language flags
2. Add a new exam/summaryLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1118Add sentence about cancel deadline being in the past to member waiting list n...2019-01-05T19:09:56+01:00Sébastiaan VersteegAdd sentence about cancel deadline being in the past to member waiting list notificationCloses #799
#### Previous behaviour
Steps to reproduce:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get email
#### New behaviour
Steps to validate that...Closes #799
#### Previous behaviour
Steps to reproduce:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get email
#### New behaviour
Steps to validate that it works:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get emailhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1095Fix sitemap reference2018-12-13T10:56:03+01:00Sébastiaan VersteegFix sitemap referencehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1050Fix header size too large on smaller screen laptops2018-11-08T15:05:15+01:00Sébastiaan VersteegFix header size too large on smaller screen laptopshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1049Fix the birthdays calendar by refactoring the start/end date query parsing2018-11-08T14:45:26+01:00Sébastiaan VersteegFix the birthdays calendar by refactoring the start/end date query parsingCloses #764
#### Previous behaviour
Steps to reproduce:
1. No birthdays in calendar
#### New behaviour
Steps to validate that it works:
1. Birthdays in calendar workCloses #764
#### Previous behaviour
Steps to reproduce:
1. No birthdays in calendar
#### New behaviour
Steps to validate that it works:
1. Birthdays in calendar workhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1048Fix usage of script tag on statistics page2018-11-08T14:44:54+01:00Sébastiaan VersteegFix usage of script tag on statistics pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1047Fix events frontpage translation2018-11-08T15:09:41+01:00Sébastiaan VersteegFix events frontpage translationhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1046Improve usability of header on mobile devices2018-11-08T15:10:03+01:00Sébastiaan VersteegImprove usability of header on mobile devicesCloses #762
#### Previous behaviour
Steps to reproduce:
1. Use the site on a small mobile device
1. Header sticks to the top
1. Breaking of header buttons to next line
#### New behaviour
Steps to validate that it works:
1. Use the sit...Closes #762
#### Previous behaviour
Steps to reproduce:
1. Use the site on a small mobile device
1. Header sticks to the top
1. Breaking of header buttons to next line
#### New behaviour
Steps to validate that it works:
1. Use the site on a small mobile device
1. Header now doesn't stick to the top, only on desktop
1. Breaking of header buttons to next line is fixedhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1045Remove BCC of every member check email to the secretary of the board2018-11-08T07:51:06+01:00Sébastiaan VersteegRemove BCC of every member check email to the secretary of the board#### Previous behaviour
Steps to reproduce:
1. All information check mails also went to the secretary
#### New behaviour
Steps to validate that it works:
1. Now they don't#### Previous behaviour
Steps to reproduce:
1. All information check mails also went to the secretary
#### New behaviour
Steps to validate that it works:
1. Now they don'thttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1022Do not exit CI job when no obsolete translations have been found2018-10-28T12:20:01+01:00Joren VranckenDo not exit CI job when no obsolete translations have been found#### Previous behaviour
Steps to reproduce:
1. CI `codestyle` job exists when no obsolete translations have been found.
#### New behaviour
Steps to validate that it works:
1. CI `codestyle` job continues when no obsolete tran...#### Previous behaviour
Steps to reproduce:
1. CI `codestyle` job exists when no obsolete translations have been found.
#### New behaviour
Steps to validate that it works:
1. CI `codestyle` job continues when no obsolete translations have been found.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1007Re-add committee admin2018-10-17T21:00:59+02:00Sébastiaan VersteegRe-add committee admin#### Previous behaviour
Steps to reproduce:
1. No committee admin
#### New behaviour
Steps to validate that it works:
1. No committee admin#### Previous behaviour
Steps to reproduce:
1. No committee admin
#### New behaviour
Steps to validate that it works:
1. No committee adminThijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/992Fix wiki login2018-10-12T08:10:19+02:00Sébastiaan VersteegFix wiki loginhttps://sentry.thalia.nu/sentry/concrexit/issues/97/
#### Previous behaviour
Steps to reproduce:
1. Login to wiki
#### New behaviour
Steps to validate that it works:
1. Login to wikihttps://sentry.thalia.nu/sentry/concrexit/issues/97/
#### Previous behaviour
Steps to reproduce:
1. Login to wiki
#### New behaviour
Steps to validate that it works:
1. Login to wikihttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/991Fix committeemembership reference in mailinglists2018-10-11T10:15:56+02:00Sébastiaan VersteegFix committeemembership reference in mailinglists#### Previous behaviour
Steps to reproduce:
1. Open the mailinglist api
#### New behaviour
Steps to validate that it works:
1. Open the mailinglist api#### Previous behaviour
Steps to reproduce:
1. Open the mailinglist api
#### New behaviour
Steps to validate that it works:
1. Open the mailinglist apiThom WiggersThom Wiggers