concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-10-10T20:00:10+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/986Fix map location in event view2018-10-10T20:00:10+02:00Sébastiaan VersteegFix map location in event view#### Previous behaviour
Steps to reproduce:
1. Check the site
#### New behaviour
Steps to validate that it works:
1. Check the site#### Previous behaviour
Steps to reproduce:
1. Check the site
#### New behaviour
Steps to validate that it works:
1. Check the site1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/963Fix member achievements in services.py2018-10-03T19:02:24+02:00Sébastiaan VersteegFix member achievements in services.py#### Previous behaviour
Steps to reproduce:
1. Open a profile with achievements
2. Not working
#### New behaviour
Steps to validate that it works:
1. Open a profile with achievements
2. Works#### Previous behaviour
Steps to reproduce:
1. Open a profile with achievements
2. Not working
#### New behaviour
Steps to validate that it works:
1. Open a profile with achievements
2. Works1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/959Fix Dutch translation in membership notification email incorrect2018-09-26T20:48:17+02:00Thijs de JongFix Dutch translation in membership notification email incorrectCloses #686
#### Previous behaviour
Steps to reproduce:
1. ./manage.py sendmembershipnotification
#### New behaviour
Steps to validate that it works:
1. ./manage.py sendmembershipnotificationCloses #686
#### Previous behaviour
Steps to reproduce:
1. ./manage.py sendmembershipnotification
#### New behaviour
Steps to validate that it works:
1. ./manage.py sendmembershipnotification1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/957Resolve "Location Map at Events broken"2018-10-01T17:02:25+02:00Luko van der MaasResolve "Location Map at Events broken"Closes #708Closes #7081.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/955Fix registrations table sorting of cancel date2018-09-26T20:28:20+02:00Sébastiaan VersteegFix registrations table sorting of cancel dateCloses #709
#### Previous behaviour
Steps to reproduce:
1. Sort registrations on cancel date
2. Incorrect
#### New behaviour
Steps to validate that it works:
1. Sort registrations on cancel date
2. CorrectCloses #709
#### Previous behaviour
Steps to reproduce:
1. Sort registrations on cancel date
2. Incorrect
#### New behaviour
Steps to validate that it works:
1. Sort registrations on cancel date
2. Correct1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/950Two registrations one email address2018-09-26T20:28:22+02:00Sébastiaan VersteegTwo registrations one email addressCloses #691
#### Previous behaviour
Steps to reproduce:
1. Create registration without student number
2. Create registration with student number, same other info
3. Works
#### New behaviour
Steps to validate that it works:
1. Create...Closes #691
#### Previous behaviour
Steps to reproduce:
1. Create registration without student number
2. Create registration with student number, same other info
3. Works
#### New behaviour
Steps to validate that it works:
1. Create registration without student number
2. Create registration with student number, same other info
3. Fails!1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/948Make registrations readonly on completed2018-09-26T20:28:22+02:00Sébastiaan VersteegMake registrations readonly on completedCloses #690
#### Previous behaviour
Steps to reproduce:
1. Complete registration
2. Editable form in backend
#### New behaviour
Steps to validate that it works:
1. Complete registration
2. Non-editable form in backendCloses #690
#### Previous behaviour
Steps to reproduce:
1. Complete registration
2. Editable form in backend
#### New behaviour
Steps to validate that it works:
1. Complete registration
2. Non-editable form in backend1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/946Make url for push messages non-required2018-09-26T20:28:21+02:00Sébastiaan VersteegMake url for push messages non-requiredAs requestedAs requested1.18Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/944Fix tests broken by default language change (#704, !943)2018-09-19T21:15:28+02:00Thom WiggersFix tests broken by default language change (#704, !943)Fixes !943
#### Previous behaviour
Steps to reproduce:
1. Tests fail
#### New behaviour
Steps to validate that it works:
1. Tests workFixes !943
#### Previous behaviour
Steps to reproduce:
1. Tests fail
#### New behaviour
Steps to validate that it works:
1. Tests work1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/940Fix #6992018-09-13T15:16:18+02:00Sébastiaan VersteegFix #699Closes #699Closes #6991.18Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/936Fix save order for payments in registrations2018-09-12T16:23:07+02:00Sébastiaan VersteegFix save order for payments in registrationsPossibly closes #680
#### Previous behaviour
Steps to reproduce:
1. Accept batch of registrations
#### New behaviour
Steps to validate that it works:
1. Accept batch of registrationsPossibly closes #680
#### Previous behaviour
Steps to reproduce:
1. Accept batch of registrations
#### New behaviour
Steps to validate that it works:
1. Accept batch of registrations1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/934Fix comparison in registration model for year and programme2018-10-03T20:15:44+02:00Sébastiaan VersteegFix comparison in registration model for year and programme~bug
Closes #693
#### Previous behaviour
Steps to reproduce:
1. Create a registration for a supporter
2. Do _not_ enter a study programme
3. Save
4. Error
#### New behaviour
Steps to validate that it works:
1. Create ...~bug
Closes #693
#### Previous behaviour
Steps to reproduce:
1. Create a registration for a supporter
2. Do _not_ enter a study programme
3. Save
4. Error
#### New behaviour
Steps to validate that it works:
1. Create a registration for a supporter
2. Do _not_ enter a study programme
3. Save
4. Done!
1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/931Add __str__ methods to the member models2018-09-05T16:32:34+02:00Thom WiggersAdd __str__ methods to the member models#### Previous behaviour
Steps to reproduce:
1. You'd get the default `__str__` to show up in various places, e.g. headers of Membership blocks on the User page in the admin or in the history.
#### New behaviour
Steps to validate that i...#### Previous behaviour
Steps to reproduce:
1. You'd get the default `__str__` to show up in various places, e.g. headers of Membership blocks on the User page in the admin or in the history.
#### New behaviour
Steps to validate that it works:
1. See that it's all pretty now.1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/925Do not create scheduled messages if they would be in the past2018-08-29T21:57:53+02:00Sébastiaan VersteegDo not create scheduled messages if they would be in the pastDo not create scheduled messages if they would be in the pastDo not create scheduled messages if they would be in the past1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/918Fix 'registration' verbose name2018-08-28T16:31:02+02:00Sébastiaan VersteegFix 'registration' verbose name#### Previous behaviour
Steps to reproduce:
1. Wrong text
#### New behaviour
Steps to validate that it works:
1. Good text#### Previous behaviour
Steps to reproduce:
1. Wrong text
#### New behaviour
Steps to validate that it works:
1. Good text1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/916Change payment processing to use POST requests2018-08-28T16:50:35+02:00Sébastiaan VersteegChange payment processing to use POST requestsCloses #678
#### Previous behaviour
Steps to reproduce:
1. Look up unprocessed payment
1. Process payment
1. Uses GET
#### New behaviour
Steps to validate that it works:
1. Look up unprocessed payment
1. Process payment
1. Uses POSTCloses #678
#### Previous behaviour
Steps to reproduce:
1. Look up unprocessed payment
1. Process payment
1. Uses GET
#### New behaviour
Steps to validate that it works:
1. Look up unprocessed payment
1. Process payment
1. Uses POST1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/915Change registrations processing to using POST2018-08-28T16:50:42+02:00Sébastiaan VersteegChange registrations processing to using POST### Short description
Change registrations processing to using POST### Short description
Change registrations processing to using POST1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/911Fix email subject of renewal rejection mail2018-08-28T16:43:05+02:00Sébastiaan VersteegFix email subject of renewal rejection mailCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Reject a renewal
2. Check email subject
#### New behaviour
Steps to validate that it works:
1. Reject a renewal
2. Check email subjectCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Reject a renewal
2. Check email subject
#### New behaviour
Steps to validate that it works:
1. Reject a renewal
2. Check email subject1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/909Fix translation of 'successful'2018-08-28T16:26:30+02:00Joren VranckenFix translation of 'successful'Closes #683
### Short description
"afgekeurd" -> "succesvol"Closes #683
### Short description
"afgekeurd" -> "succesvol"1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/901Make sure docblocks match specs2018-08-28T16:38:10+02:00Sébastiaan VersteegMake sure docblocks match specsCloses #675
#### Previous behaviour
Steps to reproduce:
1. Generate apidocs
2. :param in texts
#### New behaviour
Steps to validate that it works:
1. Generate apidocs
2. Correct formattingCloses #675
#### Previous behaviour
Steps to reproduce:
1. Generate apidocs
2. :param in texts
#### New behaviour
Steps to validate that it works:
1. Generate apidocs
2. Correct formatting1.17