concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-09-08T14:49:39+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1349Remove FontAwesome as .form-control font-family2019-09-08T14:49:39+02:00Sébastiaan VersteegRemove FontAwesome as .form-control font-familyCloses #918
#### Previous behaviour
Steps to reproduce:
1. Rendering of font incorrect (see issue)
#### New behaviour
Steps to validate that it works:
1. Rendering of font fixed (see issue)Closes #918
#### Previous behaviour
Steps to reproduce:
1. Rendering of font incorrect (see issue)
#### New behaviour
Steps to validate that it works:
1. Rendering of font fixed (see issue)27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1348removed check for expiration date of vacancies2019-09-06T16:55:58+02:00Luko van der Maasremoved check for expiration date of vacanciesCloses #917
#### Previous behaviour
Steps to reproduce:
1. open vacancies page
#### New behaviour
Steps to validate that it works:
1. open vacancies pageCloses #917
#### Previous behaviour
Steps to reproduce:
1. open vacancies page
#### New behaviour
Steps to validate that it works:
1. open vacancies pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1346Fix benefactor registrations not receiving email confirmation2019-09-06T16:45:50+02:00Sébastiaan VersteegFix benefactor registrations not receiving email confirmation#### Previous behaviour
Steps to reproduce:
1. Register as benefactor
2. Get no email confirmation message
#### New behaviour
Steps to validate that it works:
1. Register as benefactor
2. Get an email confirmation message#### Previous behaviour
Steps to reproduce:
1. Register as benefactor
2. Get no email confirmation message
#### New behaviour
Steps to validate that it works:
1. Register as benefactor
2. Get an email confirmation messagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1345Fix permission in admin views of pizzas2019-09-04T21:05:53+02:00Sébastiaan VersteegFix permission in admin views of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1344Fix thumbnailer collision2019-09-04T19:30:08+02:00Thom WiggersFix thumbnailer collisionWe now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous beh...We now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous behaviour
Steps to reproduce:
1. Withheld26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1343Don't generate invalid membership dates2019-09-04T19:07:57+02:00Thom WiggersDon't generate invalid membership dates#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
...#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
1. See that no longer happens.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1342Always quote nicknames.2019-09-04T13:18:24+02:00Thom WiggersAlways quote nicknames.Always quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nicknameAlways quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nickname26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1339Correct translations of 'wire payment'2019-09-03T12:29:47+02:00Sébastiaan VersteegCorrect translations of 'wire payment'#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer pa...#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer payments is now 'Overboeking'26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1337Photos show rotated2019-09-04T19:19:28+02:00Luko van der MaasPhotos show rotatedCloses #904
View photo with rotation, these will now be rotated correctlyCloses #904
View photo with rotation, these will now be rotated correctly26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1336Push notifications don't show content only title twice2019-08-31T12:57:12+02:00Luko van der MaasPush notifications don't show content only title twiceMessage sent from event now has correct body instead of the title
Closes #906Message sent from event now has correct body instead of the title
Closes #90626https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1334Prevent unpublished events from ending up in the newsletter2019-08-28T19:20:57+02:00Sébastiaan VersteegPrevent unpublished events from ending up in the newsletterCloses #905
#### Previous behaviour
Steps to reproduce:
When you create a newsletter and there are unpublished events in the next two weeks they are included in the newsletter.
#### New behaviour
Steps to validate that it works:
Unp...Closes #905
#### Previous behaviour
Steps to reproduce:
When you create a newsletter and there are unpublished events in the next two weeks they are included in the newsletter.
#### New behaviour
Steps to validate that it works:
Unpublished events are not be included.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1331Adjust CSS for accordion elements2019-08-28T19:58:43+02:00Sébastiaan VersteegAdjust CSS for accordion elementsAdds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/...Adds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/uploads/fdca28be337dd606ffd036fe85b75b59/Screenshot_2019-08-16_at_12.32.16.png)26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1330Block benefactors or non-members in the next lecture year from giving references2019-08-31T13:02:26+02:00Sébastiaan VersteegBlock benefactors or non-members in the next lecture year from giving referencesCloses #901 #902 #903
#### Previous behaviour
Steps to reproduce:
1. See the issues
#### New behaviour
Steps to validate that it works:
1. See the issuesCloses #901 #902 #903
#### Previous behaviour
Steps to reproduce:
1. See the issues
#### New behaviour
Steps to validate that it works:
1. See the issues26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1329Add test values for no_references post value2019-08-15T10:27:58+02:00Sébastiaan VersteegAdd test values for no_references post value#### Previous behaviour
Steps to reproduce:
1. Renew as member
2. Get a mail about references
#### New behaviour
Steps to validate that it works:
1. Renew as member
2. Get no mail about references#### Previous behaviour
Steps to reproduce:
1. Renew as member
2. Get a mail about references
#### New behaviour
Steps to validate that it works:
1. Renew as member
2. Get no mail about references25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1328Use the right class to extend SocietyDetailView2019-08-14T20:16:05+02:00Sébastiaan VersteegUse the right class to extend SocietyDetailViewCloses #900
#### Previous behaviour
Steps to reproduce:
1. Go to the societies page
2. They all don't have members
#### New behaviour
Steps to validate that it works:
1. Go to the societies page
2. They have the correct m...Closes #900
#### Previous behaviour
Steps to reproduce:
1. Go to the societies page
2. They all don't have members
#### New behaviour
Steps to validate that it works:
1. Go to the societies page
2. They have the correct members25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1326Fix society filter in member achievements2019-08-14T09:48:21+02:00Sébastiaan VersteegFix society filter in member achievementsCloses #899
#### Previous behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "ACHIEVEMENTS FOR THALIA" and "SOCIETIES".
### Expected behaviour
1. Go...Closes #899
#### Previous behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "ACHIEVEMENTS FOR THALIA" and "SOCIETIES".
### Expected behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "SOCIETIES" only.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1324Clarify costs warning2019-08-13T14:18:33+02:00Sébastiaan VersteegClarify costs warningCloses #880
#### Previous behaviour
Steps to reproduce:
1. Get a costs warning
2. It's not an estimation according to the text
#### New behaviour
Steps to validate that it works:
1. Get a costs warning
2. It's an estimati...Closes #880
#### Previous behaviour
Steps to reproduce:
1. Get a costs warning
2. It's not an estimation according to the text
#### New behaviour
Steps to validate that it works:
1. Get a costs warning
2. It's an estimation according to the text26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1321Fix pizza order permissions2019-08-28T19:10:52+02:00Sébastiaan VersteegFix pizza order permissionsCloses #872
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected be...Closes #872
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected behaviour
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. The orders page is permission denied26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1315Use new PARTNER_NOTIFICATION_ADDRESS instead of old PARTNER_EMAIL2019-08-01T13:43:05+02:00Joren VranckenUse new PARTNER_NOTIFICATION_ADDRESS instead of old PARTNER_EMAIL`PARTNER_EMAIL` was replaced in a393f6e9ec591cd61991fd888729bf3cd0140d78 by `PARTNER_NOTIFICATION_ADDRESS`.
#### Previous behaviour
Steps to reproduce:
[Sentry Issue](https://sentry.io/organizations/thalia/issues/1134801598/?project=147...`PARTNER_EMAIL` was replaced in a393f6e9ec591cd61991fd888729bf3cd0140d78 by `PARTNER_NOTIFICATION_ADDRESS`.
#### Previous behaviour
Steps to reproduce:
[Sentry Issue](https://sentry.io/organizations/thalia/issues/1134801598/?project=1470866)Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1312Fixes in calendar view and exam downloading2019-08-13T13:07:29+02:00Sébastiaan VersteegFixes in calendar view and exam downloadingCloses #898
This is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
Check start time in list view of events, check exam download function and check events api with filter parameters
#### New...Closes #898
This is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
Check start time in list view of events, check exam download function and check events api with filter parameters
#### New behaviour
Steps to validate that it works:
Check start time in list view of events, check exam download function and check events api with filter parameters25