concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-05-31T16:36:50+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/824Never import thaliawebsite.settings directly2018-05-31T16:36:50+02:00Thom WiggersNever import thaliawebsite.settings directly### Short description
You should never import `thaliawebsite.settings` directly, but instead import `django.conf.settings`.
See also !818### Short description
You should never import `thaliawebsite.settings` directly, but instead import `django.conf.settings`.
See also !8181.16Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/826Allow event detail viewing in the API2018-06-05T17:00:46+02:00Gijs HendriksenAllow event detail viewing in the APICloses ThaliApp#62
#### Previous behaviour
When opening a past event in the app, the app indicates the event cannot be loaded.
Steps to reproduce:
1. Open the calendar on the website.
2. Click on an event that has already happened.
3....Closes ThaliApp#62
#### Previous behaviour
When opening a past event in the app, the app indicates the event cannot be loaded.
Steps to reproduce:
1. Open the calendar on the website.
2. Click on an event that has already happened.
3. Let deeplinking take you to the app.
4. Notice that the event cannot be loaded.
#### New behaviour
When opening a past event in the app, the event is loaded in the app.
Steps to validate that it works:
1. Open the calendar on the website.
2. Click on an event that has already happened.
3. Let deeplinking take you to the app.
4. Notice that the event is loaded.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/808Change pizzas product pricing space to nbsp for all products in list.2018-06-13T18:54:48+02:00Sébastiaan VersteegChange pizzas product pricing space to nbsp for all products in list.### Short description
Change pizzas product pricing space to nbsp for all products in list.### Short description
Change pizzas product pricing space to nbsp for all products in list.1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/820Fix thabloids sizing on load2018-06-13T18:59:45+02:00Sébastiaan VersteegFix thabloids sizing on loadCloses #639
#### Previous behaviour
Steps to reproduce:
1. Load the thabloid page
#### New behaviour
Steps to validate that it works:
1. Load the thabloid pageCloses #639
#### Previous behaviour
Steps to reproduce:
1. Load the thabloid page
#### New behaviour
Steps to validate that it works:
1. Load the thabloid page1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/821Fix HTML entities in the event organiser email2018-06-13T19:04:40+02:00Sébastiaan VersteegFix HTML entities in the event organiser emailCloses #625
#### Previous behaviour
Steps to reproduce:
1. Create an event
2. Add registration
3. Enable cancellation emails
4. Cancel registration
#### New behaviour
Steps to validate that it works:
1. Create an event
2. Add regist...Closes #625
#### Previous behaviour
Steps to reproduce:
1. Create an event
2. Add registration
3. Enable cancellation emails
4. Cancel registration
#### New behaviour
Steps to validate that it works:
1. Create an event
2. Add registration
3. Enable cancellation emails
4. Cancel registration1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/814Add membership decorator and require an active membership to download exams/s...2018-06-13T19:43:34+02:00Sébastiaan VersteegAdd membership decorator and require an active membership to download exams/summaries#### Previous behaviour
Steps to reproduce:
1. Non-members could download summaries/exams
#### New behaviour
Steps to validate that it works:
1. Only members can download summaries/exams#### Previous behaviour
Steps to reproduce:
1. Non-members could download summaries/exams
#### New behaviour
Steps to validate that it works:
1. Only members can download summaries/exams1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/832Fix push notification registration request2018-06-13T19:56:37+02:00Sébastiaan VersteegFix push notification registration requestCloses https://gitlab.science.ru.nl/thalia/ThaliApp/issues/63
#### Previous behaviour
Steps to reproduce:
1. Login using the app
2. Notice no new devices
#### New behaviour
Steps to validate that it works:
1. Login using the app
2. N...Closes https://gitlab.science.ru.nl/thalia/ThaliApp/issues/63
#### Previous behaviour
Steps to reproduce:
1. Login using the app
2. Notice no new devices
#### New behaviour
Steps to validate that it works:
1. Login using the app
2. Notice no new devices1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/837Disallow cancellation after event start2018-06-13T22:00:47+02:00Sébastiaan VersteegDisallow cancellation after event start#### Previous behaviour
Steps to reproduce:
1. Register for event
2. Forward to time after start of event
3. Can still cancel 'after deadline'
#### New behaviour
Steps to validate that it works:
1. Register for event
2. Forward to ti...#### Previous behaviour
Steps to reproduce:
1. Register for event
2. Forward to time after start of event
3. Can still cancel 'after deadline'
#### New behaviour
Steps to validate that it works:
1. Register for event
2. Forward to time after start of event
3. Cannot cancel anymore1.16https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/839Fix LectureYearFilter if no documents yet2018-06-13T22:26:45+02:00Sébastiaan VersteegFix LectureYearFilter if no documents yetFix LectureYearFilter if no documents yet
#### Previous behaviour
Steps to reproduce:
1. Go to documents without any documents in the database
#### New behaviour
Steps to validate that it works:
1. Go to documents without any documen...Fix LectureYearFilter if no documents yet
#### Previous behaviour
Steps to reproduce:
1. Go to documents without any documents in the database
#### New behaviour
Steps to validate that it works:
1. Go to documents without any documents in the databasehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/841Allow accessing documents from admin pages2018-07-04T19:24:27+02:00Thom WiggersAllow accessing documents from admin pagesCloses #642
#### Previous behaviour
Steps to reproduce:
1. Upload some type of document
2. Click the shown link to the document
3. 404 as MEDIA_URL isn't served
#### New behaviour
Steps to validate that it works:
1. Do sa...Closes #642
#### Previous behaviour
Steps to reproduce:
1. Upload some type of document
2. Click the shown link to the document
3. 404 as MEDIA_URL isn't served
#### New behaviour
Steps to validate that it works:
1. Do same
2. Observe that the link is going to the `get_document` handler
3. Also observe that you're getting the correctly localised version.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/845Fix conditions for showing presence and payment on the event page2018-07-05T10:39:35+02:00Tom van BusselFix conditions for showing presence and payment on the event pageCloses no issue (issue reported in the Thalia Whatsapp)
#### Previous behaviour
Steps to reproduce:
1. Create an event which requires registration.
2. Register and unregister for the event.
3. It still shows the payment status a...Closes no issue (issue reported in the Thalia Whatsapp)
#### Previous behaviour
Steps to reproduce:
1. Create an event which requires registration.
2. Register and unregister for the event.
3. It still shows the payment status and presence.
#### New behaviour
Steps to validate that it works:
1. Create an event which requires registration.
2. Register and unregister for the event.
3. It no longer shows the payment status and presence.1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/842Fix 'to' email address in email change confirmation email2018-07-06T15:22:05+02:00Sébastiaan VersteegFix 'to' email address in email change confirmation email#### Previous behaviour
Steps to reproduce:
1. Change your email address
2. Both emails (confirm and verify) end up in the same inbox
#### New behaviour
Steps to validate that it works:
1. Change your email address
2. The emails (conf...#### Previous behaviour
Steps to reproduce:
1. Change your email address
2. Both emails (confirm and verify) end up in the same inbox
#### New behaviour
Steps to validate that it works:
1. Change your email address
2. The emails (confirm and verify) end up in the right (different) inboxes1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/846Enable the add permission for scheduled messages2018-07-09T09:38:10+02:00Sébastiaan VersteegEnable the add permission for scheduled messagesThis should not have been disabled.This should not have been disabled.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/847Do not schedule or delete messages for unpublished events2018-07-09T09:39:41+02:00Sébastiaan VersteegDo not schedule or delete messages for unpublished eventsCloses #655 and #656
#### Previous behaviour
Steps to reproduce:
1. Create event (unpublished)
2. See that the message is scheduled
--
1. Create event
2. Let it send
3. Change event
4. Notice that the message is still t...Closes #655 and #656
#### Previous behaviour
Steps to reproduce:
1. Create event (unpublished)
2. See that the message is scheduled
--
1. Create event
2. Let it send
3. Change event
4. Notice that the message is still there, marked as sent
#### New behaviour
Steps to validate that it works:
1. Create event (unpublished)
2. No scheduled messages
--
1. Create event
2. Let it send
3. Change event
4. Notice that the message is still there, but a new one was added as well1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/856Fix member expiration emails2018-07-11T19:18:02+02:00Sébastiaan VersteegFix member expiration emails#### Previous behaviour
Steps to reproduce:
1. Check the contents of the emails
2. Incorrect information
#### New behaviour
Steps to validate that it works:
1. Check the contents of the emails
2. Correct information#### Previous behaviour
Steps to reproduce:
1. Check the contents of the emails
2. Incorrect information
#### New behaviour
Steps to validate that it works:
1. Check the contents of the emails
2. Correct information1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/854Fix sorting of registration dates in event admin2018-07-11T19:18:33+02:00Sébastiaan VersteegFix sorting of registration dates in event adminCloses #653
#### Previous behaviour
Steps to reproduce:
1. Go to an event
2. Check the registrations
3. It's in lexicographical order
#### New behaviour
Steps to validate that it works:
1. Go to an event
2. Check the registrations
3....Closes #653
#### Previous behaviour
Steps to reproduce:
1. Go to an event
2. Check the registrations
3. It's in lexicographical order
#### New behaviour
Steps to validate that it works:
1. Go to an event
2. Check the registrations
3. It's in chronological order1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/862Fix typo in push notification devices viewset2018-07-11T21:24:15+02:00Gijs HendriksenFix typo in push notification devices viewset#### Previous behaviour
Website crashes when updating push notifications categories.
Steps to reproduce:
1. Send a POST request containing `receive_category` to `https://thalia.nu/api/v1/devices/`.
2. Receive 500 error.
#### ...#### Previous behaviour
Website crashes when updating push notifications categories.
Steps to reproduce:
1. Send a POST request containing `receive_category` to `https://thalia.nu/api/v1/devices/`.
2. Receive 500 error.
#### New behaviour
Website saves new preferences for push notifications categories.
Steps to validate that it works:
1. Send a POST request containing `receive_category` to `https://thalia.nu/api/v1/devices/`.
2. Don't receive 500 error.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/858Fix registration options to not be required2018-07-11T23:35:23+02:00Sébastiaan VersteegFix registration options to not be required1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/864Fix registration problems2018-07-25T14:25:07+02:00Sébastiaan VersteegFix registration problemsThis MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behavi...This MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Payment added to registration after accepting
### Fields not shown in admin
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Missing fields in the admin
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Missing fields in the admin1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/878Update to Django >=2.0.82018-08-02T14:20:59+02:00Thom WiggersUpdate to Django >=2.0.8New Django Security release.
> CVE-2018-14574: Open redirect possibility in CommonMiddleware
>If the django.middleware.common.CommonMiddleware and the APPEND_SLASH setting are both enabled, and if the project has a URL pattern that acc...New Django Security release.
> CVE-2018-14574: Open redirect possibility in CommonMiddleware
>If the django.middleware.common.CommonMiddleware and the APPEND_SLASH setting are both enabled, and if the project has a URL pattern that accepts any path ending in a slash (many content management systems have such a pattern), then a request to a maliciously crafted URL of that site could lead to a redirect to another site, enabling phishing and other attacks.
> Thanks Andreas Hug for reporting this issue.
We're likely affected by this issue.
https://www.djangoproject.com/weblog/2018/aug/01/security-releases/