concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-10-05T16:49:24+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1363Prevent thumbnailing crashes when original is missing2019-10-05T16:49:24+02:00Sébastiaan VersteegPrevent thumbnailing crashes when original is missingCloses #912
#### Previous behaviour
Steps to reproduce:
1. Remove an original image
2. Reload the page where the image should show
3. Crash
#### New behaviour
Steps to validate that it works:
1. Remove an original image
2. Reload the...Closes #912
#### Previous behaviour
Steps to reproduce:
1. Remove an original image
2. Reload the page where the image should show
3. Crash
#### New behaviour
Steps to validate that it works:
1. Remove an original image
2. Reload the page where the image should show
3. No crash27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1360Cannot fill in field for guest registration2019-12-02T22:39:00+01:00Luko van der MaasCannot fill in field for guest registration~bug
Closes #925
#### Previous behaviour
Steps to reproduce:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. nothings happens
#### New behaviour
Steps to valid...~bug
Closes #925
#### Previous behaviour
Steps to reproduce:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. nothings happens
#### New behaviour
Steps to validate that it works:
1. create an event with registration fields
2. add a registration with a name
3. try to change the field
4. it is changed
29https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1358Change behaviour of starting year field in registrations2019-10-08T13:54:44+02:00Sébastiaan VersteegChange behaviour of starting year field in registrations#### Previous behaviour
Steps to reproduce:
1. Start a new member registration
2. The field currently contains the next lecture year
3. People make mistakes and select that one instead of the current lecture year
#### New behavi...#### Previous behaviour
Steps to reproduce:
1. Start a new member registration
2. The field currently contains the next lecture year
3. People make mistakes and select that one instead of the current lecture year
#### New behaviour
Steps to validate that it works:
1. Start a new member registration
2. The field currently contains the next lecture year
3. People make mistakes and select that one instead of the current lecture year27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1353Allow empty values in event registrations API2019-09-15T22:01:43+02:00Gijs HendriksenAllow empty values in event registrations API#### Previous behaviour
The registration API does not allow empty values for text/integer fields that are not required.
Steps to reproduce:
1. Create an event with a registration field that is not required.
2. Register for the event.
3...#### Previous behaviour
The registration API does not allow empty values for text/integer fields that are not required.
Steps to reproduce:
1. Create an event with a registration field that is not required.
2. Register for the event.
3. Use the API to update your event, and leave the registration field empty.
4. The API does not allow it.
#### New behaviour
Steps to validate that it works:
1. Create an event with a registration field that is not required.
2. Register for the event.
3. Use the API to update your event, and leave the registration field empty.
4. The API allows it and your registration is successfully saved.27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1351Add example to student number field2019-10-02T19:11:45+02:00Sébastiaan VersteegAdd example to student number fieldCloses #908
#### Previous behaviour
Steps to reproduce:
1. Register as member
2. Unclear what the value for student number should be
#### New behaviour
Steps to validate that it works:
1. Register as member
2. The exampl...Closes #908
#### Previous behaviour
Steps to reproduce:
1. Register as member
2. Unclear what the value for student number should be
#### New behaviour
Steps to validate that it works:
1. Register as member
2. The example shows you exactly what to do
![Screenshot_2019-09-08_at_11.03.06](/uploads/06e504061222f65f1a32c89e2c73fc90/Screenshot_2019-09-08_at_11.03.06.png)
(this screenshot is missing the full stop at the end but I'm too lazy to make a new one)27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1349Remove FontAwesome as .form-control font-family2019-09-08T14:49:39+02:00Sébastiaan VersteegRemove FontAwesome as .form-control font-familyCloses #918
#### Previous behaviour
Steps to reproduce:
1. Rendering of font incorrect (see issue)
#### New behaviour
Steps to validate that it works:
1. Rendering of font fixed (see issue)Closes #918
#### Previous behaviour
Steps to reproduce:
1. Rendering of font incorrect (see issue)
#### New behaviour
Steps to validate that it works:
1. Rendering of font fixed (see issue)27https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1348removed check for expiration date of vacancies2019-09-06T16:55:58+02:00Luko van der Maasremoved check for expiration date of vacanciesCloses #917
#### Previous behaviour
Steps to reproduce:
1. open vacancies page
#### New behaviour
Steps to validate that it works:
1. open vacancies pageCloses #917
#### Previous behaviour
Steps to reproduce:
1. open vacancies page
#### New behaviour
Steps to validate that it works:
1. open vacancies pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1347Fix vacancy page error 5002019-09-06T16:46:35+02:00Sébastiaan VersteegFix vacancy page error 500Closes #917
#### Previous behaviour
Steps to reproduce:
1. Broken
#### New behaviour
Steps to validate that it works:
1. FixedCloses #917
#### Previous behaviour
Steps to reproduce:
1. Broken
#### New behaviour
Steps to validate that it works:
1. Fixedhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1346Fix benefactor registrations not receiving email confirmation2019-09-06T16:45:50+02:00Sébastiaan VersteegFix benefactor registrations not receiving email confirmation#### Previous behaviour
Steps to reproduce:
1. Register as benefactor
2. Get no email confirmation message
#### New behaviour
Steps to validate that it works:
1. Register as benefactor
2. Get an email confirmation message#### Previous behaviour
Steps to reproduce:
1. Register as benefactor
2. Get no email confirmation message
#### New behaviour
Steps to validate that it works:
1. Register as benefactor
2. Get an email confirmation messagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1345Fix permission in admin views of pizzas2019-09-04T21:05:53+02:00Sébastiaan VersteegFix permission in admin views of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1344Fix thumbnailer collision2019-09-04T19:30:08+02:00Thom WiggersFix thumbnailer collisionWe now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous beh...We now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous behaviour
Steps to reproduce:
1. Withheld26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1343Don't generate invalid membership dates2019-09-04T19:07:57+02:00Thom WiggersDon't generate invalid membership dates#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
...#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
1. See that no longer happens.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1342Always quote nicknames.2019-09-04T13:18:24+02:00Thom WiggersAlways quote nicknames.Always quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nicknameAlways quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nickname26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1341WIP: Always save profile image to save filename for user2019-09-04T13:06:05+02:00Sébastiaan VersteegWIP: Always save profile image to save filename for userCloses #ISSUE
#### Previous behaviour
![image](/uploads/8e529cec079cee79369798ef4dc45dd4/image.png)
Steps to reproduce:
1.
#### New behaviour
Steps to validate that it works:
1.Closes #ISSUE
#### Previous behaviour
![image](/uploads/8e529cec079cee79369798ef4dc45dd4/image.png)
Steps to reproduce:
1.
#### New behaviour
Steps to validate that it works:
1.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1340Fix translation for Card payment2019-09-03T12:14:29+02:00Jelle Besselingjelle@pingiun.comFix translation for Card payment#### Previous behaviour
Steps to reproduce:
1. The Dutch translations for wire transfer and card payment are the same
#### New behaviour
Steps to validate that it works:
1. The Dutch translation is correct#### Previous behaviour
Steps to reproduce:
1. The Dutch translations for wire transfer and card payment are the same
#### New behaviour
Steps to validate that it works:
1. The Dutch translation is correctSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1339Correct translations of 'wire payment'2019-09-03T12:29:47+02:00Sébastiaan VersteegCorrect translations of 'wire payment'#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer pa...#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer payments is now 'Overboeking'26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1337Photos show rotated2019-09-04T19:19:28+02:00Luko van der MaasPhotos show rotatedCloses #904
View photo with rotation, these will now be rotated correctlyCloses #904
View photo with rotation, these will now be rotated correctly26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1336Push notifications don't show content only title twice2019-08-31T12:57:12+02:00Luko van der MaasPush notifications don't show content only title twiceMessage sent from event now has correct body instead of the title
Closes #906Message sent from event now has correct body instead of the title
Closes #90626https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1334Prevent unpublished events from ending up in the newsletter2019-08-28T19:20:57+02:00Sébastiaan VersteegPrevent unpublished events from ending up in the newsletterCloses #905
#### Previous behaviour
Steps to reproduce:
When you create a newsletter and there are unpublished events in the next two weeks they are included in the newsletter.
#### New behaviour
Steps to validate that it works:
Unp...Closes #905
#### Previous behaviour
Steps to reproduce:
When you create a newsletter and there are unpublished events in the next two weeks they are included in the newsletter.
#### New behaviour
Steps to validate that it works:
Unpublished events are not be included.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1331Adjust CSS for accordion elements2019-08-28T19:58:43+02:00Sébastiaan VersteegAdjust CSS for accordion elementsAdds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/...Adds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/uploads/fdca28be337dd606ffd036fe85b75b59/Screenshot_2019-08-16_at_12.32.16.png)26