concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-08-31T12:53:44+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1311Closes #887, photo url notification is no longer relative2019-08-31T12:53:44+02:00Sébastiaan VersteegCloses #887, photo url notification is no longer relativeCloses #887
#### Previous behaviour
Steps to reproduce:
1. Photo url does not contain the domain name
#### New behaviour
Steps to validate that it works:
1. Photo url contains the domain nameCloses #887
#### Previous behaviour
Steps to reproduce:
1. Photo url does not contain the domain name
#### New behaviour
Steps to validate that it works:
1. Photo url contains the domain name26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1310Fix start/end date parsing in events API2019-08-13T11:43:26+02:00Sébastiaan VersteegFix start/end date parsing in events APIThis is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Visit `/api/v1/events/`
2. Crash
#### New behaviour
Steps to validate that it works:
1. Visit `/api/v1/events/`
2. No crashThis is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Visit `/api/v1/events/`
2. Crash
#### New behaviour
Steps to validate that it works:
1. Visit `/api/v1/events/`
2. No crash25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1309Fix calendar list upcoming items2019-08-13T11:42:16+02:00Sébastiaan VersteegFix calendar list upcoming itemsThis is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Shows all events in the calendar list
#### New behaviour
Steps to validate that it works:
1. Shows only upcoming events in the cale...This is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Shows all events in the calendar list
#### New behaviour
Steps to validate that it works:
1. Shows only upcoming events in the calendar list25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1305Fix url resolving2019-07-13T12:05:56+02:00Sébastiaan VersteegFix url resolving#### Previous behaviour
Steps to reproduce:
1. Try to open the statistics page
2. See member list
#### New behaviour
Steps to validate that it works:
1. Try to open the statistics page
2. Statistics page#### Previous behaviour
Steps to reproduce:
1. Try to open the statistics page
2. See member list
#### New behaviour
Steps to validate that it works:
1. Try to open the statistics page
2. Statistics page25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1301Fix in notification type description2019-06-27T13:47:35+02:00Jelle Besselingjelle@pingiun.comFix in notification type descriptionCloses #894Closes #89425https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1299Fix issue where list event close on scroll2019-06-26T20:14:06+02:00Sébastiaan VersteegFix issue where list event close on scrollCloses #863
#### Previous behaviour
Steps to reproduce:
1. Open an event on a mobile (Chrome + Android!?) device while having a scroll position to the top
2. Scroll
3. The event collapses
#### New behaviour
Steps to validate that it ...Closes #863
#### Previous behaviour
Steps to reproduce:
1. Open an event on a mobile (Chrome + Android!?) device while having a scroll position to the top
2. Scroll
3. The event collapses
#### New behaviour
Steps to validate that it works:
1. Open an event on a mobile (Chrome + Android!?) device while having a scroll position to the top
2. Scroll
3. The event does not automatically collapse25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1297Set minute inline extra to 02019-06-26T20:13:17+02:00Sébastiaan VersteegSet minute inline extra to 0Closes #883
#### Previous behaviour
Steps to reproduce:
1. Create a new GM in the admin
2. Note that you think the Minutes are required
#### New behaviour
Steps to validate that it works:
1. Create a new GM in the admin
2. You need t...Closes #883
#### Previous behaviour
Steps to reproduce:
1. Create a new GM in the admin
2. Note that you think the Minutes are required
#### New behaviour
Steps to validate that it works:
1. Create a new GM in the admin
2. You need to add the minutes explicitly25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1289Changed HR to Rules and Regulations2019-07-11T21:33:12+02:00Thijs de JongChanged HR to Rules and RegulationsCloses #891
#### Previous behaviour
HR was shown in the Docs.
#### New behaviour
HR is replaced with Rules and RegulationsCloses #891
#### Previous behaviour
HR was shown in the Docs.
#### New behaviour
HR is replaced with Rules and Regulations25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1285Add education sitemap2019-06-06T15:29:33+02:00Thom WiggersAdd education sitemapeducation sitemap was not included in the sitemaps (the coverage of that file was 0%).
Also adding merchandise items fixture to the sitemap because that should help test if it generates things correctly.
#### Previous behaviour
St...education sitemap was not included in the sitemaps (the coverage of that file was 0%).
Also adding merchandise items fixture to the sitemap because that should help test if it generates things correctly.
#### Previous behaviour
Steps to reproduce:
1. curl https://thalia.nu/sitemap.xml | grep education
#### New behaviour
Steps to validate that it works:
1. curl https://thalia.nu/sitemap.xml | grep education25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1282Fix add send date to admin and fix cronjob2019-06-05T19:07:22+02:00Sébastiaan VersteegFix add send date to admin and fix cronjob#### Previous behaviour
Steps to reproduce:
1. No input
#### New behaviour
Steps to validate that it works:
1. There is input#### Previous behaviour
Steps to reproduce:
1. No input
#### New behaviour
Steps to validate that it works:
1. There is input24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1278Fix pizza api serializers and viewsets2019-06-05T19:07:16+02:00Sébastiaan VersteegFix pizza api serializers and viewsets
#### Previous behaviour
Steps to reproduce:
1. Use the app
2. Cannot order etc
#### New behaviour
Steps to validate that it works:
1. Use the app
2. All works
#### Previous behaviour
Steps to reproduce:
1. Use the app
2. Cannot order etc
#### New behaviour
Steps to validate that it works:
1. Use the app
2. All works24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1276Fix filter of events cards2019-05-30T12:25:52+02:00Sébastiaan VersteegFix filter of events cards#### Previous behaviour
Steps to reproduce:
1. Create an event in the future
2. Not shown
#### New behaviour
Steps to validate that it works:
1. Same
2. Shown#### Previous behaviour
Steps to reproduce:
1. Create an event in the future
2. Not shown
#### New behaviour
Steps to validate that it works:
1. Same
2. Shown24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1275Give event notification default url of event2019-05-30T12:26:00+02:00Sébastiaan VersteegGive event notification default url of event/label ~bug
Give event notification default url of event. Currently such a notification just opens the app.
#### Previous behaviour
Steps to reproduce:
1. Send event notification
#### New behaviour
Steps to validate that it.../label ~bug
Give event notification default url of event. Currently such a notification just opens the app.
#### Previous behaviour
Steps to reproduce:
1. Send event notification
#### New behaviour
Steps to validate that it works:
1. Send event notification
24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1274Fix capitalisation of birthday field in registration form2019-05-30T12:26:05+02:00Sébastiaan VersteegFix capitalisation of birthday field in registration form
#### Previous behaviour
Steps to reproduce:
1. Non cap first
#### New behaviour
Steps to validate that it works:
1. Cap first label
#### Previous behaviour
Steps to reproduce:
1. Non cap first
#### New behaviour
Steps to validate that it works:
1. Cap first label24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1271Fix event push notifications form redirect and field labels2019-05-28T12:31:48+02:00Sébastiaan VersteegFix event push notifications form redirect and field labelsCloses https://sentry.thalia.nu/sentry/concrexit-beta/issues/541/
#### Previous behaviour
Steps to reproduce:
1. Create an event push notification
2. Send (url is required + crash on redirect)
#### New behaviour
Steps to validate that...Closes https://sentry.thalia.nu/sentry/concrexit-beta/issues/541/
#### Previous behaviour
Steps to reproduce:
1. Create an event push notification
2. Send (url is required + crash on redirect)
#### New behaviour
Steps to validate that it works:
1. Create an event push notification
2. Send (url not required, no crash)24Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1266Fix planned newsletters command2019-05-26T17:55:28+02:00Sébastiaan VersteegFix planned newsletters command#### Previous behaviour
Steps to reproduce:
1. Cannot execute
#### New behaviour
Steps to validate that it works:
1. Can execute#### Previous behaviour
Steps to reproduce:
1. Cannot execute
#### New behaviour
Steps to validate that it works:
1. Can execute24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1265Fix thumbnailing of images to same size as source2019-05-23T13:26:20+02:00Sébastiaan VersteegFix thumbnailing of images to same size as sourceCloses #873
#### Previous behaviour
Steps to reproduce:
1. Upload a 2000x430 image as slider
2. Cannot create thumbnail
#### New behaviour
Steps to validate that it works:
1. Upload a 2000x430 image as slider
2. WorksCloses #873
#### Previous behaviour
Steps to reproduce:
1. Upload a 2000x430 image as slider
2. Cannot create thumbnail
#### New behaviour
Steps to validate that it works:
1. Upload a 2000x430 image as slider
2. Works25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1261Fix thabloids out-of-item rendering2019-05-22T19:40:51+02:00Sébastiaan VersteegFix thabloids out-of-item rendering#### Previous behaviour
Steps to reproduce:
1. Go to the thabloids page
2. The items are not positioned correctly
#### New behaviour
Steps to validate that it works:
1. Go to the thabloids page
2. The items are positioned co...#### Previous behaviour
Steps to reproduce:
1. Go to the thabloids page
2. The items are not positioned correctly
#### New behaviour
Steps to validate that it works:
1. Go to the thabloids page
2. The items are positioned correctly24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1257Fix broken file validators2019-06-04T20:08:35+02:00Sébastiaan VersteegFix broken file validators#### Previous behaviour
Steps to reproduce:
1. Upload a txt or pdf file
2. Error
#### New behaviour
Steps to validate that it works:
1. Upload a txt or pdf file
2. Works#### Previous behaviour
Steps to reproduce:
1. Upload a txt or pdf file
2. Error
#### New behaviour
Steps to validate that it works:
1. Upload a txt or pdf file
2. Works24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1252Fix saving pizza event if notification already exists2019-05-22T22:34:03+02:00Sébastiaan VersteegFix saving pizza event if notification already exists#### Previous behaviour
Steps to reproduce:
1. Create a pizza event with notification
2. Edit said event and save
3. :fire:
#### New behaviour
Steps to validate that it works:
1. Create a pizza event with notification
2. Edit said eve...#### Previous behaviour
Steps to reproduce:
1. Create a pizza event with notification
2. Edit said event and save
3. :fire:
#### New behaviour
Steps to validate that it works:
1. Create a pizza event with notification
2. Edit said event and save
3. :white\_check\_mark:24