concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-07-25T14:25:07+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/864Fix registration problems2018-07-25T14:25:07+02:00Sébastiaan VersteegFix registration problemsThis MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behavi...This MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Payment added to registration after accepting
### Fields not shown in admin
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Missing fields in the admin
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Missing fields in the admin1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/867Crash on confirming non-existing registration entry2018-08-07T12:34:00+02:00Sébastiaan VersteegCrash on confirming non-existing registration entryCloses #665
#### Previous behaviour
Steps to reproduce:
1. Go to `/registration/confirm-email/00000000-0000-0000-0000-000000000000`
2. :boom:
#### New behaviour
Steps to validate that it works:
1. Go to `/registration/confirm-email/0...Closes #665
#### Previous behaviour
Steps to reproduce:
1. Go to `/registration/confirm-email/00000000-0000-0000-0000-000000000000`
2. :boom:
#### New behaviour
Steps to validate that it works:
1. Go to `/registration/confirm-email/00000000-0000-0000-0000-000000000000`
2. Redirect to registration page1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/868Fix/registrations form entry missing2018-08-08T10:34:17+02:00Sébastiaan VersteegFix/registrations form entry missingCloses #664
#### Previous behaviour
Steps to reproduce:
1. Do not enter a value in the starting year field of the registration form
2. Submit
#### New behaviour
Steps to validate that it works:
1. Do not enter a value in the startin...Closes #664
#### Previous behaviour
Steps to reproduce:
1. Do not enter a value in the starting year field of the registration form
2. Submit
#### New behaviour
Steps to validate that it works:
1. Do not enter a value in the starting year field of the registration form
2. Submit1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/872Fix pizzas uniqueness2018-08-09T16:50:55+02:00Sébastiaan VersteegFix pizzas uniquenessCloses #668
#### Previous behaviour
Steps to reproduce:
1. Create a pizza event
2. Try to edit it
#### New behaviour
Steps to validate that it works:
1. Create a pizza event
2. Try to edit itCloses #668
#### Previous behaviour
Steps to reproduce:
1. Create a pizza event
2. Try to edit it
#### New behaviour
Steps to validate that it works:
1. Create a pizza event
2. Try to edit it1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/878Update to Django >=2.0.82018-08-02T14:20:59+02:00Thom WiggersUpdate to Django >=2.0.8New Django Security release.
> CVE-2018-14574: Open redirect possibility in CommonMiddleware
>If the django.middleware.common.CommonMiddleware and the APPEND_SLASH setting are both enabled, and if the project has a URL pattern that acc...New Django Security release.
> CVE-2018-14574: Open redirect possibility in CommonMiddleware
>If the django.middleware.common.CommonMiddleware and the APPEND_SLASH setting are both enabled, and if the project has a URL pattern that accepts any path ending in a slash (many content management systems have such a pattern), then a request to a maliciously crafted URL of that site could lead to a redirect to another site, enabling phishing and other attacks.
> Thanks Andreas Hug for reporting this issue.
We're likely affected by this issue.
https://www.djangoproject.com/weblog/2018/aug/01/security-releases/https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/891Fix language override2018-08-17T11:01:51+02:00Thom WiggersFix language overrideCloses #674
#### Previous behaviour
Steps to reproduce:
1. Run script
2. Observe crash
#### New behaviour
Steps to validate that it works:
1. Run script
2. See it works
### Current status
* [x] TestedCloses #674
#### Previous behaviour
Steps to reproduce:
1. Run script
2. Observe crash
#### New behaviour
Steps to validate that it works:
1. Run script
2. See it works
### Current status
* [x] Tested1.16.2https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/892Use correct english names of studies (and translate "Access the Sentry backend")2018-08-28T17:28:11+02:00Joren VranckenUse correct english names of studies (and translate "Access the Sentry backend")### Short description
- "[Cc]omputer [Ss]cience" -> "Computing Science"
- "[Ii]nformation [Ss]cience" -> "Information Sciences"
- Translates "Access the Sentry backend"### Short description
- "[Cc]omputer [Ss]cience" -> "Computing Science"
- "[Ii]nformation [Ss]cience" -> "Information Sciences"
- Translates "Access the Sentry backend"1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/898Fix automatic membership emails2018-08-18T13:54:16+02:00Sébastiaan VersteegFix automatic membership emails#### Previous behaviour
Steps to reproduce:
1. Send automatic membership emails
#### New behaviour
Steps to validate that it works:
1. Send automatic membership emails#### Previous behaviour
Steps to reproduce:
1. Send automatic membership emails
#### New behaviour
Steps to validate that it works:
1. Send automatic membership emails1.16.3https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/899Fix renewal since date calculation2019-09-04T13:04:48+02:00Sébastiaan VersteegFix renewal since date calculationFix renewal since date calculation
#### Previous behaviour
Steps to reproduce:
1. Create renewal and process it
2. Notice that the new since date is until + 1. So 1 day of membership is missing. (until 1 sept + 1 day = 2 sept which sho...Fix renewal since date calculation
#### Previous behaviour
Steps to reproduce:
1. Create renewal and process it
2. Notice that the new since date is until + 1. So 1 day of membership is missing. (until 1 sept + 1 day = 2 sept which should be 1 sept)
#### New behaviour
Steps to validate that it works:
1. Create renewal
2. Notice that the new since date is equal to until.1.16.3https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/901Make sure docblocks match specs2018-08-28T16:38:10+02:00Sébastiaan VersteegMake sure docblocks match specsCloses #675
#### Previous behaviour
Steps to reproduce:
1. Generate apidocs
2. :param in texts
#### New behaviour
Steps to validate that it works:
1. Generate apidocs
2. Correct formattingCloses #675
#### Previous behaviour
Steps to reproduce:
1. Generate apidocs
2. :param in texts
#### New behaviour
Steps to validate that it works:
1. Generate apidocs
2. Correct formatting1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/906Fix max registration year2018-08-20T10:53:00+02:00Sébastiaan VersteegFix max registration year#### Previous behaviour
Steps to reproduce:
1. Try to register for 2018-2019
#### New behaviour
Steps to validate that it works:
1. Try to register for 2018-2019#### Previous behaviour
Steps to reproduce:
1. Try to register for 2018-2019
#### New behaviour
Steps to validate that it works:
1. Try to register for 2018-2019https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/907Hotfix: Fix registration year selection2018-08-20T10:56:56+02:00Thom WiggersHotfix: Fix registration year selectionFix max registration year
See merge request thalia/concrexit!906
(cherry picked from commit 30b26f7f80c17df61b9c4c1f8841a4ab57de808b)
41048441 Fix max registration yearFix max registration year
See merge request thalia/concrexit!906
(cherry picked from commit 30b26f7f80c17df61b9c4c1f8841a4ab57de808b)
41048441 Fix max registration yearhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/909Fix translation of 'successful'2018-08-28T16:26:30+02:00Joren VranckenFix translation of 'successful'Closes #683
### Short description
"afgekeurd" -> "succesvol"Closes #683
### Short description
"afgekeurd" -> "succesvol"1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/911Fix email subject of renewal rejection mail2018-08-28T16:43:05+02:00Sébastiaan VersteegFix email subject of renewal rejection mailCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Reject a renewal
2. Check email subject
#### New behaviour
Steps to validate that it works:
1. Reject a renewal
2. Check email subjectCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Reject a renewal
2. Check email subject
#### New behaviour
Steps to validate that it works:
1. Reject a renewal
2. Check email subject1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/915Change registrations processing to using POST2018-08-28T16:50:42+02:00Sébastiaan VersteegChange registrations processing to using POST### Short description
Change registrations processing to using POST### Short description
Change registrations processing to using POST1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/916Change payment processing to use POST requests2018-08-28T16:50:35+02:00Sébastiaan VersteegChange payment processing to use POST requestsCloses #678
#### Previous behaviour
Steps to reproduce:
1. Look up unprocessed payment
1. Process payment
1. Uses GET
#### New behaviour
Steps to validate that it works:
1. Look up unprocessed payment
1. Process payment
1. Uses POSTCloses #678
#### Previous behaviour
Steps to reproduce:
1. Look up unprocessed payment
1. Process payment
1. Uses GET
#### New behaviour
Steps to validate that it works:
1. Look up unprocessed payment
1. Process payment
1. Uses POST1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/918Fix 'registration' verbose name2018-08-28T16:31:02+02:00Sébastiaan VersteegFix 'registration' verbose name#### Previous behaviour
Steps to reproduce:
1. Wrong text
#### New behaviour
Steps to validate that it works:
1. Good text#### Previous behaviour
Steps to reproduce:
1. Wrong text
#### New behaviour
Steps to validate that it works:
1. Good text1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/925Do not create scheduled messages if they would be in the past2018-08-29T21:57:53+02:00Sébastiaan VersteegDo not create scheduled messages if they would be in the pastDo not create scheduled messages if they would be in the pastDo not create scheduled messages if they would be in the past1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/929Fix automatically selected members for scheduled messages2018-08-31T15:58:51+02:00Sébastiaan VersteegFix automatically selected members for scheduled messages#### Previous behaviour
Steps to reproduce:
1. Create event
2. See that not all current members are selected to receive the scheduled message
#### New behaviour
Steps to validate that it works:
1. Create event
2. See that all current ...#### Previous behaviour
Steps to reproduce:
1. Create event
2. See that not all current members are selected to receive the scheduled message
#### New behaviour
Steps to validate that it works:
1. Create event
2. See that all current members are selected to receive the scheduled messagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/931Add __str__ methods to the member models2018-09-05T16:32:34+02:00Thom WiggersAdd __str__ methods to the member models#### Previous behaviour
Steps to reproduce:
1. You'd get the default `__str__` to show up in various places, e.g. headers of Membership blocks on the User page in the admin or in the history.
#### New behaviour
Steps to validate that i...#### Previous behaviour
Steps to reproduce:
1. You'd get the default `__str__` to show up in various places, e.g. headers of Membership blocks on the User page in the admin or in the history.
#### New behaviour
Steps to validate that it works:
1. See that it's all pretty now.1.18