concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-10-03T20:15:44+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/934Fix comparison in registration model for year and programme2018-10-03T20:15:44+02:00Sébastiaan VersteegFix comparison in registration model for year and programme~bug
Closes #693
#### Previous behaviour
Steps to reproduce:
1. Create a registration for a supporter
2. Do _not_ enter a study programme
3. Save
4. Error
#### New behaviour
Steps to validate that it works:
1. Create ...~bug
Closes #693
#### Previous behaviour
Steps to reproduce:
1. Create a registration for a supporter
2. Do _not_ enter a study programme
3. Save
4. Error
#### New behaviour
Steps to validate that it works:
1. Create a registration for a supporter
2. Do _not_ enter a study programme
3. Save
4. Done!
1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/936Fix save order for payments in registrations2018-09-12T16:23:07+02:00Sébastiaan VersteegFix save order for payments in registrationsPossibly closes #680
#### Previous behaviour
Steps to reproduce:
1. Accept batch of registrations
#### New behaviour
Steps to validate that it works:
1. Accept batch of registrationsPossibly closes #680
#### Previous behaviour
Steps to reproduce:
1. Accept batch of registrations
#### New behaviour
Steps to validate that it works:
1. Accept batch of registrations1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/940Fix #6992018-09-13T15:16:18+02:00Sébastiaan VersteegFix #699Closes #699Closes #6991.18Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/944Fix tests broken by default language change (#704, !943)2018-09-19T21:15:28+02:00Thom WiggersFix tests broken by default language change (#704, !943)Fixes !943
#### Previous behaviour
Steps to reproduce:
1. Tests fail
#### New behaviour
Steps to validate that it works:
1. Tests workFixes !943
#### Previous behaviour
Steps to reproduce:
1. Tests fail
#### New behaviour
Steps to validate that it works:
1. Tests work1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/946Make url for push messages non-required2018-09-26T20:28:21+02:00Sébastiaan VersteegMake url for push messages non-requiredAs requestedAs requested1.18Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/948Make registrations readonly on completed2018-09-26T20:28:22+02:00Sébastiaan VersteegMake registrations readonly on completedCloses #690
#### Previous behaviour
Steps to reproduce:
1. Complete registration
2. Editable form in backend
#### New behaviour
Steps to validate that it works:
1. Complete registration
2. Non-editable form in backendCloses #690
#### Previous behaviour
Steps to reproduce:
1. Complete registration
2. Editable form in backend
#### New behaviour
Steps to validate that it works:
1. Complete registration
2. Non-editable form in backend1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/950Two registrations one email address2018-09-26T20:28:22+02:00Sébastiaan VersteegTwo registrations one email addressCloses #691
#### Previous behaviour
Steps to reproduce:
1. Create registration without student number
2. Create registration with student number, same other info
3. Works
#### New behaviour
Steps to validate that it works:
1. Create...Closes #691
#### Previous behaviour
Steps to reproduce:
1. Create registration without student number
2. Create registration with student number, same other info
3. Works
#### New behaviour
Steps to validate that it works:
1. Create registration without student number
2. Create registration with student number, same other info
3. Fails!1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/955Fix registrations table sorting of cancel date2018-09-26T20:28:20+02:00Sébastiaan VersteegFix registrations table sorting of cancel dateCloses #709
#### Previous behaviour
Steps to reproduce:
1. Sort registrations on cancel date
2. Incorrect
#### New behaviour
Steps to validate that it works:
1. Sort registrations on cancel date
2. CorrectCloses #709
#### Previous behaviour
Steps to reproduce:
1. Sort registrations on cancel date
2. Incorrect
#### New behaviour
Steps to validate that it works:
1. Sort registrations on cancel date
2. Correct1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/957Resolve "Location Map at Events broken"2018-10-01T17:02:25+02:00Luko van der MaasResolve "Location Map at Events broken"Closes #708Closes #7081.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/959Fix Dutch translation in membership notification email incorrect2018-09-26T20:48:17+02:00Thijs de JongFix Dutch translation in membership notification email incorrectCloses #686
#### Previous behaviour
Steps to reproduce:
1. ./manage.py sendmembershipnotification
#### New behaviour
Steps to validate that it works:
1. ./manage.py sendmembershipnotificationCloses #686
#### Previous behaviour
Steps to reproduce:
1. ./manage.py sendmembershipnotification
#### New behaviour
Steps to validate that it works:
1. ./manage.py sendmembershipnotification1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/963Fix member achievements in services.py2018-10-03T19:02:24+02:00Sébastiaan VersteegFix member achievements in services.py#### Previous behaviour
Steps to reproduce:
1. Open a profile with achievements
2. Not working
#### New behaviour
Steps to validate that it works:
1. Open a profile with achievements
2. Works#### Previous behaviour
Steps to reproduce:
1. Open a profile with achievements
2. Not working
#### New behaviour
Steps to validate that it works:
1. Open a profile with achievements
2. Works1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/966Fix statistics member types input2018-11-05T20:11:13+01:00Sébastiaan VersteegFix statistics member types input#### Previous behaviour
Steps to reproduce:
1. Statistics broken
#### New behaviour
Steps to validate that it works:
1. Statistics not broken#### Previous behaviour
Steps to reproduce:
1. Statistics broken
#### New behaviour
Steps to validate that it works:
1. Statistics not broken19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/968Fix registrations tests2018-10-03T19:33:59+02:00Sébastiaan VersteegFix registrations testsTitle says enoughTitle says enoughhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/973Fix societies pages2018-10-03T21:20:33+02:00Sébastiaan VersteegFix societies pages#### Previous behaviour
Steps to reproduce:
1. Go to society pages
#### New behaviour
Steps to validate that it works:
1. Go to society pages#### Previous behaviour
Steps to reproduce:
1. Go to society pages
#### New behaviour
Steps to validate that it works:
1. Go to society pageshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/974Fix societies pages2018-10-03T21:32:41+02:00Sébastiaan VersteegFix societies pages#### Previous behaviour
Steps to reproduce:
1. No working societies
#### New behaviour
Steps to validate that it works:
1. No working societies#### Previous behaviour
Steps to reproduce:
1. No working societies
#### New behaviour
Steps to validate that it works:
1. No working societieshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/977Make student number unique2018-11-05T20:17:21+01:00Thom WiggersMake student number uniqueRelated to #691
### Short description
Make sure duplicates can't happen again by adding a constraint.Related to #691
### Short description
Make sure duplicates can't happen again by adding a constraint.19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/984Event registration export does not have the correct date associated with it.2018-11-05T20:10:08+01:00Luko van der MaasEvent registration export does not have the correct date associated with it.Closes #720Closes #72019https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/986Fix map location in event view2018-10-10T20:00:10+02:00Sébastiaan VersteegFix map location in event view#### Previous behaviour
Steps to reproduce:
1. Check the site
#### New behaviour
Steps to validate that it works:
1. Check the site#### Previous behaviour
Steps to reproduce:
1. Check the site
#### New behaviour
Steps to validate that it works:
1. Check the site1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/988Fix translations of activemembers2018-11-05T20:13:54+01:00Sébastiaan VersteegFix translations of activemembersI didn't check the translations in !933 and !965.I didn't check the translations in !933 and !965.19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/989Fix events translations after new template2018-11-05T20:13:49+01:00Sébastiaan VersteegFix events translations after new templateDidn't check in !965Didn't check in !96519