concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-03-11T20:14:25+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1529Fix summary creation message2020-03-11T20:14:25+01:00Sébastiaan VersteegFix summary creation messageReally fixes #998
#### Previous behaviour
Steps to reproduce:
1. Create a summary
#### New behaviour
Steps to validate that it works:
1. Create a summaryReally fixes #998
#### Previous behaviour
Steps to reproduce:
1. Create a summary
#### New behaviour
Steps to validate that it works:
1. Create a summary31Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1528Change alamanc setting to environ variable2020-03-11T19:52:01+01:00Luko van der MaasChange alamanc setting to environ variable#### Previous behaviour
Steps to reproduce:
1. Go to thalia.nu/members/almanac
2. You see coming soon
#### New behaviour
Steps to validate that it works:
1. Go to thalia.nu/members/almanac
2. See something for the almanac#### Previous behaviour
Steps to reproduce:
1. Go to thalia.nu/members/almanac
2. You see coming soon
#### New behaviour
Steps to validate that it works:
1. Go to thalia.nu/members/almanac
2. See something for the almanac31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1512Fix events blacklist announcement if-statement2020-03-11T19:08:38+01:00Sébastiaan VersteegFix events blacklist announcement if-statement#### Previous behaviour
Steps to reproduce:
1. The 'you are blocked from going to events' banner is always showing
#### New behaviour
Steps to validate that it works:
1. The 'you are blocked from going to events' banner is not always ...#### Previous behaviour
Steps to reproduce:
1. The 'you are blocked from going to events' banner is always showing
#### New behaviour
Steps to validate that it works:
1. The 'you are blocked from going to events' banner is not always showing31Marthijn van den NieuwenhuizenMarthijn van den Nieuwenhuizenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1506Resolve "Show deregistration disclaimer text even if not registered for event"2020-02-23T16:53:09+01:00Mark BouteResolve "Show deregistration disclaimer text even if not registered for event"Closes #1008Closes #100831https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1503Resolve "Missing translations in statistics page"2020-02-19T23:46:54+01:00Mark BouteResolve "Missing translations in statistics page"Closes #981Closes #98131https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1501Disable payment button for Thalia Pay in payment widget2020-02-19T21:48:25+01:00Marie SimonDisable payment button for Thalia Pay in payment widgetCloses #980
#### Previous behaviour
Steps to reproduce:
1. One can click the process button for Thalia Pay for a membership registration
2. It crashes
#### New behaviour
Steps to validate that it works:
1.Cannot click it anymoreCloses #980
#### Previous behaviour
Steps to reproduce:
1. One can click the process button for Thalia Pay for a membership registration
2. It crashes
#### New behaviour
Steps to validate that it works:
1.Cannot click it anymore31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1500Fixed login message visible2020-02-19T21:47:58+01:00Luc KnolFixed login message visible/label ~bug
Closes #968
#### Previous behaviour
Steps to reproduce:
1. Do not log in.
2. Go to an event for which no registration is required.
3. A login button appears.
#### New behaviour
Steps to validate that it works:.../label ~bug
Closes #968
#### Previous behaviour
Steps to reproduce:
1. Do not log in.
2. Go to an event for which no registration is required.
3. A login button appears.
#### New behaviour
Steps to validate that it works:
1. Do not log in.
2. Go to an event for which no registration is required.
3. No login button appears, a message "no registration required" is displayed.
31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1497Set Postgres Password in CI2020-02-19T21:50:16+01:00Joren VranckenSet Postgres Password in CI#### Previous behaviour
CI failed, because Postgres password was not set ([upstream commit](https://github.com/docker-library/postgres/commit/f1bc8782e7e57cc403d0b32c0e24599535859f76)).
#### New behaviour
Postgres password is set.#### Previous behaviour
CI failed, because Postgres password was not set ([upstream commit](https://github.com/docker-library/postgres/commit/f1bc8782e7e57cc403d0b32c0e24599535859f76)).
#### New behaviour
Postgres password is set.31Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1492Resolve "/api/v1/token-auth does not return json on login failure"2020-02-20T08:45:53+01:00Simcha van CollemResolve "/api/v1/token-auth does not return json on login failure"Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-...Closes #975
#### Previous behaviour
Steps to reproduce:
1. Post wrong credentials to `/api/v1/token-auth`
2. "Unauthorized" is returned
#### New behaviour
Steps to validate that it works:
1. Post wrong credentials to `/api/v1/token-auth`
2. `{"error": "Unauthorized"}` is returned31Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1486Login page not visible anymore when logged-in2020-02-05T21:24:02+01:00Luc KnolLogin page not visible anymore when logged-inCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to homeCloses #979
#### Previous behaviour
Steps to reproduce:
1. log in
2. visit thalia.nu/user/login
#### New behaviour
Steps to validate that it works:
1. log in
2. visit thalia.nu/user/login
3. get redirected to home31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1485Resolve "'All members' in members directory not marked as active"2020-02-05T21:18:38+01:00Simcha van CollemResolve "'All members' in members directory not marked as active"Closes #1004
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
#### New behaviour
Steps to validate that it works:
1. Go to https://thalia.nu/members/directory/
2. ...Closes #1004
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/members/directory/
2. The item is not selected
#### New behaviour
Steps to validate that it works:
1. Go to https://thalia.nu/members/directory/
2. The item is selected31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1483Resolve "Event admin view does not include 'user-tools' like other admin temp...2020-02-19T19:38:58+01:00Simcha van CollemResolve "Event admin view does not include 'user-tools' like other admin templates"Closes #978
#### Previous behaviour
Steps to reproduce:
1. Edit an event
2. There is no user-tools in the navbar
#### New behaviour
Steps to validate that it works:
1. Edit an event
2. There is an user-tools in the navbarCloses #978
#### Previous behaviour
Steps to reproduce:
1. Edit an event
2. There is no user-tools in the navbar
#### New behaviour
Steps to validate that it works:
1. Edit an event
2. There is an user-tools in the navbar31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1482Success_messages added for every exam and summary upload2020-02-05T21:35:25+01:00Marthijn van den NieuwenhuizenSuccess_messages added for every exam and summary uploadCloses #998
#### Previous behaviour
Steps to reproduce:
1. Upload Exam or Summary
2. Receive no notification message upon successful upload
#### New behaviour
Steps to validate that it works:
1. Upload Exam or Summary
2. Receive not...Closes #998
#### Previous behaviour
Steps to reproduce:
1. Upload Exam or Summary
2. Receive no notification message upon successful upload
#### New behaviour
Steps to validate that it works:
1. Upload Exam or Summary
2. Receive notification message upon successful upload31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1481Resolve "No favicon for the admin site"2020-02-05T21:24:49+01:00Wouter DoelandResolve "No favicon for the admin site"/label ~bug
Closes #999
#### Previous behaviour
Steps to reproduce:
1. Open the admin panel
2. There is no favicon
#### New behaviour
Steps to validate that it works:
1. Open the admin panel
2. There is a favicon
/label ~bug
Closes #999
#### Previous behaviour
Steps to reproduce:
1. Open the admin panel
2. There is no favicon
#### New behaviour
Steps to validate that it works:
1. Open the admin panel
2. There is a favicon
31https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1472Replace Nextcloud menu item with G Suite Knowledge Base2020-02-19T19:55:43+01:00Joren VranckenReplace Nextcloud menu item with G Suite Knowledge Base### Short description
Replace Nextcloud menu item with G Suite Knowledge Base, because we will shutdown Nextcloud on February 3rd in favor of G Suite.### Short description
Replace Nextcloud menu item with G Suite Knowledge Base, because we will shutdown Nextcloud on February 3rd in favor of G Suite.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1471Use timezone aware date2020-02-05T12:37:15+01:00Joren VranckenUse timezone aware date### Short description
Fix the following warning in `PaymentListViewTest`:
```
RuntimeWarning: DateTimeField Payment.processing_date received a naive datetime (2019-03-06 00:00:00) while time zone support is active.
```### Short description
Fix the following warning in `PaymentListViewTest`:
```
RuntimeWarning: DateTimeField Payment.processing_date received a naive datetime (2019-03-06 00:00:00) while time zone support is active.
```30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1470Add ordering to fix UnorderedObjectListWarning warnings2020-02-05T12:35:58+01:00Joren VranckenAdd ordering to fix UnorderedObjectListWarning warnings### Short description
Add ordering to fix `UnorderedObjectListWarning` warnings.### Short description
Add ordering to fix `UnorderedObjectListWarning` warnings.30Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1468Make registration deadline, cancellation deadline, and number of registration...2020-01-25T17:45:09+01:00Luna-Elise SchernthanerMake registration deadline, cancellation deadline, and number of registrations...Closes #919
#### Previous behaviour
Steps to reproduce:
1. View an event with a registration deadline, cancellation deadline, and a number of registrations on thalia.nu without logging in.
2. You can see the registration deadline, canc...Closes #919
#### Previous behaviour
Steps to reproduce:
1. View an event with a registration deadline, cancellation deadline, and a number of registrations on thalia.nu without logging in.
2. You can see the registration deadline, cancellation deadline, and the number of registrations.
#### New behaviour
Steps to validate that it works:
1. View an event with a registration deadline, cancellation deadline, and a number of registrations on thalia.nu without logging in.
2. You cannot see the registration deadline, cancellation deadline, and the number of registrations.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1463Remove review host dns record2020-01-25T17:45:08+01:00Joren VranckenRemove review host dns recordCloses #996
#### Previous behaviour
Steps to reproduce:
1. Run remove review CI job.
2. The DNS record is not removed.
#### New behaviour
Steps to validate that it works:
1. Run remove review CI job.
2. The DNS record is rem...Closes #996
#### Previous behaviour
Steps to reproduce:
1. Run remove review CI job.
2. The DNS record is not removed.
#### New behaviour
Steps to validate that it works:
1. Run remove review CI job.
2. The DNS record is removed.30https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1457Added more colors for the statistics page graphs2020-01-08T22:43:26+01:00Luc KnolAdded more colors for the statistics page graphsCloses #982
#### Previous behaviour
Steps to reproduce:
1. There are not enough different colors in the statistics committee chart.
#### New behaviour
Steps to validate that it works:
1. Now there are enough colors, every c...Closes #982
#### Previous behaviour
Steps to reproduce:
1. There are not enough different colors in the statistics committee chart.
#### New behaviour
Steps to validate that it works:
1. Now there are enough colors, every committee now has its own color.30