concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-11-05T20:14:00+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/990Fix dataminimisation tests2018-11-05T20:14:00+01:00Sébastiaan VersteegFix dataminimisation tests19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/991Fix committeemembership reference in mailinglists2018-10-11T10:15:56+02:00Sébastiaan VersteegFix committeemembership reference in mailinglists#### Previous behaviour
Steps to reproduce:
1. Open the mailinglist api
#### New behaviour
Steps to validate that it works:
1. Open the mailinglist api#### Previous behaviour
Steps to reproduce:
1. Open the mailinglist api
#### New behaviour
Steps to validate that it works:
1. Open the mailinglist apiThom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/992Fix wiki login2018-10-12T08:10:19+02:00Sébastiaan VersteegFix wiki loginhttps://sentry.thalia.nu/sentry/concrexit/issues/97/
#### Previous behaviour
Steps to reproduce:
1. Login to wiki
#### New behaviour
Steps to validate that it works:
1. Login to wikihttps://sentry.thalia.nu/sentry/concrexit/issues/97/
#### Previous behaviour
Steps to reproduce:
1. Login to wiki
#### New behaviour
Steps to validate that it works:
1. Login to wikihttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/994Fix activemembers sitemap2018-10-13T14:10:05+02:00Sébastiaan VersteegFix activemembers sitemap#### Previous behaviour
Steps to reproduce:
1. Open sitemap.xml
#### New behaviour
Steps to validate that it works:
1. Open sitemap.xml#### Previous behaviour
Steps to reproduce:
1. Open sitemap.xml
#### New behaviour
Steps to validate that it works:
1. Open sitemap.xml19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1004Fix membership information email variables2018-11-05T20:10:46+01:00Sébastiaan VersteegFix membership information email variables#### Previous behaviour
Steps to reproduce:
1. Execute `./manage.py sendinformationcheck`
2. Send emails without information
#### New behaviour
Steps to validate that it works:
1. Execute `./manage.py sendinformationcheck`
2. Send ema...#### Previous behaviour
Steps to reproduce:
1. Execute `./manage.py sendinformationcheck`
2. Send emails without information
#### New behaviour
Steps to validate that it works:
1. Execute `./manage.py sendinformationcheck`
2. Send emails without information19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1007Re-add committee admin2018-10-17T21:00:59+02:00Sébastiaan VersteegRe-add committee admin#### Previous behaviour
Steps to reproduce:
1. No committee admin
#### New behaviour
Steps to validate that it works:
1. No committee admin#### Previous behaviour
Steps to reproduce:
1. No committee admin
#### New behaviour
Steps to validate that it works:
1. No committee adminThijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1012Fix new template issues on production, with partner banners and course catego...2018-11-05T20:14:22+01:00Sébastiaan VersteegFix new template issues on production, with partner banners and course categorie commasCloses #730, #736
- No space after comma in course list
- No inline style for partner banners
- Fix context preprocessors on production
- Fix visible 'None' value in grid item
- Change event listview to 1 week with empty state ale...Closes #730, #736
- No space after comma in course list
- No inline style for partner banners
- Fix context preprocessors on production
- Fix visible 'None' value in grid item
- Change event listview to 1 week with empty state alert
- Documents page: dropdown for GM's now opens 1 by 1 instead of all
- Vacancies page can now have companies without logo instead of a crash
- CSRF in language change now working
- Fix order of years on course page19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1015Fix translations for information check2018-11-05T20:10:38+01:00Sébastiaan VersteegFix translations for information check#### Previous behaviour
Steps to reproduce:
1. Send information check
#### New behaviour
Steps to validate that it works:
1. Send information check#### Previous behaviour
Steps to reproduce:
1. Send information check
#### New behaviour
Steps to validate that it works:
1. Send information check19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1016Sort association documents by name2018-11-05T20:18:02+01:00Joren VranckenSort association documents by nameCloses #700
### Short description
Sort association documents by name.Closes #700
### Short description
Sort association documents by name.19Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1017Use member.profile.display_name instead of member.display_name for profile im...2018-11-05T20:10:28+01:00Joren VranckenUse member.profile.display_name instead of member.display_name for profile images alt attribute#### Previous behaviour
Steps to reproduce:
1. Go to user profile page.
2. Look at `alt` attribute of the profile image.
3. It is not the `display_name`.
#### New behaviour
Steps to validate that it works:
1. Go to user profile page.
...#### Previous behaviour
Steps to reproduce:
1. Go to user profile page.
2. Look at `alt` attribute of the profile image.
3. It is not the `display_name`.
#### New behaviour
Steps to validate that it works:
1. Go to user profile page.
2. Look at `alt` attribute of the profile image.
3. It is the `display_name` (or the username if there is no `display_name`).19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1019Add ListAlias.__str__2018-11-05T20:17:52+01:00Thom WiggersAdd ListAlias.__str__### Short description
Adds `__str__` method to `ListAlias` model. This allows me to read history.### Short description
Adds `__str__` method to `ListAlias` model. This allows me to read history.19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1020Add help text about active committees2018-11-05T11:59:03+01:00Thom WiggersAdd help text about active committeesSee #731. Apparently @rwechel interpreted 'active' differently, so this change clarifies the situation.See #731. Apparently @rwechel interpreted 'active' differently, so this change clarifies the situation.19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1021Clarify address specification2018-11-05T11:54:03+01:00Thom WiggersClarify address specificationCloses #746
#### Previous behaviour
Steps to reproduce:
1. Enter `1 kerkstraat`
2. Get a confusing message
#### New behaviour
Steps to validate that it works:
1. Enter `1 kerkstraat`
2. Get a message telling you to put it after.Closes #746
#### Previous behaviour
Steps to reproduce:
1. Enter `1 kerkstraat`
2. Get a confusing message
#### New behaviour
Steps to validate that it works:
1. Enter `1 kerkstraat`
2. Get a message telling you to put it after.19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1022Do not exit CI job when no obsolete translations have been found2018-10-28T12:20:01+01:00Joren VranckenDo not exit CI job when no obsolete translations have been found#### Previous behaviour
Steps to reproduce:
1. CI `codestyle` job exists when no obsolete translations have been found.
#### New behaviour
Steps to validate that it works:
1. CI `codestyle` job continues when no obsolete tran...#### Previous behaviour
Steps to reproduce:
1. CI `codestyle` job exists when no obsolete translations have been found.
#### New behaviour
Steps to validate that it works:
1. CI `codestyle` job continues when no obsolete translations have been found.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1023Fix registration date in event member email2018-10-31T19:13:38+01:00Sébastiaan VersteegFix registration date in event member emailCloses #754
#### Previous behaviour
Steps to reproduce:
1. Get an email that you can go to an event after waiting in the queue
#### New behaviour
Steps to validate that it works:
1. Get an email that you can go to an event after wait...Closes #754
#### Previous behaviour
Steps to reproduce:
1. Get an email that you can go to an event after waiting in the queue
#### New behaviour
Steps to validate that it works:
1. Get an email that you can go to an event after waiting in the queue19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1024Add check to newsletters to prevent /admin/newsletters urls2018-11-02T15:42:49+01:00Sébastiaan VersteegAdd check to newsletters to prevent /admin/newsletters urlsCloses #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Add text to the newsletter with a url lacking `http(s)`
2. No problems, but the url in the newsletter is `base_url/newsletters/newsletter/(id)/(url)`
#### New behaviour
Step...Closes #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Add text to the newsletter with a url lacking `http(s)`
2. No problems, but the url in the newsletter is `base_url/newsletters/newsletter/(id)/(url)`
#### New behaviour
Steps to validate that it works:
1. Add text to the newsletter with a url lacking `http(s)`
2. Get an error preventing this from happening19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1025Fix translation of 'Only nickname' in Dutch2018-10-25T08:24:56+02:00Sébastiaan VersteegFix translation of 'Only nickname' in DutchCloses #753
#### Previous behaviour
Steps to reproduce:
1. Go to profile edit page
2. Change display name
3. Different meaning in EN and NL
#### New behaviour
Steps to validate that it works:
1. Go to profile edit page
2. Change dis...Closes #753
#### Previous behaviour
Steps to reproduce:
1. Go to profile edit page
2. Change display name
3. Different meaning in EN and NL
#### New behaviour
Steps to validate that it works:
1. Go to profile edit page
2. Change display name
3. Same meaning in EN and NL19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1026Fix next url in events registrations admin2018-11-02T15:46:26+01:00Sébastiaan VersteegFix next url in events registrations adminCloses #735
#### Previous behaviour
Steps to reproduce:
1. Create a registration in the backend for and event using 'save and add another'
1. Get the overview instead of form
#### New behaviour
Steps to validate that it works:
1. Cre...Closes #735
#### Previous behaviour
Steps to reproduce:
1. Create a registration in the backend for and event using 'save and add another'
1. Get the overview instead of form
#### New behaviour
Steps to validate that it works:
1. Create a registration in the backend for and event using 'save and add another'
1. Get the form19https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1030Change events admin urls2018-12-05T20:39:07+01:00Sébastiaan VersteegChange events admin urlsCloses #759 and #785
### Short description
Change the url schemes for our custom event admin views by using the `ModelAdmin` override.
Also removes the custom url API by adding admin functionality to the registrations api.
Closes #759 and #785
### Short description
Change the url schemes for our custom event admin views by using the `ModelAdmin` override.
Also removes the custom url API by adding admin functionality to the registrations api.
20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1033Fix pizzas classes in HTML, better member ordering by default and fix event…2018-11-07T20:19:25+01:00Sébastiaan VersteegFix pizzas classes in HTML, better member ordering by default and fix event…#### Previous behaviour
Steps to reproduce:
1. Events page was not working on mobile due to use of too large columns
1. Also, pizza classes in the HTML were incorrect
1. And the member ordering is now improved, put people without c...#### Previous behaviour
Steps to reproduce:
1. Events page was not working on mobile due to use of too large columns
1. Also, pizza classes in the HTML were incorrect
1. And the member ordering is now improved, put people without cohorts in the back
1. Moreover, no descriptions for member groups (boards, committees, societies)
1. Document names are too long in Dutch
#### New behaviour
Steps to validate that it works:
1. Use a phone to check the register button and map location on the screen.
1. Look in the source of the pizzas app
1. And check the members page of your local instance, make sure you have a user without cohort though
1. Member groups have their descriptions shown again
1. Hyphenate the document names in Dutch19