concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-02-13T19:15:59+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1153Fix registration payment object migration values2019-02-13T19:15:59+01:00Sébastiaan VersteegFix registration payment object migration values#### Previous behaviour
Steps to reproduce:
1. Migrate events
2. Notes in payments like `Event registration Event object (417). Registration: Registration object (8887)`
#### New behaviour
Steps to validate that it works:
1. Migrate e...#### Previous behaviour
Steps to reproduce:
1. Migrate events
2. Notes in payments like `Event registration Event object (417). Registration: Registration object (8887)`
#### New behaviour
Steps to validate that it works:
1. Migrate events
2. Notes in payments like `Event registration Bowling 2019-02-16 18:00. Registration: Registration object (8887)`22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1152Fix vars in fstr in conscribosync.py2019-02-13T19:16:31+01:00Sébastiaan VersteegFix vars in fstr in conscribosync.py#### Previous behaviour
Steps to reproduce:
1. Syncs name with `$` inside value
#### New behaviour
Steps to validate that it works:
1. Syncs name without `$` inside value#### Previous behaviour
Steps to reproduce:
1. Syncs name with `$` inside value
#### New behaviour
Steps to validate that it works:
1. Syncs name without `$` inside value22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1149Fixed Visual Error Committees2019-02-13T21:00:25+01:00Thijs de JongFixed Visual Error CommitteesCloses #791
#### Previous behaviour
Text in Committee Grid View would not match on phone
#### New behaviour
Text in Committee Grid View matches the boxCloses #791
#### Previous behaviour
Text in Committee Grid View would not match on phone
#### New behaviour
Text in Committee Grid View matches the box22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1146Remove SECRET_KEY from production.py2019-02-09T19:02:13+01:00Jelle Besselingjelle@pingiun.comRemove SECRET_KEY from production.pyCloses #818Closes #81822Jelle Besselingjelle@pingiun.comJelle Besselingjelle@pingiun.comhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1144Don't cascade user deletion into deletion of exams etc2019-02-10T17:15:58+01:00Thom WiggersDon't cascade user deletion into deletion of exams etc#### Previous behaviour
Steps to reproduce:
1. try to delete userid 1
1. See that it tries to nuke a lot of exams
#### New behaviour
Steps to validate that it works:
1. nuke user 1 without extensive fallout.#### Previous behaviour
Steps to reproduce:
1. try to delete userid 1
1. See that it tries to nuke a lot of exams
#### New behaviour
Steps to validate that it works:
1. nuke user 1 without extensive fallout.22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1142Fix all entityType values of conscribosync2019-02-10T17:16:01+01:00Sébastiaan VersteegFix all entityType values of conscribosync#### Previous behaviour
Steps to reproduce:
1. Run conscribosync
#### New behaviour
Steps to validate that it works:
1. Run conscribosync#### Previous behaviour
Steps to reproduce:
1. Run conscribosync
#### New behaviour
Steps to validate that it works:
1. Run conscribosync22Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1137Set right entity type in conscribo sync2019-01-24T19:28:42+01:00Sébastiaan VersteegSet right entity type in conscribo sync#### Previous behaviour
Steps to reproduce:
1. manage.py conscribosync
#### New behaviour
Steps to validate that it works:
1. manage.py conscribosync#### Previous behaviour
Steps to reproduce:
1. manage.py conscribosync
#### New behaviour
Steps to validate that it works:
1. manage.py conscribosynchttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1136Add translation for hardcoded "Locatie"2019-01-23T20:06:24+01:00Jelle Besselingjelle@pingiun.comAdd translation for hardcoded "Locatie"#### Previous behaviour
Steps to reproduce:
1. Look at GM documents at https://beta.thalia.nu/documents/
2. The word "Locatie" is in Dutch even on an English preference
#### New behaviour
Steps to validate that it works:
1. See that ...#### Previous behaviour
Steps to reproduce:
1. Look at GM documents at https://beta.thalia.nu/documents/
2. The word "Locatie" is in Dutch even on an English preference
#### New behaviour
Steps to validate that it works:
1. See that the word is translated correctly21.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1135Fix events unpublish2019-01-23T20:20:20+01:00Sébastiaan VersteegFix events unpublishCloses no issue
This bugs only occurs when using Postgres
#### Previous behaviour
Steps to reproduce:
1. Create an event
2. Publish
3. Try to unpublish
#### New behaviour
Steps to validate that it works:
1. Create an event
2. Publish...Closes no issue
This bugs only occurs when using Postgres
#### Previous behaviour
Steps to reproduce:
1. Create an event
2. Publish
3. Try to unpublish
#### New behaviour
Steps to validate that it works:
1. Create an event
2. Publish
3. Try to unpublish21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1134Remove notifications on event delete2019-01-23T20:02:50+01:00Sébastiaan VersteegRemove notifications on event deleteCloses #805
#### Previous behaviour
Steps to reproduce:
1. Create published event in future
2. Check created notifications
3. Delete said event
4. Created notifications still exist
#### New behaviour
Steps to validate that it works:
...Closes #805
#### Previous behaviour
Steps to reproduce:
1. Create published event in future
2. Check created notifications
3. Delete said event
4. Created notifications still exist
#### New behaviour
Steps to validate that it works:
1. Create published event in future
2. Check created notifications
3. Delete said event
4. Created notifications are deleted21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1131Replace non-existent redirect_to with request.get_full_path_info2019-01-23T12:13:21+01:00Joren VranckenReplace non-existent redirect_to with request.get_full_path_infoCloses #806
#### Previous behaviour
Steps to reproduce:
1. Redirect to homepage after switching language.
#### New behaviour
Steps to validate that it works:
1. Redirect to same page after switching language.Closes #806
#### Previous behaviour
Steps to reproduce:
1. Redirect to homepage after switching language.
#### New behaviour
Steps to validate that it works:
1. Redirect to same page after switching language.21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1130Automatic pizza save fix2019-01-23T20:20:43+01:00Luko van der MaasAutomatic pizza save fixCloses #807Closes #80721.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1125Remove XFrameOptionsMiddleware2019-01-14T11:29:37+01:00Joren VranckenRemove XFrameOptionsMiddlewareThe `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-option...The `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-options: SAMEORIGIN
...
```
#### New behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
```https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1124Fix problems with pizza event notifications2019-01-16T19:29:56+01:00Sébastiaan VersteegFix problems with pizza event notificationsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1123Add language to frontend form for exams/summaries + fixed unknown language st...2019-01-16T17:01:58+01:00Sébastiaan VersteegAdd language to frontend form for exams/summaries + fixed unknown language state in course overviewCloses #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Check a course https://beta.thalia.nu/education/courses/80/
2. Add a new exam/summary
#### New behaviour
Steps to validate that it works:
1. Check a course for language fla...Closes #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Check a course https://beta.thalia.nu/education/courses/80/
2. Add a new exam/summary
#### New behaviour
Steps to validate that it works:
1. Check a course for language flags
2. Add a new exam/summaryLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1122Change partner banner size thumbnail to medium2019-01-09T19:57:02+01:00Sébastiaan VersteegChange partner banner size thumbnail to medium#### Previous behaviour
Steps to reproduce:
1. Check partners on home
2. Bad quality
#### New behaviour
Steps to validate that it works:
1. Check partners on home
2. Bad quality#### Previous behaviour
Steps to reproduce:
1. Check partners on home
2. Bad quality
#### New behaviour
Steps to validate that it works:
1. Check partners on home
2. Bad quality21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1120Fix header on homepage if slider is not used2019-01-09T19:55:34+01:00Sébastiaan VersteegFix header on homepage if slider is not used#### Previous behaviour
Steps to reproduce:
1. Go to homepage, no slider, no image
#### New behaviour
Steps to validate that it works:
1. Go to homepage, has image, no slider#### Previous behaviour
Steps to reproduce:
1. Go to homepage, no slider, no image
#### New behaviour
Steps to validate that it works:
1. Go to homepage, has image, no slider21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1118Add sentence about cancel deadline being in the past to member waiting list n...2019-01-05T19:09:56+01:00Sébastiaan VersteegAdd sentence about cancel deadline being in the past to member waiting list notificationCloses #799
#### Previous behaviour
Steps to reproduce:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get email
#### New behaviour
Steps to validate that...Closes #799
#### Previous behaviour
Steps to reproduce:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get email
#### New behaviour
Steps to validate that it works:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get emailhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1117Fix new event saving2019-01-05T19:10:36+01:00Sébastiaan VersteegFix new event saving#### Previous behaviour
Steps to reproduce:
1. Create published event from nothing
2. Enter registration date
3. Crash with <=
#### New behaviour
Steps to validate that it works:
1. Create published event from nothing
2. Enter registr...#### Previous behaviour
Steps to reproduce:
1. Create published event from nothing
2. Enter registration date
3. Crash with <=
#### New behaviour
Steps to validate that it works:
1. Create published event from nothing
2. Enter registration date
3. No crash21Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1116Block creation of more mailinglists because they're automatic2019-01-05T19:11:32+01:00Sébastiaan VersteegBlock creation of more mailinglists because they're automaticCloses #794
#### Previous behaviour
Steps to reproduce:
1. Add a mailing list with name 'oldboards'
2. Can do
#### New behaviour
Steps to validate that it works:
1. Add a mailing list with name 'oldboards'
2. Can't doCloses #794
#### Previous behaviour
Steps to reproduce:
1. Add a mailing list with name 'oldboards'
2. Can do
#### New behaviour
Steps to validate that it works:
1. Add a mailing list with name 'oldboards'
2. Can't do21