concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-11-08T07:51:06+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1045Remove BCC of every member check email to the secretary of the board2018-11-08T07:51:06+01:00Sébastiaan VersteegRemove BCC of every member check email to the secretary of the board#### Previous behaviour
Steps to reproduce:
1. All information check mails also went to the secretary
#### New behaviour
Steps to validate that it works:
1. Now they don't#### Previous behaviour
Steps to reproduce:
1. All information check mails also went to the secretary
#### New behaviour
Steps to validate that it works:
1. Now they don'thttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1048Fix usage of script tag on statistics page2018-11-08T14:44:54+01:00Sébastiaan VersteegFix usage of script tag on statistics pagehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1049Fix the birthdays calendar by refactoring the start/end date query parsing2018-11-08T14:45:26+01:00Sébastiaan VersteegFix the birthdays calendar by refactoring the start/end date query parsingCloses #764
#### Previous behaviour
Steps to reproduce:
1. No birthdays in calendar
#### New behaviour
Steps to validate that it works:
1. Birthdays in calendar workCloses #764
#### Previous behaviour
Steps to reproduce:
1. No birthdays in calendar
#### New behaviour
Steps to validate that it works:
1. Birthdays in calendar workhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1050Fix header size too large on smaller screen laptops2018-11-08T15:05:15+01:00Sébastiaan VersteegFix header size too large on smaller screen laptopshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1047Fix events frontpage translation2018-11-08T15:09:41+01:00Sébastiaan VersteegFix events frontpage translationhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1046Improve usability of header on mobile devices2018-11-08T15:10:03+01:00Sébastiaan VersteegImprove usability of header on mobile devicesCloses #762
#### Previous behaviour
Steps to reproduce:
1. Use the site on a small mobile device
1. Header sticks to the top
1. Breaking of header buttons to next line
#### New behaviour
Steps to validate that it works:
1. Use the sit...Closes #762
#### Previous behaviour
Steps to reproduce:
1. Use the site on a small mobile device
1. Header sticks to the top
1. Breaking of header buttons to next line
#### New behaviour
Steps to validate that it works:
1. Use the site on a small mobile device
1. Header now doesn't stick to the top, only on desktop
1. Breaking of header buttons to next line is fixedhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1068Changed Search Button On Member Page2018-12-05T20:37:57+01:00Thijs de JongChanged Search Button On Member PageCloses #773
Fixed the button for searching members on the member page. Scales with the window size.Closes #773
Fixed the button for searching members on the member page. Scales with the window size.20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1057Remove unused JS from pizzas overview2018-12-05T20:37:59+01:00Sébastiaan VersteegRemove unused JS from pizzas overview20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1058Fix events javascript to be compressed again2018-12-05T20:38:00+01:00Sébastiaan VersteegFix events javascript to be compressed againCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Events JS not compressed due to errors in new template migration
#### New behaviour
Steps to validate that it works:
1. Compressed again and still working calendar!Closes no issue
#### Previous behaviour
Steps to reproduce:
1. Events JS not compressed due to errors in new template migration
#### New behaviour
Steps to validate that it works:
1. Compressed again and still working calendar!20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1037Improve vacancy validation2018-12-05T20:38:02+01:00Tom van BusselImprove vacancy validationCloses #761
### Short description
The description is now required, and either a partner or both the company logo are now required.Closes #761
### Short description
The description is now required, and either a partner or both the company logo are now required.20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1081Restrict changing registrations to organiser2018-12-05T20:38:03+01:00Tom van BusselRestrict changing registrations to organiserCloses #786
#### Previous behaviour
Steps to reproduce:
1. Create an user without super user
2. Add this user to a committee which is allowed to organize events.
3. Create a registration for an event organized by a different co...Closes #786
#### Previous behaviour
Steps to reproduce:
1. Create an user without super user
2. Add this user to a committee which is allowed to organize events.
3. Create a registration for an event organized by a different committee.
4. Notice that the user can see and change the registrations for the event of the other committee.
#### New behaviour
Steps to validate that it works:
1. Create an user without super user
2. Add this user to a committee which is allowed to organize events.
3. Create a registration for an event organized by a different committee.
4. Notice that the user can no longer see and change the registrations for the event of the other committee.20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1069Added the Possibility To Enter Uppercase Student Number2018-12-05T20:38:04+01:00Thijs de JongAdded the Possibility To Enter Uppercase Student NumberCloses #740
### Short description
Added the Possibility To Enter Uppercase Student Number, instead of only lowercase(s1015438), you can now enter Uppercase(S1015438) as well.Closes #740
### Short description
Added the Possibility To Enter Uppercase Student Number, instead of only lowercase(s1015438), you can now enter Uppercase(S1015438) as well.20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1056Fix JavaScript on pizzas order page2018-12-05T20:38:04+01:00Sébastiaan VersteegFix JavaScript on pizzas order page#### Previous behaviour
Steps to reproduce:
1. Cannot open pizzas orders page
#### New behaviour
Steps to validate that it works:
1. Can open pizzas orders page#### Previous behaviour
Steps to reproduce:
1. Cannot open pizzas orders page
#### New behaviour
Steps to validate that it works:
1. Can open pizzas orders page20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1085Handle update of present/payment fields separately2018-12-05T20:38:05+01:00Sébastiaan VersteegHandle update of present/payment fields separatelyCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Put/patch to `http://<url>/api/v1/registrations/<id>/` without permissions
2. Can change present/payment value of the registration
#### New behaviour
Steps to validate tha...Closes no issue
#### Previous behaviour
Steps to reproduce:
1. Put/patch to `http://<url>/api/v1/registrations/<id>/` without permissions
2. Can change present/payment value of the registration
#### New behaviour
Steps to validate that it works:
1. Put/patch to `http://<url>/api/v1/registrations/<id>/` without permissions
2. Cannot change present/payment value of the registration20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1078Changed No Registration Needed Text2018-12-05T20:38:06+01:00Thijs de JongChanged No Registration Needed TextCloses #784
#### Previous behaviour
In the back-end, when creating events, the Default of no registration needed was wrong.
#### New behaviour
The Deafault text is correct.Closes #784
#### Previous behaviour
In the back-end, when creating events, the Default of no registration needed was wrong.
#### New behaviour
The Deafault text is correct.20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1070Fix birthdays calendar button2018-12-05T20:39:03+01:00Sébastiaan VersteegFix birthdays calendar buttonCloses #782
#### Previous behaviour
Steps to reproduce:
1. Click agenda (you see the calender view with a few events on it)
1. Click 'show birthdays'
1. Click list
1. There is nothing on most weeks, or sometimes only 1 event from that ...Closes #782
#### Previous behaviour
Steps to reproduce:
1. Click agenda (you see the calender view with a few events on it)
1. Click 'show birthdays'
1. Click list
1. There is nothing on most weeks, or sometimes only 1 event from that week
1. broken
#### New behaviour
Steps to validate that it works:
1. Click agenda (you see the calender view with a few events on it)
1. Click show verjaardagen
1. Click list
1. works fine20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1067Make footer stick to bottom2018-12-05T20:39:03+01:00Sébastiaan VersteegMake footer stick to bottomCloses #781
#### Previous behaviour
Steps to reproduce:
1. Run website visit book sale page
#### New behaviour
Steps to validate that it works:
1. Run website visit book sale pageCloses #781
#### Previous behaviour
Steps to reproduce:
1. Run website visit book sale page
#### New behaviour
Steps to validate that it works:
1. Run website visit book sale page20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1051Make member-event combination unique for event registrations2018-12-05T20:39:04+01:00Sébastiaan VersteegMake member-event combination unique for event registrationsCloses #487
#### Previous behaviour
Steps to reproduce:
1. Possible to have two registrations for one user-event combo
#### New behaviour
Steps to validate that it works:
1. Possible to have only one registration for one us...Closes #487
#### Previous behaviour
Steps to reproduce:
1. Possible to have two registrations for one user-event combo
#### New behaviour
Steps to validate that it works:
1. Possible to have only one registration for one user-event combo20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1064Fix aspect ratio of membergroup photos2018-12-05T20:39:05+01:00Sébastiaan VersteegFix aspect ratio of membergroup photosCloses #774
#### Previous behaviour
![Screenshot_2018-11-15_at_11.25.43](/uploads/8ae04d86405c19898eb1cae074ee595d/Screenshot_2018-11-15_at_11.25.43.png)
#### New behaviour
![Screenshot_2018-11-15_at_11.32.03](/uploads/04f680f887800...Closes #774
#### Previous behaviour
![Screenshot_2018-11-15_at_11.25.43](/uploads/8ae04d86405c19898eb1cae074ee595d/Screenshot_2018-11-15_at_11.25.43.png)
#### New behaviour
![Screenshot_2018-11-15_at_11.32.03](/uploads/04f680f887800c1f9fc8fa1322a52919/Screenshot_2018-11-15_at_11.32.03.png)20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1065Changed Layout Button2018-12-05T20:39:05+01:00Thijs de JongChanged Layout ButtonCloses #780
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/education/courses/72/
2. Look at it not being aligned
#### New behaviour
Steps to validate that it works:
1. Check it on your localhost on bug/button...Closes #780
#### Previous behaviour
Steps to reproduce:
1. Go to https://thalia.nu/education/courses/72/
2. Look at it not being aligned
#### New behaviour
Steps to validate that it works:
1. Check it on your localhost on bug/button-alignment20