concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-01-23T20:20:43+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1130Automatic pizza save fix2019-01-23T20:20:43+01:00Luko van der MaasAutomatic pizza save fixCloses #807Closes #80721.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1125Remove XFrameOptionsMiddleware2019-01-14T11:29:37+01:00Joren VranckenRemove XFrameOptionsMiddlewareThe `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-option...The `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-options: SAMEORIGIN
...
```
#### New behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
```https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1124Fix problems with pizza event notifications2019-01-16T19:29:56+01:00Sébastiaan VersteegFix problems with pizza event notificationsLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1123Add language to frontend form for exams/summaries + fixed unknown language st...2019-01-16T17:01:58+01:00Sébastiaan VersteegAdd language to frontend form for exams/summaries + fixed unknown language state in course overviewCloses #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Check a course https://beta.thalia.nu/education/courses/80/
2. Add a new exam/summary
#### New behaviour
Steps to validate that it works:
1. Check a course for language fla...Closes #ISSUE
#### Previous behaviour
Steps to reproduce:
1. Check a course https://beta.thalia.nu/education/courses/80/
2. Add a new exam/summary
#### New behaviour
Steps to validate that it works:
1. Check a course for language flags
2. Add a new exam/summaryLuko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1122Change partner banner size thumbnail to medium2019-01-09T19:57:02+01:00Sébastiaan VersteegChange partner banner size thumbnail to medium#### Previous behaviour
Steps to reproduce:
1. Check partners on home
2. Bad quality
#### New behaviour
Steps to validate that it works:
1. Check partners on home
2. Bad quality#### Previous behaviour
Steps to reproduce:
1. Check partners on home
2. Bad quality
#### New behaviour
Steps to validate that it works:
1. Check partners on home
2. Bad quality21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1120Fix header on homepage if slider is not used2019-01-09T19:55:34+01:00Sébastiaan VersteegFix header on homepage if slider is not used#### Previous behaviour
Steps to reproduce:
1. Go to homepage, no slider, no image
#### New behaviour
Steps to validate that it works:
1. Go to homepage, has image, no slider#### Previous behaviour
Steps to reproduce:
1. Go to homepage, no slider, no image
#### New behaviour
Steps to validate that it works:
1. Go to homepage, has image, no slider21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1118Add sentence about cancel deadline being in the past to member waiting list n...2019-01-05T19:09:56+01:00Sébastiaan VersteegAdd sentence about cancel deadline being in the past to member waiting list notificationCloses #799
#### Previous behaviour
Steps to reproduce:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get email
#### New behaviour
Steps to validate that...Closes #799
#### Previous behaviour
Steps to reproduce:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get email
#### New behaviour
Steps to validate that it works:
1. Put 1 user on mailing list and 1 in registration with reg limit 1
2. Unregister the registered user via the _frontend_.
3. Get emailhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1117Fix new event saving2019-01-05T19:10:36+01:00Sébastiaan VersteegFix new event saving#### Previous behaviour
Steps to reproduce:
1. Create published event from nothing
2. Enter registration date
3. Crash with <=
#### New behaviour
Steps to validate that it works:
1. Create published event from nothing
2. Enter registr...#### Previous behaviour
Steps to reproduce:
1. Create published event from nothing
2. Enter registration date
3. Crash with <=
#### New behaviour
Steps to validate that it works:
1. Create published event from nothing
2. Enter registration date
3. No crash21Luko van der MaasLuko van der Maashttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1116Block creation of more mailinglists because they're automatic2019-01-05T19:11:32+01:00Sébastiaan VersteegBlock creation of more mailinglists because they're automaticCloses #794
#### Previous behaviour
Steps to reproduce:
1. Add a mailing list with name 'oldboards'
2. Can do
#### New behaviour
Steps to validate that it works:
1. Add a mailing list with name 'oldboards'
2. Can't doCloses #794
#### Previous behaviour
Steps to reproduce:
1. Add a mailing list with name 'oldboards'
2. Can do
#### New behaviour
Steps to validate that it works:
1. Add a mailing list with name 'oldboards'
2. Can't do21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1115Sort member list always alphabetically2019-01-05T19:11:06+01:00Sébastiaan VersteegSort member list always alphabeticallyCloses #775
#### Previous behaviour
Steps to reproduce:
1. Go to the member list
2. Members are sorted by cohort
#### New behaviour
Steps to validate that it works:
1. Go to the member list
2. Members are sorted by nameCloses #775
#### Previous behaviour
Steps to reproduce:
1. Go to the member list
2. Members are sorted by cohort
#### New behaviour
Steps to validate that it works:
1. Go to the member list
2. Members are sorted by name21Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1114Use thumbnailer everywhere for partners2019-01-05T19:12:02+01:00Sébastiaan VersteegUse thumbnailer everywhere for partnersCloses #801
#### Previous behaviour
Steps to reproduce:
1. No thumbnailer used for partner images
#### New behaviour
Steps to validate that it works:
1. Thumbnailer used for partner imagesCloses #801
#### Previous behaviour
Steps to reproduce:
1. No thumbnailer used for partner images
#### New behaviour
Steps to validate that it works:
1. Thumbnailer used for partner images21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1113Fix paid status sorting pizzas2019-01-05T19:12:31+01:00Sébastiaan VersteegFix paid status sorting pizzasCloses #800
#### Previous behaviour
Go to pizza order page and try to sort on paid status: not working.
Page like this: https://thalia.nu/pizzas/orders/76/
#### New behaviour
Steps to validate that it works:
Go to pizza ord...Closes #800
#### Previous behaviour
Go to pizza order page and try to sort on paid status: not working.
Page like this: https://thalia.nu/pizzas/orders/76/
#### New behaviour
Steps to validate that it works:
Go to pizza order page and try to sort on paid status: working.21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1111Do not send membership notifications for future members2018-12-19T21:41:13+01:00Tom van BusselDo not send membership notifications for future membersCloses #687
#### Previous behaviour
Steps to reproduce:
1. `./manage.py sendmembershipnotification`
#### New behaviour
Steps to validate that it works:
1. `./manage.py sendmembershipnotification`Closes #687
#### Previous behaviour
Steps to reproduce:
1. `./manage.py sendmembershipnotification`
#### New behaviour
Steps to validate that it works:
1. `./manage.py sendmembershipnotification`21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1108Exclude groups named admin from nextcloud api2019-01-09T18:52:33+01:00Sébastiaan VersteegExclude groups named admin from nextcloud api21Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1106Only really show upcoming events in the upcoming events view2019-01-09T18:37:42+01:00Sébastiaan VersteegOnly really show upcoming events in the upcoming events view#### Previous behaviour
Steps to reproduce:
1. Go to the upcoming view instroduced in !1091
2. Notice that it shows events _before_ today
#### New behaviour
Steps to validate that it works:
1. Go to the upcoming view instroduced in !1...#### Previous behaviour
Steps to reproduce:
1. Go to the upcoming view instroduced in !1091
2. Notice that it shows events _before_ today
#### New behaviour
Steps to validate that it works:
1. Go to the upcoming view instroduced in !1091
2. Notice that it only shows events on or after today21Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1105Prevent changes to price and registration start after registration has started2018-12-18T15:56:20+01:00Sébastiaan VersteegPrevent changes to price and registration start after registration has startedCloses #788
#### Previous behaviour
Steps to reproduce:
1. Create an event with a price and registration start.
2. Publish it
3. Change price/registration start
4. Possible
#### New behaviour
Steps to validate that it works...Closes #788
#### Previous behaviour
Steps to reproduce:
1. Create an event with a price and registration start.
2. Publish it
3. Change price/registration start
4. Possible
#### New behaviour
Steps to validate that it works:
1. Create an event with a price and registration start.
2. Publish it
3. Change price/registration start
4. Blocked
21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1103Fix unpublished events feed2018-12-18T14:03:06+01:00Sébastiaan VersteegFix unpublished events feed#### Previous behaviour
Steps to reproduce:
1. 500 error when loading https://thalia.nu/api/v1/events/unpublished/?start=2018-12-14&end=2020-01-01
#### New behaviour
Steps to validate that it works:
1. no error
#### Previous behaviour
Steps to reproduce:
1. 500 error when loading https://thalia.nu/api/v1/events/unpublished/?start=2018-12-14&end=2020-01-01
#### New behaviour
Steps to validate that it works:
1. no error
21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1101Fix foreignkeys in sqlite local database2018-12-16T20:29:51+01:00Sébastiaan VersteegFix foreignkeys in sqlite local databaseFixes local issue with SQLite databasesFixes local issue with SQLite databaseshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1100Save event first before creating notifications when adding2018-12-16T19:46:35+01:00Sébastiaan VersteegSave event first before creating notifications when adding#### Previous behaviour
Steps to reproduce:
1. Create an event that is published immediately
2. Error
#### New behaviour
Steps to validate that it works:
1. Create an event that is published immediately
2. No error#### Previous behaviour
Steps to reproduce:
1. Create an event that is published immediately
2. Error
#### New behaviour
Steps to validate that it works:
1. Create an event that is published immediately
2. No error21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1099Make the slider responsive to hold a steady aspect ratio of 2.52018-12-16T16:05:29+01:00Sébastiaan VersteegMake the slider responsive to hold a steady aspect ratio of 2.5#### Previous behaviour
Steps to reproduce:
1. The slider only showed the exact center of a slide
2.
#### New behaviour
Steps to validate that it works:
1. The slider shows an image of 1075px always the same minimal visible ...#### Previous behaviour
Steps to reproduce:
1. The slider only showed the exact center of a slide
2.
#### New behaviour
Steps to validate that it works:
1. The slider shows an image of 1075px always the same minimal visible when resizing
2. When the window size exceeds 2000px the image is still fully visible and not covering with text falling off
test image:
![christmas-karaoke_copy](/uploads/d40c773e6a2f83c9a4b454548fa090ee/christmas-karaoke_copy.png)21