concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-01-05T19:11:06+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1115Sort member list always alphabetically2019-01-05T19:11:06+01:00Sébastiaan VersteegSort member list always alphabeticallyCloses #775
#### Previous behaviour
Steps to reproduce:
1. Go to the member list
2. Members are sorted by cohort
#### New behaviour
Steps to validate that it works:
1. Go to the member list
2. Members are sorted by nameCloses #775
#### Previous behaviour
Steps to reproduce:
1. Go to the member list
2. Members are sorted by cohort
#### New behaviour
Steps to validate that it works:
1. Go to the member list
2. Members are sorted by name21Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1114Use thumbnailer everywhere for partners2019-01-05T19:12:02+01:00Sébastiaan VersteegUse thumbnailer everywhere for partnersCloses #801
#### Previous behaviour
Steps to reproduce:
1. No thumbnailer used for partner images
#### New behaviour
Steps to validate that it works:
1. Thumbnailer used for partner imagesCloses #801
#### Previous behaviour
Steps to reproduce:
1. No thumbnailer used for partner images
#### New behaviour
Steps to validate that it works:
1. Thumbnailer used for partner images21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1113Fix paid status sorting pizzas2019-01-05T19:12:31+01:00Sébastiaan VersteegFix paid status sorting pizzasCloses #800
#### Previous behaviour
Go to pizza order page and try to sort on paid status: not working.
Page like this: https://thalia.nu/pizzas/orders/76/
#### New behaviour
Steps to validate that it works:
Go to pizza ord...Closes #800
#### Previous behaviour
Go to pizza order page and try to sort on paid status: not working.
Page like this: https://thalia.nu/pizzas/orders/76/
#### New behaviour
Steps to validate that it works:
Go to pizza order page and try to sort on paid status: working.21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1111Do not send membership notifications for future members2018-12-19T21:41:13+01:00Tom van BusselDo not send membership notifications for future membersCloses #687
#### Previous behaviour
Steps to reproduce:
1. `./manage.py sendmembershipnotification`
#### New behaviour
Steps to validate that it works:
1. `./manage.py sendmembershipnotification`Closes #687
#### Previous behaviour
Steps to reproduce:
1. `./manage.py sendmembershipnotification`
#### New behaviour
Steps to validate that it works:
1. `./manage.py sendmembershipnotification`21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1108Exclude groups named admin from nextcloud api2019-01-09T18:52:33+01:00Sébastiaan VersteegExclude groups named admin from nextcloud api21Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1106Only really show upcoming events in the upcoming events view2019-01-09T18:37:42+01:00Sébastiaan VersteegOnly really show upcoming events in the upcoming events view#### Previous behaviour
Steps to reproduce:
1. Go to the upcoming view instroduced in !1091
2. Notice that it shows events _before_ today
#### New behaviour
Steps to validate that it works:
1. Go to the upcoming view instroduced in !1...#### Previous behaviour
Steps to reproduce:
1. Go to the upcoming view instroduced in !1091
2. Notice that it shows events _before_ today
#### New behaviour
Steps to validate that it works:
1. Go to the upcoming view instroduced in !1091
2. Notice that it only shows events on or after today21Thijs de JongThijs de Jonghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1105Prevent changes to price and registration start after registration has started2018-12-18T15:56:20+01:00Sébastiaan VersteegPrevent changes to price and registration start after registration has startedCloses #788
#### Previous behaviour
Steps to reproduce:
1. Create an event with a price and registration start.
2. Publish it
3. Change price/registration start
4. Possible
#### New behaviour
Steps to validate that it works...Closes #788
#### Previous behaviour
Steps to reproduce:
1. Create an event with a price and registration start.
2. Publish it
3. Change price/registration start
4. Possible
#### New behaviour
Steps to validate that it works:
1. Create an event with a price and registration start.
2. Publish it
3. Change price/registration start
4. Blocked
21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1103Fix unpublished events feed2018-12-18T14:03:06+01:00Sébastiaan VersteegFix unpublished events feed#### Previous behaviour
Steps to reproduce:
1. 500 error when loading https://thalia.nu/api/v1/events/unpublished/?start=2018-12-14&end=2020-01-01
#### New behaviour
Steps to validate that it works:
1. no error
#### Previous behaviour
Steps to reproduce:
1. 500 error when loading https://thalia.nu/api/v1/events/unpublished/?start=2018-12-14&end=2020-01-01
#### New behaviour
Steps to validate that it works:
1. no error
21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1100Save event first before creating notifications when adding2018-12-16T19:46:35+01:00Sébastiaan VersteegSave event first before creating notifications when adding#### Previous behaviour
Steps to reproduce:
1. Create an event that is published immediately
2. Error
#### New behaviour
Steps to validate that it works:
1. Create an event that is published immediately
2. No error#### Previous behaviour
Steps to reproduce:
1. Create an event that is published immediately
2. Error
#### New behaviour
Steps to validate that it works:
1. Create an event that is published immediately
2. No error21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1099Make the slider responsive to hold a steady aspect ratio of 2.52018-12-16T16:05:29+01:00Sébastiaan VersteegMake the slider responsive to hold a steady aspect ratio of 2.5#### Previous behaviour
Steps to reproduce:
1. The slider only showed the exact center of a slide
2.
#### New behaviour
Steps to validate that it works:
1. The slider shows an image of 1075px always the same minimal visible ...#### Previous behaviour
Steps to reproduce:
1. The slider only showed the exact center of a slide
2.
#### New behaviour
Steps to validate that it works:
1. The slider shows an image of 1075px always the same minimal visible when resizing
2. When the window size exceeds 2000px the image is still fully visible and not covering with text falling off
test image:
![christmas-karaoke_copy](/uploads/d40c773e6a2f83c9a4b454548fa090ee/christmas-karaoke_copy.png)21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1095Fix sitemap reference2018-12-13T10:56:03+01:00Sébastiaan VersteegFix sitemap referencehttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1094Add rel=noopener where target=_blank2018-12-16T16:06:31+01:00Sébastiaan VersteegAdd rel=noopener where target=_blankCloses #783
#### Previous behaviour
Steps to reproduce:
1. None
#### New behaviour
Steps to validate that it works:
1. NoneCloses #783
#### Previous behaviour
Steps to reproduce:
1. None
#### New behaviour
Steps to validate that it works:
1. None21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1093Correctly align members and photos search forms2018-12-16T16:08:24+01:00Sébastiaan VersteegCorrectly align members and photos search formsCloses #795
#### Previous behaviour
Steps to reproduce:
1. Go to members/photos indexes on mobile
#### New behaviour
Steps to validate that it works:
1. Go to members/photos indexes on mobileCloses #795
#### Previous behaviour
Steps to reproduce:
1. Go to members/photos indexes on mobile
#### New behaviour
Steps to validate that it works:
1. Go to members/photos indexes on mobile21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1092Fix thabloid filtering column/rows2019-01-03T12:34:54+01:00Sébastiaan VersteegFix thabloid filtering column/rowsCloses #793
#### Previous behaviour
Steps to reproduce:
1. Go to thabloid page
2. Filter thabloids
#### New behaviour
Steps to validate that it works:
1. Go to thabloid page
2. Filter thabloidsCloses #793
#### Previous behaviour
Steps to reproduce:
1. Go to thabloid page
2. Filter thabloids
#### New behaviour
Steps to validate that it works:
1. Go to thabloid page
2. Filter thabloids21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1091Changed List View in Calendar2018-12-16T21:45:54+01:00Thijs de JongChanged List View in CalendarCloses #789
#### Previous behaviour
Steps to reproduce:
1. Check out https://thalia.nu/events/#year=2018&month=12&day=13&view=list (for instance) and see that not all upcoming events are shown.
#### New behaviour
Steps to validate th...Closes #789
#### Previous behaviour
Steps to reproduce:
1. Check out https://thalia.nu/events/#year=2018&month=12&day=13&view=list (for instance) and see that not all upcoming events are shown.
#### New behaviour
Steps to validate that it works:
1. use branch bug/list-calendar and visit the calendar list view.21https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1088Limit view permission to organisers only2018-12-12T19:07:06+01:00Sébastiaan VersteegLimit view permission to organisers only#### Previous behaviour
Steps to reproduce:
1. Can view registration of any events
#### New behaviour
Steps to validate that it works:
1. Can only view/change registration of organised events#### Previous behaviour
Steps to reproduce:
1. Can view registration of any events
#### New behaviour
Steps to validate that it works:
1. Can only view/change registration of organised events20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1087Fix events non published 404 in admin2018-12-12T18:52:50+01:00Sébastiaan VersteegFix events non published 404 in adminCloses #797
#### Previous behaviour
Try to open https://beta.thalia.nu/admin/events/event/388/details/
#### New behaviour
Steps to validate that it works:
It opens the event overviewCloses #797
#### Previous behaviour
Try to open https://beta.thalia.nu/admin/events/event/388/details/
#### New behaviour
Steps to validate that it works:
It opens the event overview20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1085Handle update of present/payment fields separately2018-12-05T20:38:05+01:00Sébastiaan VersteegHandle update of present/payment fields separatelyCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Put/patch to `http://<url>/api/v1/registrations/<id>/` without permissions
2. Can change present/payment value of the registration
#### New behaviour
Steps to validate tha...Closes no issue
#### Previous behaviour
Steps to reproduce:
1. Put/patch to `http://<url>/api/v1/registrations/<id>/` without permissions
2. Can change present/payment value of the registration
#### New behaviour
Steps to validate that it works:
1. Put/patch to `http://<url>/api/v1/registrations/<id>/` without permissions
2. Cannot change present/payment value of the registration20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1083Fix migrations in master branch2018-12-05T20:45:54+01:00Sébastiaan VersteegFix migrations in master branchFix buildFix build20https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1081Restrict changing registrations to organiser2018-12-05T20:38:03+01:00Tom van BusselRestrict changing registrations to organiserCloses #786
#### Previous behaviour
Steps to reproduce:
1. Create an user without super user
2. Add this user to a committee which is allowed to organize events.
3. Create a registration for an event organized by a different co...Closes #786
#### Previous behaviour
Steps to reproduce:
1. Create an user without super user
2. Add this user to a committee which is allowed to organize events.
3. Create a registration for an event organized by a different committee.
4. Notice that the user can see and change the registrations for the event of the other committee.
#### New behaviour
Steps to validate that it works:
1. Create an user without super user
2. Add this user to a committee which is allowed to organize events.
3. Create a registration for an event organized by a different committee.
4. Notice that the user can no longer see and change the registrations for the event of the other committee.20