concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2020-01-22T20:45:29+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1467WIP: Resolve "Event information is public"2020-01-22T20:45:29+01:00Luna-Elise SchernthanerWIP: Resolve "Event information is public"Closes #919Closes #919https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1456WIP: Resolve "Missing colors in statistics committee chart"2020-01-08T22:45:52+01:00Luc KnolWIP: Resolve "Missing colors in statistics committee chart"Closes #982Closes #982https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1347Fix vacancy page error 5002019-09-06T16:46:35+02:00Sébastiaan VersteegFix vacancy page error 500Closes #917
#### Previous behaviour
Steps to reproduce:
1. Broken
#### New behaviour
Steps to validate that it works:
1. FixedCloses #917
#### Previous behaviour
Steps to reproduce:
1. Broken
#### New behaviour
Steps to validate that it works:
1. Fixedhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1341WIP: Always save profile image to save filename for user2019-09-04T13:06:05+02:00Sébastiaan VersteegWIP: Always save profile image to save filename for userCloses #ISSUE
#### Previous behaviour
![image](/uploads/8e529cec079cee79369798ef4dc45dd4/image.png)
Steps to reproduce:
1.
#### New behaviour
Steps to validate that it works:
1.Closes #ISSUE
#### Previous behaviour
![image](/uploads/8e529cec079cee79369798ef4dc45dd4/image.png)
Steps to reproduce:
1.
#### New behaviour
Steps to validate that it works:
1.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1340Fix translation for Card payment2019-09-03T12:14:29+02:00Jelle Besselingjelle@pingiun.comFix translation for Card payment#### Previous behaviour
Steps to reproduce:
1. The Dutch translations for wire transfer and card payment are the same
#### New behaviour
Steps to validate that it works:
1. The Dutch translation is correct#### Previous behaviour
Steps to reproduce:
1. The Dutch translations for wire transfer and card payment are the same
#### New behaviour
Steps to validate that it works:
1. The Dutch translation is correctSébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1204WIP: Mailing lists api fails without boards2019-10-02T18:58:40+02:00Michiel KraanWIP: Mailing lists api fails without boardsCloses #842
#### Previous behaviour
Steps to reproduce:
1. Start a local server with no boards (thalia.nu has the same problem, but it already has boards so it can't be reproduced there).
2. Go to <ip>/api/v1/mailinglists/
#### New b...Closes #842
#### Previous behaviour
Steps to reproduce:
1. Start a local server with no boards (thalia.nu has the same problem, but it already has boards so it can't be reproduced there).
2. Go to <ip>/api/v1/mailinglists/
#### New behaviour
Steps to validate that it works: (Same as above)
1. Start a local server with no boards (thalia.nu has the same problem, but it already has boards so it can't be reproduced there).
2. Go to <ip>/api/v1/mailinglists/26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1101Fix foreignkeys in sqlite local database2018-12-16T20:29:51+01:00Sébastiaan VersteegFix foreignkeys in sqlite local databaseFixes local issue with SQLite databasesFixes local issue with SQLite databaseshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/958Fix Dutch translation in membership notification email incorrect2018-09-26T20:18:35+02:00Thijs de JongFix Dutch translation in membership notification email incorrectCloses #686
#### Previous behaviour
Steps to reproduce:
1. ./manage.py sendmembershipnotification
#### New behaviour
Steps to validate that it works:
1. ./manage.py sendmembershipnotificationCloses #686
#### Previous behaviour
Steps to reproduce:
1. ./manage.py sendmembershipnotification
#### New behaviour
Steps to validate that it works:
1. ./manage.py sendmembershipnotificationhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/865WIP: Remember push notification category preferences when a device already ex...2018-07-25T16:28:36+02:00Gijs HendriksenWIP: Remember push notification category preferences when a device already exists#### Previous behaviour
Whenever a device tried to register after having already registered once before, all push notifications are enabled, no matter what the previous preferences were.
Steps to reproduce:
1. Open the app on your...#### Previous behaviour
Whenever a device tried to register after having already registered once before, all push notifications are enabled, no matter what the previous preferences were.
Steps to reproduce:
1. Open the app on your phone.
2. Notice a new `Device` is created which contains your phone's push notification preferences.
3. Disable a few push notification categories.
4. Close the app and reopen it (upon which your devices tries to register again).
5. Notice all push notification categories are enabled.
#### New behaviour
When a device has already registered before, the next time it registers only the relevant fields will be updated, i.e. fields that are either in the body or implicitly transferred in the request (user, language).
Steps to validate that it works:
1. Open the app on your phone.
2. Notice a new `Device` is created which contains your phone's push notification preferences.
3. Disable a few push notification categories.
4. Close the app and reopen it (upon which your devices tries to register again).
5. Notice the specific categories are still disabled.