concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-09-15T22:28:25+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/704Move Payment model to dedicated 'payments' app2019-09-15T22:28:25+02:00Sébastiaan VersteegMove Payment model to dedicated 'payments' app### Short description
This MR moves the Payment model to a new 'payments' app so that if we are going to implement payments in other places of our codebase this model can be reused.### Short description
This MR moves the Payment model to a new 'payments' app so that if we are going to implement payments in other places of our codebase this model can be reused.1.14https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/787Improve usability by adding explanation about existing accounts2018-05-16T19:02:37+02:00Sébastiaan VersteegImprove usability by adding explanation about existing accountsCloses #608
### Short description
Improve usability by adding explanation about existing accountsCloses #608
### Short description
Improve usability by adding explanation about existing accounts1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/786Fix typo on renewal page2018-05-16T19:02:33+02:00Sébastiaan VersteegFix typo on renewal pageCloses #623Closes #6231.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/785Fix membership renewal page when user has no previous memberships2018-05-16T19:02:35+02:00Sébastiaan VersteegFix membership renewal page when user has no previous membershipsCloses #622
#### Previous behaviour
Steps to reproduce:
1. Create a user without memberships
2. Go to the renewal page
#### New behaviour
Steps to validate that it works:
1. Create a user without memberships
2. Go to the ...Closes #622
#### Previous behaviour
Steps to reproduce:
1. Create a user without memberships
2. Go to the renewal page
#### New behaviour
Steps to validate that it works:
1. Create a user without memberships
2. Go to the renewal page1.15https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/864Fix registration problems2018-07-25T14:25:07+02:00Sébastiaan VersteegFix registration problemsThis MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behavi...This MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Payment added to registration after accepting
### Fields not shown in admin
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Missing fields in the admin
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Missing fields in the admin1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/858Fix registration options to not be required2018-07-11T23:35:23+02:00Sébastiaan VersteegFix registration options to not be required1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/855Add privacy policy checkbox to renewal form2018-07-11T14:36:27+02:00Sébastiaan VersteegAdd privacy policy checkbox to renewal formCloses #657
### Short description
Add privacy policy checkbox to renewal form
### Steps to use this feature
1. Go to the renewal page
2. Be forced to accept the privacy policyCloses #657
### Short description
Add privacy policy checkbox to renewal form
### Steps to use this feature
1. Go to the renewal page
2. Be forced to accept the privacy policy1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/849Add optins to members registration form2018-07-11T19:18:26+02:00Sébastiaan VersteegAdd optins to members registration formCloses #658and #659
### Short description
Add optins to members registration form
### Steps to use this feature
1. Use the registration formCloses #658and #659
### Short description
Add optins to members registration form
### Steps to use this feature
1. Use the registration form1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/848Make phone number optional during member registration2018-07-09T09:37:48+02:00Sébastiaan VersteegMake phone number optional during member registrationCloses #660
### Short description
Make phone number optional during member registrationCloses #660
### Short description
Make phone number optional during member registration1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/918Fix 'registration' verbose name2018-08-28T16:31:02+02:00Sébastiaan VersteegFix 'registration' verbose name#### Previous behaviour
Steps to reproduce:
1. Wrong text
#### New behaviour
Steps to validate that it works:
1. Good text#### Previous behaviour
Steps to reproduce:
1. Wrong text
#### New behaviour
Steps to validate that it works:
1. Good text1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/917Add direct link to payment from registrations model admins2018-08-28T16:34:31+02:00Sébastiaan VersteegAdd direct link to payment from registrations model adminsThis doesn't completely close #682, but it is a start.
### Short description
Add direct link to payment from registrations model admins
### Steps to use this feature
1. Open an accepted registration or renewal
2. Check the value at t...This doesn't completely close #682, but it is a start.
### Short description
Add direct link to payment from registrations model admins
### Steps to use this feature
1. Open an accepted registration or renewal
2. Check the value at the 'payment' field.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/916Change payment processing to use POST requests2018-08-28T16:50:35+02:00Sébastiaan VersteegChange payment processing to use POST requestsCloses #678
#### Previous behaviour
Steps to reproduce:
1. Look up unprocessed payment
1. Process payment
1. Uses GET
#### New behaviour
Steps to validate that it works:
1. Look up unprocessed payment
1. Process payment
1. Uses POSTCloses #678
#### Previous behaviour
Steps to reproduce:
1. Look up unprocessed payment
1. Process payment
1. Uses GET
#### New behaviour
Steps to validate that it works:
1. Look up unprocessed payment
1. Process payment
1. Uses POST1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/915Change registrations processing to using POST2018-08-28T16:50:42+02:00Sébastiaan VersteegChange registrations processing to using POST### Short description
Change registrations processing to using POST### Short description
Change registrations processing to using POST1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/914Change lunch break times in registrations emails2018-08-28T17:05:22+02:00Sébastiaan VersteegChange lunch break times in registrations emails### Short description
Change lunch break times in registrations emails### Short description
Change lunch break times in registrations emails1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/911Fix email subject of renewal rejection mail2018-08-28T16:43:05+02:00Sébastiaan VersteegFix email subject of renewal rejection mailCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Reject a renewal
2. Check email subject
#### New behaviour
Steps to validate that it works:
1. Reject a renewal
2. Check email subjectCloses no issue
#### Previous behaviour
Steps to reproduce:
1. Reject a renewal
2. Check email subject
#### New behaviour
Steps to validate that it works:
1. Reject a renewal
2. Check email subject1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/909Fix translation of 'successful'2018-08-28T16:26:30+02:00Joren VranckenFix translation of 'successful'Closes #683
### Short description
"afgekeurd" -> "succesvol"Closes #683
### Short description
"afgekeurd" -> "succesvol"1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/904Uncapitalize two translations for registrations2018-08-28T16:13:07+02:00Joren VranckenUncapitalize two translations for registrations### Short description
Improve translations.### Short description
Improve translations.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/903Replace 'sponsor' with 'partner'2018-08-27T17:30:35+02:00Joren VranckenReplace 'sponsor' with 'partner'### Short description
Last year I (as commissionair of external affairs) started using "partner" instead of "sponsor" because it is a more professional term.### Short description
Last year I (as commissionair of external affairs) started using "partner" instead of "sponsor" because it is a more professional term.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/954Make it possible for previous members to prolong their benefactorship2018-10-08T15:31:23+02:00Sébastiaan VersteegMake it possible for previous members to prolong their benefactorshipCloses #684
### Short description
Make it possible for previous members to prolong their benefactorship
### Steps to use this feature
1. Be a benefactor
2. Prolong your membership
or
1. Be a year member
2. Change your membership...Closes #684
### Short description
Make it possible for previous members to prolong their benefactorship
### Steps to use this feature
1. Be a benefactor
2. Prolong your membership
or
1. Be a year member
2. Change your membership type to benefactor1.18https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/950Two registrations one email address2018-09-26T20:28:22+02:00Sébastiaan VersteegTwo registrations one email addressCloses #691
#### Previous behaviour
Steps to reproduce:
1. Create registration without student number
2. Create registration with student number, same other info
3. Works
#### New behaviour
Steps to validate that it works:
1. Create...Closes #691
#### Previous behaviour
Steps to reproduce:
1. Create registration without student number
2. Create registration with student number, same other info
3. Works
#### New behaviour
Steps to validate that it works:
1. Create registration without student number
2. Create registration with student number, same other info
3. Fails!1.18