concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-07-25T14:25:07+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/864Fix registration problems2018-07-25T14:25:07+02:00Sébastiaan VersteegFix registration problemsThis MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behavi...This MR fixes two things in the registrations app.
### Payment not attached to Registration
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Payment not added to registration after accepting
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Payment added to registration after accepting
### Fields not shown in admin
#### Previous behaviour
Steps to reproduce:
1. Create a new registration
2. Missing fields in the admin
#### New behaviour
Steps to validate that it works:
1. Create a new registration
2. Missing fields in the admin1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/862Fix typo in push notification devices viewset2018-07-11T21:24:15+02:00Gijs HendriksenFix typo in push notification devices viewset#### Previous behaviour
Website crashes when updating push notifications categories.
Steps to reproduce:
1. Send a POST request containing `receive_category` to `https://thalia.nu/api/v1/devices/`.
2. Receive 500 error.
#### ...#### Previous behaviour
Website crashes when updating push notifications categories.
Steps to reproduce:
1. Send a POST request containing `receive_category` to `https://thalia.nu/api/v1/devices/`.
2. Receive 500 error.
#### New behaviour
Website saves new preferences for push notifications categories.
Steps to validate that it works:
1. Send a POST request containing `receive_category` to `https://thalia.nu/api/v1/devices/`.
2. Don't receive 500 error.1.16.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/858Fix registration options to not be required2018-07-11T23:35:23+02:00Sébastiaan VersteegFix registration options to not be required1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/856Fix member expiration emails2018-07-11T19:18:02+02:00Sébastiaan VersteegFix member expiration emails#### Previous behaviour
Steps to reproduce:
1. Check the contents of the emails
2. Incorrect information
#### New behaviour
Steps to validate that it works:
1. Check the contents of the emails
2. Correct information#### Previous behaviour
Steps to reproduce:
1. Check the contents of the emails
2. Incorrect information
#### New behaviour
Steps to validate that it works:
1. Check the contents of the emails
2. Correct information1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/855Add privacy policy checkbox to renewal form2018-07-11T14:36:27+02:00Sébastiaan VersteegAdd privacy policy checkbox to renewal formCloses #657
### Short description
Add privacy policy checkbox to renewal form
### Steps to use this feature
1. Go to the renewal page
2. Be forced to accept the privacy policyCloses #657
### Short description
Add privacy policy checkbox to renewal form
### Steps to use this feature
1. Go to the renewal page
2. Be forced to accept the privacy policy1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/849Add optins to members registration form2018-07-11T19:18:26+02:00Sébastiaan VersteegAdd optins to members registration formCloses #658and #659
### Short description
Add optins to members registration form
### Steps to use this feature
1. Use the registration formCloses #658and #659
### Short description
Add optins to members registration form
### Steps to use this feature
1. Use the registration form1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/848Make phone number optional during member registration2018-07-09T09:37:48+02:00Sébastiaan VersteegMake phone number optional during member registrationCloses #660
### Short description
Make phone number optional during member registrationCloses #660
### Short description
Make phone number optional during member registration1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/845Fix conditions for showing presence and payment on the event page2018-07-05T10:39:35+02:00Tom van BusselFix conditions for showing presence and payment on the event pageCloses no issue (issue reported in the Thalia Whatsapp)
#### Previous behaviour
Steps to reproduce:
1. Create an event which requires registration.
2. Register and unregister for the event.
3. It still shows the payment status a...Closes no issue (issue reported in the Thalia Whatsapp)
#### Previous behaviour
Steps to reproduce:
1. Create an event which requires registration.
2. Register and unregister for the event.
3. It still shows the payment status and presence.
#### New behaviour
Steps to validate that it works:
1. Create an event which requires registration.
2. Register and unregister for the event.
3. It no longer shows the payment status and presence.1.16.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/842Fix 'to' email address in email change confirmation email2018-07-06T15:22:05+02:00Sébastiaan VersteegFix 'to' email address in email change confirmation email#### Previous behaviour
Steps to reproduce:
1. Change your email address
2. Both emails (confirm and verify) end up in the same inbox
#### New behaviour
Steps to validate that it works:
1. Change your email address
2. The emails (conf...#### Previous behaviour
Steps to reproduce:
1. Change your email address
2. Both emails (confirm and verify) end up in the same inbox
#### New behaviour
Steps to validate that it works:
1. Change your email address
2. The emails (confirm and verify) end up in the right (different) inboxes1.16.1