concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2018-07-05T10:47:24+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/831Scheduled notifications for events2018-07-05T10:47:24+02:00Sébastiaan VersteegScheduled notifications for eventsPartially solves #559
### Short description
Scheduled notifications for events
### Steps to use this feature
1. Create an event
2. Notice that scheduled messages are created
3. The messages are sent when scheduledPartially solves #559
### Short description
Scheduled notifications for events
### Steps to use this feature
1. Create an event
2. Notice that scheduled messages are created
3. The messages are sent when scheduled1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/841Allow accessing documents from admin pages2018-07-04T19:24:27+02:00Thom WiggersAllow accessing documents from admin pagesCloses #642
#### Previous behaviour
Steps to reproduce:
1. Upload some type of document
2. Click the shown link to the document
3. 404 as MEDIA_URL isn't served
#### New behaviour
Steps to validate that it works:
1. Do sa...Closes #642
#### Previous behaviour
Steps to reproduce:
1. Upload some type of document
2. Click the shown link to the document
3. 404 as MEDIA_URL isn't served
#### New behaviour
Steps to validate that it works:
1. Do same
2. Observe that the link is going to the `get_document` handler
3. Also observe that you're getting the correctly localised version.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/851Validate docker-compose.yml2018-08-28T16:18:30+02:00Joren VranckenValidate docker-compose.yml### Short description
Validate `docker-compose.yml` before building and running containers.### Short description
Validate `docker-compose.yml` before building and running containers.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/850Docker compose update2018-08-28T16:20:00+02:00Joren VranckenDocker compose update### Short description
Updates docker-compose file### Short description
Updates docker-compose file1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/846Enable the add permission for scheduled messages2018-07-09T09:38:10+02:00Sébastiaan VersteegEnable the add permission for scheduled messagesThis should not have been disabled.This should not have been disabled.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/847Do not schedule or delete messages for unpublished events2018-07-09T09:39:41+02:00Sébastiaan VersteegDo not schedule or delete messages for unpublished eventsCloses #655 and #656
#### Previous behaviour
Steps to reproduce:
1. Create event (unpublished)
2. See that the message is scheduled
--
1. Create event
2. Let it send
3. Change event
4. Notice that the message is still t...Closes #655 and #656
#### Previous behaviour
Steps to reproduce:
1. Create event (unpublished)
2. See that the message is scheduled
--
1. Create event
2. Let it send
3. Change event
4. Notice that the message is still there, marked as sent
#### New behaviour
Steps to validate that it works:
1. Create event (unpublished)
2. No scheduled messages
--
1. Create event
2. Let it send
3. Change event
4. Notice that the message is still there, but a new one was added as well1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/852Get CELERY_BROKER_URL from env vars as a whole2018-08-28T16:19:46+02:00Joren VranckenGet CELERY_BROKER_URL from env vars as a whole### Short description
Get CELERY_BROKER_URL from env vars as a whole### Short description
Get CELERY_BROKER_URL from env vars as a whole1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/853Add LectureYear filter to EventAdmin2018-07-11T17:31:10+02:00Sébastiaan VersteegAdd LectureYear filter to EventAdminCloses #403
### Short description
Add LectureYear filter to EventAdmin
### Steps to use this feature
1. Go to the event admin
2. Filter on leture yearCloses #403
### Short description
Add LectureYear filter to EventAdmin
### Steps to use this feature
1. Go to the event admin
2. Filter on leture year1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/854Fix sorting of registration dates in event admin2018-07-11T19:18:33+02:00Sébastiaan VersteegFix sorting of registration dates in event adminCloses #653
#### Previous behaviour
Steps to reproduce:
1. Go to an event
2. Check the registrations
3. It's in lexicographical order
#### New behaviour
Steps to validate that it works:
1. Go to an event
2. Check the registrations
3....Closes #653
#### Previous behaviour
Steps to reproduce:
1. Go to an event
2. Check the registrations
3. It's in lexicographical order
#### New behaviour
Steps to validate that it works:
1. Go to an event
2. Check the registrations
3. It's in chronological order1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/859No linenos in po2018-08-28T16:18:50+02:00Thom WiggersNo linenos in po### Short description
Reduce diffs by no longer tracking exact positions of strings: omit line numbers.
This should make translation changes easier to verify from now forward.### Short description
Reduce diffs by no longer tracking exact positions of strings: omit line numbers.
This should make translation changes easier to verify from now forward.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/844Resolve "Automatic generation of board email addresses"2018-08-28T16:11:20+02:00Luko van der MaasResolve "Automatic generation of board email addresses"Closes #649Closes #6491.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/861Fix some small bugs in translations2018-08-28T16:20:30+02:00Thom WiggersFix some small bugs in translations#### Previous behaviour
Steps to reproduce:
1. see issues
#### New behaviour
Steps to validate that it works:
1. blissful ignorance#### Previous behaviour
Steps to reproduce:
1. see issues
#### New behaviour
Steps to validate that it works:
1. blissful ignorance1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/860Resolve "Fix names of categories of pushnotifications"2018-08-28T16:11:06+02:00Luko van der MaasResolve "Fix names of categories of pushnotifications"/label ~bug
Closes #663
#### Previous behaviour
Steps to reproduce:
1. View names of categories of push notifications
2. They are all lowercase
#### New behaviour
Steps to validate that it works:
1. View names of catego.../label ~bug
Closes #663
#### Previous behaviour
Steps to reproduce:
1. View names of categories of push notifications
2. They are all lowercase
#### New behaviour
Steps to validate that it works:
1. View names of categories of push notifications
2. They are all title case
1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/876Fix requirements.txt2018-07-25T14:22:49+02:00Sébastiaan VersteegFix requirements.txt### Short description
Fix requirements.txt### Short description
Fix requirements.txt1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/879Use pipenv instead of requirements.txt2018-08-28T16:18:09+02:00Thom WiggersUse pipenv instead of requirements.txtCloses #672, #631
### Short description
* Use pipenv instead of requirements.txt
* Easier usage of virtual envs
* Easier handling of dev environments (`pipenv install --dev`)
* Supersedes pipconflictchecker (thus closes #631)
* Supers...Closes #672, #631
### Short description
* Use pipenv instead of requirements.txt
* Easier usage of virtual envs
* Easier handling of dev environments (`pipenv install --dev`)
* Supersedes pipconflictchecker (thus closes #631)
* Supersedes `safety` (integrated in `pipenv check`)
### Todo
* [x] Fix tests
* [x] Delete requirements.txt
* [x] Update docs
* [x] Figure out how `pipenv check` handles `python_version` (https://github.com/pypa/pipenv/issues/2694)
* [x] Fix docker build
* [x] https://github.com/thaliawww/python-thalia/pull/1
* [x] https://github.com/thaliawww/python-thalia/pull/2
### Caveats
* This does get rid of the separate `production-requirements.txt` and thus may require installing more C libraries (`argon2`, `postgresql`) on development systems. On the other hand, production and development will be much closer.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/889Remove django-slack dependency2018-08-28T17:30:23+02:00Joren VranckenRemove django-slack dependency### Short description
We do not need django-slack anymore, since we now use [sentry instead of slack](!875).### Short description
We do not need django-slack anymore, since we now use [sentry instead of slack](!875).1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/892Use correct english names of studies (and translate "Access the Sentry backend")2018-08-28T17:28:11+02:00Joren VranckenUse correct english names of studies (and translate "Access the Sentry backend")### Short description
- "[Cc]omputer [Ss]cience" -> "Computing Science"
- "[Ii]nformation [Ss]cience" -> "Information Sciences"
- Translates "Access the Sentry backend"### Short description
- "[Cc]omputer [Ss]cience" -> "Computing Science"
- "[Ii]nformation [Ss]cience" -> "Information Sciences"
- Translates "Access the Sentry backend"1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/904Uncapitalize two translations for registrations2018-08-28T16:13:07+02:00Joren VranckenUncapitalize two translations for registrations### Short description
Improve translations.### Short description
Improve translations.1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/905Update Pipfile.lock2018-08-27T17:30:36+02:00Joren VranckenUpdate Pipfile.lock### Short description
Update `Pipfile.lock`### Short description
Update `Pipfile.lock`1.17https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/903Replace 'sponsor' with 'partner'2018-08-27T17:30:35+02:00Joren VranckenReplace 'sponsor' with 'partner'### Short description
Last year I (as commissionair of external affairs) started using "partner" instead of "sponsor" because it is a more professional term.### Short description
Last year I (as commissionair of external affairs) started using "partner" instead of "sponsor" because it is a more professional term.1.17