concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-03-15T13:26:32+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1193Add coverage reporting on coverage.technicie.nl2019-03-15T13:26:32+01:00Jelle Besselingjelle@pingiun.comAdd coverage reporting on coverage.technicie.nl### Short description
Adds a new stage to the gitlab CI which pushes the coverage html report
to coverage.technicie.nl using the sftp command
### Steps to use this feature
1. Open a merge request
2. Pipeline automatically pushes covera...### Short description
Adds a new stage to the gitlab CI which pushes the coverage html report
to coverage.technicie.nl using the sftp command
### Steps to use this feature
1. Open a merge request
2. Pipeline automatically pushes coverage report to website
3. Find the url for the report in the pipeline information23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1192Ignore *.egg-info2019-03-27T19:50:18+01:00Joren VranckenIgnore *.egg-info### Short description
Ignore `*.egg-info`, because `poetry` creates `concrexit.egg-info`.### Short description
Ignore `*.egg-info`, because `poetry` creates `concrexit.egg-info`.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1191Update PC description with correct abbreviation and FB link2019-03-27T19:50:17+01:00Joren VranckenUpdate PC description with correct abbreviation and FB link### Short description
Update PC description with correct abbreviation and FB link.### Short description
Update PC description with correct abbreviation and FB link.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1190Test the merchandise package2019-03-27T19:50:17+01:00Thom WiggersTest the merchandise package### Short description
Implements unit tests for the merchandise package, to make fun of @sversteeg.### Short description
Implements unit tests for the merchandise package, to make fun of @sversteeg.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1189Add manual data minimisation functionality2019-03-06T19:34:15+01:00Sébastiaan VersteegAdd manual data minimisation functionality### Short description
Add manual data minimisation functionality
### Steps to use this feature
1. Go to the user admin
2. Make sure the user has no memberships or an ended membership that ended > 31 days ago
3. Minimise
4. Check that ...### Short description
Add manual data minimisation functionality
### Steps to use this feature
1. Go to the user admin
2. Make sure the user has no memberships or an ended membership that ended > 31 days ago
3. Minimise
4. Check that the user has an empty profile23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1188Add coverage badge2019-03-27T19:50:16+01:00Sébastiaan VersteegAdd coverage badge### Short description
Add coverage badge### Short description
Add coverage badge23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1187Do not specifiy parameters for coverage in ci: use .coveragerc2019-03-27T19:50:17+01:00Sébastiaan VersteegDo not specifiy parameters for coverage in ci: use .coveragerc### Short description
Do not specifiy parameters for coverage in ci: use .coveragerc### Short description
Do not specifiy parameters for coverage in ci: use .coveragerc23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1186Add automatic testing for model str method2019-03-02T17:11:15+01:00Jelle Besselingjelle@pingiun.comAdd automatic testing for model str methodThis adds dynamic tests which check if the overwritten __str__ method of a Model is not the same as the default __str__ method
If we want 100% coverage, the str methods should be tested. But usually, there is not really a good way to te...This adds dynamic tests which check if the overwritten __str__ method of a Model is not the same as the default __str__ method
If we want 100% coverage, the str methods should be tested. But usually, there is not really a good way to test them. This adds coverage to all the str methods automatically by testing that they contain "something useful" instead of having the default implementation.
In addition, it's good to have the str methods overridden because instance names will look weird in the admin without the user friendly name.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1185Fix data minimisation2019-04-10T20:47:51+02:00Sébastiaan VersteegFix data minimisation#### Previous behaviour
Steps to reproduce:
1. Data minimising trying for members with newer study memberships
#### New behaviour
Steps to validate that it works:
1. Data minimising not trying for members with newer study memb...#### Previous behaviour
Steps to reproduce:
1. Data minimising trying for members with newer study memberships
#### New behaviour
Steps to validate that it works:
1. Data minimising not trying for members with newer study memberships23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1184Replace Google Drive with Nextcloud links in styleguide2019-03-27T19:50:16+01:00Sébastiaan VersteegReplace Google Drive with Nextcloud links in styleguide### Short description
Replace Google Drive with Nextcloud links in styleguide### Short description
Replace Google Drive with Nextcloud links in styleguide23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1183Allow board membership to contain end date2019-03-27T19:50:29+01:00Tobias van der WerffAllow board membership to contain end dateCloses #416
#### Previous behaviour
Steps to reproduce:
1. Enter end date for Board membership; this produces an error message.
#### New behaviour
Steps to validate that it works:
1. Enter end date for Board membership; this no long...Closes #416
#### Previous behaviour
Steps to reproduce:
1. Enter end date for Board membership; this produces an error message.
#### New behaviour
Steps to validate that it works:
1. Enter end date for Board membership; this no longer produces an error message.23Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1182Improve createfixtures2019-02-27T20:13:19+01:00Sébastiaan VersteegImprove createfixturesCloses #827
### Short description
Improve createfixturesCloses #827
### Short description
Improve createfixtures23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1181Fix member tabs active state2019-02-27T20:14:50+01:00Sébastiaan VersteegFix member tabs active state#### Previous behaviour
Steps to reproduce:
1. Click 'former' or 'older' members tabs in directory
2. No active state
#### New behaviour
Steps to validate that it works:
1. Click 'former' or 'older' members tabs in director...#### Previous behaviour
Steps to reproduce:
1. Click 'former' or 'older' members tabs in directory
2. No active state
#### New behaviour
Steps to validate that it works:
1. Click 'former' or 'older' members tabs in directory
2. Has active state23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1180Remove redundant CMD instruction from Dockerfile2019-02-22T14:04:27+01:00Joren VranckenRemove redundant CMD instruction from Dockerfile### Short description
The instruction does nothing for the production entrypoint, because it
runs an uwsgi server.
The instruction is redundant for the default entrypoint, because --help
is implied if no command is given to manage.py.### Short description
The instruction does nothing for the production entrypoint, because it
runs an uwsgi server.
The instruction is redundant for the default entrypoint, because --help
is implied if no command is given to manage.py.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1179Do migrate, collectstatic and compress in entrypoints2019-04-11T12:55:08+02:00Joren VranckenDo migrate, collectstatic and compress in entrypointsCloses #831Closes #83123https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1178Thumbnail the merchandise images2019-02-27T20:15:24+01:00Sébastiaan VersteegThumbnail the merchandise images#### Previous behaviour
Steps to reproduce:
1. Go to the merchandise page
2. All full size images loaded
#### New behaviour
Steps to validate that it works:
1. Go to the merchandise page
2. Thumbnails loaded#### Previous behaviour
Steps to reproduce:
1. Go to the merchandise page
2. All full size images loaded
#### New behaviour
Steps to validate that it works:
1. Go to the merchandise page
2. Thumbnails loaded23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1177Replace the wiki menu item by Nextcloud2019-02-27T20:15:07+01:00Sébastiaan VersteegReplace the wiki menu item by Nextcloud### Short description
Replace the wiki menu item by Nextcloud### Short description
Replace the wiki menu item by Nextcloud23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1176Migrate to poetry and remove tox2019-02-27T19:29:01+01:00Jelle Besselingjelle@pingiun.comMigrate to poetry and remove toxCloses #829
### Short description
This MR removes pipenv files, removes tox and adds poetryCloses #829
### Short description
This MR removes pipenv files, removes tox and adds poetry23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1174Write newsletter html to file on sending2019-03-27T20:38:46+01:00Michiel KraanWrite newsletter html to file on sendingCloses https://gitlab.science.ru.nl/thalia/concrexit/issues/321 <br>
### Short description
Generates media/newsletters/pk_lang.html when sending a newsletter's mail, and displays this from thereon. Also adds a "createnewsletterhtml" co...Closes https://gitlab.science.ru.nl/thalia/concrexit/issues/321 <br>
### Short description
Generates media/newsletters/pk_lang.html when sending a newsletter's mail, and displays this from thereon. Also adds a "createnewsletterhtml" command that generates html files for already-existing newsletters.
### Steps to use this feature
1. Create a newsletter
2. All changes in the admin panel are reflected in /newsletters/<pk>
3. Send using /newsletters/admin/send/<pk>
4. Making changes to the newsletter or template now no longer changes /newsletters/<pk>
5. Running "<manage.py> createnewsletterhtml [--include-unsent] server-name server-port" writes all previous newsletters to file.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1170Add functionality to admin to edit information fields2019-04-03T14:09:56+02:00Sébastiaan VersteegAdd functionality to admin to edit information fieldsCloses #472
### Short description
Add functionality to admin to edit information fields
### Steps to use this feature
1. Create event with information fields
2. Register and fill in fields
3. Go to registration admin
4. Edit fields!Closes #472
### Short description
Add functionality to admin to edit information fields
### Steps to use this feature
1. Create event with information fields
2. Register and fill in fields
3. Go to registration admin
4. Edit fields!23