concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-09-04T21:05:53+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1345Fix permission in admin views of pizzas2019-09-04T21:05:53+02:00Sébastiaan VersteegFix permission in admin views of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas#### Previous behaviour
Steps to reproduce:
1. Try to change orders of pizzas
#### New behaviour
Steps to validate that it works:
1. Try to change orders of pizzas26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1320Improve event categories2019-09-04T19:37:35+02:00Sébastiaan VersteegImprove event categoriesCloses #869
### Short description
Improve event categoriesCloses #869
### Short description
Improve event categories26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1344Fix thumbnailer collision2019-09-04T19:30:08+02:00Thom WiggersFix thumbnailer collisionWe now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous beh...We now handle the uploading of files based on the Storage api, and make sure to use its methods to prevent collisions.
In addition, it now drops user-provided filenames completely, and instead generates them randomly.
#### Previous behaviour
Steps to reproduce:
1. Withheld26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1337Photos show rotated2019-09-04T19:19:28+02:00Luko van der MaasPhotos show rotatedCloses #904
View photo with rotation, these will now be rotated correctlyCloses #904
View photo with rotation, these will now be rotated correctly26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1343Don't generate invalid membership dates2019-09-04T19:07:57+02:00Thom WiggersDon't generate invalid membership dates#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
...#### Previous behaviour
Steps to reproduce:
1. Generate fixtures
2. Try to change one that has a membership expiration date < membership start date
3. observe validation rejects you
#### New behaviour
Steps to validate that it works:
1. See that no longer happens.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1342Always quote nicknames.2019-09-04T13:18:24+02:00Thom WiggersAlways quote nicknames.Always quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nicknameAlways quote nicknames.
Otherwise it's possible to set your nickname to 'Jen Dusseljee' and from the front end you can't tell that it's a nickname26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1339Correct translations of 'wire payment'2019-09-03T12:29:47+02:00Sébastiaan VersteegCorrect translations of 'wire payment'#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer pa...#### Previous behaviour
Steps to reproduce:
1. Dutch translation in payments app of wire transfer payments was 'Pin betaling'
#### New behaviour
Steps to validate that it works:
1. Dutch translation in payments app of wire transfer payments is now 'Overboeking'26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1318Remove unused features from partners package2019-09-01T11:40:23+02:00Sébastiaan VersteegRemove unused features from partners packageCloses #877
### Short description
Remove unused features from partners package, also makes sure strings are properly translated.Closes #877
### Short description
Remove unused features from partners package, also makes sure strings are properly translated.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1330Block benefactors or non-members in the next lecture year from giving references2019-08-31T13:02:26+02:00Sébastiaan VersteegBlock benefactors or non-members in the next lecture year from giving referencesCloses #901 #902 #903
#### Previous behaviour
Steps to reproduce:
1. See the issues
#### New behaviour
Steps to validate that it works:
1. See the issuesCloses #901 #902 #903
#### Previous behaviour
Steps to reproduce:
1. See the issues
#### New behaviour
Steps to validate that it works:
1. See the issues26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1336Push notifications don't show content only title twice2019-08-31T12:57:12+02:00Luko van der MaasPush notifications don't show content only title twiceMessage sent from event now has correct body instead of the title
Closes #906Message sent from event now has correct body instead of the title
Closes #90626https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1311Closes #887, photo url notification is no longer relative2019-08-31T12:53:44+02:00Sébastiaan VersteegCloses #887, photo url notification is no longer relativeCloses #887
#### Previous behaviour
Steps to reproduce:
1. Photo url does not contain the domain name
#### New behaviour
Steps to validate that it works:
1. Photo url contains the domain nameCloses #887
#### Previous behaviour
Steps to reproduce:
1. Photo url does not contain the domain name
#### New behaviour
Steps to validate that it works:
1. Photo url contains the domain name26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1313Add tests for close announcement2019-08-31T12:53:28+02:00Thom WiggersAdd tests for close announcement### Short description
Adds unit tests for closing announcements and catch a potential exception.### Short description
Adds unit tests for closing announcements and catch a potential exception.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1325Add explicit end date for members to board pages2019-08-28T20:11:23+02:00Sébastiaan VersteegAdd explicit end date for members to board pagesCloses #857
### Short description
Add explicit end date for members to board pages
### Steps to use this feature
1. Add a board membership that ends prematurely
2. Check the date on the board pageCloses #857
### Short description
Add explicit end date for members to board pages
### Steps to use this feature
1. Add a board membership that ends prematurely
2. Check the date on the board page26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1323Wire transfer payments for events2019-08-28T20:10:35+02:00Sébastiaan VersteegWire transfer payments for eventsCloses #838
### Short description
Wire transfer payments for events
### Steps to use this feature
1. Go to the events admin and use the selectbox to edit paymentsCloses #838
### Short description
Wire transfer payments for events
### Steps to use this feature
1. Go to the events admin and use the selectbox to edit payments26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1331Adjust CSS for accordion elements2019-08-28T19:58:43+02:00Sébastiaan VersteegAdjust CSS for accordion elementsAdds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/...Adds a missing bottom border.
#### Previous behaviour
![Screenshot_2019-08-16_at_12.32.27](/uploads/6c400ac64c9f4f25791c885ff5ffe831/Screenshot_2019-08-16_at_12.32.27.png)
#### New behaviour
![Screenshot_2019-08-16_at_12.32.16](/uploads/fdca28be337dd606ffd036fe85b75b59/Screenshot_2019-08-16_at_12.32.16.png)26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1322Remove obsolete Topicus logo HTML from newsletter2019-08-28T19:18:46+02:00Sébastiaan VersteegRemove obsolete Topicus logo HTML from newsletter### Short description
Remove obsolete Topicus logo HTML from newsletter### Short description
Remove obsolete Topicus logo HTML from newsletter26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1321Fix pizza order permissions2019-08-28T19:10:52+02:00Sébastiaan VersteegFix pizza order permissionsCloses #872
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected be...Closes #872
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected behaviour
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. The orders page is permission denied26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1319Remove shorthand and period from education Course model2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove shorthand and period from education Course modelCloses #896
### Short description
Remove shorthand and period from education Course model. Shorthand is unused and periods are never updated.Closes #896
### Short description
Remove shorthand and period from education Course model. Shorthand is unused and periods are never updated.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1284Remove mark all present feature from events2019-08-28T18:56:22+02:00Sébastiaan VersteegRemove mark all present feature from eventsCloses #878
### Short description
Remove mark all present feature from events since this cannot really be used anymore due to the new payments system.
It is broken in it's current form.Closes #878
### Short description
Remove mark all present feature from events since this cannot really be used anymore due to the new payments system.
It is broken in it's current form.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1326Fix society filter in member achievements2019-08-14T09:48:21+02:00Sébastiaan VersteegFix society filter in member achievementsCloses #899
#### Previous behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "ACHIEVEMENTS FOR THALIA" and "SOCIETIES".
### Expected behaviour
1. Go...Closes #899
#### Previous behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "ACHIEVEMENTS FOR THALIA" and "SOCIETIES".
### Expected behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "SOCIETIES" only.26