concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-08-15T10:27:58+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1329Add test values for no_references post value2019-08-15T10:27:58+02:00Sébastiaan VersteegAdd test values for no_references post value#### Previous behaviour
Steps to reproduce:
1. Renew as member
2. Get a mail about references
#### New behaviour
Steps to validate that it works:
1. Renew as member
2. Get no mail about references#### Previous behaviour
Steps to reproduce:
1. Renew as member
2. Get a mail about references
#### New behaviour
Steps to validate that it works:
1. Renew as member
2. Get no mail about references25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1328Use the right class to extend SocietyDetailView2019-08-14T20:16:05+02:00Sébastiaan VersteegUse the right class to extend SocietyDetailViewCloses #900
#### Previous behaviour
Steps to reproduce:
1. Go to the societies page
2. They all don't have members
#### New behaviour
Steps to validate that it works:
1. Go to the societies page
2. They have the correct m...Closes #900
#### Previous behaviour
Steps to reproduce:
1. Go to the societies page
2. They all don't have members
#### New behaviour
Steps to validate that it works:
1. Go to the societies page
2. They have the correct members25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1327Update dependency recommonmark to ~0.6.02019-08-13T13:08:44+02:00Thalia TechnicieUpdate dependency recommonmark to ~0.6.0This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [recommonmark](https://github.com/rtfd/recommonmark) | dependencies | minor | `~0.5.0` -> `~0.6.0` |
---
### Renovate configuration
:dat...This MR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [recommonmark](https://github.com/rtfd/recommonmark) | dependencies | minor | `~0.5.0` -> `~0.6.0` |
---
### Renovate configuration
:date: **Schedule**: "every weekday except on Wednesday,every weekend,before 5pm on Wednesday" (UTC).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever MR becomes conflicted.
:no_bell: **Ignore**: Close this MR and you won't be reminded about this update again.
---
- [ ] <!-- renovate-rebase -->If you want to rebase/retry this MR, check this box
---
Available now for GitLab: [Renovate Pro](https://renovatebot.com/pro) with real-time webhook handling and priority job queue.https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1326Fix society filter in member achievements2019-08-14T09:48:21+02:00Sébastiaan VersteegFix society filter in member achievementsCloses #899
#### Previous behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "ACHIEVEMENTS FOR THALIA" and "SOCIETIES".
### Expected behaviour
1. Go...Closes #899
#### Previous behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "ACHIEVEMENTS FOR THALIA" and "SOCIETIES".
### Expected behaviour
1. Go to [Joren's profile page](https://thalia.nu/members/profile/1239).
1. Notice that "Cooks' Guild" is listed under "SOCIETIES" only.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1325Add explicit end date for members to board pages2019-08-28T20:11:23+02:00Sébastiaan VersteegAdd explicit end date for members to board pagesCloses #857
### Short description
Add explicit end date for members to board pages
### Steps to use this feature
1. Add a board membership that ends prematurely
2. Check the date on the board pageCloses #857
### Short description
Add explicit end date for members to board pages
### Steps to use this feature
1. Add a board membership that ends prematurely
2. Check the date on the board page26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1324Clarify costs warning2019-08-13T14:18:33+02:00Sébastiaan VersteegClarify costs warningCloses #880
#### Previous behaviour
Steps to reproduce:
1. Get a costs warning
2. It's not an estimation according to the text
#### New behaviour
Steps to validate that it works:
1. Get a costs warning
2. It's an estimati...Closes #880
#### Previous behaviour
Steps to reproduce:
1. Get a costs warning
2. It's not an estimation according to the text
#### New behaviour
Steps to validate that it works:
1. Get a costs warning
2. It's an estimation according to the text26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1323Wire transfer payments for events2019-08-28T20:10:35+02:00Sébastiaan VersteegWire transfer payments for eventsCloses #838
### Short description
Wire transfer payments for events
### Steps to use this feature
1. Go to the events admin and use the selectbox to edit paymentsCloses #838
### Short description
Wire transfer payments for events
### Steps to use this feature
1. Go to the events admin and use the selectbox to edit payments26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1322Remove obsolete Topicus logo HTML from newsletter2019-08-28T19:18:46+02:00Sébastiaan VersteegRemove obsolete Topicus logo HTML from newsletter### Short description
Remove obsolete Topicus logo HTML from newsletter### Short description
Remove obsolete Topicus logo HTML from newsletter26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1321Fix pizza order permissions2019-08-28T19:10:52+02:00Sébastiaan VersteegFix pizza order permissionsCloses #872
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected be...Closes #872
### Current behaviour / Reproducing the bug
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. Clicking doesn't do anything
### Expected behaviour
1. Make a pizza event and add some orders
2. Your user should not be a superuser
3. Try to mark the orders as paid in the frontend
4. The orders page is permission denied26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1320Improve event categories2019-09-04T19:37:35+02:00Sébastiaan VersteegImprove event categoriesCloses #869
### Short description
Improve event categoriesCloses #869
### Short description
Improve event categories26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1319Remove shorthand and period from education Course model2019-08-28T19:01:48+02:00Sébastiaan VersteegRemove shorthand and period from education Course modelCloses #896
### Short description
Remove shorthand and period from education Course model. Shorthand is unused and periods are never updated.Closes #896
### Short description
Remove shorthand and period from education Course model. Shorthand is unused and periods are never updated.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1318Remove unused features from partners package2019-09-01T11:40:23+02:00Sébastiaan VersteegRemove unused features from partners packageCloses #877
### Short description
Remove unused features from partners package, also makes sure strings are properly translated.Closes #877
### Short description
Remove unused features from partners package, also makes sure strings are properly translated.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1317Remove redis dependency2019-08-01T13:34:15+02:00Joren VranckenRemove redis dependency### Short description
Remove unused `redis` dependency.### Short description
Remove unused `redis` dependency.26Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1316Rely on timezone.now instead of datetime.now for expiration emails so that te...2019-08-01T13:49:50+02:00Sébastiaan VersteegRely on timezone.now instead of datetime.now for expiration emails so that tests workhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1315Use new PARTNER_NOTIFICATION_ADDRESS instead of old PARTNER_EMAIL2019-08-01T13:43:05+02:00Joren VranckenUse new PARTNER_NOTIFICATION_ADDRESS instead of old PARTNER_EMAIL`PARTNER_EMAIL` was replaced in a393f6e9ec591cd61991fd888729bf3cd0140d78 by `PARTNER_NOTIFICATION_ADDRESS`.
#### Previous behaviour
Steps to reproduce:
[Sentry Issue](https://sentry.io/organizations/thalia/issues/1134801598/?project=147...`PARTNER_EMAIL` was replaced in a393f6e9ec591cd61991fd888729bf3cd0140d78 by `PARTNER_NOTIFICATION_ADDRESS`.
#### Previous behaviour
Steps to reproduce:
[Sentry Issue](https://sentry.io/organizations/thalia/issues/1134801598/?project=1470866)Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1313Add tests for close announcement2019-08-31T12:53:28+02:00Thom WiggersAdd tests for close announcement### Short description
Adds unit tests for closing announcements and catch a potential exception.### Short description
Adds unit tests for closing announcements and catch a potential exception.26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1312Fixes in calendar view and exam downloading2019-08-13T13:07:29+02:00Sébastiaan VersteegFixes in calendar view and exam downloadingCloses #898
This is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
Check start time in list view of events, check exam download function and check events api with filter parameters
#### New...Closes #898
This is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
Check start time in list view of events, check exam download function and check events api with filter parameters
#### New behaviour
Steps to validate that it works:
Check start time in list view of events, check exam download function and check events api with filter parameters25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1311Closes #887, photo url notification is no longer relative2019-08-31T12:53:44+02:00Sébastiaan VersteegCloses #887, photo url notification is no longer relativeCloses #887
#### Previous behaviour
Steps to reproduce:
1. Photo url does not contain the domain name
#### New behaviour
Steps to validate that it works:
1. Photo url contains the domain nameCloses #887
#### Previous behaviour
Steps to reproduce:
1. Photo url does not contain the domain name
#### New behaviour
Steps to validate that it works:
1. Photo url contains the domain name26https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1310Fix start/end date parsing in events API2019-08-13T11:43:26+02:00Sébastiaan VersteegFix start/end date parsing in events APIThis is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Visit `/api/v1/events/`
2. Crash
#### New behaviour
Steps to validate that it works:
1. Visit `/api/v1/events/`
2. No crashThis is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Visit `/api/v1/events/`
2. Crash
#### New behaviour
Steps to validate that it works:
1. Visit `/api/v1/events/`
2. No crash25https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1309Fix calendar list upcoming items2019-08-13T11:42:16+02:00Sébastiaan VersteegFix calendar list upcoming itemsThis is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Shows all events in the calendar list
#### New behaviour
Steps to validate that it works:
1. Shows only upcoming events in the cale...This is already deployed in a hotfix on v25.
#### Previous behaviour
Steps to reproduce:
1. Shows all events in the calendar list
#### New behaviour
Steps to validate that it works:
1. Shows only upcoming events in the calendar list25