concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-04-09T16:35:01+02:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1205Move `factory_boy` to main packages2019-04-09T16:35:01+02:00Joren VranckenMove `factory_boy` to main packages### Short description
Move `factory_boy` to main packages. This allows us to run fixtures in production and staging.### Short description
Move `factory_boy` to main packages. This allows us to run fixtures in production and staging.23Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1203Add command to minimise registrations data2019-05-08T19:50:33+02:00Sébastiaan VersteegAdd command to minimise registrations dataCloses #689
### Short description
Add command to minimise registrations data
### Steps to use this feature
1. Run `manage.py minimiseregistrations`Closes #689
### Short description
Add command to minimise registrations data
### Steps to use this feature
1. Run `manage.py minimiseregistrations`24https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1202Changed Mentor Achievement to be Unclickable + Code Cleanup2019-04-03T20:34:15+02:00Thijs de JongChanged Mentor Achievement to be Unclickable + Code Cleanup#### Previous behaviour
The achievements on the profile page of a member were all clickable, including the ``Mentor`` achievements, which lead to nowhere.
#### New behaviour
The ``Mentor`` achievements are no longer clickable, and a...#### Previous behaviour
The achievements on the profile page of a member were all clickable, including the ``Mentor`` achievements, which lead to nowhere.
#### New behaviour
The ``Mentor`` achievements are no longer clickable, and are black instead of magenta.
Also cleaned code in ``profile.html``23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1201Changed Translation For Programme Registration2019-04-03T20:10:14+02:00Thijs de JongChanged Translation For Programme RegistrationCloses #846
#### Previous behaviour
Translation to Dutch for ``Computing Science`` and ``Information Sciences`` was ``Informatica`` and ``Informatiekunde``.
#### New behaviour
New translations have been added; in Dutch, it is no...Closes #846
#### Previous behaviour
Translation to Dutch for ``Computing Science`` and ``Information Sciences`` was ``Informatica`` and ``Informatiekunde``.
#### New behaviour
New translations have been added; in Dutch, it is now ``Informatica (Computing Science)`` and ``Informatiekunde (Information Sciences)``.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1200Add automatic events input for newsletters2019-04-03T14:11:02+02:00Sébastiaan VersteegAdd automatic events input for newslettersCloses #305
### Short description
Add automatic events input for newsletters
### Steps to use this feature
1. Create a new newsletter
2. Add a newsletter event item
3. Select an event from the dropdown
4. All fields should be automa...Closes #305
### Short description
Add automatic events input for newsletters
### Steps to use this feature
1. Create a new newsletter
2. Add a newsletter event item
3. Select an event from the dropdown
4. All fields should be automatically filled for the event23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1199Replace FileValidator and remove old validator from previous migrations2019-03-27T20:30:46+01:00Sébastiaan VersteegReplace FileValidator and remove old validator from previous migrationsCloses #833
### Short description
Replace FileValidator and remove old validator from previous migrationsCloses #833
### Short description
Replace FileValidator and remove old validator from previous migrations23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1198Set html language code based on current session2019-03-27T19:50:18+01:00Sébastiaan VersteegSet html language code based on current sessionCloses #835
#### Previous behaviour
Steps to reproduce:
1. Check the HTML attribute on production when the language is Dutch
2. It's set to `en`
#### New behaviour
Steps to validate that it works:
1. Check the HTML attribute on produ...Closes #835
#### Previous behaviour
Steps to reproduce:
1. Check the HTML attribute on production when the language is Dutch
2. It's set to `en`
#### New behaviour
Steps to validate that it works:
1. Check the HTML attribute on production when the language is Dutch
2. It's set to `nl`23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1197Fix grayscaling of unavailable albums2019-03-27T19:18:00+01:00Sébastiaan VersteegFix grayscaling of unavailable albumsCloses #834
#### Previous behaviour
Steps to reproduce:
1. Go to a photo album that is not accessible for you
2. It is not grayed out and clickable
#### New behaviour
Steps to validate that it works:
1. Go to a photo album that is n...Closes #834
#### Previous behaviour
Steps to reproduce:
1. Go to a photo album that is not accessible for you
2. It is not grayed out and clickable
#### New behaviour
Steps to validate that it works:
1. Go to a photo album that is not accessible for you in the list of photo albums
2. It is grayed out and not clickable23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1196Fix race condition in registration approve/save2019-04-03T20:32:13+02:00Sébastiaan VersteegFix race condition in registration approve/saveCloses #841
#### Previous behaviour
Steps to reproduce:
1. Create new registration
2. Try to approve + save within couple of seconds
3. Empty payment
#### New behaviour
Steps to validate that it works:
1. Create new registration
2. ...Closes #841
#### Previous behaviour
Steps to reproduce:
1. Create new registration
2. Try to approve + save within couple of seconds
3. Empty payment
#### New behaviour
Steps to validate that it works:
1. Create new registration
2. Try to approve + save within couple of seconds
3. Cannot save + existing payment23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1195Add docs static html pushing in gitlab ci to docs.technicie.nl2019-03-27T19:50:16+01:00Jelle Besselingjelle@pingiun.comAdd docs static html pushing in gitlab ci to docs.technicie.nl### Short description
This adds docs hosting in the GitLab CI. Instead of docs.thalia.nu this will host the docs on docs.technicie.nl/branch.
Blocked on: https://gitlab.science.ru.nl/thalia/serverconfig/merge_requests/547### Short description
This adds docs hosting in the GitLab CI. Instead of docs.thalia.nu this will host the docs on docs.technicie.nl/branch.
Blocked on: https://gitlab.science.ru.nl/thalia/serverconfig/merge_requests/54723https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1194Fix registration editing organiser non member2019-03-27T20:33:33+01:00Sébastiaan VersteegFix registration editing organiser non memberCloses #839
#### Previous behaviour
Steps to reproduce:
1. Create two non-members in an event registration
2. Mark one as paid & refresh
3. Status moved back
#### New behaviour
Steps to validate that it works:
1. Create two non-memb...Closes #839
#### Previous behaviour
Steps to reproduce:
1. Create two non-members in an event registration
2. Mark one as paid & refresh
3. Status moved back
#### New behaviour
Steps to validate that it works:
1. Create two non-members in an event registration
2. Mark one as paid & refresh
3. Works23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1193Add coverage reporting on coverage.technicie.nl2019-03-15T13:26:32+01:00Jelle Besselingjelle@pingiun.comAdd coverage reporting on coverage.technicie.nl### Short description
Adds a new stage to the gitlab CI which pushes the coverage html report
to coverage.technicie.nl using the sftp command
### Steps to use this feature
1. Open a merge request
2. Pipeline automatically pushes covera...### Short description
Adds a new stage to the gitlab CI which pushes the coverage html report
to coverage.technicie.nl using the sftp command
### Steps to use this feature
1. Open a merge request
2. Pipeline automatically pushes coverage report to website
3. Find the url for the report in the pipeline information23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1192Ignore *.egg-info2019-03-27T19:50:18+01:00Joren VranckenIgnore *.egg-info### Short description
Ignore `*.egg-info`, because `poetry` creates `concrexit.egg-info`.### Short description
Ignore `*.egg-info`, because `poetry` creates `concrexit.egg-info`.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1191Update PC description with correct abbreviation and FB link2019-03-27T19:50:17+01:00Joren VranckenUpdate PC description with correct abbreviation and FB link### Short description
Update PC description with correct abbreviation and FB link.### Short description
Update PC description with correct abbreviation and FB link.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1190Test the merchandise package2019-03-27T19:50:17+01:00Thom WiggersTest the merchandise package### Short description
Implements unit tests for the merchandise package, to make fun of @sversteeg.### Short description
Implements unit tests for the merchandise package, to make fun of @sversteeg.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1189Add manual data minimisation functionality2019-03-06T19:34:15+01:00Sébastiaan VersteegAdd manual data minimisation functionality### Short description
Add manual data minimisation functionality
### Steps to use this feature
1. Go to the user admin
2. Make sure the user has no memberships or an ended membership that ended > 31 days ago
3. Minimise
4. Check that ...### Short description
Add manual data minimisation functionality
### Steps to use this feature
1. Go to the user admin
2. Make sure the user has no memberships or an ended membership that ended > 31 days ago
3. Minimise
4. Check that the user has an empty profile23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1188Add coverage badge2019-03-27T19:50:16+01:00Sébastiaan VersteegAdd coverage badge### Short description
Add coverage badge### Short description
Add coverage badge23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1187Do not specifiy parameters for coverage in ci: use .coveragerc2019-03-27T19:50:17+01:00Sébastiaan VersteegDo not specifiy parameters for coverage in ci: use .coveragerc### Short description
Do not specifiy parameters for coverage in ci: use .coveragerc### Short description
Do not specifiy parameters for coverage in ci: use .coveragerc23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1186Add automatic testing for model str method2019-03-02T17:11:15+01:00Jelle Besselingjelle@pingiun.comAdd automatic testing for model str methodThis adds dynamic tests which check if the overwritten __str__ method of a Model is not the same as the default __str__ method
If we want 100% coverage, the str methods should be tested. But usually, there is not really a good way to te...This adds dynamic tests which check if the overwritten __str__ method of a Model is not the same as the default __str__ method
If we want 100% coverage, the str methods should be tested. But usually, there is not really a good way to test them. This adds coverage to all the str methods automatically by testing that they contain "something useful" instead of having the default implementation.
In addition, it's good to have the str methods overridden because instance names will look weird in the admin without the user friendly name.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1185Fix data minimisation2019-04-10T20:47:51+02:00Sébastiaan VersteegFix data minimisation#### Previous behaviour
Steps to reproduce:
1. Data minimising trying for members with newer study memberships
#### New behaviour
Steps to validate that it works:
1. Data minimising not trying for members with newer study memb...#### Previous behaviour
Steps to reproduce:
1. Data minimising trying for members with newer study memberships
#### New behaviour
Steps to validate that it works:
1. Data minimising not trying for members with newer study memberships23