concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-03-27T19:50:16+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1184Replace Google Drive with Nextcloud links in styleguide2019-03-27T19:50:16+01:00Sébastiaan VersteegReplace Google Drive with Nextcloud links in styleguide### Short description
Replace Google Drive with Nextcloud links in styleguide### Short description
Replace Google Drive with Nextcloud links in styleguide23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1183Allow board membership to contain end date2019-03-27T19:50:29+01:00Tobias van der WerffAllow board membership to contain end dateCloses #416
#### Previous behaviour
Steps to reproduce:
1. Enter end date for Board membership; this produces an error message.
#### New behaviour
Steps to validate that it works:
1. Enter end date for Board membership; this no long...Closes #416
#### Previous behaviour
Steps to reproduce:
1. Enter end date for Board membership; this produces an error message.
#### New behaviour
Steps to validate that it works:
1. Enter end date for Board membership; this no longer produces an error message.23Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1182Improve createfixtures2019-02-27T20:13:19+01:00Sébastiaan VersteegImprove createfixturesCloses #827
### Short description
Improve createfixturesCloses #827
### Short description
Improve createfixtures23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1181Fix member tabs active state2019-02-27T20:14:50+01:00Sébastiaan VersteegFix member tabs active state#### Previous behaviour
Steps to reproduce:
1. Click 'former' or 'older' members tabs in directory
2. No active state
#### New behaviour
Steps to validate that it works:
1. Click 'former' or 'older' members tabs in director...#### Previous behaviour
Steps to reproduce:
1. Click 'former' or 'older' members tabs in directory
2. No active state
#### New behaviour
Steps to validate that it works:
1. Click 'former' or 'older' members tabs in directory
2. Has active state23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1180Remove redundant CMD instruction from Dockerfile2019-02-22T14:04:27+01:00Joren VranckenRemove redundant CMD instruction from Dockerfile### Short description
The instruction does nothing for the production entrypoint, because it
runs an uwsgi server.
The instruction is redundant for the default entrypoint, because --help
is implied if no command is given to manage.py.### Short description
The instruction does nothing for the production entrypoint, because it
runs an uwsgi server.
The instruction is redundant for the default entrypoint, because --help
is implied if no command is given to manage.py.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1179Do migrate, collectstatic and compress in entrypoints2019-04-11T12:55:08+02:00Joren VranckenDo migrate, collectstatic and compress in entrypointsCloses #831Closes #83123https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1178Thumbnail the merchandise images2019-02-27T20:15:24+01:00Sébastiaan VersteegThumbnail the merchandise images#### Previous behaviour
Steps to reproduce:
1. Go to the merchandise page
2. All full size images loaded
#### New behaviour
Steps to validate that it works:
1. Go to the merchandise page
2. Thumbnails loaded#### Previous behaviour
Steps to reproduce:
1. Go to the merchandise page
2. All full size images loaded
#### New behaviour
Steps to validate that it works:
1. Go to the merchandise page
2. Thumbnails loaded23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1177Replace the wiki menu item by Nextcloud2019-02-27T20:15:07+01:00Sébastiaan VersteegReplace the wiki menu item by Nextcloud### Short description
Replace the wiki menu item by Nextcloud### Short description
Replace the wiki menu item by Nextcloud23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1176Migrate to poetry and remove tox2019-02-27T19:29:01+01:00Jelle Besselingjelle@pingiun.comMigrate to poetry and remove toxCloses #829
### Short description
This MR removes pipenv files, removes tox and adds poetryCloses #829
### Short description
This MR removes pipenv files, removes tox and adds poetry23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1175Fix admin.py headers in payments2019-02-20T21:33:26+01:00Sébastiaan VersteegFix admin.py headers in paymentsFix admin.py headers in paymentsFix admin.py headers in paymentshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1174Write newsletter html to file on sending2019-03-27T20:38:46+01:00Michiel KraanWrite newsletter html to file on sendingCloses https://gitlab.science.ru.nl/thalia/concrexit/issues/321 <br>
### Short description
Generates media/newsletters/pk_lang.html when sending a newsletter's mail, and displays this from thereon. Also adds a "createnewsletterhtml" co...Closes https://gitlab.science.ru.nl/thalia/concrexit/issues/321 <br>
### Short description
Generates media/newsletters/pk_lang.html when sending a newsletter's mail, and displays this from thereon. Also adds a "createnewsletterhtml" command that generates html files for already-existing newsletters.
### Steps to use this feature
1. Create a newsletter
2. All changes in the admin panel are reflected in /newsletters/<pk>
3. Send using /newsletters/admin/send/<pk>
4. Making changes to the newsletter or template now no longer changes /newsletters/<pk>
5. Running "<manage.py> createnewsletterhtml [--include-unsent] server-name server-port" writes all previous newsletters to file.23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1173Change generate thumbnail url2019-02-20T20:59:24+01:00Sébastiaan VersteegChange generate thumbnail url### Short description
For easier nginx config### Short description
For easier nginx config22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1172Fix events payments migration2019-02-20T20:49:41+01:00Sébastiaan VersteegFix events payments migration/label ~bug
#### Previous behaviour
Steps to reproduce:
1. Migrate the events.
2. Weird notes.
#### New behaviour
Steps to validate that it works:
1. Migrate the events.
2. Better notes.
/label ~bug
#### Previous behaviour
Steps to reproduce:
1. Migrate the events.
2. Weird notes.
#### New behaviour
Steps to validate that it works:
1. Migrate the events.
2. Better notes.
22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1171Change sendfile url2019-02-20T20:50:56+01:00Sébastiaan VersteegChange sendfile url/label ~"technical change"
### Short description
Change sendfile url so that we don't need weird nginx configs.
/label ~"technical change"
### Short description
Change sendfile url so that we don't need weird nginx configs.
22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1170Add functionality to admin to edit information fields2019-04-03T14:09:56+02:00Sébastiaan VersteegAdd functionality to admin to edit information fieldsCloses #472
### Short description
Add functionality to admin to edit information fields
### Steps to use this feature
1. Create event with information fields
2. Register and fill in fields
3. Go to registration admin
4. Edit fields!Closes #472
### Short description
Add functionality to admin to edit information fields
### Steps to use this feature
1. Create event with information fields
2. Register and fill in fields
3. Go to registration admin
4. Edit fields!23https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1169Fix NoneType error in payments csv export2019-02-17T15:04:17+01:00Sébastiaan VersteegFix NoneType error in payments csv export#### Previous behaviour
Steps to reproduce:
1. Export a csv of payments
2. Crash
#### New behaviour
Steps to validate that it works:
1. Export a csv of payments
2. No crash#### Previous behaviour
Steps to reproduce:
1. Export a csv of payments
2. Crash
#### New behaviour
Steps to validate that it works:
1. Export a csv of payments
2. No crash22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1168Add automatic NextCloud group for committee chairs2019-02-18T20:09:59+01:00Sébastiaan VersteegAdd automatic NextCloud group for committee chairsCloses #830
### Short description
Add automatic NextCloud group for committee chairs
### Steps to use this feature
1. Check the NextCloud groups api for the right return valueCloses #830
### Short description
Add automatic NextCloud group for committee chairs
### Steps to use this feature
1. Check the NextCloud groups api for the right return value22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1167Remove duplicate code from photos_cards.py2019-02-18T20:09:54+01:00Sébastiaan VersteegRemove duplicate code from photos_cards.py### Short description
Remove duplicate code from photos_cards.py### Short description
Remove duplicate code from photos_cards.py22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1166Restrict changing registration to users with change registration perms2019-04-03T20:30:42+02:00Sébastiaan VersteegRestrict changing registration to users with change registration permsCloses #825
#### Previous behaviour
Steps to reproduce:
1. Create a user without registration change permission but with event change permission
2. Edit a registration of an event organised by a member group that the member is in
3. W...Closes #825
#### Previous behaviour
Steps to reproduce:
1. Create a user without registration change permission but with event change permission
2. Edit a registration of an event organised by a member group that the member is in
3. Works
#### New behaviour
Steps to validate that it works:
1. Create a user without registration change permission but with event change permission
2. Edit a registration of an event organised by a member group that the member is in
3. Does not work23Gijs HendriksenGijs Hendriksenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1165Always show member group members for authenticated users2019-02-20T20:20:09+01:00Sébastiaan VersteegAlways show member group members for authenticated usersCloses #478
#### Previous behaviour
Steps to reproduce:
1. Hide member group
2. Authenticated
3. No visible members
#### New behaviour
Steps to validate that it works:
1. Hide member group
2. Authenticated
3. Visible membersCloses #478
#### Previous behaviour
Steps to reproduce:
1. Hide member group
2. Authenticated
3. No visible members
#### New behaviour
Steps to validate that it works:
1. Hide member group
2. Authenticated
3. Visible members22Luko van der MaasLuko van der Maas