concrexit merge requestshttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests2019-02-10T17:15:58+01:00https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1144Don't cascade user deletion into deletion of exams etc2019-02-10T17:15:58+01:00Thom WiggersDon't cascade user deletion into deletion of exams etc#### Previous behaviour
Steps to reproduce:
1. try to delete userid 1
1. See that it tries to nuke a lot of exams
#### New behaviour
Steps to validate that it works:
1. nuke user 1 without extensive fallout.#### Previous behaviour
Steps to reproduce:
1. try to delete userid 1
1. See that it tries to nuke a lot of exams
#### New behaviour
Steps to validate that it works:
1. nuke user 1 without extensive fallout.22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1143Unify used tablesorter plugins2019-02-10T17:16:28+01:00Sébastiaan VersteegUnify used tablesorter pluginsCloses #804
### Short description
Unify used tablesorter pluginsCloses #804
### Short description
Unify used tablesorter plugins22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1142Fix all entityType values of conscribosync2019-02-10T17:16:01+01:00Sébastiaan VersteegFix all entityType values of conscribosync#### Previous behaviour
Steps to reproduce:
1. Run conscribosync
#### New behaviour
Steps to validate that it works:
1. Run conscribosync#### Previous behaviour
Steps to reproduce:
1. Run conscribosync
#### New behaviour
Steps to validate that it works:
1. Run conscribosync22Joren VranckenJoren Vranckenhttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1141Replace 'supporter' value in Membership model by 'benefactor'2019-02-06T20:44:37+01:00Sébastiaan VersteegReplace 'supporter' value in Membership model by 'benefactor'Closes #712
### Short description
Replace 'supporter' value in Membership model by 'benefactor'Closes #712
### Short description
Replace 'supporter' value in Membership model by 'benefactor'22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1140Add country field to user profiles2019-02-06T20:43:08+01:00Sébastiaan VersteegAdd country field to user profilesCloses #810
### Short description
Add country field to user profiles
### Steps to use this feature
1. Go to a user profile
2. Set the country
3. Export the country in the user overview
4. Edit the country on the user profile
5. Chec...Closes #810
### Short description
Add country field to user profiles
### Steps to use this feature
1. Go to a user profile
2. Set the country
3. Export the country in the user overview
4. Edit the country on the user profile
5. Check the country in the information check mail
6. Enter a country when registering22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1139Remove miscellaneous from top of documents page2019-01-26T15:03:34+01:00Joren VranckenRemove miscellaneous from top of documents page### Short description
It is a bit weird that the top of the documents page says miscellaneous documents.
You would expect that the top of the page presents the most important documents. This change reflects that.### Short description
It is a bit weird that the top of the documents page says miscellaneous documents.
You would expect that the top of the page presents the most important documents. This change reflects that.22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1138Set download attribute on Thabloid download links2019-02-10T17:16:39+01:00Joren VranckenSet download attribute on Thabloid download links### Short description
Setting the `download` attribute makes sure the browser downloads the file and does not load it into its own pdf reader. This is better because pdf readers of some browsers violate our content security policy.
Th...### Short description
Setting the `download` attribute makes sure the browser downloads the file and does not load it into its own pdf reader. This is better because pdf readers of some browsers violate our content security policy.
This is also better for consistency, because other documents are downloaded as well (because Django sets the `Content-Disposition` header).22https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1137Set right entity type in conscribo sync2019-01-24T19:28:42+01:00Sébastiaan VersteegSet right entity type in conscribo sync#### Previous behaviour
Steps to reproduce:
1. manage.py conscribosync
#### New behaviour
Steps to validate that it works:
1. manage.py conscribosync#### Previous behaviour
Steps to reproduce:
1. manage.py conscribosync
#### New behaviour
Steps to validate that it works:
1. manage.py conscribosynchttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1136Add translation for hardcoded "Locatie"2019-01-23T20:06:24+01:00Jelle Besselingjelle@pingiun.comAdd translation for hardcoded "Locatie"#### Previous behaviour
Steps to reproduce:
1. Look at GM documents at https://beta.thalia.nu/documents/
2. The word "Locatie" is in Dutch even on an English preference
#### New behaviour
Steps to validate that it works:
1. See that ...#### Previous behaviour
Steps to reproduce:
1. Look at GM documents at https://beta.thalia.nu/documents/
2. The word "Locatie" is in Dutch even on an English preference
#### New behaviour
Steps to validate that it works:
1. See that the word is translated correctly21.1Sébastiaan VersteegSébastiaan Versteeghttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1135Fix events unpublish2019-01-23T20:20:20+01:00Sébastiaan VersteegFix events unpublishCloses no issue
This bugs only occurs when using Postgres
#### Previous behaviour
Steps to reproduce:
1. Create an event
2. Publish
3. Try to unpublish
#### New behaviour
Steps to validate that it works:
1. Create an event
2. Publish...Closes no issue
This bugs only occurs when using Postgres
#### Previous behaviour
Steps to reproduce:
1. Create an event
2. Publish
3. Try to unpublish
#### New behaviour
Steps to validate that it works:
1. Create an event
2. Publish
3. Try to unpublish21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1134Remove notifications on event delete2019-01-23T20:02:50+01:00Sébastiaan VersteegRemove notifications on event deleteCloses #805
#### Previous behaviour
Steps to reproduce:
1. Create published event in future
2. Check created notifications
3. Delete said event
4. Created notifications still exist
#### New behaviour
Steps to validate that it works:
...Closes #805
#### Previous behaviour
Steps to reproduce:
1. Create published event in future
2. Check created notifications
3. Delete said event
4. Created notifications still exist
#### New behaviour
Steps to validate that it works:
1. Create published event in future
2. Check created notifications
3. Delete said event
4. Created notifications are deleted21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1133Update LICENSE.md2019-01-23T12:13:21+01:00Sébastiaan VersteegUpdate LICENSE.md21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1132Conscribo member sync2019-09-15T22:28:25+02:00Sébastiaan VersteegConscribo member syncCloses #790
### Short description
Conscribo member sync
### Steps to use this feature
1. Run `./manage.py conscribosync`
Closes #790
### Short description
Conscribo member sync
### Steps to use this feature
1. Run `./manage.py conscribosync`
21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1131Replace non-existent redirect_to with request.get_full_path_info2019-01-23T12:13:21+01:00Joren VranckenReplace non-existent redirect_to with request.get_full_path_infoCloses #806
#### Previous behaviour
Steps to reproduce:
1. Redirect to homepage after switching language.
#### New behaviour
Steps to validate that it works:
1. Redirect to same page after switching language.Closes #806
#### Previous behaviour
Steps to reproduce:
1. Redirect to homepage after switching language.
#### New behaviour
Steps to validate that it works:
1. Redirect to same page after switching language.21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1130Automatic pizza save fix2019-01-23T20:20:43+01:00Luko van der MaasAutomatic pizza save fixCloses #807Closes #80721.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1129Add special automatic NextCloud group with current board members2019-01-23T19:49:44+01:00Sébastiaan VersteegAdd special automatic NextCloud group with current board membersAnd properly exclude 'admin' group + inactive committeesAnd properly exclude 'admin' group + inactive committees21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1128Add explanatory text to societies page2019-01-23T12:13:22+01:00Joren VranckenAdd explanatory text to societies pageCloses #792
### Short description
Add explanatory text to societies pageCloses #792
### Short description
Add explanatory text to societies page21.1https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1127Sphinx during docker build2019-01-15T13:37:23+01:00Joren VranckenSphinx during docker build### Short description
Sphinx during docker build
I left out `-j $(nproc)`, because it generates `EOFError`s.### Short description
Sphinx during docker build
I left out `-j $(nproc)`, because it generates `EOFError`s.Thom WiggersThom Wiggershttps://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1125Remove XFrameOptionsMiddleware2019-01-14T11:29:37+01:00Joren VranckenRemove XFrameOptionsMiddlewareThe `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-option...The `XFrameOptionsMiddleware` middleware sets the `X-Frame-Options` header, which we already do in our `nginx` instance.
#### Previous behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
x-frame-options: SAMEORIGIN
...
```
#### New behaviour
```
$ curl -I https://thalia.nu/
...
x-frame-options: SAMEORIGIN
...
```https://gitlab.science.ru.nl/thalia/concrexit/-/merge_requests/1124Fix problems with pizza event notifications2019-01-16T19:29:56+01:00Sébastiaan VersteegFix problems with pizza event notificationsLuko van der MaasLuko van der Maas